From serb at openjdk.org Thu Jan 1 04:24:24 2026 From: serb at openjdk.org (Sergey Bylokhov) Date: Thu, 1 Jan 2026 04:24:24 GMT Subject: Withdrawn: 8374320: Update copyright year to 2025 for java.net.http in files where it was missed In-Reply-To: References: Message-ID: On Wed, 24 Dec 2025 02:05:28 GMT, Sergey Bylokhov wrote: > The copyright year in "java.net.http" files updated in 2025 has been bumped to 2025. All files are updated which touched the src/java.net.http and related files. > > The next command can be run (on top of this PR) to verify that each file had prior commits in 2025: > > ` > git diff HEAD~1 --name-only | while read f; do git log HEAD~1 --since="2025-01-01" --oneline -- "$f" | head -1 | grep -q . || echo "NOT IN 2025: $f"; done ` This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk/pull/28973 From fmeum at openjdk.org Thu Jan 1 06:53:42 2026 From: fmeum at openjdk.org (Fabian Meumertzheim) Date: Thu, 1 Jan 2026 06:53:42 GMT Subject: RFR: 8374441: FileSystemProvider.readAttributesIfExists should return null for ENOTDIR (unix) Message-ID: `FileSystemProvider.readAttributesIfExists` now returns `null` for paths with a true prefix that is not a directory rather than throwing `NotDirectoryException`. ------------- Commit messages: - 8374441: FileSystemProvider.readAttributesIfExists should return null for ENOTDIR (unix) Changes: https://git.openjdk.org/jdk/pull/29013/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=29013&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8374441 Stats: 17 lines in 2 files changed: 16 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk/pull/29013.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/29013/head:pull/29013 PR: https://git.openjdk.org/jdk/pull/29013 From alanb at openjdk.org Thu Jan 1 07:53:13 2026 From: alanb at openjdk.org (Alan Bateman) Date: Thu, 1 Jan 2026 07:53:13 GMT Subject: Integrated: 8374382: (aio) AsynchronousFileChannel writes wrong content using heap ByteBuffer when position != 0 In-Reply-To: References: Message-ID: On Wed, 31 Dec 2025 07:08:40 GMT, Alan Bateman wrote: > On Windows only, if AsynchronousFileChannel is used with a heap ByteBuffer with a non-0 buffer position then the AsynchronousFileChannel read/write methods don't work correctly when the buffer is "substituted" for the underlying I/O operation. > > This is a regression in JDK 26 after JDK-8357847, missed as we didn't have tests that exercise this scenario. This pull request has now been integrated. Changeset: d9bd300c Author: Alan Bateman URL: https://git.openjdk.org/jdk/commit/d9bd300c6eddfd30a83e53e7ae03c47ea43a9e08 Stats: 191 lines in 2 files changed: 189 ins; 0 del; 2 mod 8374382: (aio) AsynchronousFileChannel writes wrong content using heap ByteBuffer when position != 0 Reviewed-by: jpai ------------- PR: https://git.openjdk.org/jdk/pull/29010 From fmeum at openjdk.org Thu Jan 1 17:23:52 2026 From: fmeum at openjdk.org (Fabian Meumertzheim) Date: Thu, 1 Jan 2026 17:23:52 GMT Subject: RFR: 8374441: FileSystemProvider.readAttributesIfExists should return null for ENOTDIR (unix) In-Reply-To: References: Message-ID: On Wed, 31 Dec 2025 21:14:29 GMT, Fabian Meumertzheim wrote: > `FileSystemProvider.readAttributesIfExists` now returns `null` for a path with a true prefix that is not a directory rather than throwing `NotDirectoryException`. The linux-x64 debug build job consistently fails with "No space left on device", which doesn't appear to be related to this PR. ------------- PR Comment: https://git.openjdk.org/jdk/pull/29013#issuecomment-3703922943 From alanb at openjdk.org Fri Jan 2 07:09:51 2026 From: alanb at openjdk.org (Alan Bateman) Date: Fri, 2 Jan 2026 07:09:51 GMT Subject: RFR: 8374441: FileSystemProvider.readAttributesIfExists should return null for ENOTDIR (unix) In-Reply-To: References: Message-ID: <9gJrARkc90ok91ShPMFlnwC2vDyMoXy6S6pkqpWit4s=.83195f51-8d67-4f51-9269-c67ab74d17c2@github.com> On Wed, 31 Dec 2025 21:14:29 GMT, Fabian Meumertzheim wrote: > `FileSystemProvider.readAttributesIfExists` now returns `null` for a path with a true prefix that is not a directory rather than throwing `NotDirectoryException`. FileSystemProvider.readAttributesIfExists is part of the SPI so should be rare to see a direct usage. Instead, the usages are indirect, e.g. Files.isXXX to avoid using exceptions for control flow. Would it be possible to update the JBS issue or this PR with a some context as to how you ran into this. The implementation of APIs such as Files.isXXX will already handle the FileSystemException so the change should be transparent. I'm wondering if we've missed something in another usage (of some API) that causes the FileSystemException to surface. ------------- PR Comment: https://git.openjdk.org/jdk/pull/29013#issuecomment-3704640027 From alanb at openjdk.org Fri Jan 2 07:35:11 2026 From: alanb at openjdk.org (Alan Bateman) Date: Fri, 2 Jan 2026 07:35:11 GMT Subject: [jdk26] RFR: 8374382: (aio) AsynchronousFileChannel writes wrong content using heap ByteBuffer when position != 0 Message-ID: This pull request contains a clean backport of changeset https://github.com/openjdk/jdk/commit/d9bd300c6eddfd30a83e53e7ae03c47ea43a9e08 from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. ------------- Commit messages: - Backport d9bd300c6eddfd30a83e53e7ae03c47ea43a9e08 Changes: https://git.openjdk.org/jdk/pull/29015/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=29015&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8374382 Stats: 191 lines in 2 files changed: 189 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk/pull/29015.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/29015/head:pull/29015 PR: https://git.openjdk.org/jdk/pull/29015 From jpai at openjdk.org Fri Jan 2 07:41:51 2026 From: jpai at openjdk.org (Jaikiran Pai) Date: Fri, 2 Jan 2026 07:41:51 GMT Subject: [jdk26] RFR: 8374382: (aio) AsynchronousFileChannel writes wrong content using heap ByteBuffer when position != 0 In-Reply-To: References: Message-ID: <5XyCwu5Nji_X7LnqASm-irnkXqoZWAKVV6ccD5-7wj8=.9583b2e2-486a-448f-b7ac-4074101170c8@github.com> On Fri, 2 Jan 2026 06:58:43 GMT, Alan Bateman wrote: > This pull request contains a clean backport of changeset https://github.com/openjdk/jdk/commit/d9bd300c6eddfd30a83e53e7ae03c47ea43a9e08 from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. Marked as reviewed by jpai (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk/pull/29015#pullrequestreview-3622380585 From fmeum at openjdk.org Fri Jan 2 11:42:01 2026 From: fmeum at openjdk.org (Fabian Meumertzheim) Date: Fri, 2 Jan 2026 11:42:01 GMT Subject: RFR: 8374441: FileSystemProvider.readAttributesIfExists should return null for ENOTDIR (unix) In-Reply-To: References: Message-ID: On Wed, 31 Dec 2025 21:14:29 GMT, Fabian Meumertzheim wrote: > `FileSystemProvider.readAttributesIfExists` now returns `null` for a path with a true prefix that is not a directory rather than throwing `NotDirectoryException`. I added more details to the JBS issue. Bazel would like to use the provider method directly so that it doesn't have to pay for the cost of an exception in the case where a file does not exist, but our tests show that the method still throws in some edge cases in which the file is considered missing by higher-level APIs. ------------- PR Comment: https://git.openjdk.org/jdk/pull/29013#issuecomment-3705149978 From alanb at openjdk.org Sat Jan 3 06:29:01 2026 From: alanb at openjdk.org (Alan Bateman) Date: Sat, 3 Jan 2026 06:29:01 GMT Subject: [jdk26] Integrated: 8374382: (aio) AsynchronousFileChannel writes wrong content using heap ByteBuffer when position != 0 In-Reply-To: References: Message-ID: On Fri, 2 Jan 2026 06:58:43 GMT, Alan Bateman wrote: > This pull request contains a clean backport of changeset https://github.com/openjdk/jdk/commit/d9bd300c6eddfd30a83e53e7ae03c47ea43a9e08 from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. This pull request has now been integrated. Changeset: 6950503d Author: Alan Bateman URL: https://git.openjdk.org/jdk/commit/6950503dcf786e875a75c76141759e24ac46c3f4 Stats: 191 lines in 2 files changed: 189 ins; 0 del; 2 mod 8374382: (aio) AsynchronousFileChannel writes wrong content using heap ByteBuffer when position != 0 Reviewed-by: jpai Backport-of: d9bd300c6eddfd30a83e53e7ae03c47ea43a9e08 ------------- PR: https://git.openjdk.org/jdk/pull/29015 From alanb at openjdk.org Mon Jan 5 12:58:48 2026 From: alanb at openjdk.org (Alan Bateman) Date: Mon, 5 Jan 2026 12:58:48 GMT Subject: RFR: 8374441: FileSystemProvider.readAttributesIfExists should return null for ENOTDIR (unix) In-Reply-To: References: Message-ID: On Wed, 31 Dec 2025 21:14:29 GMT, Fabian Meumertzheim wrote: > `FileSystemProvider.readAttributesIfExists` now returns `null` for a path with a true prefix that is not a directory rather than throwing `NotDirectoryException`. > Title mismatch between PR and JBS. Can you update the PR title to match the JBS issue? src/java.base/unix/classes/sun/nio/fs/UnixFileAttributes.java line 102: > 100: return attrs; > 101: else if (errno == UnixConstants.ENOENT || > 102: errno == UnixConstants.ENOTDIR) I think this is okay. Can you update the end copyright from 2025 to 2026. test/jdk/java/nio/file/Files/NotADirectory.java line 54: > 52: > 53: import static org.junit.jupiter.api.Assertions.assertFalse; > 54: import static org.junit.jupiter.api.Assertions.assertNull; The tests in Files/* are meant to test the FIles API. I suppose it's okay to have it also test a related/underlying FileSystemProvider method but it will mean we need to update the test summary. Also need to add the JBS issue number to the `@bug` line. test/jdk/java/nio/file/Files/NotADirectory.java line 151: > 149: assertNull( > 150: BOGUS.getFileSystem().provider().readAttributesIfExists( > 151: BOGUS, BasicFileAttributes.class)); You can define a constant `static final FileSystemProvider PROVIDER = FileSystems.getDefault().provider()` and it will clean up these two tests. ------------- PR Comment: https://git.openjdk.org/jdk/pull/29013#issuecomment-3710305339 PR Review Comment: https://git.openjdk.org/jdk/pull/29013#discussion_r2661384778 PR Review Comment: https://git.openjdk.org/jdk/pull/29013#discussion_r2661387754 PR Review Comment: https://git.openjdk.org/jdk/pull/29013#discussion_r2661395319 From fmeum at openjdk.org Mon Jan 5 16:18:38 2026 From: fmeum at openjdk.org (Fabian Meumertzheim) Date: Mon, 5 Jan 2026 16:18:38 GMT Subject: RFR: 8374441: (fs) FileSystemProvider.readAttributesIfExists throws "Not a directory" when element in path is not directory should return null for ENOTDIR (unix) [v2] In-Reply-To: References: Message-ID: > `FileSystemProvider.readAttributesIfExists` now returns `null` for a path with a true prefix that is not a directory rather than throwing `NotDirectoryException`. Fabian Meumertzheim has updated the pull request incrementally with one additional commit since the last revision: Address review comments ------------- Changes: - all: https://git.openjdk.org/jdk/pull/29013/files - new: https://git.openjdk.org/jdk/pull/29013/files/d7377abf..91f4b3ac Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk&pr=29013&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=29013&range=00-01 Stats: 13 lines in 2 files changed: 6 ins; 2 del; 5 mod Patch: https://git.openjdk.org/jdk/pull/29013.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/29013/head:pull/29013 PR: https://git.openjdk.org/jdk/pull/29013 From alanb at openjdk.org Mon Jan 5 19:29:58 2026 From: alanb at openjdk.org (Alan Bateman) Date: Mon, 5 Jan 2026 19:29:58 GMT Subject: RFR: 8374441: (fs) FileSystemProvider.readAttributesIfExists throws "Not a directory" when element in path is not directory should return null for ENOTDIR (unix) [v2] In-Reply-To: References: Message-ID: On Mon, 5 Jan 2026 16:18:38 GMT, Fabian Meumertzheim wrote: >> `FileSystemProvider.readAttributesIfExists` now returns `null` for a path with a true prefix that is not a directory rather than throwing `NotDirectoryException`. > > Fabian Meumertzheim has updated the pull request incrementally with one additional commit since the last revision: > > Address review comments test/jdk/java/nio/file/Files/NotADirectory.java line 25: > 23: > 24: /* @test > 25: * @bug 8356678 8374441 Thanks for the update, I think it looks okay. Can you update the end copyright date on the test? I don't have any other comments. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/29013#discussion_r2662569066 From fmeum at openjdk.org Mon Jan 5 20:16:22 2026 From: fmeum at openjdk.org (Fabian Meumertzheim) Date: Mon, 5 Jan 2026 20:16:22 GMT Subject: RFR: 8374441: (fs) FileSystemProvider.readAttributesIfExists throws "Not a directory" when element in path is not directory should return null for ENOTDIR (unix) [v3] In-Reply-To: References: Message-ID: > `FileSystemProvider.readAttributesIfExists` now returns `null` for a path with a true prefix that is not a directory rather than throwing `NotDirectoryException`. Fabian Meumertzheim has updated the pull request incrementally with one additional commit since the last revision: Update copyright range ------------- Changes: - all: https://git.openjdk.org/jdk/pull/29013/files - new: https://git.openjdk.org/jdk/pull/29013/files/91f4b3ac..868e0f41 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk&pr=29013&range=02 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=29013&range=01-02 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk/pull/29013.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/29013/head:pull/29013 PR: https://git.openjdk.org/jdk/pull/29013 From bpb at openjdk.org Mon Jan 5 20:49:23 2026 From: bpb at openjdk.org (Brian Burkhalter) Date: Mon, 5 Jan 2026 20:49:23 GMT Subject: RFR: 8337143: (fc, fs) Move filesystem-related native objects from libnio to libjava [v19] In-Reply-To: References: Message-ID: > This proposed change would move the native objects required for NIO file interaction from the libnio native library to the libjava native library on Linux, macOS, and Windows. Brian Burkhalter has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 19 commits: - Merge - Merge - Merge - Merge - Merge - Merge - Merge - Merge - Merge - Merge - ... and 9 more: https://git.openjdk.org/jdk/compare/27dbdec2...c7446357 ------------- Changes: https://git.openjdk.org/jdk/pull/20317/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=20317&range=18 Stats: 1539 lines in 92 files changed: 774 ins; 668 del; 97 mod Patch: https://git.openjdk.org/jdk/pull/20317.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/20317/head:pull/20317 PR: https://git.openjdk.org/jdk/pull/20317 From alanb at openjdk.org Tue Jan 6 06:47:42 2026 From: alanb at openjdk.org (Alan Bateman) Date: Tue, 6 Jan 2026 06:47:42 GMT Subject: RFR: 8374441: (fs) FileSystemProvider.readAttributesIfExists throws "Not a directory" when element in path is not directory should return null for ENOTDIR (unix) [v3] In-Reply-To: References: Message-ID: On Mon, 5 Jan 2026 20:16:22 GMT, Fabian Meumertzheim wrote: >> `FileSystemProvider.readAttributesIfExists` now returns `null` for a path with a true prefix that is not a directory rather than throwing `NotDirectoryException`. > > Fabian Meumertzheim has updated the pull request incrementally with one additional commit since the last revision: > > Update copyright range Marked as reviewed by alanb (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk/pull/29013#pullrequestreview-3629644573 From duke at openjdk.org Tue Jan 6 06:56:23 2026 From: duke at openjdk.org (duke) Date: Tue, 6 Jan 2026 06:56:23 GMT Subject: RFR: 8374441: (fs) FileSystemProvider.readAttributesIfExists throws "Not a directory" when element in path is not directory should return null for ENOTDIR (unix) [v3] In-Reply-To: References: Message-ID: <3f85In6PDZc2CLtZbrfp9C9kgMoDlEc5tN-rxcWv1XA=.c0595f4e-e7e6-4b3c-802a-557eb9580adf@github.com> On Mon, 5 Jan 2026 20:16:22 GMT, Fabian Meumertzheim wrote: >> `FileSystemProvider.readAttributesIfExists` now returns `null` for a path with a true prefix that is not a directory rather than throwing `NotDirectoryException`. > > Fabian Meumertzheim has updated the pull request incrementally with one additional commit since the last revision: > > Update copyright range @fmeum Your change (at version 868e0f41cbcd7ed0782c59c31b9bf3812e447d8b) is now ready to be sponsored by a Committer. ------------- PR Comment: https://git.openjdk.org/jdk/pull/29013#issuecomment-3713367953 From fmeum at openjdk.org Tue Jan 6 08:12:13 2026 From: fmeum at openjdk.org (Fabian Meumertzheim) Date: Tue, 6 Jan 2026 08:12:13 GMT Subject: Integrated: 8374441: (fs) FileSystemProvider.readAttributesIfExists throws "Not a directory" when element in path is not directory should return null for ENOTDIR (unix) In-Reply-To: References: Message-ID: On Wed, 31 Dec 2025 21:14:29 GMT, Fabian Meumertzheim wrote: > `FileSystemProvider.readAttributesIfExists` now returns `null` for a path with a true prefix that is not a directory rather than throwing `NotDirectoryException`. This pull request has now been integrated. Changeset: 2fbc4162 Author: Fabian Meumertzheim Committer: Alan Bateman URL: https://git.openjdk.org/jdk/commit/2fbc4162e808f14b6114499f49db3e6ef1590f24 Stats: 25 lines in 2 files changed: 20 ins; 0 del; 5 mod 8374441: (fs) FileSystemProvider.readAttributesIfExists throws "Not a directory" when element in path is not directory should return null for ENOTDIR (unix) Reviewed-by: alanb ------------- PR: https://git.openjdk.org/jdk/pull/29013 From vyazici at openjdk.org Tue Jan 6 08:23:16 2026 From: vyazici at openjdk.org (Volkan Yazici) Date: Tue, 6 Jan 2026 08:23:16 GMT Subject: RFR: 8374523: [BACKOUT] Move input validation checks to Java for java.lang.StringCoding intrinsics Message-ID: Back out `java.lang.StringCoding` changes delivered in [JDK-8361842] (655dc516c22), which causes regressions reported in [JDK-8374210]. [JDK-8361842]: https://bugs.openjdk.org/browse/JDK-8361842 [JDK-8374210]: https://bugs.openjdk.org/browse/JDK-8374210 ------------- Commit messages: - Revert "8361842: Move input validation checks to Java for java.lang.StringCoding intrinsics" Changes: https://git.openjdk.org/jdk/pull/29055/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=29055&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8374523 Stats: 437 lines in 23 files changed: 25 ins; 331 del; 81 mod Patch: https://git.openjdk.org/jdk/pull/29055.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/29055/head:pull/29055 PR: https://git.openjdk.org/jdk/pull/29055 From vyazici at openjdk.org Tue Jan 6 08:23:16 2026 From: vyazici at openjdk.org (Volkan Yazici) Date: Tue, 6 Jan 2026 08:23:16 GMT Subject: RFR: 8374523: [BACKOUT] Move input validation checks to Java for java.lang.StringCoding intrinsics In-Reply-To: References: Message-ID: On Tue, 6 Jan 2026 08:16:16 GMT, Volkan Yazici wrote: > Back out `java.lang.StringCoding` changes delivered in [JDK-8361842] (655dc516c22), which causes regressions reported in [JDK-8374210]. > > [JDK-8361842]: https://bugs.openjdk.org/browse/JDK-8361842 > [JDK-8374210]: https://bugs.openjdk.org/browse/JDK-8374210 Tier 1-3 are clear on c8acc80b8c6. ------------- PR Comment: https://git.openjdk.org/jdk/pull/29055#issuecomment-3713645184 From bpb at openjdk.org Tue Jan 6 22:44:29 2026 From: bpb at openjdk.org (Brian Burkhalter) Date: Tue, 6 Jan 2026 22:44:29 GMT Subject: RFR: 8374641: Remove java/nio/channels/AsyncCloseAndInterrupt.java from problem list Message-ID: Remove the test from the problem list as many repetitions of manual testing has not revealed any failures. ------------- Commit messages: - 8374641: Remove java/nio/channels/AsyncCloseAndInterrupt.java from problem list Changes: https://git.openjdk.org/jdk/pull/29074/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=29074&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8374641 Stats: 3 lines in 1 file changed: 0 ins; 2 del; 1 mod Patch: https://git.openjdk.org/jdk/pull/29074.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/29074/head:pull/29074 PR: https://git.openjdk.org/jdk/pull/29074 From iris at openjdk.org Tue Jan 6 23:56:34 2026 From: iris at openjdk.org (Iris Clark) Date: Tue, 6 Jan 2026 23:56:34 GMT Subject: RFR: 8374641: Remove java/nio/channels/AsyncCloseAndInterrupt.java from problem list In-Reply-To: References: Message-ID: On Tue, 6 Jan 2026 22:28:44 GMT, Brian Burkhalter wrote: > Remove the test from the problem list as many repetitions of manual testing have not revealed any failures. Marked as reviewed by iris (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk/pull/29074#pullrequestreview-3632877959