RFR: 8376419: (fs) Minor improvement of java/nio/file/attribute/UserDefinedFileAttributeView/Basic.java [v2]
Jaikiran Pai
jpai at openjdk.org
Wed Jan 28 01:15:51 UTC 2026
On Tue, 27 Jan 2026 17:03:52 GMT, Brian Burkhalter <bpb at openjdk.org> wrote:
>> 1. Use `RandomFactory` instead of `new Random` to allow reproducibility.
>> 2. Use `jtreg.SkippedException` instead of printing a message and returning silently.
>
> Brian Burkhalter has updated the pull request incrementally with one additional commit since the last revision:
>
> 8376419: Align @summary text with other tests using RandomFactory
Hello Brian, this looks OK to me. I just noticed one thing though - I think adding an explicit `@build jtreg.SkippedException` would be a good thing. That should prevent any intermittent/unexpected failures.
-------------
PR Review: https://git.openjdk.org/jdk/pull/29434#pullrequestreview-3714155897
More information about the nio-dev
mailing list