RFR: 8376700: java/nio/file/DirectoryStream/SecureDS.java fails AtomicMoveNotSupportedException [v5]

SendaoYan syan at openjdk.org
Fri Jan 30 01:11:43 UTC 2026


On Thu, 29 Jan 2026 19:17:46 GMT, Brian Burkhalter <bpb at openjdk.org> wrote:

>> SendaoYan has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - Update comment
>>  - Re-throw the AtomicMoveNotSupportedException if renmae between the same FileStore
>
> test/jdk/java/nio/file/DirectoryStream/SecureDS.java line 319:
> 
>> 317:                     sds.move(file, null, file);
>> 318:                 } catch (AtomicMoveNotSupportedException e) {
>> 319:                     throw new SkippedException("java.nio.file.AtomicMoveNotSupportedException");
> 
> Should this instead re-throw the `AtomicMoveNotSupportedException` if `dir` is the `CWD`, i.e., the rename is within the same volume?

`dir` and `cwd` always at the different path, but maybe at the same volume. So check if they are at the some FileStore and re-throw `AtomicMoveNotSupportedException`.


Below is the actual path when run this test.

cwd: /home/yansendao/git/jdk-ysd/build/manual-run/jt-work/scratch
dir: /home/yansendao/git/jdk-ysd/build/manual-run/jt-work/scratch/name7513119775509255640

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/29487#discussion_r2744193338


More information about the nio-dev mailing list