<!DOCTYPE html><html><head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
</head>
<body>
On 14/11/2023 15:16, Baesken, Matthias wrote:<br>
<blockquote type="cite" cite="mid:AM9PR02MB6770AD613E6651FE26006A4093B2A@AM9PR02MB6770.eurprd02.prod.outlook.com">
<meta name="Generator" content="Microsoft Word 15 (filtered medium)">
<style>@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0cm;
font-size:11.0pt;
font-family:"Calibri",sans-serif;
mso-fareast-language:EN-US;}a:link, span.MsoHyperlink
{mso-style-priority:99;
color:#0563C1;
text-decoration:underline;}span.EmailStyle17
{mso-style-type:personal-compose;
font-family:"Calibri",sans-serif;
color:windowtext;}.MsoChpDefault
{mso-style-type:export-only;
font-family:"Calibri",sans-serif;
mso-fareast-language:EN-US;}div.WordSection1
{page:WordSection1;}</style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
<div class="WordSection1">
<p class="MsoNormal"><span lang="EN-US">Hi, while looking at
some net/nio coding, I noticed that at a lot of places the
return value of setsockopt is checked :<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="en-DE"><o:p> </o:p></span></p>
<p class="MsoNormal"><span lang="en-DE"><a href="https://github.com/search?q=repo%3Aopenjdk%2Fjdk+%22setsockopt%22&type=code" moz-do-not-send="true">https://github.com/search?q=repo%3Aopenjdk%2Fjdk+%22setsockopt%22&type=code</a><o:p></o:p></span></p>
<p class="MsoNormal"><span lang="en-DE"><o:p> </o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">but the check is omitted
at some places .</span></p>
</div>
</blockquote>
<br>
The setsockopt usages in ping4 and ping6 (Inet4Address.c and
Inet6Address.c) should probably have checks.<br>
<br>
There are a few others where they are set when supported. An
argument could be made to have these handle other errors. So I think
it means working through them on a case-by-case basis.<br>
<br>
-Alan<br>
</body>
</html>