<div dir="ltr"><div>Thanks for cc'ing Aleksey, Thomas.<br><br>Sorry if I went ahead and created a PR because I hadn't received a response for a few days. I apologize if I stepped on someone's toes, I just wanted to show an example of a possible solution and run it through people in this mailing list.<br><br></div><div><br></div><div><br></div><br></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Tue, Apr 30, 2024 at 4:21 PM Thomas Stüfe <<a href="mailto:thomas.stuefe@gmail.com">thomas.stuefe@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div>Hi Iñigo,</div><div><br></div><div>as others have mentioned, the normal way to do this would be to ping the owner of the issue. They may already be planning a different fix or have a different solution in mind.</div><div><br></div><div>I am cc'ing Aleksey; he can chime in if Elif does not react.<br></div><div><br></div><div>..Thomas<br></div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Tue, Apr 30, 2024 at 4:15 PM Iñigo Mediavilla <<a href="mailto:imediava@gmail.com" target="_blank">imediava@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div>I went ahead and created a proposal PR to tackle this issue: <a href="https://github.com/openjdk/jdk/pull/19021" target="_blank">https://github.com/openjdk/jdk/pull/19021</a>. <br><br></div><div>I'd be happy to hear anyone's thoughts on the proposed solution, and to hopefully get a sponsor on my first attempt to contribute to openjdk.</div><div><br></div><div>Thanks in advance<br><br>Íñigo<br></div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Thu, Apr 25, 2024 at 11:14 PM Iñigo Mediavilla <<a href="mailto:imediava@gmail.com" target="_blank">imediava@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr">After looking at <span>JDK-8313674</span> I'm wondering what is the current impact:<br><br>- Is it affecting the CI or the CI is always running in linux systems with sda devices ?<br>- Is it that local tests fail when they’re run from a linux device that doesn’t have a sda device ?<br><br>In terms of possible fixes, I think that a quick fix would be to add a nvm* device in the list of hard-coded devices to be tested. The test could iterate over the list of devices to test skipping devices that don't exist but running the checks on the first existing device.<br><br>As an alternative I also considered adding logic to list existing block devices and picking one to run the test, however I've not being able to figure out a way to do this in a simple way:<br><br>- There are libraries like (<a href="https://github.com/jnr/jnr-posix/" target="_blank">https://github.com/jnr/jnr-posix/</a>) that implement that logic, but I feel like it’s not worth incorporating such library only for the purpose of this test.<br>- I see that there are parts of the native code in the JDK repo that use S_ISBLK to check if a device is a block device, but I haven’t been able to find that information surfaced to Java.<br><br><div>Happy to hear the thoughts of people with more background on the topic :)</div><div><br></div><div>Íñigo Mediavilla Saiz<br></div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Thu, Apr 25, 2024 at 5:23 PM Iñigo Mediavilla <<a href="mailto:imediava@gmail.com" target="_blank">imediava@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><span><div dir="auto">Hello,</div>
<div dir="auto"><br>
</div>
<div dir="auto">For my first contribution to OpenJDK,
I've started looking into JDK-8313674.<br><br>Elif Aslan, I see that you've been assigned to this ticket, would you mind if I try to propose a solution for it ? </div><div dir="auto"><br></div><div dir="auto">If Elif is OK with it, I'd like to find a sponsor, since this would be my first time contributing to OpenJDK. Would anyone be available to sponsor my contribution ?<br><br></div><div>Thanks in advance</div><div><br></div><div>Íñigo Mediavilla Saiz<br></div></span></div>
</blockquote></div>
</blockquote></div>
</blockquote></div>
</blockquote></div>