git: openjdk/jfx-sandbox: renderperf_infinite-8331570: RenderPerf: Review fixes
duke
duke at openjdk.org
Tue Sep 10 09:00:06 UTC 2024
Changeset: 25e7ad9d
Branch: renderperf_infinite-8331570
Author: Lukasz Kostyra <lukasz.kostyra at oracle.com>
Date: 2024-09-10 10:08:31 +0000
URL: https://git.openjdk.org/jfx-sandbox/commit/25e7ad9d231390d97651bdaaaab88e69f893d525
RenderPerf: Review fixes
- Fixed occasional exceptions when closing in multi-test scenario. It
could've happened that AnimationTimer would advance as the Stage is
closed and resources released, but before the timer is stopped by the
test program. This caused unwanted NPEs. Prevented by putting
moveComponents() call inside a check if stage was closed by user.
- Moved Particles class logic inside ParticleRenderable. This reduces
places in which we keep object count (now it is kept in ParticleRenderer
and provided to ParticleRenderable via new methods) and allows test
renderers to modify the object count on their own.
- Following up the above, added roundUpTo4() method that is used to
round up object count to a multiple of 4. This method is used in
MultiShape tests. Method will print a warning message that rounding
occured if it detects the object count is not a multiple of 4.
! tests/performance/animation/RenderPerfTest/src/renderperf/RenderPerfTest.java
More information about the openjfx-changes
mailing list