[REVIEW] ComboBox Control

[Jonathan Giles]

Hi All,

This is a review request for RT-17956: 
http://javafx-jira.kenai.com/browse/RT-17956

The purpose of this feature request is to add a ComboBox control to 
JavaFX. The two public API classes can be found in the OpenJFX repo in 
the com.javafx.preview.control package, but I've also attached them to 
the Jira issue above for easier review. The intention is to move these 
classes to javafx.scene.control once approval is received.

We see a variety of implementations of ComboBoxBase in future releases 
of JavaFX (or created by members of the community). The most commonly 
required combo box, where a scrollable list appears within a popup, is 
what we provide in the ComboBox class. It supports both editable and 
non-editable modes, and provides a 'converter' property (which is a 
StringConverter) to allow for converting user text input into an Object, 
and vice versa to allow for an Object to be edited as a String. Richard 
intends to post separately about expanding the use of this API to other 
controls such as ChoiceBox.

All API is documented (although suggested improvements are always 
welcome), and there are 91 unit tests covering 100% of lines and 91% of 
branches.

If you find any problems with the API, or anything else, please let me 
know whilst there is still time to take action.

Thanks,
-- Jonathan