API Review request for ColorPicker control : RT-19312

[Richard Bair]

Looks OK. I'm slightly bothered by the colorLabelVisible property and wondering if either (a) we should specify this via CSS instead or (b) we should add contentDisplay. With ContentDisplay you can not only choose TEXT_ONLY or GRAPHIC_ONLY (graphic in this case being the color swatch you show), but also specify how they are positioned relative to each other.

I'm not sure I prefer the contentDisplay solution just because in the future I could imagine wanting to add a ColorPickerCell or something for completely customizing the editor area.

Speaking of which, is the color picker editable? Do we need to expose the editor like we are thinking about for ComboBox?

On Apr 25, 2012, at 5:23 PM, Paru Somashekar <parvathi.somashekar at oracle.com> wrote:

> A revised API for ColorPicker is attached to the JIRA now.
> 
> thanks,
> Paru.
> 
> On 4/24/12 5:05 PM, Paru Somashekar wrote:
>> 
>> The ColorPicker control allows the user to select a color from either a standard palette of colors with a simple one click selection OR define their own custom color.
>> 
>> JIRA : http://javafx-jira.kenai.com/browse/RT-19312
>> 
>> The proposed API for the ColorPicker control is attached to the JIRA above for review.
>> 
>> thanks,
>> Paru.
>