API REVIEW REQUEST: Public API for Backgrounds and Borders on Region

Richard Bair richard.bair at oracle.com
Sat Aug 25 16:07:48 PDT 2012


Hi Kevin,

> Two quick questions about packaging (I don't have an opinion, just raising the questions).
> 
> 1) Is Radii general purpose enough to warrant being in the geometry package?

Yes, I think so, much like Side or Insets. At least, it isn't strictly region-ish (whereas many of the other classes are for they have CSS semantics in them such as whether the value is literal or percentage).

> 2) Is it worth moving the Background*, etc., new classes into a new package, perhaps something like "javafx.scene.layout.css", given that you will otherwise double the number of classes in the layout package?

I would not want to use a sub-package, because there is some package private stuff that can be leveraged between Region and its various pieces. However, we could make them inner classes of Region for the additional name space partitioning. Overall though there aren't many classes in the package. Also of note, there were a lot more classes than this before! They were just hidden from view :-)

Richard


More information about the openjfx-dev mailing list