API REVIEW: RT-23888, Make PopupFeatures and PromptData final

[Tom Eugelink]

All I can say is that I hate final classes. "Not meant" does not mean "no one ever wants to".

What is the gain of making them final and what is the loss of not making them final?

Tom



On 2012-08-31 14:59, Peter Zhelezniakov wrote:
> Hello,
>
> There are two helper classes in javafx.scene.web package: PopupFeatures
> and PromptData. They are not meant to be extended by developers, so I
> hereby propose making them final, i.e.:
>
> public final class PopupFeatures {
>      public final boolean hasMenu();
>      public final boolean hasStatus();
>      public final boolean hasToolbar();
>      public final boolean isResizable();
> }
>
> public final class PromptData {
>      public PromptData(String message, String defaultValue);
>      public final String getMessage();
>      public final String getDefaultValue();
> }
>
> Thanks!