API REVIEW: RT-23888, Make PopupFeatures and PromptData final

[Tom Eugelink]

None of the classes in Swing are final and I do not know of any evil done via that UI framework. However, I do know a whole list of moments where final classes caused me a lot of grieve.

I could really appreciate one good example where a non final class has caused a security issue.

Tom


On 2012-08-31 15:45, Richard Bair wrote:
> Security for one. You can do evil things to non final classes! That is just a general rule (which is why generally we want to make everything final we can). In this particular case it may not matter.
>
> Richard
>
> On Aug 31, 2012, at 6:03 AM, Tom Eugelink wrote:
>
>> All I can say is that I hate final classes. "Not meant" does not mean "no one ever wants to".
>>
>> What is the gain of making them final and what is the loss of not making them final?
>>
>> Tom
>>
>>
>>
>> On 2012-08-31 14:59, Peter Zhelezniakov wrote:
>>> Hello,
>>>
>>> There are two helper classes in javafx.scene.web package: PopupFeatures
>>> and PromptData. They are not meant to be extended by developers, so I
>>> hereby propose making them final, i.e.:
>>>
>>> public final class PopupFeatures {
>>>      public final boolean hasMenu();
>>>      public final boolean hasStatus();
>>>      public final boolean hasToolbar();
>>>      public final boolean isResizable();
>>> }
>>>
>>> public final class PromptData {
>>>      public PromptData(String message, String defaultValue);
>>>      public final String getMessage();
>>>      public final String getDefaultValue();
>>> }
>>>
>>> Thanks!