Review of solution for Cancelled Tasks

Richard Bair richard.bair at oracle.com
Thu Jan 5 13:13:05 PST 2012


> If 2) ("Simply document that you have to check for isCancelled and leave it to the developer")
>    - what about updateXXX()?  You can call it but what does it do
>    - does it actually update anything?  Probably should (it's canceled ... but work is being done)

Yes, calling it will actually update the message / progress / title

>    - if it updates, then whatever UI is put on top of the task can decide how progress is shown for a canceled task that won't cancel

Right, they can have a more complicated binding such that:

progressIndicator.progressProperty().bind(
    Bindings.when(task.runningProperty()).then(task.progressProperty()).otherwise(-1)
);

Although they can do that with option #1 too.

Richard



More information about the openjfx-dev mailing list