[REVIEW REQUEST] Add text property to ComboBox

[Jonathan Giles]

As far as I'm aware, skins will always be com.sun.* 'private' API. I'm 
not sure there is a need for these to be exposed any further.

Of course, there is a plan to expose the foundation classes for building 
skins with more abstraction than just the Skin interface, but that won't 
be for a few releases yet.

-- Jonathan


On 14/03/2012 8:00 p.m., Tom Eugelink wrote:
>
> Seems legit, I'll also add it to JFXtras' spinner. I'm curious how 
> much more of skins we're going to expose in the future.
>
> Tom
>
>
>
> On 2012-03-14 07:19, Jonathan Giles wrote:
>> Yes, the text value would be set on every keystroke - it would be 
>> bound to the text property on TextField, which works in precisely 
>> this manner.
>>
>> Also, you're correct, the text property would only be useful in edit 
>> mode. In non-edit mode the property will never change.
>>
>> -- Jonathan
>>
>>
>> On 14/03/2012 7:17 p.m., Tom Eugelink wrote:
>>>
>>> So this is a feature for edit mode only. When would the property be 
>>> set? On every keystroke?
>>>
>>> Tom
>>>
>>>
>>> On 2012-03-14 01:53, Jonathan Giles wrote:
>>>> Hi all (yet again),
>>>>
>>>> A quick one this time: http://javafx-jira.kenai.com/browse/RT-19589
>>>>
>>>> I'm wanting to add a text property to ComboBox, to allow for people 
>>>> to easily set the text in the ComboBox without committing it to 
>>>> being a value. More importantly, this also allows for developers to 
>>>> extract the content of the ComboBox TextField without having to 
>>>> have end-users press the Enter key to commit the text into the 
>>>> value property.
>>>>
>>>> Without this end users who want to support Enter-less committing of 
>>>> content have to reach into the ComboBox skin, which is not 
>>>> particularly pleasant.
>>>>
>>>> Any thoughts?
>>>>
>>>
>>>
>>
>
>