javafx.scene.input.*Event classes construction

[Richard Bair]

OK.

On Nov 5, 2012, at 7:51 AM, Martin Sladecek <martin.sladecek at oracle.com> wrote:

> I would agree when talking in general, but this case is different.
> 
> The constructors will create Gesture event will everything set to default value (0, false). All of these fields are private and final and there are no setters (and never were) and I can't imagine anything where such event could be useful, not even when used together with some "copyFor" method.
> Both of these constructors will just generate gesture events at (0,0), with no modifiers set. This can be probably used just for testing this one particular case, so I'm fairly sure removing this will never break any code.
> 
> -Martin
> 
> On 11/05/2012 04:31 PM, Richard Bair wrote:
>> On Nov 5, 2012, at 3:50 AM, Martin Sladecek <martin.sladecek at oracle.com> wrote:
>> 
>>> On 11/02/2012 06:41 PM, Richard Bair wrote:
>>>> Looks OK to me. Lets not deprecated the protected constructors though, unless there is a good reason to (even if they are more or less useless).
>>> Well, one good reason is that they won't stay in the API once there will be FX JSR, as I guess all deprecated methods will be removed then.
>> This is true, however we want to limit this usage to those cases that are absolutely necessary, as any change is bound to make it more difficult for somebody to upgrade or raises the possibility of breaking somebody in the wild, which is not something I would want to do.
>> 
>>> But otherwise there's no reason to deprecated them (like security or something), it just keeps the API clean IMO.
>> I think the reason needs to be more compelling to break developers. I'm as obsessive compulsive about API design as the next guy, but I think we need to accept a certain amount of imperfection and be doubly careful that new API is seen as being forever, unless it is well and truly broken (security, etc).
>> 
>> Richard
>