API REVIEW: RT-23888, Make PopupFeatures and PromptData final

[Tom Schindl]

>From a API provider point of view it is easier to evolve a final class
because there can't be subclasses you can break.

See http://wiki.eclipse.org/Evolving_Java-based_APIs_2

Tom

Am 31.08.12 15:03, schrieb Tom Eugelink:
> All I can say is that I hate final classes. "Not meant" does not mean
> "no one ever wants to".
> 
> What is the gain of making them final and what is the loss of not making
> them final?
> 
> Tom
> 
> 
> 
> On 2012-08-31 14:59, Peter Zhelezniakov wrote:
>> Hello,
>>
>> There are two helper classes in javafx.scene.web package: PopupFeatures
>> and PromptData. They are not meant to be extended by developers, so I
>> hereby propose making them final, i.e.:
>>
>> public final class PopupFeatures {
>>      public final boolean hasMenu();
>>      public final boolean hasStatus();
>>      public final boolean hasToolbar();
>>      public final boolean isResizable();
>> }
>>
>> public final class PromptData {
>>      public PromptData(String message, String defaultValue);
>>      public final String getMessage();
>>      public final String getDefaultValue();
>> }
>>
>> Thanks!
> 


-- 
B e s t S o l u t i o n . a t                        EDV Systemhaus GmbH
------------------------------------------------------------------------
tom schindl                 geschäftsführer/CEO
------------------------------------------------------------------------
eduard-bodem-gasse 5-7/1   A-6020 innsbruck     fax      ++43 512 935833
http://www.BestSolution.at                      phone    ++43 512 935834