[API Review]: RT-28148 - Add createSymbols Property to AreaChart / StackedAreaChart

Paru Somashekar parvathi.somashekar at oracle.com
Mon Apr 8 15:29:45 PDT 2013


I have reviewed the patch provided by Sven and tested it. Also have unit 
tests for createSymbols API.
Ready to check it in once Rich approves the API change.

thanks,
Paru.

On 3/8/13 4:12 AM, Sven Reimers wrote:
> Hi all
>
> AreaChart and StackedAreaChart are missing an API to simply disable the
> creation of symbols. At the moment this is only possible by complex css
> style acrobatics. LineChart on the other hand already provides a simple way
> to do this. The proposed tweak takes the existing API from LineChart and
> adds this to AreaChart and StackedAreaChart.
>
> Desired API change:
>
>   /**
>       * Indicates whether symbols for data points will be created or not.
>       *
>       * @return true if symbols for data points will be created and false
> otherwise.
>       */
>      public final boolean getCreateSymbols() { return
> createSymbols.getValue(); }
>      public final void setCreateSymbols(boolean value) {
> createSymbols.setValue(value); }
>      public final BooleanProperty createSymbolsProperty() { return
> createSymbols; }
>
> Desired additional CSS property (incldues additional StyleableProperty):
>
> -fx-create-symbols
>
>
> JIRA:
> http://javafx-jira.kenai.com/browse/RT-28148
>
> Thank
>
> -Sven
>
> P.S. An updated patch will hopefully be available there too.
>



More information about the openjfx-dev mailing list