[API REVIEW] RT-29812: Add Set<PseudoClass> getPseudoClassState() to javafx.css.Styleable

Richard Bair richard.bair at oracle.com
Wed Apr 17 11:25:43 PDT 2013


Should we do so then?

On Apr 17, 2013, at 11:11 AM, David Grieve <david.grieve at oracle.com> wrote:

> That was my original thought a couple of months ago. Think of what that could do for tooling. 
> 
> On Apr 17, 2013, at 12:58 PM, Richard Bair <richard.bair at oracle.com> wrote:
> 
>> Being really wild here, should here (and on Node) actually be ObservableSet? If nobody listens to an ObservableSet I assume its performance is the same as a normal Set?
>> 
>> On Apr 17, 2013, at 5:41 AM, David Grieve <david.grieve at oracle.com> wrote:
>> 
>>> https://javafx-jira.kenai.com/browse/RT-29812
>>> 
>>> The Styleable interface comprises the minimal interface required for an object to be styled by CSS, but is currently missing API to get the pseudo-class state of the object. 
>>> 
>>> ADD: 
>>>   public Set<PseudoClass> getPseudoClassStates() 
>>> 
>>> Note that this method is already implemented by Node. Adding it the Styleable interface will allow CSS to avoid casting to Node to get pseudo-class state. CSS will also be able to handle other classes which are Styleable but do not extend Node (e.g., MenuItem, PopupControl, Tab, and TableColumnBase)
>>> 
>>> 
>> 
> 



More information about the openjfx-dev mailing list