[API Review] RT-24916 - TableView.scrollTo(TableColumn)

[Richard Bair]

Looks OK to me.

On Feb 4, 2013, at 12:25 AM, Tom Schindl <tom.schindl at bestsolution.at> wrote:

> hi,
> 
> We (Jonathan and myself) are requesting an API review to add the
> following public APIs:
> 
> New APIS:
> ---------
> * ListView:
>  scrollTo(T) : void
> 
> * TableView:
>  scrollTo(S) : void
>  scrollToColumn(TableColumn<S, ?>) : void
>  scrollToColumnIndex(int) : void
>  setOnScrollToColumn(EventHandler<ScrollToEvent<TableColumn<S, ?>>>): void
>  getOnScrollToColumn() : EventHandler<ScrollToEvent<TableColumn<S, ?>>>
>  onScrollToColumnProperty():
> ObjectProperty<EventHandler<ScrollToEvent<TableColumn<S, ?>>>>
> 
> * TreeTableView
>  scrollToColumn(TableColumn<S, ?> column) : void
>  scrollToColumnIndex(int columnIndex) : void
>  setOnScrollToColumn(EventHandler<ScrollToEvent<TreeTableColumn<S, ?>>>
> value) : void
>  getOnScrollToColumn() : EventHandler<ScrollToEvent<TreeTableColumn<S, ?>>>
>  onScrollToColumnProperty() :
> ObjectProperty<EventHandler<ScrollToEvent<TreeTableColumn<S, ?>>>>
> 
> * ScrollToEvent:
>  static <T extends TableColumnBase<?, ?>> scrollToColumn() :
> EventType<ScrollToEvent<T>>
> 
> Modified APIS:
> --------------
> To align better we'd like to change the ScrollToEvent-API to be
> consitent and use static accessor methods instead of public static fields:
>  * SCROLL_TO_NODE => scrollToNode() : EventType<ScrollToEvent<Node>>
>  * SCROLL_TO_TOP_INDEX => scrollToTopIndex() :
> EventType<ScrollToEvent<Integer>>
> 
> 
> Thanks
> 
> Jonathan + Tom
> 
> -- 
> B e s t S o l u t i o n . a t                        EDV Systemhaus GmbH
> ------------------------------------------------------------------------
> tom schindl                 geschäftsführer/CEO
> ------------------------------------------------------------------------
> eduard-bodem-gasse 5-7/1   A-6020 innsbruck     fax      ++43 512 935833
> http://www.BestSolution.at                      phone    ++43 512 935834