[REVIEW REQUEST] Add support for an emptyText property in ComboBox

[Jonathan Giles]

Conceptually I have no issue with the use of a placeholder Node property 
being used instead of an emptyText String property - I like the 
consistency across the controls. The only (slight) concern is the 
increased complexity for the common use case: you go from 
comboBox.setEmptyText("empty!!") to comboBox.setPlaceholder(new 
Label("empty!!")).

I'll leave it up for discussion, but as of now the status quo is emptyText.

-- Jonathan

On 20/02/2013 11:03 p.m., Knut Arne Vedaa wrote:
>
>
> Scott Palmer wrote:
>> What about consistency with TableView?
>
> TableView has:
>
> ObjectProperty<Node>     placeholder
> This Node is shown to the user when the table has no content to show.
>
> ListView doesn't, but I think it should. It means "no items", and both 
> TableView and ListView has an "items" list, thus it is analogous.
>
> ComboBox could then just utilize its ListView's placeholder, instead 
> of introducing another "empty" concept.
>
>
> Knut Arne Vedaa