API review: RT-27762: Text not centered vertically in bounds for windows default 12px

[Felipe Heidrich]

Just to confirm:

Text#boundsTypeProperty() will be made styleable and the CSS name will be "-fx-bounds-type"

check ?


On Feb 27, 2013, at 10:41 AM, Richard Bair wrote:

> That's fine too.
> 
> On Feb 27, 2013, at 10:40 AM, Felipe Heidrich <felipe.heidrich at oracle.com> wrote:
> 
>> Hi,
>> 
>> While reviewing the code with Phil he suggested to use LOGICAL_VERTICAL_CENTER.
>> 
>> Everybody okay with it ?
>> 
>> Felipe
>> 
>> 
>> On Feb 26, 2013, at 2:37 PM, Jasper Potts wrote:
>> 
>>> sounds good, go for it.
>>> 
>>> On Feb 26, 2013, at 11:32 AM, Richard Bair <Richard.Bair at oracle.com> wrote:
>>> 
>>>>> Honestly I couldn't think of a good name, I nearly named CENTER (so that the bounds type are LOGICAL, VISUAL, CENTER). Maybe LOGICAL_CENTER (as we will never have a horizontal variation of this).
>>>> 
>>>> LOGICAL_CENTER seems like a good name (and shorter to boot). If you're OK with that I'll +1 the issue.
>>>> 
>>>>> Other problem Jasper brought up is that we can't set this mode on caspian (as it already has uneven padding to workaround this problem). While we could detected the theme name in the code to decide when to set the mode it felt a bit hacky. A cleaner solution is to make Text#boundsTypeProperty() styleable. What do you think ?
>>>> 
>>>> Probably doesn't hurt to have it be style able.
>>> 
>> 
>