hg: openjfx/8/graphics/rt: 2 new changesets

Tom Schindl tom.schindl at bestsolution.at
Thu Jan 3 03:16:31 PST 2013


Hi,

I wonder if translating fx:id to Node.setId() is a good idea (it was
this way in 2.x, but changed in 8.x until this commit if i read it get
correctly).

One could have argued that this is a regression - although I think fx:id
has never been speced to set the Node.id-attribute - but I personally
liked the change because fx:id should only bring something into the
namespace so that it could be injected into the controller.

Tom

Am 03.01.13 11:47, schrieb hang.vo at oracle.com:
> Changeset: 637214644dc8
> Author:    Milan Kubec <milan.kubec at oracle.com>
> Date:      2013-01-03 09:18 +0000
> URL:       http://hg.openjdk.java.net/openjfx/8/graphics/rt/rev/637214644dc8
> 
> fx:id is set as value for Node.id only if Node.id was not previously set during processing of start element attributes; id renamed to fx_id to lessen confusion
> 
> ! javafx-fxml/src/javafx/fxml/FXMLLoader.java
> 
> Changeset: 1b7e12459a11
> Author:    Milan Kubec <milan.kubec at oracle.com>
> Date:      2013-01-03 10:39 +0000
> URL:       http://hg.openjdk.java.net/openjfx/8/graphics/rt/rev/1b7e12459a11
> 
> Automated merge with ssh://jfxsrc.us.oracle.com//javafx/8.0/scrum/graphics/jfx////rt
> 
> 


-- 
B e s t S o l u t i o n . a t                        EDV Systemhaus GmbH
------------------------------------------------------------------------
tom schindl                 geschäftsführer/CEO
------------------------------------------------------------------------
eduard-bodem-gasse 5-7/1   A-6020 innsbruck     fax      ++43 512 935833
http://www.BestSolution.at                      phone    ++43 512 935834


More information about the openjfx-dev mailing list