[Review] RT-27600: API Redesign Control#getCssMetaData() & impl_getControlStyleableProperties()

[Richard Bair]

Looks good. Instead of just having inheritDoc on getCssMetaData, I'd suggest adding doc to describe that this method returns the CssMetaData for the control and for its skin. At first I didn't understand the difference between getCssMetaData and getControlCssMetaData.

Richard

On Jan 10, 2013, at 1:20 PM, Tom Schindl <tom.schindl at bestsolution.at> wrote:

> Hi,
> 
> While working on another bug (RT-27088) Jonathan, David and myself
> discovered that Skin-CSS-Styleproperties are not correctly published
> anymore because subclasses of Control simply overwrote getCssMetaData()
> and didn't take the Skin-Styleproperties into account.
> 
> In RT-27600 we propose the following changes:
> * make the until now internal API impl_getControlStyleableProperties()
>  API and rename it to getControlCssMetaData()
> 
> * make getCssMetaData() final so that subclasses are not in danger of
>  repeating the bug introduced in controls already
> 
> The rest of the attached patch simply fixes all current controls who
> incorrectly overwrote getCssMetaData().
> 
> Tom
> 
> -- 
> B e s t S o l u t i o n . a t                        EDV Systemhaus GmbH
> ------------------------------------------------------------------------
> tom schindl                 geschäftsführer/CEO
> ------------------------------------------------------------------------
> eduard-bodem-gasse 5-7/1   A-6020 innsbruck     fax      ++43 512 935833
> http://www.BestSolution.at                      phone    ++43 512 935834