Button(graphic) constructor addition breaks existing code

Richard Bair richard.bair at oracle.com
Sat Jan 19 07:52:03 PST 2013


The new constructor I added in http://javafx-jira.kenai.com/browse/RT-16206 breaks existing code, as we can see below reported by Hudson. As such I'm going to back that change out and close the issue as will not fix (it isn't worth breaking existing code for this minor addition).

Richard

Begin forwarded message:

>  [mkdir] Created dir: C:\workspace\8.0-controls-test\label\windows-amd64-t30\rt\javafx-ui-controls\build\test\classes
>    [javac] Compiling 108 source files to C:\workspace\8.0-controls-test\label\windows-amd64-t30\rt\javafx-ui-controls\build\test\classes
>    [javac] warning: Cannot make builder for javafx.scene.control.SkinStub because no constructor specifies only properties as parameters
>    [javac] C:\workspace\8.0-controls-test\label\windows-amd64-t30\rt\javafx-ui-controls\test\javafx\scene\control\ButtonTest.java:70: error: reference to Button is ambiguous, both constructor Button(String) in Button and constructor Button(Node) in Button match
>    [javac]         Button b2 = new Button(null);
>    [javac]                     ^
>    [javac] C:\workspace\8.0-controls-test\label\windows-amd64-t30\rt\javafx-ui-controls\test\javafx\scene\control\ButtonTest.java:99: error: reference to Button is ambiguous, both constructor Button(String) in Button and constructor Button(Node) in Button match
>    [javac]         Button b2 = new Button(null);
>    [javac]                     ^
>    [javac] Note: Some input files use or override a deprecated API.
>    [javac] Note: Recompile with -Xlint:deprecation for details.
>    [javac] Note: Some input files use unchecked or unsafe operations.
>    [javac] Note: Recompile with -Xlint:unchecked for details.
>    [javac] 2 errors
>    [javac] 1 warning



More information about the openjfx-dev mailing list