[API Review]: Add "margin" property to node and make it styleable from CSS

Martin Sladecek martin.sladecek at oracle.com
Tue Jun 11 06:36:27 PDT 2013


On 06/11/2013 03:01 PM, Tom Eugelink wrote:
>
> I know I'm reiterating, but just to keep the point alive; personally I 
> would still prefer to have such information placed in an explicit 
> layout constraint class.
>
> node.setMargin(x); layout.getChildren().add(node);
> vs
> layout.add(node, new Constraint().margin(x));
>
> It also prevents the Node class from bloating.

Means new *Constraint class and new "add" method for each layout *Pane 
class. Also one of the nice side-effects of having this as a property is 
that we can style it using "-fx-margin" CSS property.

Regards,
-Martin


More information about the openjfx-dev mailing list