hg: openjfx/8/master/rt: 48 new changesets

[Ali Ebrahimi]

Hi,


On Fri, May 3, 2013 at 8:56 AM, <hang.vo at oracle.com> wrote:

> Changeset: 6fa04ee78684
> Author:    snorthov
> ...
>
>
> Changeset: b1c70760de87
> Author:    Seeon Birger <seeon.birger at oracle.com>
> Date:      2013-04-29 18:53 +0300
> URL:       http://hg.openjdk.java.net/openjfx/8/master/rt/rev/b1c70760de87
>
> Fix RT-29858: CSS style for the virtual keyboard is not loaded
>
> ! javafx-ui-controls/src/com/sun/javafx/scene/control/skin/FXVKSkin.java
>
> ...
>
> I just reviewed this Changeset and I think hard coding "prism" in code is
not good practice. if we we want completely plugable theming for javafx ui
better we define an standard and unified (directory layout) structure for
all css and image files of one theme. Mey be better we define an SPI for
theming.

StyleManager.getInstance().addUserAgentStylesheet("com/sun/javafx/scene/control/skin/caspian/fxvk.css");


Ali Ebrahimi