Patches for packager tweaks

[Mark Howe]

Unfortunately the packager has been on hold due to other priorities for several months. I understand it's really frustrating to submit patches and have nothing happen, please understand it's not intentional and I apologize for the delay. I have been finding some time to work on the packager the last couple of weeks and hope to continue that.  I will try to review these patches next week.

Mark


On May 31, 2013, at 8:12 AM, Daniel Zwolenski <zonski at gmail.com> wrote:

> +1
> 
> 
> On 31/05/2013, at 12:31 PM, Danno Ferrin <danno.ferrin at shemnon.com> wrote:
> 
>> I have an OCA signed and in force: http://www.oracle.com/technetwork/community/oca-486395.html#f
>> 
>> If my statement seemed a little cynical with the subtext being a concern about whether or not OpenJFX is even interested interested in some of these patches, that's because it was.
>> 
>> I have two bugs, for things which are obviously broken, with patches that have not had as far as I can tell any serious consideration.  In fact one of the bugs has been seen by the SceneBuilder team for their linux install, and tagged as an importint bug for them!
>> 
>> https://javafx-jira.kenai.com/browse/RT-27989
>> https://javafx-jira.kenai.com/browse/RT-27984
>> 
>> A bug without a solution is one thing, but these come with fixes.  And they have been sitting with a patch for over five months now!  Seriously, after five months I consider these informally rejected, except that the packager branch hasn't seen much work in that time frame anyway.
>> 
>> I would like to be contributing more but the benign neglect I am seeing towards my code contributions makes me re-think what I should be doing with my free time.  Even a formal rejection would be better. 
>> 
>> On Thu, May 30, 2013 at 8:08 PM, Kevin Rushforth <kevin.rushforth at oracle.com> wrote:
>> Right. I was answering the general question.
>> 
>> For the specific question, I will defer to Mark Howe, who is working on the packager.
>> 
>> -- Kevin
>> 
>> 
>> 
>> Daniel Zwolenski wrote:
>>> 
>>> I'm guessing Danno would like to know how long he should expect to wait for the patches he kindly contributed and linked to in that email to get included. Seems like a fair and reasonable question and one I'd also like to know the answer to. 
>>> 
>>> Perhaps a linked question that I'd also like to know: is anyone actually allocated to any work on the packager at the moment, and if not when are they next going to be?  
>>> 
>>> 
>>> On Fri, May 31, 2013 at 11:44 AM, Kevin Rushforth <kevin.rushforth at oracle.com> wrote:
>>> 
>>> How long is it taking for community patches to get into a build these days?
>>> 
>>> Hi Danno,
>>> 
>>> There are two parts to the answer:
>>> 
>>> 1) How long does it take for a proposed fix (patch) to be reviewed and accepted?
>>> 
>>> 2) Once your patch is accepted and the changeset is pushed to the repo, how long before it shows up in an EA build?
>>> 
>>> #1 depends on what area it is, what is the scale of the proposed change: is it a simple bug fix, or a new feature with API or documentation implications, are there compatibility concerns, how risky is it, etc.
>>> 
>>> #2 is typically between 0.5 and 1.5 weeks depending when it is pushed.
>>> 
>>> As a reminder (Richard may have recently posted something about this, so my apologies if this is a duplicate reminder), anyone submitting a patch must first sign the Oracle Contributor Agreement (OCA) before we can consider taking it.
>>> 
>>> -- Kevin
>>> 
>>> 
>>> 
>>> 
>>> Danno Ferrin wrote:
>>> Just posted to bugs with patches for some tweaks I'de like to see to the
>>> packager.
>>> 
>>> https://javafx-jira.kenai.com/browse/RT-30792
>>> https://javafx-jira.kenai.com/browse/RT-30793
>>> 
>>> The first one is to allow for a comma separated list of enumerated
>>> packagers, so it's not one or all.
>>> 
>>> The second one is more relevant, it moves the discovery of the bundlers
>>> from being hard coded in the class file to loaded off of the
>>> META-INF/services directory.  This allows a bunlder to be added at
>>> "runtime" when the build is being done.  For example, a bundler that would
>>> bundle RoboVM or APK files provided at runtime rather than having to
>>> package it's reference into the source code itself.
>>> 
>>> How long is it taking for community patches to get into a build these days?
>>> 
>>> 
>>