Code Review Policies

Stephen F Northover steve.x.northover at oracle.com
Thu Nov 7 06:36:48 PST 2013


Hello Committers,

Let me summarize how to initiate a code review, since this changed recently.

All information about how a bug was fixed needs to be in the JIRA. This 
means that all patches, webrevs, discussions and who is doing the review 
needs to be captured there.  The email to openjfx-dev is intended to 
inform the community that a review is happening so others can join in, 
but it doesn't need to contain detailed information about the fix.  
People can get all that from the JIRA.

This about it this way:  What we are trying to avoid is having any 
interesting information about the fix appear only in the mailing list.  
The bottom line is that the comment section of JIRA should contains the 
contents of the email that previously you would have sent to the list.  
If you want the information to be in two places, that is fine, but it 
must be in the JIRA.  However, the discussion and any subsequent action 
is in the JIRA.

https://wiki.openjdk.java.net/display/OpenJFX/Code+Reviews

Thanks,
Steve and Daniel



More information about the openjfx-dev mailing list