hg: openjfx/8/graphics/rt: [REFACTOR-ONLY]: Added some tests for NGRegion, and also did some very coarse refactoring by breaking the render method up into several sub methods. The only actual code change I made was to a copy/paste bug that existed where bottom was using "right" in its computation. All region tests continue passing. Some new region tests are ignored because of existing bugs. I'm pushing this refactor first, so I can then fix those bugs I found.

hang.vo at oracle.com hang.vo at oracle.com
Thu Oct 3 09:18:31 PDT 2013


Changeset: 26fbef1eb521
Author:    rbair
Date:      2013-10-03 09:03 -0700
URL:       http://hg.openjdk.java.net/openjfx/8/graphics/rt/rev/26fbef1eb521

[REFACTOR-ONLY]: Added some tests for NGRegion, and also did some very coarse refactoring by breaking the render method up into several sub methods. The only actual code change I made was to a copy/paste bug that existed where bottom was using "right" in its computation. All region tests continue passing. Some new region tests are ignored because of existing bugs. I'm pushing this refactor first, so I can then fix those bugs I found.

! modules/graphics/src/main/java/com/sun/javafx/sg/prism/NGNode.java
! modules/graphics/src/main/java/com/sun/javafx/sg/prism/NGRegion.java
+ modules/graphics/src/test/java/com/sun/javafx/sg/prism/NGRegionTest.java



More information about the openjfx-dev mailing list