hg: openjfx/8u-dev/rt: 4 new changesets

hang.vo at oracle.com hang.vo at oracle.com
Mon Apr 7 20:32:59 UTC 2014


Changeset: 27c2cb26999c
Author:    jgiles
Date:      2014-04-04 16:13 +1300
URL:       http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/27c2cb26999c

RT-36443: [TabPane] NPE from TabPaneSkin removeTab

! modules/controls/src/main/java/com/sun/javafx/scene/control/skin/TabPaneSkin.java

Changeset: 018792e200fa
Author:    jgiles
Date:      2014-04-08 07:23 +1200
URL:       http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/018792e200fa

RT-36353: When TableView sorting changes the SelectionModel selectedObject is changed to null temporarily.
Fix required a small change to TableView, but also uncovered a bug in SortedList when
setting the comparator back to null. I have written tests for both bugs, and they
have both been fixed in this Jira issue. The SortedList fix was provided by Martin.

! modules/base/src/main/java/javafx/collections/transformation/SortedList.java
! modules/base/src/test/java/javafx/collections/SortedListTest.java
! modules/controls/src/main/java/javafx/scene/control/TableView.java
! modules/controls/src/test/java/javafx/scene/control/TableViewTest.java

Changeset: deb903b836e2
Author:    jgiles
Date:      2014-04-08 07:29 +1200
URL:       http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/deb903b836e2

RT-36565: Tab lacks equals / hashCode methods

! modules/controls/src/main/java/javafx/scene/control/Tab.java
! modules/controls/src/test/java/javafx/scene/control/TabPaneTest.java

Changeset: 3d6222a15ffd
Author:    jgiles
Date:      2014-04-08 08:16 +1200
URL:       http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/3d6222a15ffd

[TEST ONLY] Updated controls tests to be more responsible - they now dispose of their StageLoader instances properly.
This should hopefully also improve the random test failures (which, according to my current theory, was due to GC happening too soon and taking down the stage).

! modules/controls/src/test/java/com/sun/javafx/scene/control/behavior/BehaviorBaseTest.java
! modules/controls/src/test/java/com/sun/javafx/scene/control/infrastructure/MouseEventFirer.java
! modules/controls/src/test/java/com/sun/javafx/scene/control/infrastructure/VirtualFlowTestUtils.java
! modules/controls/src/test/java/javafx/scene/control/ButtonTest.java
! modules/controls/src/test/java/javafx/scene/control/ColorPickerTest.java
! modules/controls/src/test/java/javafx/scene/control/ComboBoxTest.java
! modules/controls/src/test/java/javafx/scene/control/ListViewKeyInputTest.java
! modules/controls/src/test/java/javafx/scene/control/ListViewTest.java
! modules/controls/src/test/java/javafx/scene/control/SplitPaneTest.java
! modules/controls/src/test/java/javafx/scene/control/TabPaneTest.java
! modules/controls/src/test/java/javafx/scene/control/TableViewKeyInputTest.java
! modules/controls/src/test/java/javafx/scene/control/TableViewMouseInputTest.java
! modules/controls/src/test/java/javafx/scene/control/TableViewTest.java
! modules/controls/src/test/java/javafx/scene/control/TextFieldTest.java
! modules/controls/src/test/java/javafx/scene/control/TreeTableViewKeyInputTest.java
! modules/controls/src/test/java/javafx/scene/control/TreeTableViewMouseInputTest.java
! modules/controls/src/test/java/javafx/scene/control/TreeTableViewTest.java
! modules/controls/src/test/java/javafx/scene/control/TreeViewKeyInputTest.java
! modules/controls/src/test/java/javafx/scene/control/TreeViewTest.java
! modules/controls/src/test/java/javafx/scene/control/cell/TextFieldTableCellTest.java



More information about the openjfx-dev mailing list