[8u40] Review Request: (RT-37454) Node lookup with TabPane

David Grieve david.grieve at oracle.com
Mon Aug 4 16:47:01 UTC 2014


Jonathan,

If you could please, review 
http://cr.openjdk.java.net/~dgrieve/RT-37454/webrev.00 relative to 
https://javafx-jira.kenai.com/browse/RT-37454.

Basically, I override the Node methods in TabPane. In the normal case, 
where the control has been skinned, the call to super.lookup will return 
the node since it will be found in the skin. If the TabPane hasn't been 
skinned yet, the code will plumb the tab's content.

I wonder, though, whether the code should always look at the tab's 
content first.


More information about the openjfx-dev mailing list