[Review request] RT-12643: JavaFX Dialogs API

[Jonathan Giles]

Yes, that has already been resolved in my local repo - I noticed it after the webrev was generated.

Thanks,
-- Jonathan
Sent from a touch device. Please excuse my brevity.

On 15 August 2014 19:05:07 GMT+12:00, Ali Ebrahimi <ali.ebrahimi1781 at gmail.com> wrote:
>Hi,
>
>What do you think about this constants in javafx public API:
>
>+    // represented as a ButtonType
>+    public static final String BUTTON_DATA_PROPERTY  =
>"controlfx.button.type"; //$NON-NLS-1$
>+
>+    // allows to exclude button from uniform resizing
>+    public static final String BUTTON_SIZE_INDEPENDENCE =
>"controlfx.button.size.indepenence"; //$NON-NLS-1$
>
>may be you want javafx.button instead of controlfx.button, No?
>
>Ali Ebrahimi
>
>
>On Fri, Aug 15, 2014 at 4:18 AM, Jonathan Giles
><jonathan.giles at oracle.com>
>wrote:
>
>> Hi all,
>>
>> After much discussion a 'final' JavaFX Dialogs API has been created
>and is
>> awaiting final review. The plan is to integrate this into the 8udev
>repo
>> before it is promoted early next week.
>>
>> The Jira discussion for the dialogs API is long, but very
>informative. You
>> can find it here: https://javafx-jira.kenai.com/browse/RT-12643
>> The webrev can be found here: http://cr.openjdk.java.net/~
>> kcr/RT-12643/webrev.00/
>>
>> Any comments should be directed into the jira issue, rather than
>discussed
>> on this list (so that we can keep everything in one place).
>>
>> Thanks,
>> Jonathan
>>