[8u40] Review request: RT-39344 - [Ensemble8] Need various improvements in Dialog sample

[Kevin Rushforth]

As a reminder, please post review comments in JIRA (and I agree with 
both of Morris' comments).

Thanks.

-- Kevin


Morris Meyer wrote:
> On 12/4/14, 3:18 PM, Elina Kleyman wrote:
>>
>> Hi Morris and Kevin,
>>
>>  
>>
>> Please review my change to Ensemble (Dialogs):
>>
>>  
>>
>> JIRA:  https://javafx-jira.kenai.com/browse/RT-39344
>>
>> WEBREV:  http://cr.openjdk.java.net/~ekleyman/RT-39344/webrev/ 
>> <http://cr.openjdk.java.net/%7Eekleyman/RT-39344/webrev/>
>>
>>  
>>
>> Thanks,
>>
>> Elina
>>
>>  
>>
> Elina,
>
> Looks good.  My notes:
>
> 1. ! import javafx.scene.control.*;
>
> I'd rather see all of the classes explicitly in a developer facing 
> sample. 
>
> 2.  !             String type = (String) alert_types.getValue();
> !             switch (type) {
> !                 case "Information" :  
> setAlertType(AlertType.INFORMATION);
> !                                       break;
>
>
> Would rather see:
>         case "Information":
>             setAlertType(AlertType.INFORMATION);
>             break;
>
> Fine otherwise.
>
>         --mm
>
>