where to set properties

[Kevin Rushforth]

Hi Johan,

The build.properties was split out as a separate file for properties 
that change from release to release (or in the case of the JDK build 
number, from build to build) to make merges between code lines easier.

> We can either change jfx.build.jdk.version in build.properties (but not
> conditionally),

No, this is not what we want, since for desktop builds we require JDK 8 
and do not plan to relax this requirement.

> or we can skip the test if
> System.getProperty("jfx.build.jdk.defenders) is true, or we can check if
> the OS is Dalvik, or... or...

One possibility might be to define a property in buildSrc/dalvik.gradle 
that will act as an override for the JDK version check if it is set.

-- Kevin


Johan Vos wrote:
> Is there a policy on the location where properties are defined?
> I see there are properties on a number of places:
> build.properties (e.g. jfx.build.jdk.version=1.8.0)
> build.gradle (e.g. ext.JAVA_HOME = JDK_HOME)
> buildSrc/(e.g. linux).gradle (e.g. LINUX.compileSwing = true;)
> command line properties (e.g. -Djfx.build.jdk.defenders=true)
>
> The reason I'm asking:
> for Android/Dalvik, we don't require jfxBuildJdkVersion to be 1.8.0. There
> are a number of ways to fix this. The current test is
>  if (jdkVersion != jfxBuildJdkVersion) {
>             fail("java version mismatch: ${jdkVersion} must be
> ${jfxBuildJdkVersion}")
>         }
>
> We build the Android/Dalvik runtime with Java 7, hence this check fails.
> We can either change jfx.build.jdk.version in build.properties (but not
> conditionally), or we can skip the test if
> System.getProperty("jfx.build.jdk.defenders) is true, or we can check if
> the OS is Dalvik, or... or...
>
> I don't want to pollute the build files with too many tests, so I prefer to
> stick to the policy, if there is one.
>
> Thanks,
>
> - Johan
>