[Review request] 8145143: Promote Image.impl_getUrl() to public API as Image.getUrl()

Kevin Rushforth kevin.rushforth at oracle.com
Thu Dec 10 21:42:06 UTC 2015


Since this is a read-only get method of an immutable property, I guess 
it doesn't matter much. We can make it an Optional if that's what most 
folks want.

-- Kevin


Jonathan Giles wrote:
> I tend to be a fan of Optional....but it isn't something we have used 
> much of in JavaFX (I might be the only user of it so far in the Dialog 
> API).
>
> From my perspective then, I can +1 on the Optional, but we'll see what 
> others say.
>
> -- Jonathan
>
> On 11/12/15 10:27 AM, Tom Schindl wrote:
>> As i see it the url is optional so wouldn't make sense to return 
>> Optional<URL> to make this more explicit?
>>
>> Tom
>>
>> Von meinem iPhone gesendet
>>
>>> Am 10.12.2015 um 21:54 schrieb Jonathan Giles 
>>> <jonathan.giles at oracle.com>:
>>>
>>> Hi Chien, Kevin,
>>>
>>> Please can you review the following JBS issue (and attached patch):
>>>
>>> https://bugs.openjdk.java.net/browse/JDK-8145143
>>>
>>> As the subject line states, this issue proposes to promote the 
>>> Image.impl_getUrl() method to Image.getUrl(), so that it is public API.
>>>
>>> -- 
>>>
>>>
>>> -- Jonathan
>>>
>


More information about the openjfx-dev mailing list