From kevin.rushforth at oracle.com Wed Jul 1 01:11:26 2015 From: kevin.rushforth at oracle.com (Kevin Rushforth) Date: Tue, 30 Jun 2015 18:11:26 -0700 Subject: JavaFX features in JDK 9 In-Reply-To: References: <4A33E952-B3B0-4C19-9F5E-CBB10EC9E19B@gmail.com> <558EBC40.3020300@oracle.com> <558EED1C.8030005@poczta.onet.pl> <55918EB7.3060807@oracle.com> <5591956C.3080607@poczta.onet.pl> <5591AD59.3040000@oracle.com> <5591AE4E.3000409@poczta.onet.pl> <3BECEB07-DEA7-480C-82C9-BF957E7EFD50@gmail.com> <6D4A8ED9-A096-4E1E-9516-9BC48AC69C8D@moxley.co.uk> Message-ID: <55933E3E.6010101@oracle.com> Hard to say whether a public equivalent of NGExternalNode would be feasible in the JDK 9 time frame. It depends on how much work would be to expose what you would need in a way that would be robust. It isn't something we plan for JDK 9, but I haven't given it enough thought to know what would be involved. More interesting I think would be WebGL support itself or Rich Text (which was mentioned in this thread). We have RFEs filed for both, but neither are committed features. -- Kevin Michael Hoffer wrote: > Hi all, > > I agree that we need WebGL support in JavaFX. Recently, I made some > experiments with integrating the Qt based WebView/WebEngine into JavaFX via > synchronized shared memory buffers (see > https://www.youtube.com/watch?v=FlIrY1SlNM4 and > https://www.youtube.com/watch?v=CQXG77O2MqQ). > > what can i do as a lowly developer to help? > > > The implementation is highly experimental and there is a lot of work to do. > Any help is highly appreciated! The advantage compared to the > JavaFX WebKit project is that it is not necessary to fork WebKit. The > downside is that the integration is not as good. Updating to a new > versionof Qt WebView/WebEngine, however, is relatively easy since I'm using > a QPainter that draws to a shared memory buffer. JavaFX gets access to the > buffer via JNI. What concerns me is the limited API to directly draw > buffers without performing too much copying. > > Therefore, *we need a public equivalent of NGExternalNode* (used by > SwingNode, integrates Swing into JavaFX). Kevin, do you think this is > realistic for JavaFX 9? > > Anyway, here is a link to the github repo: https://github.com/miho/VFXWebKit > > Regards, > Michael > > > > 2015-06-30 14:09 GMT+02:00 Scott Palmer : > > >>> On Jun 30, 2015, at 7:21 AM, Mike Hearn wrote: >>> >>> ... >>> With respect to things like "support WebRTC" or "support WebGL" - >>> seriously? WebRTC is useful for exactly one kind of app, video chat. It >>> seems to have been driven primarily so Google could make a Skype >>> >> competitor >> >>> inside Gmail without having to make a downloadable plugin. There are >>> already many competing video call apps that work fine. >>> >> Video streaming, conferencing, etc. are important technologies. But if >> you are going with a Java UI, there isn?t much point in handcuffing >> yourself to a Web UI that will have a far worse user experience. >> >> >>> As for WebGL, you can already do OpenGL from within Java just fine. >>> >> Not ?just fine" in a JavaFX app though. With no access to native window >> handles or an OpenGL surface it?s not so simple. You have to fall back to >> AWT/Swing or go native and then you?ve got issues with the OpenGL parts not >> being well integrated into the rest of the UI. My commercial application >> has to create a separate AWT window to implement a video preview to avoid >> performance issues. With the AWT window I can get the native window handle >> and blit directly to the window without extra copies of uncompressed HD >> video frames. >> >> >>> Being >>> able to do arbitrary GL within an FX scene graph would be nice for some >>> apps, but of course, on Windows you'd really need to be using Direct3D or >>> some kind of performance-hurting translation layer as WebGL itself uses. >>> >> Exactly. Access to a native drawing surface has been discussed for a long >> time. It would be nice to see some progress made with JavaFX 9. >> >> >>> If I had a single wish it'd be for better rich text support, like a rich >>> text editor component (maybe based on Tomas Mikula's work). >>> >> That would be a great area for improvement. >> >> I personally would like to see my request for extensible media support >> (from 2008) to get some attention >> https://bugs.openjdk.java.net/browse/JDK-8091063 >> It should be possible (and reasonable) to write a non-linear editor like >> Final Cut Pro in Java (and some JNI) with a JavaFX UI. >> :-) >> >> >> Scott >> >> >>> On Tue, Jun 30, 2015 at 1:13 PM, Jack Moxley wrote: >>> >>> >>>> Maybe it should its aspirations a little higher, especially with the >>>> advent of unity, webgl or even scenegraph impls such as jmonkeyengine >>>> >> that >> >>>> do. >>>> >>>> Sent from my iPhone >>>> >>>> >>>>> On 30 Jun 2015, at 09:42, Felix Bembrick >>>>> >>>> wrote: >>>> >>>>> JavaFX has *never* claimed to be write once, run anyway >>>>> >>>>> >>>>> >>>>>> On 30 Jun 2015, at 18:13, Mike wrote: >>>>>> >>>>>> write once, run anywhere >>>>>> >>>>>> This about sums it up! >>>>>> >>>>>> >>>>>> >>>>>> >>>>>>> On Tue, Jun 30, 2015 at 12:12 AM, Jack Moxley >>>>>>> >>>> wrote: >>>> >>>>>>> write once, run anywhere >>>>>>> >>>>>>> Sent from my iPhone >>>>>>> >>>>>>> >>>>>>>>> On 29 Jun 2015, at 21:45, Micha? Zegan >>>>>>>> >>>>>>>> wrote: >>>>>>>> >>>>>>>> -----BEGIN PGP SIGNED MESSAGE----- >>>>>>>> Hash: SHA1 >>>>>>>> >>>>>>>> Does it mean platform support for linux won't be implemented now, or >>>>>>>> at all? >>>>>>>> I usually use windows, but still depend on that support because I >>>>>>>> sometimes use linux, so I am interested about that. >>>>>>>> >>>>>>>> W dniu 2015-06-29 o 22:40, Kevin Rushforth pisze: >>>>>>>> >>>>>>>>> There is public API in 8u40 to support accessibility. Applications >>>>>>>>> using standard JavaFX controls can, for example, use the >>>>>>>>> accessibleText property to define the text that the screen reader >>>>>>>>> will speak or the accessibleHelp property to provide a more >>>>>>>>> detailed description. These properties have reasonable defaults, >>>>>>>>> but can be overridden by applications. Additionally, if you use the >>>>>>>>> "labelFor" property to point to a Control that the Label is >>>>>>>>> associated with, the accessibility framework will use that when the >>>>>>>>> screen reader is active. >>>>>>>>> >>>>>>>>> Custom controls can override the queryAccessibleAttribute, >>>>>>>>> executeAccessibleAction, and notifyAccessibleAttributeChanged >>>>>>>>> methods. >>>>>>>>> >>>>>>>>> As for platform support, we currently support Windows and Mac >>>>>>>>> platforms. We have no plan to make FX accessible on Linux . >>>>>>>>> >>>>>>>>> -- Kevin >>>>>>>>> >>>>>>>>> >>>>>>>>> Micha? Zegan wrote: I saw it, and it seems promising, but: first, >>>>>>>>> there is probably, or I heard it wrong? no public api for making >>>>>>>>> accessibility related stuff... Also, I believe there is no linux >>>>>>>>> accessibility bridge as opposed to windows and mac. And I do not >>>>>>>>> know if I am wrong, or when this is going to be implemented. >>>>>>>>> >>>>>>>>> W dniu 2015-06-29 o 20:30, Kevin Rushforth pisze: >>>>>>>>> >>>>>>>>> >>>>>>>>>>>> JavaFX accessibility is already implemented and was delivered >>>>>>>>>>>> in JDK 8u40. >>>>>>>>>>>> >>>>>>>>>>>> -- Kevin >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> Micha? Zegan wrote: What about accessibility work? Work on it >>>>>>>>>>>> has been started, but not sure if it is still targetted for >>>>>>>>>>>> 9. >>>>>>>>>>>> >>>>>>>>>>>> W dniu 2015-06-27 o 20:16, Mike pisze: >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>>>>> a lot of FULL blown Webrtc support and building >>>>>>>>>>>>>>> something in Javafx (like Scene Builder) that Proves >>>>>>>>>>>>>>> Webrtc support would be awesome. Ditto to Webgl >>>>>>>>>>>>>>> support. >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> On Sat, Jun 27, 2015 at 8:07 AM, Kevin Rushforth >>>>>>>>>>>>>>> >>>>>>>>>>>>>> >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> wrote: >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> Hi Felix, >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> Sorry for the delay. Most of us were still pretty >>>>>>>>>>>>>>>> focused on 8u60, but we are turning our attention to >>>>>>>>>>>>>>>> JDK 9 now. >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> The focus for JDK 9 is Jigsaw. The currently planned >>>>>>>>>>>>>>>> big features (JEPs) for FX in JDK 9 are these: >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> JEP 253: Prepare JavaFX UI Controls & CSS APIs for >>>>>>>>>>>>>>>> Modularization JEP 257: Update JavaFX/Media to Newer >>>>>>>>>>>>>>>> Version of GStreamer >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> Related to Jigasw, we intend to look into new API for >>>>>>>>>>>>>>>> heavily used internal methods / classes since they >>>>>>>>>>>>>>>> will no longer be accessible otherwise. We also plan >>>>>>>>>>>>>>>> to update WebKit at least one more time, and will >>>>>>>>>>>>>>>> likely do a few RFEs such as better Hi-DPI support >>>>>>>>>>>>>>>> (with API control) on Mac, Windows, Linux. >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> We don't currently plan any other big features for 9, >>>>>>>>>>>>>>>> but will consider additional RFEs if they are >>>>>>>>>>>>>>>> important to enough developers and if they fit into >>>>>>>>>>>>>>>> the time frame. >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> -- Kevin >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> Felix Bembrick wrote: >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>> Anyone got anything or is there a link somewhere >>>>>>>>>>>>>>>>> that talks about these? >>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>> On 15 June 2015 at 22:00, Felix Bembrick >>>>>>>>>>>>>>>>> wrote: >>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>> I realise we are a long way off JDK 9 still and >>>>>>>>>>>>>>>>>> with crucial features such as Jigsaw still a >>>>>>>>>>>>>>>>>> little up in the air but is it possible someone >>>>>>>>>>>>>>>>>> could itemise the most likely new features, >>>>>>>>>>>>>>>>>> enhancements and bug fixes that we will see in >>>>>>>>>>>>>>>>>> JavaFX when JDK 9 is released? >>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>> Of course it's purely speculation at this point >>>>>>>>>>>>>>>>>> but it would assist me greatly to have some of >>>>>>>>>>>>>>>>>> idea of where JavaFX is heading and which areas >>>>>>>>>>>>>>>>>> are seen as most important. >>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>> Thanks, >>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>> Felix >>>>>>>>>>>>>>>>>> >> > > > From ooo_saturn7 at mail.ru Wed Jul 1 05:37:41 2015 From: ooo_saturn7 at mail.ru (=?UTF-8?B?QWxleCBTdmlyaWRvdg==?=) Date: Wed, 01 Jul 2015 08:37:41 +0300 Subject: =?UTF-8?B?Y29tYm9Cb3guc2V0VmFsdWUgYW5kIEFjdGlvbkV2ZW50IGN5Y2xl?= Message-ID: <1435729061.862490624@f424.i.mail.ru> I have combobox with page numbers (1,2,3,etc). When user select the certain page (by mouse or by keyboard(as combobox editable)) I? want to show and total pages. That's why on combobox action I do: @FXMLprivatevoid onPageComboBoxAction(ActionEvent event){ .... combobox.setValue(currentPage+"/"+totalPages) } However this code ( combobox . setValue ) fires one more ActionEvent and code cycles. I tried to use swithers like boolean ignoreActionEvent but it didn't work as it seems event is handled in different thread. How to solve such problem? P.S. I understand that this problem is for user mailing list but I ask at stackoverflow and get no answer. From samir.hadzic.pro at gmail.com Wed Jul 1 09:42:12 2015 From: samir.hadzic.pro at gmail.com (Sam') Date: Wed, 1 Jul 2015 11:42:12 +0200 Subject: Supported Font of JavaFX Message-ID: Is there a list somewhere of supported font by JavaFX? For example, the "Algerian" font is supported but italic font style is not working. But is working with Excel on my computer. So is that a bug or simply because that Font is not shipped with italic mode? Sam' From philip.race at oracle.com Wed Jul 1 15:23:49 2015 From: philip.race at oracle.com (Phil Race) Date: Wed, 01 Jul 2015 08:23:49 -0700 Subject: Supported Font of JavaFX In-Reply-To: References: Message-ID: <55940605.7080204@oracle.com> Exactly what version of Windows are you using ? Is there an actual italic variant of Algerian installed on your computer that you can see in the filesystem ? There used to be an issue that we had not implemented synthetic styling but I thought that went away when we started using DirectWrite. -phil. On 7/1/15 2:42 AM, Sam' wrote: > Is there a list somewhere of supported font by JavaFX? > > For example, the "Algerian" font is supported but italic font style is not > working. But is working with Excel on my computer. > > So is that a bug or simply because that Font is not shipped with italic > mode? > > Sam' From samir.hadzic.pro at gmail.com Wed Jul 1 15:29:11 2015 From: samir.hadzic.pro at gmail.com (Sam') Date: Wed, 1 Jul 2015 17:29:11 +0200 Subject: Supported Font of JavaFX In-Reply-To: <55940605.7080204@oracle.com> References: <55940605.7080204@oracle.com> Message-ID: I'm using Windows 7 64 bits. I looked into my fonts and you are right, I don't have an italic variant of the Algerian font. Question is, how does Excel and my navigator (Firefox) managed to display an Italic version of that font if I don't have it? They have their own fonts? Thanks 2015-07-01 17:23 GMT+02:00 Phil Race : > Exactly what version of Windows are you using ? > Is there an actual italic variant of Algerian installed on > your computer that you can see in the filesystem ? > There used to be an issue that we had not implemented synthetic styling > but I thought that went away when we started using DirectWrite. > > -phil. > > > On 7/1/15 2:42 AM, Sam' wrote: > >> Is there a list somewhere of supported font by JavaFX? >> >> For example, the "Algerian" font is supported but italic font style is not >> working. But is working with Excel on my computer. >> >> So is that a bug or simply because that Font is not shipped with italic >> mode? >> >> Sam' >> > > From philip.race at oracle.com Wed Jul 1 19:04:02 2015 From: philip.race at oracle.com (Phil Race) Date: Wed, 01 Jul 2015 12:04:02 -0700 Subject: Supported Font of JavaFX In-Reply-To: References: <55940605.7080204@oracle.com> Message-ID: <559439A2.3070901@oracle.com> On 07/01/2015 08:29 AM, Sam' wrote: > I'm using Windows 7 64 bits. > > I looked into my fonts and you are right, I don't have an italic > variant of the Algerian font. > > Question is, how does Excel and my navigator (Firefox) managed to > display an Italic version of that font if I don't have it? They have > their own fonts? No, they are synthesising it. This is what we do in Java SE (ie Java 2D). So far as I can see we do pass down the style request to DirectWrite so perhaps it gets lost somewhere before that .. or afterward, or perhaps it just has no effect in the way we use it. -phil. > > Thanks > > > 2015-07-01 17:23 GMT+02:00 Phil Race >: > > Exactly what version of Windows are you using ? > Is there an actual italic variant of Algerian installed on > your computer that you can see in the filesystem ? > There used to be an issue that we had not implemented synthetic > styling > but I thought that went away when we started using DirectWrite. > > -phil. > > > On 7/1/15 2:42 AM, Sam' wrote: > > Is there a list somewhere of supported font by JavaFX? > > For example, the "Algerian" font is supported but italic font > style is not > working. But is working with Excel on my computer. > > So is that a bug or simply because that Font is not shipped > with italic > mode? > > Sam' > > > From fbrunnerlist at gmx.ch Wed Jul 1 23:01:52 2015 From: fbrunnerlist at gmx.ch (Florian Brunner) Date: Thu, 02 Jul 2015 01:01:52 +0200 Subject: JavaFX features in JDK 9 In-Reply-To: <558EBC40.3020300@oracle.com> References: <4A33E952-B3B0-4C19-9F5E-CBB10EC9E19B@gmail.com> <558EBC40.3020300@oracle.com> Message-ID: <3509104.k00R3ZrUHt@andor> Hi Kevin, Thanks for the update. Back in 2012 there was the following statement from Oracle: "Oracle intends to standardize relevant parts of JavaFX through the JCP in the Java SE 9 time frame." http://www.oracle.com/us/corporate/press/1854982 What about this plan? -Florian Am Samstag, 27. Juni 2015, 08.07:44 schrieb Kevin Rushforth: > Hi Felix, > > Sorry for the delay. Most of us were still pretty focused on 8u60, but > we are turning our attention to JDK 9 now. > > The focus for JDK 9 is Jigsaw. The currently planned big features (JEPs) > for FX in JDK 9 are these: > > JEP 253: Prepare JavaFX UI Controls & CSS APIs for Modularization > JEP 257: Update JavaFX/Media to Newer Version of GStreamer > > Related to Jigasw, we intend to look into new API for heavily used > internal methods / classes since they will no longer be accessible > otherwise. We also plan to update WebKit at least one more time, and > will likely do a few RFEs such as better Hi-DPI support (with API > control) on Mac, Windows, Linux. > > We don't currently plan any other big features for 9, but will consider > additional RFEs if they are important to enough developers and if they > fit into the time frame. > > -- Kevin > > Felix Bembrick wrote: > > Anyone got anything or is there a link somewhere that talks about these? > > > > On 15 June 2015 at 22:00, Felix Bembrick wrote: > >> I realise we are a long way off JDK 9 still and with crucial features > >> such > >> as Jigsaw still a little up in the air but is it possible someone could > >> itemise the most likely new features, enhancements and bug fixes that we > >> will see in JavaFX when JDK 9 is released? > >> > >> Of course it's purely speculation at this point but it would assist me > >> greatly to have some of idea of where JavaFX is heading and which areas > >> are > >> seen as most important. > >> > >> Thanks, > >> > >> Felix From samir.hadzic.pro at gmail.com Thu Jul 2 07:53:39 2015 From: samir.hadzic.pro at gmail.com (Sam') Date: Thu, 2 Jul 2015 09:53:39 +0200 Subject: Supported Font of JavaFX In-Reply-To: <559439A2.3070901@oracle.com> References: <55940605.7080204@oracle.com> <559439A2.3070901@oracle.com> Message-ID: Then you tell me JavaFX should be able to display them? Should I open a bug then in the tracker? ----------------------------------------- Hadzic Samir Ing?nieur informatique 06 45 91 51 93 2015-07-01 21:04 GMT+02:00 Phil Race : > On 07/01/2015 08:29 AM, Sam' wrote: > > I'm using Windows 7 64 bits. > > I looked into my fonts and you are right, I don't have an italic variant > of the Algerian font. > > Question is, how does Excel and my navigator (Firefox) managed to display > an Italic version of that font if I don't have it? They have their own > fonts? > > > No, they are synthesising it. This is what we do in Java SE (ie Java 2D). > So far as I can see we do pass down the style request to DirectWrite > so perhaps it gets lost somewhere before that .. or afterward, or > perhaps it just has no effect in the way we use it. > > -phil. > > > Thanks > > > 2015-07-01 17:23 GMT+02:00 Phil Race : > >> Exactly what version of Windows are you using ? >> Is there an actual italic variant of Algerian installed on >> your computer that you can see in the filesystem ? >> There used to be an issue that we had not implemented synthetic styling >> but I thought that went away when we started using DirectWrite. >> >> -phil. >> >> >> On 7/1/15 2:42 AM, Sam' wrote: >> >>> Is there a list somewhere of supported font by JavaFX? >>> >>> For example, the "Algerian" font is supported but italic font style is >>> not >>> working. But is working with Excel on my computer. >>> >>> So is that a bug or simply because that Font is not shipped with italic >>> mode? >>> >>> Sam' >>> >> >> > > From steve.hruda at hexagongeospatial.com Thu Jul 2 10:09:26 2015 From: steve.hruda at hexagongeospatial.com (Hruda, Steve) Date: Thu, 2 Jul 2015 10:09:26 +0000 Subject: Patch for JDK-8090098 - [regression] Webview - getTimezoneOffset() of a ISO strings returns a wrong value In-Reply-To: <55930730.6050302@oracle.com> References: <559191AA.8030800@oracle.com> <5592D943.3090407@oracle.com> <5592E269.6050200@oracle.com> <5592FFDB.5090501@oracle.com> <55930730.6050302@oracle.com> Message-ID: Hi Anton, I saw your comments on https://bugs.openjdk.java.net/browse/JDK-8090098. We?ve opened the test page which you have mentioned in our own compiled WebKit version -> clean build & latest version. Used Timezone: Vienna CEST ? current Offset UTC+2:00 Without our Fix: Only the first and latest test pass. With our Fix: The same ? only the first and latest test pass. It seems that one changeset regress this behavior, but not the our latest ?if ?fix? if (diff<0) diff += secondsPerDay; I?m not able to build openjfx because of the missing dependencies (1.3). Please can you try what happens if you only apply the diff fix and not the previous patch, which includes all other date fixes. From my point of view are these fixes (which were provided by the patch file) not necessary to solve our datepicker problem. Thanks in advance, Steve From: Kevin Rushforth [mailto:kevin.rushforth at oracle.com] Sent: Tuesday, June 30, 2015 11:17 PM To: Hruda, Steve Cc: Anton V. Tarasov; openjfx-dev at openjdk.java.net Subject: Re: Patch for JDK-8090098 - [regression] Webview - getTimezoneOffset() of a ISO strings returns a wrong value Not by itself, although regressions are certainly taken very seriously. In any case, the process is to get this into 9-dev (once it has been reviewed), test it thoroughly, and then consider whether we can make a case for taking it to the 8u60 release team. -- Kevin Hruda, Steve wrote: Is a regression not release critical? Diese E-Mail wurde versandt im Auftrag des Unternehmens Intergraph Ges.m.b.H. Vertretungsberechtigte Gesch?ftsf?hrer: Maximilian Weber Sitz der Gesellschaft: Margaretenstra?e 70/I/1, 1050 Wien, ?sterreich, Tel. +43 (1) 9610567-0 Eingetragen beim Handelsgericht Wien, Firmenbuch-Nr.: FN 116859 b Umsatzsteuer-Identifikationsnummer / VAT-ID: ATU15138401, Steuer-Nummer: 264/4807 This E-Mail has been sent on behalf of the company Intergraph Ges.m.b.H. Authorised Managing Directors: Maximilian Weber Registered office and Austrian headquarters: Margaretenstr. 70/I/1, 1050 Wien, Austria, Tel. +43 (1) 9610567-0 The company is recorded at the commercial court of Vienna under the company register number FN 116859 b VAT-ID: ATU15138401, Austrian Tax ID: 264/4807 Diese E-Mail (mit zugeh?rigen Dateien) enth?lt m?glicherweise Informationen, die vertraulich sind, dem Urheberrecht unterliegen oder ein Gesch?ftsgeheimnis darstellen. Falls Sie diese Nachricht irrt?mlicherweise erhalten haben, benachrichtigen Sie uns bitte umgehend, indem Sie eine Antwort senden, und l?schen Sie bitte diese E-Mail und Ihre Antwort darauf. S?mtliche aufgef?hrten Ansichten oder Meinungen sind ausschlie?lich diejenigen des Autors und entsprechen nicht notwendigerweise denen des Unternehmens Intergraph. This E-Mail (and any attachments) may be confidential and protected by legal privilege. If you are not the intended recipient please notify us immediately by replying to the sender and delete this E-Mail and your reply from your system. All the views and opinions published here are solely based on the author's own opinion and should not be considered necessarily as reflecting the opinion of Intergraph. Diese E-Mail wurde versandt im Auftrag des Unternehmens Intergraph Ges.m.b.H. Vertretungsberechtigte Gesch?ftsf?hrer: Maximilian Weber Sitz der Gesellschaft: Margaretenstra?e 70/I/1, 1050 Wien, ?sterreich, Tel. +43 (1) 9610567-0 Eingetragen beim Handelsgericht Wien, Firmenbuch-Nr.: FN 116859 b Umsatzsteuer-Identifikationsnummer / VAT-ID: ATU15138401, Steuer-Nummer: 264/4807 This E-Mail has been sent on behalf of the company Intergraph Ges.m.b.H. Authorised Managing Directors: Maximilian Weber Registered office and Austrian headquarters: Margaretenstr. 70/I/1, 1050 Wien, Austria, Tel. +43 (1) 9610567-0 The company is recorded at the commercial court of Vienna under the company register number FN 116859 b VAT-ID: ATU15138401, Austrian Tax ID: 264/4807 Diese E-Mail (mit zugeh?rigen Dateien) enth?lt m?glicherweise Informationen, die vertraulich sind, dem Urheberrecht unterliegen oder ein Gesch?ftsgeheimnis darstellen. Falls Sie diese Nachricht irrt?mlicherweise erhalten haben, benachrichtigen Sie uns bitte umgehend, indem Sie eine Antwort senden, und l?schen Sie bitte diese E-Mail und Ihre Antwort darauf. S?mtliche aufgef?hrten Ansichten oder Meinungen sind ausschlie?lich diejenigen des Autors und entsprechen nicht notwendigerweise denen des Unternehmens Intergraph. This E-Mail (and any attachments) may be confidential and protected by legal privilege. If you are not the intended recipient please notify us immediately by replying to the sender and delete this E-Mail and your reply from your system. All the views and opinions published here are solely based on the author's own opinion and should not be considered necessarily as reflecting the opinion of Intergraph. -----Original Message----- From: Kevin Rushforth [mailto:kevin.rushforth at oracle.com] Sent: Tuesday, June 30, 2015 10:45 PM To: Anton V. Tarasov Cc: Hruda, Steve; openjfx-dev at openjdk.java.net Subject: Re: Patch for JDK-8090098 - [regression] Webview - getTimezoneOffset() of a ISO strings returns a wrong value Anton V. Tarasov wrote: On 30.06.2015 21:13, Hruda, Steve wrote: Hi Anton, thanks for the detailed information and the good news. You talk about JDK's jira? Am I right? ..... I don't have an access for that JIRA system since the JavaFX's Jira has moved to the JDK Bug System. Ah, ok. Then I'll quote your e-mail. About the Apple stuff. I know that Apple dropped Windows Safari support and in my opinion is this a very bad situation for WebKit (in case of Windows).... and especially since Google and Opera using Google's Blink engine. In case of the JDK it would be more practicable to switch from WebKit to Blink, because this engine is still used by Companies which have Windows end-users. There is a high probability that WebKit get more such bugs if there is no big player like Google or Apple who has the man power to fix such OS dependent issues. I see. However, switching to Blink is another story. Honestly, we're not planning it in the nearest future. This requires extra resources which we don't have at the moment... Last questions: Do you need any additional information from my side? And is it possible to integrate this fix in 8u60? From my side, I'll do a sanity check with WebKit LayoutTests, then if it goes well, we can consider commiting this to 8u60. @Kevin, do you think we can? Very unlikely. The JDK release team would need to approve, and only release-critical issues may be considered at this point (it would be hard to argue that this is release-critical since it has already been deferred). -- Kevin Also, as an option for you (Steve). You can post the changes to the WebKit alias and ask if they think this is a valid fix for the issue. Any confirmation from the WebKit team would help us to make sure the fix is reliable. Thanks! Anton. Thanks in advance! Best Regards, Steve Diese E-Mail wurde versandt im Auftrag des Unternehmens Intergraph Ges.m.b.H. Vertretungsberechtigte Gesch?ftsf?hrer: Maximilian Weber Sitz der Gesellschaft: Margaretenstra?e 70/I/1, 1050 Wien, ?sterreich, Tel. +43 (1) 9610567-0 Eingetragen beim Handelsgericht Wien, Firmenbuch-Nr.: FN 116859 b Umsatzsteuer-Identifikationsnummer / VAT-ID: ATU15138401, Steuer-Nummer: 264/4807 This E-Mail has been sent on behalf of the company Intergraph Ges.m.b.H. Authorised Managing Directors: Maximilian Weber Registered office and Austrian headquarters: Margaretenstr. 70/I/1, 1050 Wien, Austria, Tel. +43 (1) 9610567-0 The company is recorded at the commercial court of Vienna under the company register number FN 116859 b VAT-ID: ATU15138401, Austrian Tax ID: 264/4807 Diese E-Mail (mit zugeh?rigen Dateien) enth?lt m?glicherweise Informationen, die vertraulich sind, dem Urheberrecht unterliegen oder ein Gesch?ftsgeheimnis darstellen. Falls Sie diese Nachricht irrt?mlicherweise erhalten haben, benachrichtigen Sie uns bitte umgehend, indem Sie eine Antwort senden, und l?schen Sie bitte diese E-Mail und Ihre Antwort darauf. S?mtliche aufgef?hrten Ansichten oder Meinungen sind ausschlie?lich diejenigen des Autors und entsprechen nicht notwendigerweise denen des Unternehmens Intergraph. This E-Mail (and any attachments) may be confidential and protected by legal privilege. If you are not the intended recipient please notify us immediately by replying to the sender and delete this E-Mail and your reply from your system. All the views and opinions published here are solely based on the author's own opinion and should not be considered necessarily as reflecting the opinion of Intergraph. -----Original Message----- From: Anton V. Tarasov [mailto:anton.tarasov at oracle.com] Sent: Tuesday, June 30, 2015 8:01 PM To: Hruda, Steve; Kevin Rushforth Cc: openjfx-dev at openjdk.java.net Subject: Re: Patch for JDK-8090098 - [regression] Webview - getTimezoneOffset() of a ISO strings returns a wrong value Steve, I applied your suggestion and it worked on Windows. The missed check you discovered could really be a mistake in WebKit, because Apple dropped releasing (and shipping nightly builds for) Safari for Windows at 2012. Safari 5.1.7 was the last version. I downloaded and checked it. The date bug is not reproducible with it, but this gives us almost nothing taking into account the version is much outdated. So that Windows code path might not have been well tested, since http://trac.webkit.org/changeset/159892 was commited... (WebKit Win port is still supported and can be built on your own.) What I can do else to verify the changes is to run WebKit LayoutTests aimed at date testing and see if there're no regressions. Also, please put the info you posted into JIRA. Regards, Anton. On 29.06.2015 21:42, Anton Tarasov wrote: Hi Steve, Ok, I'll investigate it. Thanks, Anton. On 29.06.2015 18:39, Hruda, Steve wrote: Hi Anton & Kevin, we read your comments in the JDK bug system and analyzed WebKit's changesets again. We?ve found the code which made this regression. http://trac.webkit.org/changeset/159892 This changeset doesn't handle one special case, which was handled by the previous code.... double diff = ((localSystemTime.wHour - offsetHour) * secondsPerHour) + ((localSystemTime.wMinute - offsetMinute) *60); (http://trac.webkit.org/browser/trunk/Source/WTF/wtf/DateMath.cpp?a nn otate=blame#L481 ) The diff is wrong if the calculated the offsetTime is one day before in case of the extreme values (e.g. midnight) where the offsetHour of the UTC time is 23 because of the day difference. In case of all other OS systems you will see the same code -> http://trac.webkit.org/browser/trunk/Source/WTF/wtf/DateMath.cpp?an no tate=blame#L495 But there are two additional lines -> 497 & 497 which fixes this special case? *if*(diff<0) diff += secondsPerDay; That means ?. localSystemTime.wHour = 0; offsetHour=23 ? which causes a negative value ? and the diff+=secondsPerDay ensures that the diff result would be one Hour instead of -23 hours We?ve found the attached V8DateTests.js (renamed to .txt) and adjusted it a little bit to get the results logged in the browsers console. As you can see at ?ResulBeforeOurBugFix.txt? and ?ResultAfterOurBugFix.txt?, we were able to fix 6 tests which failed before out bug fix. assertEquals("Sat Oct 25 2014 23:00:00 GMT+0200 (W. Europe Daylight Time)", (new Date(2014, 9, 25, 23, 0)).toString()); assertEquals("Sat, 25 Oct 2014 21:00:00 GMT", (new Date(2014, 9, 25, 23, 0)).toUTCString()); assertEquals("Sat Oct 25 2014 23:59:00 GMT+0200 (W. Europe Daylight Time)", (new Date(2014, 9, 25, 23, 59)).toString()); assertEquals("Sat, 25 Oct 2014 21:59:00 GMT", (new Date(2014, 9, 25, 23, 59)).toUTCString()); assertEquals("Sun Oct 26 2014 00:00:00 GMT+0200 (W. Europe Daylight Time)", (new Date(2014, 9, 26, 0, 0)).toString()); assertEquals("Sun Oct 26 2014 00:59:00 GMT+0200 (W. Europe Daylight Time)", (new Date(2014, 9, 26, 0, 59)).toString()); In addition we found out that WebKit also have problems in case of Windows in case of the change from winter to summer time. *_Winter to summer time:_* assertEquals("Sun Mar 30 2014 03:00:00 GMT+0200 (W. Europe Daylight Time)", (new Date(2014, 2, 30, 2, 0)).toString()); assertEquals("Sun, 30 Mar 2014 01:00:00 GMT", (new Date(2014, 2, 30, 2, 0)).toUTCString()); assertEquals("Sun Mar 30 2014 03:59:00 GMT+0200 (W. Europe Daylight Time)", (new Date(2014, 2, 30, 2, 59)).toString()); assertEquals("Sun, 30 Mar 2014 01:59:00 GMT", (new Date(2014, 2, 30, 2, 59)).toUTCString()); *_Summer to winter time:_* assertEquals("Sun Oct 26 2014 02:00:00 GMT+0200 (W. Europe Daylight Time)", (new Date(2014, 9, 26, 2, 0)).toString()); assertEquals("Sun, 26 Oct 2014 00:00:00 GMT", (new Date(2014, 9, 26, 2, 0)).toUTCString()); assertEquals("Sun Oct 26 2014 02:59:00 GMT+0200 (W. Europe Daylight Time)", (new Date(2014, 9, 26, 2, 59)).toString()); assertEquals("Sun, 26 Oct 2014 00:59:00 GMT", (new Date(2014, 9, 26, 2, 59)).toUTCString()); We will try to find a solution for that, but I think that the priority of this issue is lower than the priority of the opened regression. It would be amazing if you can add the patch of my previous and these additional two lines (DateMath.cpp) to the JDK8u60. Best Regards, Steve Diese E-Mail wurde versandt im Auftrag des Unternehmens Intergraph Ges.m.b.H. Vertretungsberechtigte Gesch?ftsf?hrer: Maximilian Weber Sitz der Gesellschaft: Margaretenstra?e 70/I/1, 1050 Wien, ?sterreich, Tel. +43 (1) 9610567-0 Eingetragen beim Handelsgericht Wien, Firmenbuch-Nr.: FN 116859 b Umsatzsteuer-Identifikationsnummer / VAT-ID: ATU15138401, Steuer-Nummer: 264/4807 This E-Mail has been sent on behalf of the company Intergraph Ges.m.b.H. Authorised Managing Directors: Maximilian Weber Registered office and Austrian headquarters: Margaretenstr. 70/I/1, 1050 Wien, Austria, Tel. +43 (1) 9610567-0 The company is recorded at the commercial court of Vienna under the company register number FN 116859 b VAT-ID: ATU15138401, Austrian Tax ID: 264/4807 Diese E-Mail (mit zugeh?rigen Dateien) enth?lt m?glicherweise Informationen, die vertraulich sind, dem Urheberrecht unterliegen oder ein Gesch?ftsgeheimnis darstellen. Falls Sie diese Nachricht irrt?mlicherweise erhalten haben, benachrichtigen Sie uns bitte umgehend, indem Sie eine Antwort senden, und l?schen Sie bitte diese E-Mail und Ihre Antwort darauf. S?mtliche aufgef?hrten Ansichten oder Meinungen sind ausschlie?lich diejenigen des Autors und entsprechen nicht notwendigerweise denen des Unternehmens Intergraph. This E-Mail (and any attachments) may be confidential and protected by legal privilege. If you are not the intended recipient please notify us immediately by replying to the sender and delete this E-Mail and your reply from your system. All the views and opinions published here are solely based on the author's own opinion and should not be considered necessarily as reflecting the opinion of Intergraph. -----Original Message----- From: openjfx-dev [mailto:openjfx-dev-bounces at openjdk.java.net] On Behalf Of Hruda, Steve Sent: Tuesday, June 23, 2015 6:26 PM To: Anton V. Tarasov; Kevin Rushforth Cc: openjfx-dev at openjdk.java.net Subject: RE: Patch for JDK-8090098 - [regression] Webview - getTimezoneOffset() of a ISO strings returns a wrong value Very cool Anton. I would be great if that pach could be added to 8u60, otherwise our all our customers have to avoid Java 8u60. Regards, Steve Diese E-Mail wurde versandt im Auftrag des Unternehmens Intergraph Ges.m.b.H. Vertretungsberechtigte Gesch?ftsf?hrer: Maximilian Weber Sitz der Gesellschaft: Margaretenstra?e 70/I/1, 1050 Wien, ?sterreich, Tel. +43 (1) 9610567-0 Eingetragen beim Handelsgericht Wien, Firmenbuch-Nr.: FN 116859 b Umsatzsteuer-Identifikationsnummer / VAT-ID: ATU15138401, Steuer-Nummer: 264/4807 This E-Mail has been sent on behalf of the company Intergraph Ges.m.b.H. Authorised Managing Directors: Maximilian Weber Registered office and Austrian headquarters: Margaretenstr. 70/I/1, 1050 Wien, Austria, Tel. +43 (1) 9610567-0 The company is recorded at the commercial court of Vienna under the company register number FN 116859 b VAT-ID: ATU15138401, Austrian Tax ID: 264/4807 Diese E-Mail (mit zugeh?rigen Dateien) enth?lt m?glicherweise Informationen, die vertraulich sind, dem Urheberrecht unterliegen oder ein Gesch?ftsgeheimnis darstellen. Falls Sie diese Nachricht irrt?mlicherweise erhalten haben, benachrichtigen Sie uns bitte umgehend, indem Sie eine Antwort senden, und l?schen Sie bitte diese E-Mail und Ihre Antwort darauf. S?mtliche aufgef?hrten Ansichten oder Meinungen sind ausschlie?lich diejenigen des Autors und entsprechen nicht notwendigerweise denen des Unternehmens Intergraph. This E-Mail (and any attachments) may be confidential and protected by legal privilege. If you are not the intended recipient please notify us immediately by replying to the sender and delete this E-Mail and your reply from your system. All the views and opinions published here are solely based on the author's own opinion and should not be considered necessarily as reflecting the opinion of Intergraph. -----Original Message----- From: Anton V. Tarasov [mailto:anton.tarasov at oracle.com] Sent: Tuesday, June 23, 2015 5:46 PM To: Kevin Rushforth; Hruda, Steve Cc: openjfx-dev at openjdk.java.net Subject: Re: Patch for JDK-8090098 - [regression] Webview - getTimezoneOffset() of a ISO strings returns a wrong value On 23.06.2015 17:48, Kevin Rushforth wrote: Hi Steve, Thank you for taking the time to create this patch. I will add this information to the bug report. Since your OCA is in progress we will take a look at your patch, but will need indication from the OCA office that it the OCA has been received before we could push it. And just to be clear, you won't have access to the repository even with an OCA. What the OCA will do is allow you to contribute patches. I will note that it is likely too late for 8u60, but Anton can evaluate it and post his comment in the bug report. Kevin, I'm checking it. Steve, thanks for the participation! Regards, Anton. -- Kevin Hruda, Steve wrote: Hi, I've created a 8u-dev patch for the following WeKit regression which comes with 8u60. https://bugs.openjdk.java.net/browse/JDK-8090098 Please can someone of you apply this patch to fix the getTimezoneOffset() issue. I have no access to the repository -> my OCA is still pending. In addition I tried to test this patch , but I wasn't able to build the necessary jfxwebkit.dll on my windows system (https://www.mail-archive.com/openjfx-dev at openjdk.java.net/msg094 3 9.h tml )..... but I got no compile erros on Mac. Patch download: https://drive.google.com/file/d/0B7P_rknS1TWxM3BSTTU2OVZ4dGM/view ?u sp =sharing The patch includes the following WebKit fixes: Changeset 174377 - [Win] DateMath's calculateUTFOffset does not account for DST. http://trac.webkit.org/changeset/174377 Changeset 175078 - String(new Date(Mar 30 2014 01:00:00)) is wrong in CET http://trac.webkit.org/changeset/175078 Changeset 181360 - [Win] 17 different JSC tests started to fail in DST http://trac.webkit.org/changeset/181360 Please let me know if you need further information. Thanks in advance! Best Regards Steve Diese E-Mail wurde versandt im Auftrag des Unternehmens Intergraph Ges.m.b.H. Vertretungsberechtigte Gesch?ftsf?hrer: Maximilian Weber Sitz der Gesellschaft: Margaretenstra?e 70/I/1, 1050 Wien, ?sterreich, Tel. +43 (1) 9610567-0 Eingetragen beim Handelsgericht Wien, Firmenbuch-Nr.: FN 116859 b Umsatzsteuer-Identifikationsnummer / VAT-ID: ATU15138401, Steuer-Nummer: 264/4807 This E-Mail has been sent on behalf of the company Intergraph Ges.m.b.H. Authorised Managing Directors: Maximilian Weber Registered office and Austrian headquarters: Margaretenstr. 70/I/1, 1050 Wien, Austria, Tel. +43 (1) 9610567-0 The company is recorded at the commercial court of Vienna under the company register number FN 116859 b VAT-ID: ATU15138401, Austrian Tax ID: 264/4807 Diese E-Mail (mit zugeh?rigen Dateien) enth?lt m?glicherweise Informationen, die vertraulich sind, dem Urheberrecht unterliegen oder ein Gesch?ftsgeheimnis darstellen. Falls Sie diese Nachricht irrt?mlicherweise erhalten haben, benachrichtigen Sie uns bitte umgehend, indem Sie eine Antwort senden, und l?schen Sie bitte diese E-Mail und Ihre Antwort darauf. S?mtliche aufgef?hrten Ansichten oder Meinungen sind ausschlie?lich diejenigen des Autors und entsprechen nicht notwendigerweise denen des Unternehmens Intergraph. This E-Mail (and any attachments) may be confidential and protected by legal privilege. If you are not the intended recipient please notify us immediately by replying to the sender and delete this E-Mail and your reply from your system. All the views and opinions published here are solely based on the author's own opinion and should not be considered necessarily as reflecting the opinion of Intergraph. From anton.tarasov at oracle.com Thu Jul 2 12:50:05 2015 From: anton.tarasov at oracle.com (Anton V. Tarasov) Date: Thu, 02 Jul 2015 15:50:05 +0300 Subject: Patch for JDK-8090098 - [regression] Webview - getTimezoneOffset() of a ISO strings returns a wrong value In-Reply-To: References: <559191AA.8030800@oracle.com> <5592D943.3090407@oracle.com> <5592E269.6050200@oracle.com> <5592FFDB.5090501@oracle.com> <55930730.6050302@oracle.com> Message-ID: <5595337D.6000609@oracle.com> Hi Steve, Actually, I already checked that removing if (diff<0) diff += secondsPerDay; didn't help. Regards, Anton. On 02.07.2015 13:09, Hruda, Steve wrote: > > Hi Anton, > > I saw your comments on https://bugs.openjdk.java.net/browse/JDK-8090098. > > We?ve opened the test page which you have mentioned in our own compiled WebKit version -> clean > build & latest version. > > Used Timezone: Vienna CEST ? current Offset UTC+2:00 > > Without our Fix: > > Only the first and latest test pass. > > With our Fix: > > The same ? only the first and latest test pass. > > It seems that one changeset regress this behavior, but not the our latest ?if ?fix? > > if (diff<0) > diff += secondsPerDay; > > I?m not able to build openjfx because of the missing dependencies (1.3). Please can you try what > happens if you only apply the diff fix and not the previous patch, which includes all other date > fixes. From my point of view are these fixes (which were provided by the patch file) not > necessary to solve our datepicker problem. > > Thanks in advance, > > Steve > > *From:*Kevin Rushforth [mailto:kevin.rushforth at oracle.com] > *Sent:* Tuesday, June 30, 2015 11:17 PM > *To:* Hruda, Steve > *Cc:* Anton V. Tarasov; openjfx-dev at openjdk.java.net > *Subject:* Re: Patch for JDK-8090098 - [regression] Webview - getTimezoneOffset() of a ISO strings > returns a wrong value > > Not by itself, although regressions are certainly taken very seriously. > > In any case, the process is to get this into 9-dev (once it has been reviewed), test it > thoroughly, and then consider whether we can make a case for taking it to the 8u60 release team. > > -- Kevin > > > Hruda, Steve wrote: > > Is a regression not release critical? > > > > > > > > > > Diese E-Mail wurde versandt im Auftrag des Unternehmens Intergraph Ges.m.b.H. > > Vertretungsberechtigte Gesch?ftsf?hrer: Maximilian Weber > > Sitz der Gesellschaft: Margaretenstra?e 70/I/1, 1050 Wien, ?sterreich, Tel. +43 (1) 9610567-0 > > Eingetragen beim Handelsgericht Wien, Firmenbuch-Nr.: FN 116859 b > > Umsatzsteuer-Identifikationsnummer / VAT-ID: ATU15138401, Steuer-Nummer: 264/4807 > > > > This E-Mail has been sent on behalf of the company Intergraph Ges.m.b.H. > > Authorised Managing Directors: Maximilian Weber > > Registered office and Austrian headquarters: Margaretenstr. 70/I/1, 1050 Wien, Austria, Tel. +43 (1) 9610567-0 > > The company is recorded at the commercial court of Vienna under the company register number FN 116859 b > > VAT-ID: ATU15138401, Austrian Tax ID: 264/4807 > > > > Diese E-Mail (mit zugeh?rigen Dateien) enth?lt m?glicherweise Informationen, die vertraulich sind, dem Urheberrecht unterliegen oder ein Gesch?ftsgeheimnis darstellen. Falls Sie diese Nachricht irrt?mlicherweise erhalten haben, benachrichtigen Sie uns bitte umgehend, indem Sie eine Antwort senden, und l?schen Sie bitte diese E-Mail und Ihre Antwort darauf. S?mtliche aufgef?hrten Ansichten oder Meinungen sind ausschlie?lich diejenigen des Autors und entsprechen nicht notwendigerweise denen des Unternehmens Intergraph. > > > > This E-Mail (and any attachments) may be confidential and protected by legal privilege. If you are not the intended recipient please notify us immediately by replying to the sender and delete this E-Mail and your reply from your system. All the views and opinions published here are solely based on the author's own opinion and should not be considered necessarily as reflecting the opinion of Intergraph. > > > > > > > Diese E-Mail wurde versandt im Auftrag des Unternehmens Intergraph Ges.m.b.H. > Vertretungsberechtigte Gesch?ftsf?hrer: Maximilian Weber > Sitz der Gesellschaft: Margaretenstra?e 70/I/1, 1050 Wien, ?sterreich, Tel. +43 (1) 9610567-0 > Eingetragen beim Handelsgericht Wien, Firmenbuch-Nr.: FN 116859 b > Umsatzsteuer-Identifikationsnummer / VAT-ID: ATU15138401, Steuer-Nummer: 264/4807 > > This E-Mail has been sent on behalf of the company Intergraph Ges.m.b.H. > Authorised Managing Directors: Maximilian Weber > Registered office and Austrian headquarters: Margaretenstr. 70/I/1, 1050 Wien, Austria, Tel. +43 > (1) 9610567-0 > The company is recorded at the commercial court of Vienna under the company register number FN > 116859 b > VAT-ID: ATU15138401, Austrian Tax ID: 264/4807 > > Diese E-Mail (mit zugeh?rigen Dateien) enth?lt m?glicherweise Informationen, die vertraulich sind, > dem Urheberrecht unterliegen oder ein Gesch?ftsgeheimnis darstellen. Falls Sie diese Nachricht > irrt?mlicherweise erhalten haben, benachrichtigen Sie uns bitte umgehend, indem Sie eine Antwort > senden, und l?schen Sie bitte diese E-Mail und Ihre Antwort darauf. S?mtliche aufgef?hrten > Ansichten oder Meinungen sind ausschlie?lich diejenigen des Autors und entsprechen nicht > notwendigerweise denen des Unternehmens Intergraph. > > This E-Mail (and any attachments) may be confidential and protected by legal privilege. If you are > not the intended recipient please notify us immediately by replying to the sender and delete this > E-Mail and your reply from your system. All the views and opinions published here are solely based > on the author's own opinion and should not be considered necessarily as reflecting the opinion of > Intergraph. > > -----Original Message----- > > From: Kevin Rushforth [mailto:kevin.rushforth at oracle.com] > > Sent: Tuesday, June 30, 2015 10:45 PM > > To: Anton V. Tarasov > > Cc: Hruda, Steve;openjfx-dev at openjdk.java.net > > Subject: Re: Patch for JDK-8090098 - [regression] Webview - getTimezoneOffset() of a ISO strings returns a wrong value > > > > > > > > Anton V. Tarasov wrote: > > > > On 30.06.2015 21:13, Hruda, Steve wrote: > > > > Hi Anton, > > thanks for the detailed information and the good news. > > > > You talk about JDK's jira? Am I right? ..... I don't have an access > > for that JIRA system since the JavaFX's Jira has moved to the JDK Bug > > System. > > > > Ah, ok. Then I'll quote your e-mail. > > > > > > About the Apple stuff. > > I know that Apple dropped Windows Safari support and in my opinion is > > this a very bad situation for WebKit (in case of Windows).... and > > especially since Google and Opera using Google's Blink engine. > > > > In case of the JDK it would be more practicable to switch from WebKit > > to Blink, because this engine is still used by Companies which have > > Windows end-users. > > > > There is a high probability that WebKit get more such bugs if there > > is no big player like Google or Apple who has the man power to fix > > such OS dependent issues. > > > > I see. However, switching to Blink is another story. Honestly, we're > > not planning it in the nearest future. This requires extra resources > > which we don't have at the moment... > > > > > > Last questions: > > Do you need any additional information from my side? And is it > > possible to integrate this fix in 8u60? > > > > From my side, I'll do a sanity check with WebKit LayoutTests, then if > > it goes well, we can consider commiting this to 8u60. > > > > @Kevin, do you think we can? > > > > > > Very unlikely. The JDK release team would need to approve, and only release-critical issues may be considered at this point (it would be hard to argue that this is release-critical since it has already been deferred). > > > > -- Kevin > > > > > > > > Also, as an option for you (Steve). You can post the changes to the > > WebKit alias and ask if they think this is a valid fix for the issue. > > Any confirmation from the WebKit team would help us to make sure the > > fix is reliable. > > > > Thanks! > > Anton. > > > > > > Thanks in advance! > > Best Regards, > > Steve > > > > > > > > > > Diese E-Mail wurde versandt im Auftrag des Unternehmens Intergraph > > Ges.m.b.H. > > Vertretungsberechtigte Gesch?ftsf?hrer: Maximilian Weber Sitz der > > Gesellschaft: Margaretenstra?e 70/I/1, 1050 Wien, ?sterreich, Tel. > > +43 (1) 9610567-0 Eingetragen beim Handelsgericht Wien, > > Firmenbuch-Nr.: FN 116859 b Umsatzsteuer-Identifikationsnummer / > > VAT-ID: ATU15138401, > > Steuer-Nummer: 264/4807 > > > > This E-Mail has been sent on behalf of the company Intergraph Ges.m.b.H. > > Authorised Managing Directors: Maximilian Weber Registered office and > > Austrian headquarters: Margaretenstr. 70/I/1, > > 1050 Wien, Austria, Tel. +43 (1) 9610567-0 The company is recorded at > > the commercial court of Vienna under the company register number FN > > 116859 b > > VAT-ID: ATU15138401, Austrian Tax ID: 264/4807 > > > > Diese E-Mail (mit zugeh?rigen Dateien) enth?lt m?glicherweise > > Informationen, die vertraulich sind, dem Urheberrecht unterliegen > > oder ein Gesch?ftsgeheimnis darstellen. Falls Sie diese Nachricht > > irrt?mlicherweise erhalten haben, benachrichtigen Sie uns bitte > > umgehend, indem Sie eine Antwort senden, und l?schen Sie bitte diese > > E-Mail und Ihre Antwort darauf. S?mtliche aufgef?hrten Ansichten oder > > Meinungen sind ausschlie?lich diejenigen des Autors und entsprechen > > nicht notwendigerweise denen des Unternehmens Intergraph. > > > > This E-Mail (and any attachments) may be confidential and protected > > by legal privilege. If you are not the intended recipient please > > notify us immediately by replying to the sender and delete this > > E-Mail and your reply from your system. All the views and opinions > > published here are solely based on the author's own opinion and > > should not be considered necessarily as reflecting the opinion of > > Intergraph. > > > > > > -----Original Message----- > > From: Anton V. Tarasov [mailto:anton.tarasov at oracle.com] > > Sent: Tuesday, June 30, 2015 8:01 PM > > To: Hruda, Steve; Kevin Rushforth > > Cc:openjfx-dev at openjdk.java.net > > Subject: Re: Patch for JDK-8090098 - [regression] Webview - > > getTimezoneOffset() of a ISO strings returns a wrong value > > > > Steve, > > > > I applied your suggestion and it worked on Windows. > > > > The missed check you discovered could really be a mistake in WebKit, > > because Apple dropped releasing (and shipping nightly builds for) > > Safari for Windows at 2012. > > Safari 5.1.7 was the last version. I downloaded and checked it. The > > date bug is not reproducible with it, but this gives us almost > > nothing taking into account the version is much outdated. > > > > So that Windows code path might not have been well tested, since > > http://trac.webkit.org/changeset/159892 was commited... > > > > (WebKit Win port is still supported and can be built on your own.) > > > > What I can do else to verify the changes is to run WebKit LayoutTests > > aimed at date testing and see if there're no regressions. > > > > Also, please put the info you posted into JIRA. > > > > Regards, > > Anton. > > > > On 29.06.2015 21:42, Anton Tarasov wrote: > > > > Hi Steve, > > > > Ok, I'll investigate it. > > > > Thanks, > > Anton. > > > > On 29.06.2015 18:39, Hruda, Steve wrote: > > > > Hi Anton & Kevin, > > > > we read your comments in the JDK bug system and analyzed WebKit's > > changesets again. > > > > We?ve found the code which made this regression. > > > > http://trac.webkit.org/changeset/159892 > > > > This changeset doesn't handle one special case, which was handled > > by the previous code.... > > > > double diff = ((localSystemTime.wHour - offsetHour) * > > secondsPerHour) > > + ((localSystemTime.wMinute > > - offsetMinute) *60); > > > > > > (http://trac.webkit.org/browser/trunk/Source/WTF/wtf/DateMath.cpp?a > > nn > > otate=blame#L481 ) > > > > The diff is wrong if the calculated the offsetTime is one day > > before in case of the extreme values (e.g. midnight) where the > > offsetHour of the UTC time is 23 because of the day difference. > > > > In case of all other OS systems you will see the same code -> > > http://trac.webkit.org/browser/trunk/Source/WTF/wtf/DateMath.cpp?an > > no > > tate=blame#L495 > > > > But there are two additional lines -> 497 & 497 which fixes this > > special case? > > > > *if*(diff<0) > > > > diff += secondsPerDay; > > > > > > That means ?. > > > > localSystemTime.wHour = 0; > > > > offsetHour=23 ? which causes a negative value ? and the > > diff+=secondsPerDay ensures that the diff result would be one Hour > > instead of -23 hours > > > > We?ve found the attached V8DateTests.js (renamed to .txt) and > > adjusted it a little bit to get the results logged in the browsers > > console. > > > > As you can see at ?ResulBeforeOurBugFix.txt? and > > ?ResultAfterOurBugFix.txt?, we were able to fix > > 6 tests which failed before out bug fix. > > > > assertEquals("Sat Oct 25 2014 23:00:00 GMT+0200 (W. Europe Daylight > > Time)", > > > > (new Date(2014, 9, 25, 23, 0)).toString()); > > > > assertEquals("Sat, 25 Oct 2014 21:00:00 GMT", > > > > (new Date(2014, 9, 25, 23, 0)).toUTCString()); > > > > assertEquals("Sat Oct 25 2014 23:59:00 GMT+0200 (W. Europe > > Daylight Time)", > > > > (new Date(2014, 9, 25, 23, 59)).toString()); > > > > assertEquals("Sat, 25 Oct 2014 21:59:00 GMT", > > > > (new Date(2014, 9, 25, 23, 59)).toUTCString()); > > > > assertEquals("Sun Oct 26 2014 00:00:00 GMT+0200 (W. Europe > > Daylight Time)", > > > > (new Date(2014, 9, 26, 0, 0)).toString()); > > > > assertEquals("Sun Oct 26 2014 00:59:00 GMT+0200 (W. Europe Daylight > > Time)", > > > > (new Date(2014, 9, 26, 0, 59)).toString()); > > > > In addition we found out that WebKit also have problems in case of > > Windows in case of the change from winter to summer time. > > > > *_Winter to summer time:_* > > > > assertEquals("Sun Mar 30 2014 03:00:00 GMT+0200 (W. Europe Daylight > > Time)", > > > > (new Date(2014, 2, 30, 2, 0)).toString()); > > > > assertEquals("Sun, 30 Mar 2014 01:00:00 GMT", > > > > (new Date(2014, 2, 30, 2, 0)).toUTCString()); > > > > assertEquals("Sun Mar 30 2014 03:59:00 GMT+0200 (W. Europe > > Daylight Time)", > > > > (new Date(2014, 2, 30, 2, 59)).toString()); > > > > assertEquals("Sun, 30 Mar 2014 01:59:00 GMT", > > > > (new Date(2014, 2, 30, 2, 59)).toUTCString()); > > > > *_Summer to winter time:_* > > > > assertEquals("Sun Oct 26 2014 02:00:00 GMT+0200 (W. Europe Daylight > > Time)", > > > > (new Date(2014, 9, 26, 2, 0)).toString()); > > > > assertEquals("Sun, 26 Oct 2014 00:00:00 GMT", > > > > (new Date(2014, 9, 26, 2, 0)).toUTCString()); > > > > assertEquals("Sun Oct 26 2014 02:59:00 GMT+0200 (W. Europe > > Daylight Time)", > > > > (new Date(2014, 9, 26, 2, 59)).toString()); > > > > assertEquals("Sun, 26 Oct 2014 00:59:00 GMT", > > > > (new Date(2014, 9, 26, 2, 59)).toUTCString()); > > > > We will try to find a solution for that, but I think that the > > priority of this issue is lower than the priority of the opened > > regression. > > > > It would be amazing if you can add the patch of my previous and > > these additional two lines > > (DateMath.cpp) to the JDK8u60. > > > > Best Regards, > > > > Steve > > > > > > Diese E-Mail wurde versandt im Auftrag des Unternehmens Intergraph > > Ges.m.b.H. > > Vertretungsberechtigte Gesch?ftsf?hrer: Maximilian Weber Sitz der > > Gesellschaft: Margaretenstra?e 70/I/1, 1050 Wien, ?sterreich, Tel. > > +43 (1) 9610567-0 Eingetragen beim Handelsgericht Wien, > > Firmenbuch-Nr.: FN 116859 b Umsatzsteuer-Identifikationsnummer / > > VAT-ID: ATU15138401, Steuer-Nummer: 264/4807 > > > > This E-Mail has been sent on behalf of the company Intergraph > > Ges.m.b.H. > > Authorised Managing Directors: Maximilian Weber Registered office > > and Austrian headquarters: Margaretenstr. 70/I/1, 1050 Wien, > > Austria, Tel. +43 > > (1) 9610567-0 > > The company is recorded at the commercial court of Vienna under the > > company register number FN > > 116859 b > > VAT-ID: ATU15138401, Austrian Tax ID: 264/4807 > > > > Diese E-Mail (mit zugeh?rigen Dateien) enth?lt m?glicherweise > > Informationen, die vertraulich sind, dem Urheberrecht unterliegen > > oder ein Gesch?ftsgeheimnis darstellen. Falls Sie diese Nachricht > > irrt?mlicherweise erhalten haben, benachrichtigen Sie uns bitte > > umgehend, indem Sie eine Antwort senden, und l?schen Sie bitte > > diese E-Mail und Ihre Antwort darauf. S?mtliche aufgef?hrten > > Ansichten oder Meinungen sind ausschlie?lich diejenigen des Autors > > und entsprechen nicht notwendigerweise denen des Unternehmens Intergraph. > > > > This E-Mail (and any attachments) may be confidential and protected > > by legal privilege. If you are not the intended recipient please > > notify us immediately by replying to the sender and delete this > > E-Mail and your reply from your system. All the views and opinions > > published here are solely based on the author's own opinion and > > should not be considered necessarily as reflecting the opinion of > > Intergraph. > > > > -----Original Message----- > > > > From: openjfx-dev [mailto:openjfx-dev-bounces at openjdk.java.net] On > > Behalf Of Hruda, Steve > > > > Sent: Tuesday, June 23, 2015 6:26 PM > > > > To: Anton V. Tarasov; Kevin Rushforth > > > > Cc:openjfx-dev at openjdk.java.net > > > > Subject: RE: Patch for JDK-8090098 - [regression] Webview - > > getTimezoneOffset() of a ISO strings returns a wrong value > > > > Very cool Anton. > > > > I would be great if that pach could be added to 8u60, otherwise our > > all our customers have to avoid Java 8u60. > > > > Regards, > > > > Steve > > > > Diese E-Mail wurde versandt im Auftrag des Unternehmens Intergraph > > Ges.m.b.H. > > > > Vertretungsberechtigte Gesch?ftsf?hrer: Maximilian Weber Sitz der > > Gesellschaft: Margaretenstra?e 70/I/1, 1050 Wien, ?sterreich, Tel. > > +43 (1) 9610567-0 Eingetragen beim Handelsgericht Wien, > > Firmenbuch-Nr.: FN 116859 b Umsatzsteuer-Identifikationsnummer / > > VAT-ID: ATU15138401, > > Steuer-Nummer: 264/4807 > > > > This E-Mail has been sent on behalf of the company Intergraph > > Ges.m.b.H. > > > > Authorised Managing Directors: Maximilian Weber Registered office > > and Austrian headquarters: > > Margaretenstr. 70/I/1, 1050 Wien, Austria, Tel. +43 (1) 9610567-0 > > The company is recorded at the commercial court of Vienna under the > > company register number FN 116859 b > > > > VAT-ID: ATU15138401, Austrian Tax ID: 264/4807 > > > > Diese E-Mail (mit zugeh?rigen Dateien) enth?lt m?glicherweise > > Informationen, die vertraulich sind, dem Urheberrecht unterliegen > > oder ein Gesch?ftsgeheimnis darstellen. Falls Sie diese Nachricht > > irrt?mlicherweise erhalten haben, benachrichtigen Sie uns bitte > > umgehend, indem Sie eine Antwort senden, und l?schen Sie bitte > > diese E-Mail und Ihre Antwort darauf. S?mtliche aufgef?hrten > > Ansichten oder Meinungen sind ausschlie?lich diejenigen des Autors > > und entsprechen nicht notwendigerweise denen des Unternehmens Intergraph. > > > > This E-Mail (and any attachments) may be confidential and protected > > by legal privilege. If you are not the intended recipient please > > notify us immediately by replying to the sender and delete this > > E-Mail and your reply from your system. All the views and opinions > > published here are solely based on the author's own opinion and > > should not be considered necessarily as reflecting the opinion of > > Intergraph. > > > > -----Original Message----- > > > > From: Anton V. Tarasov [mailto:anton.tarasov at oracle.com] > > > > Sent: Tuesday, June 23, 2015 5:46 PM > > > > To: Kevin Rushforth; Hruda, Steve > > > > Cc:openjfx-dev at openjdk.java.net > > > > Subject: Re: Patch for JDK-8090098 - [regression] Webview - > > getTimezoneOffset() of a ISO strings returns a wrong value > > > > On 23.06.2015 17:48, Kevin Rushforth wrote: > > > > > > Hi Steve, > > Thank you for taking the time to create this patch. I will add > > this information to the bug report. > > Since your OCA is in progress we will take a look at your patch, > > but will need indication from the OCA office that it the OCA has > > been received before we could push it. And just to be clear, you > > won't have access to the repository even with an OCA. What the OCA > > will do is allow you to contribute > > > > patches. > > > > > > I will note that it is likely too late for 8u60, but Anton can > > evaluate it and post his comment in the bug report. > > > > Kevin, > > > > I'm checking it. > > > > Steve, thanks for the participation! > > > > Regards, > > > > Anton. > > > > > > -- Kevin > > Hruda, Steve wrote: > > > > Hi, > > I've created a 8u-dev patch for the following WeKit regression > > which comes with 8u60. > > https://bugs.openjdk.java.net/browse/JDK-8090098 > > Please can someone of you apply this patch to fix the > > getTimezoneOffset() issue. I have no access to the repository -> > > my OCA is still pending. > > In addition I tried to test this patch , but I wasn't able to > > build the necessary jfxwebkit.dll on my windows system > > (https://www.mail-archive.com/openjfx-dev at openjdk.java.net/msg094 > > 3 > > 9.h > > tml )..... but I got no compile erros on Mac. > > Patch download: > > https://drive.google.com/file/d/0B7P_rknS1TWxM3BSTTU2OVZ4dGM/view > > ?u > > sp > > =sharing > > The patch includes the following WebKit fixes: > > Changeset 174377 - [Win] DateMath's calculateUTFOffset does not > > account for DST. > > http://trac.webkit.org/changeset/174377 > > Changeset 175078 - String(new Date(Mar 30 2014 01:00:00)) is > > wrong in CET > > http://trac.webkit.org/changeset/175078 > > Changeset 181360 - [Win] 17 different JSC tests started to fail > > in DST > > http://trac.webkit.org/changeset/181360 > > Please let me know if you need further information. > > Thanks in advance! > > Best Regards > > Steve > > Diese E-Mail wurde versandt im Auftrag des Unternehmens > > Intergraph Ges.m.b.H. > > Vertretungsberechtigte Gesch?ftsf?hrer: Maximilian Weber Sitz der > > Gesellschaft: Margaretenstra?e 70/I/1, 1050 Wien, ?sterreich, Tel. > > +43 (1) 9610567-0 Eingetragen beim Handelsgericht Wien, > > Firmenbuch-Nr.: FN 116859 b Umsatzsteuer-Identifikationsnummer / > > VAT-ID: ATU15138401, Steuer-Nummer: 264/4807 This E-Mail has been > > sent on behalf of the company Intergraph Ges.m.b.H. > > Authorised Managing Directors: Maximilian Weber Registered office > > and Austrian headquarters: Margaretenstr. 70/I/1, 1050 Wien, > > Austria, Tel. +43 > > (1) 9610567-0 > > The company is recorded at the commercial court of Vienna under > > the company register number FN > > 116859 b > > VAT-ID: ATU15138401, Austrian Tax ID: 264/4807 Diese E-Mail (mit > > zugeh?rigen Dateien) enth?lt m?glicherweise Informationen, die > > vertraulich sind, dem Urheberrecht unterliegen oder ein > > Gesch?ftsgeheimnis darstellen. Falls Sie diese Nachricht > > irrt?mlicherweise erhalten haben, benachrichtigen Sie uns bitte > > umgehend, indem Sie eine Antwort senden, und l?schen Sie bitte > > diese E-Mail und Ihre Antwort darauf. S?mtliche aufgef?hrten > > Ansichten oder Meinungen sind > > > > ausschlie?lich diejenigen des Autors und entsprechen nicht > > notwendigerweise denen des Unternehmens Intergraph. > > > > > > This E-Mail (and any attachments) may be confidential and > > protected by legal privilege. If you are not the intended > > recipient please notify us immediately by replying to the sender > > and delete this E-Mail and your reply from your system. All the > > views and opinions published here are solely based on the > > author's own opinion and should not be considered > > > > necessarily as reflecting the opinion of Intergraph. > > > > > > > > > From steve.hruda at hexagongeospatial.com Thu Jul 2 12:54:43 2015 From: steve.hruda at hexagongeospatial.com (Hruda, Steve) Date: Thu, 2 Jul 2015 12:54:43 +0000 Subject: Patch for JDK-8090098 - [regression] Webview - getTimezoneOffset() of a ISO strings returns a wrong value In-Reply-To: <5595337D.6000609@oracle.com> References: <559191AA.8030800@oracle.com> <5592D943.3090407@oracle.com> <5592E269.6050200@oracle.com> <5592FFDB.5090501@oracle.com> <55930730.6050302@oracle.com> <5595337D.6000609@oracle.com> Message-ID: HI Anton, The diff fix must be there. if (diff<0) diff += secondsPerDay; ? but the following fixes are unnecessary, for the midnight bug. I think one of these fixes could be the problem. http://cr.openjdk.java.net/~ant/JDK-8090098/webrev.0/ which contains the following fixed issues: http://trac.webkit.org/changeset/174377 http://trac.webkit.org/changeset/175078 http://trac.webkit.org/changeset/181360 Regards, Steve From: Anton V. Tarasov [mailto:anton.tarasov at oracle.com] Sent: Thursday, July 2, 2015 2:50 PM To: Hruda, Steve Cc: Kevin Rushforth; openjfx-dev at openjdk.java.net Subject: Re: Patch for JDK-8090098 - [regression] Webview - getTimezoneOffset() of a ISO strings returns a wrong value Hi Steve, Actually, I already checked that removing if (diff<0) diff += secondsPerDay; didn't help. Regards, Anton. On 02.07.2015 13:09, Hruda, Steve wrote: Hi Anton, I saw your comments on https://bugs.openjdk.java.net/browse/JDK-8090098. We?ve opened the test page which you have mentioned in our own compiled WebKit version -> clean build & latest version. Used Timezone: Vienna CEST ? current Offset UTC+2:00 Without our Fix: Only the first and latest test pass. With our Fix: The same ? only the first and latest test pass. It seems that one changeset regress this behavior, but not the our latest ?if ?fix? if (diff<0) diff += secondsPerDay; I?m not able to build openjfx because of the missing dependencies (1.3). Please can you try what happens if you only apply the diff fix and not the previous patch, which includes all other date fixes. From my point of view are these fixes (which were provided by the patch file) not necessary to solve our datepicker problem. Thanks in advance, Steve From: Kevin Rushforth [mailto:kevin.rushforth at oracle.com] Sent: Tuesday, June 30, 2015 11:17 PM To: Hruda, Steve Cc: Anton V. Tarasov; openjfx-dev at openjdk.java.net Subject: Re: Patch for JDK-8090098 - [regression] Webview - getTimezoneOffset() of a ISO strings returns a wrong value Not by itself, although regressions are certainly taken very seriously. In any case, the process is to get this into 9-dev (once it has been reviewed), test it thoroughly, and then consider whether we can make a case for taking it to the 8u60 release team. -- Kevin Hruda, Steve wrote: Is a regression not release critical? Diese E-Mail wurde versandt im Auftrag des Unternehmens Intergraph Ges.m.b.H. Vertretungsberechtigte Gesch?ftsf?hrer: Maximilian Weber Sitz der Gesellschaft: Margaretenstra?e 70/I/1, 1050 Wien, ?sterreich, Tel. +43 (1) 9610567-0 Eingetragen beim Handelsgericht Wien, Firmenbuch-Nr.: FN 116859 b Umsatzsteuer-Identifikationsnummer / VAT-ID: ATU15138401, Steuer-Nummer: 264/4807 This E-Mail has been sent on behalf of the company Intergraph Ges.m.b.H. Authorised Managing Directors: Maximilian Weber Registered office and Austrian headquarters: Margaretenstr. 70/I/1, 1050 Wien, Austria, Tel. +43 (1) 9610567-0 The company is recorded at the commercial court of Vienna under the company register number FN 116859 b VAT-ID: ATU15138401, Austrian Tax ID: 264/4807 Diese E-Mail (mit zugeh?rigen Dateien) enth?lt m?glicherweise Informationen, die vertraulich sind, dem Urheberrecht unterliegen oder ein Gesch?ftsgeheimnis darstellen. Falls Sie diese Nachricht irrt?mlicherweise erhalten haben, benachrichtigen Sie uns bitte umgehend, indem Sie eine Antwort senden, und l?schen Sie bitte diese E-Mail und Ihre Antwort darauf. S?mtliche aufgef?hrten Ansichten oder Meinungen sind ausschlie?lich diejenigen des Autors und entsprechen nicht notwendigerweise denen des Unternehmens Intergraph. This E-Mail (and any attachments) may be confidential and protected by legal privilege. If you are not the intended recipient please notify us immediately by replying to the sender and delete this E-Mail and your reply from your system. All the views and opinions published here are solely based on the author's own opinion and should not be considered necessarily as reflecting the opinion of Intergraph. Diese E-Mail wurde versandt im Auftrag des Unternehmens Intergraph Ges.m.b.H. Vertretungsberechtigte Gesch?ftsf?hrer: Maximilian Weber Sitz der Gesellschaft: Margaretenstra?e 70/I/1, 1050 Wien, ?sterreich, Tel. +43 (1) 9610567-0 Eingetragen beim Handelsgericht Wien, Firmenbuch-Nr.: FN 116859 b Umsatzsteuer-Identifikationsnummer / VAT-ID: ATU15138401, Steuer-Nummer: 264/4807 This E-Mail has been sent on behalf of the company Intergraph Ges.m.b.H. Authorised Managing Directors: Maximilian Weber Registered office and Austrian headquarters: Margaretenstr. 70/I/1, 1050 Wien, Austria, Tel. +43 (1) 9610567-0 The company is recorded at the commercial court of Vienna under the company register number FN 116859 b VAT-ID: ATU15138401, Austrian Tax ID: 264/4807 Diese E-Mail (mit zugeh?rigen Dateien) enth?lt m?glicherweise Informationen, die vertraulich sind, dem Urheberrecht unterliegen oder ein Gesch?ftsgeheimnis darstellen. Falls Sie diese Nachricht irrt?mlicherweise erhalten haben, benachrichtigen Sie uns bitte umgehend, indem Sie eine Antwort senden, und l?schen Sie bitte diese E-Mail und Ihre Antwort darauf. S?mtliche aufgef?hrten Ansichten oder Meinungen sind ausschlie?lich diejenigen des Autors und entsprechen nicht notwendigerweise denen des Unternehmens Intergraph. This E-Mail (and any attachments) may be confidential and protected by legal privilege. If you are not the intended recipient please notify us immediately by replying to the sender and delete this E-Mail and your reply from your system. All the views and opinions published here are solely based on the author's own opinion and should not be considered necessarily as reflecting the opinion of Intergraph. Diese E-Mail wurde versandt im Auftrag des Unternehmens Intergraph Ges.m.b.H. Vertretungsberechtigte Gesch?ftsf?hrer: Maximilian Weber Sitz der Gesellschaft: Margaretenstra?e 70/I/1, 1050 Wien, ?sterreich, Tel. +43 (1) 9610567-0 Eingetragen beim Handelsgericht Wien, Firmenbuch-Nr.: FN 116859 b Umsatzsteuer-Identifikationsnummer / VAT-ID: ATU15138401, Steuer-Nummer: 264/4807 This E-Mail has been sent on behalf of the company Intergraph Ges.m.b.H. Authorised Managing Directors: Maximilian Weber Registered office and Austrian headquarters: Margaretenstr. 70/I/1, 1050 Wien, Austria, Tel. +43 (1) 9610567-0 The company is recorded at the commercial court of Vienna under the company register number FN 116859 b VAT-ID: ATU15138401, Austrian Tax ID: 264/4807 Diese E-Mail (mit zugeh?rigen Dateien) enth?lt m?glicherweise Informationen, die vertraulich sind, dem Urheberrecht unterliegen oder ein Gesch?ftsgeheimnis darstellen. Falls Sie diese Nachricht irrt?mlicherweise erhalten haben, benachrichtigen Sie uns bitte umgehend, indem Sie eine Antwort senden, und l?schen Sie bitte diese E-Mail und Ihre Antwort darauf. S?mtliche aufgef?hrten Ansichten oder Meinungen sind ausschlie?lich diejenigen des Autors und entsprechen nicht notwendigerweise denen des Unternehmens Intergraph. This E-Mail (and any attachments) may be confidential and protected by legal privilege. If you are not the intended recipient please notify us immediately by replying to the sender and delete this E-Mail and your reply from your system. All the views and opinions published here are solely based on the author's own opinion and should not be considered necessarily as reflecting the opinion of Intergraph. -----Original Message----- From: Kevin Rushforth [mailto:kevin.rushforth at oracle.com] Sent: Tuesday, June 30, 2015 10:45 PM To: Anton V. Tarasov Cc: Hruda, Steve; openjfx-dev at openjdk.java.net Subject: Re: Patch for JDK-8090098 - [regression] Webview - getTimezoneOffset() of a ISO strings returns a wrong value Anton V. Tarasov wrote: On 30.06.2015 21:13, Hruda, Steve wrote: Hi Anton, thanks for the detailed information and the good news. You talk about JDK's jira? Am I right? ..... I don't have an access for that JIRA system since the JavaFX's Jira has moved to the JDK Bug System. Ah, ok. Then I'll quote your e-mail. About the Apple stuff. I know that Apple dropped Windows Safari support and in my opinion is this a very bad situation for WebKit (in case of Windows).... and especially since Google and Opera using Google's Blink engine. In case of the JDK it would be more practicable to switch from WebKit to Blink, because this engine is still used by Companies which have Windows end-users. There is a high probability that WebKit get more such bugs if there is no big player like Google or Apple who has the man power to fix such OS dependent issues. I see. However, switching to Blink is another story. Honestly, we're not planning it in the nearest future. This requires extra resources which we don't have at the moment... Last questions: Do you need any additional information from my side? And is it possible to integrate this fix in 8u60? From my side, I'll do a sanity check with WebKit LayoutTests, then if it goes well, we can consider commiting this to 8u60. @Kevin, do you think we can? Very unlikely. The JDK release team would need to approve, and only release-critical issues may be considered at this point (it would be hard to argue that this is release-critical since it has already been deferred). -- Kevin Also, as an option for you (Steve). You can post the changes to the WebKit alias and ask if they think this is a valid fix for the issue. Any confirmation from the WebKit team would help us to make sure the fix is reliable. Thanks! Anton. Thanks in advance! Best Regards, Steve Diese E-Mail wurde versandt im Auftrag des Unternehmens Intergraph Ges.m.b.H. Vertretungsberechtigte Gesch?ftsf?hrer: Maximilian Weber Sitz der Gesellschaft: Margaretenstra?e 70/I/1, 1050 Wien, ?sterreich, Tel. +43 (1) 9610567-0 Eingetragen beim Handelsgericht Wien, Firmenbuch-Nr.: FN 116859 b Umsatzsteuer-Identifikationsnummer / VAT-ID: ATU15138401, Steuer-Nummer: 264/4807 This E-Mail has been sent on behalf of the company Intergraph Ges.m.b.H. Authorised Managing Directors: Maximilian Weber Registered office and Austrian headquarters: Margaretenstr. 70/I/1, 1050 Wien, Austria, Tel. +43 (1) 9610567-0 The company is recorded at the commercial court of Vienna under the company register number FN 116859 b VAT-ID: ATU15138401, Austrian Tax ID: 264/4807 Diese E-Mail (mit zugeh?rigen Dateien) enth?lt m?glicherweise Informationen, die vertraulich sind, dem Urheberrecht unterliegen oder ein Gesch?ftsgeheimnis darstellen. Falls Sie diese Nachricht irrt?mlicherweise erhalten haben, benachrichtigen Sie uns bitte umgehend, indem Sie eine Antwort senden, und l?schen Sie bitte diese E-Mail und Ihre Antwort darauf. S?mtliche aufgef?hrten Ansichten oder Meinungen sind ausschlie?lich diejenigen des Autors und entsprechen nicht notwendigerweise denen des Unternehmens Intergraph. This E-Mail (and any attachments) may be confidential and protected by legal privilege. If you are not the intended recipient please notify us immediately by replying to the sender and delete this E-Mail and your reply from your system. All the views and opinions published here are solely based on the author's own opinion and should not be considered necessarily as reflecting the opinion of Intergraph. -----Original Message----- From: Anton V. Tarasov [mailto:anton.tarasov at oracle.com] Sent: Tuesday, June 30, 2015 8:01 PM To: Hruda, Steve; Kevin Rushforth Cc: openjfx-dev at openjdk.java.net Subject: Re: Patch for JDK-8090098 - [regression] Webview - getTimezoneOffset() of a ISO strings returns a wrong value Steve, I applied your suggestion and it worked on Windows. The missed check you discovered could really be a mistake in WebKit, because Apple dropped releasing (and shipping nightly builds for) Safari for Windows at 2012. Safari 5.1.7 was the last version. I downloaded and checked it. The date bug is not reproducible with it, but this gives us almost nothing taking into account the version is much outdated. So that Windows code path might not have been well tested, since http://trac.webkit.org/changeset/159892 was commited... (WebKit Win port is still supported and can be built on your own.) What I can do else to verify the changes is to run WebKit LayoutTests aimed at date testing and see if there're no regressions. Also, please put the info you posted into JIRA. Regards, Anton. On 29.06.2015 21:42, Anton Tarasov wrote: Hi Steve, Ok, I'll investigate it. Thanks, Anton. On 29.06.2015 18:39, Hruda, Steve wrote: Hi Anton & Kevin, we read your comments in the JDK bug system and analyzed WebKit's changesets again. We?ve found the code which made this regression. http://trac.webkit.org/changeset/159892 This changeset doesn't handle one special case, which was handled by the previous code.... double diff = ((localSystemTime.wHour - offsetHour) * secondsPerHour) + ((localSystemTime.wMinute - offsetMinute) *60); (http://trac.webkit.org/browser/trunk/Source/WTF/wtf/DateMath.cpp?a nn otate=blame#L481 ) The diff is wrong if the calculated the offsetTime is one day before in case of the extreme values (e.g. midnight) where the offsetHour of the UTC time is 23 because of the day difference. In case of all other OS systems you will see the same code -> http://trac.webkit.org/browser/trunk/Source/WTF/wtf/DateMath.cpp?an no tate=blame#L495 But there are two additional lines -> 497 & 497 which fixes this special case? *if*(diff<0) diff += secondsPerDay; That means ?. localSystemTime.wHour = 0; offsetHour=23 ? which causes a negative value ? and the diff+=secondsPerDay ensures that the diff result would be one Hour instead of -23 hours We?ve found the attached V8DateTests.js (renamed to .txt) and adjusted it a little bit to get the results logged in the browsers console. As you can see at ?ResulBeforeOurBugFix.txt? and ?ResultAfterOurBugFix.txt?, we were able to fix 6 tests which failed before out bug fix. assertEquals("Sat Oct 25 2014 23:00:00 GMT+0200 (W. Europe Daylight Time)", (new Date(2014, 9, 25, 23, 0)).toString()); assertEquals("Sat, 25 Oct 2014 21:00:00 GMT", (new Date(2014, 9, 25, 23, 0)).toUTCString()); assertEquals("Sat Oct 25 2014 23:59:00 GMT+0200 (W. Europe Daylight Time)", (new Date(2014, 9, 25, 23, 59)).toString()); assertEquals("Sat, 25 Oct 2014 21:59:00 GMT", (new Date(2014, 9, 25, 23, 59)).toUTCString()); assertEquals("Sun Oct 26 2014 00:00:00 GMT+0200 (W. Europe Daylight Time)", (new Date(2014, 9, 26, 0, 0)).toString()); assertEquals("Sun Oct 26 2014 00:59:00 GMT+0200 (W. Europe Daylight Time)", (new Date(2014, 9, 26, 0, 59)).toString()); In addition we found out that WebKit also have problems in case of Windows in case of the change from winter to summer time. *_Winter to summer time:_* assertEquals("Sun Mar 30 2014 03:00:00 GMT+0200 (W. Europe Daylight Time)", (new Date(2014, 2, 30, 2, 0)).toString()); assertEquals("Sun, 30 Mar 2014 01:00:00 GMT", (new Date(2014, 2, 30, 2, 0)).toUTCString()); assertEquals("Sun Mar 30 2014 03:59:00 GMT+0200 (W. Europe Daylight Time)", (new Date(2014, 2, 30, 2, 59)).toString()); assertEquals("Sun, 30 Mar 2014 01:59:00 GMT", (new Date(2014, 2, 30, 2, 59)).toUTCString()); *_Summer to winter time:_* assertEquals("Sun Oct 26 2014 02:00:00 GMT+0200 (W. Europe Daylight Time)", (new Date(2014, 9, 26, 2, 0)).toString()); assertEquals("Sun, 26 Oct 2014 00:00:00 GMT", (new Date(2014, 9, 26, 2, 0)).toUTCString()); assertEquals("Sun Oct 26 2014 02:59:00 GMT+0200 (W. Europe Daylight Time)", (new Date(2014, 9, 26, 2, 59)).toString()); assertEquals("Sun, 26 Oct 2014 00:59:00 GMT", (new Date(2014, 9, 26, 2, 59)).toUTCString()); We will try to find a solution for that, but I think that the priority of this issue is lower than the priority of the opened regression. It would be amazing if you can add the patch of my previous and these additional two lines (DateMath.cpp) to the JDK8u60. Best Regards, Steve Diese E-Mail wurde versandt im Auftrag des Unternehmens Intergraph Ges.m.b.H. Vertretungsberechtigte Gesch?ftsf?hrer: Maximilian Weber Sitz der Gesellschaft: Margaretenstra?e 70/I/1, 1050 Wien, ?sterreich, Tel. +43 (1) 9610567-0 Eingetragen beim Handelsgericht Wien, Firmenbuch-Nr.: FN 116859 b Umsatzsteuer-Identifikationsnummer / VAT-ID: ATU15138401, Steuer-Nummer: 264/4807 This E-Mail has been sent on behalf of the company Intergraph Ges.m.b.H. Authorised Managing Directors: Maximilian Weber Registered office and Austrian headquarters: Margaretenstr. 70/I/1, 1050 Wien, Austria, Tel. +43 (1) 9610567-0 The company is recorded at the commercial court of Vienna under the company register number FN 116859 b VAT-ID: ATU15138401, Austrian Tax ID: 264/4807 Diese E-Mail (mit zugeh?rigen Dateien) enth?lt m?glicherweise Informationen, die vertraulich sind, dem Urheberrecht unterliegen oder ein Gesch?ftsgeheimnis darstellen. Falls Sie diese Nachricht irrt?mlicherweise erhalten haben, benachrichtigen Sie uns bitte umgehend, indem Sie eine Antwort senden, und l?schen Sie bitte diese E-Mail und Ihre Antwort darauf. S?mtliche aufgef?hrten Ansichten oder Meinungen sind ausschlie?lich diejenigen des Autors und entsprechen nicht notwendigerweise denen des Unternehmens Intergraph. This E-Mail (and any attachments) may be confidential and protected by legal privilege. If you are not the intended recipient please notify us immediately by replying to the sender and delete this E-Mail and your reply from your system. All the views and opinions published here are solely based on the author's own opinion and should not be considered necessarily as reflecting the opinion of Intergraph. -----Original Message----- From: openjfx-dev [mailto:openjfx-dev-bounces at openjdk.java.net] On Behalf Of Hruda, Steve Sent: Tuesday, June 23, 2015 6:26 PM To: Anton V. Tarasov; Kevin Rushforth Cc: openjfx-dev at openjdk.java.net Subject: RE: Patch for JDK-8090098 - [regression] Webview - getTimezoneOffset() of a ISO strings returns a wrong value Very cool Anton. I would be great if that pach could be added to 8u60, otherwise our all our customers have to avoid Java 8u60. Regards, Steve Diese E-Mail wurde versandt im Auftrag des Unternehmens Intergraph Ges.m.b.H. Vertretungsberechtigte Gesch?ftsf?hrer: Maximilian Weber Sitz der Gesellschaft: Margaretenstra?e 70/I/1, 1050 Wien, ?sterreich, Tel. +43 (1) 9610567-0 Eingetragen beim Handelsgericht Wien, Firmenbuch-Nr.: FN 116859 b Umsatzsteuer-Identifikationsnummer / VAT-ID: ATU15138401, Steuer-Nummer: 264/4807 This E-Mail has been sent on behalf of the company Intergraph Ges.m.b.H. Authorised Managing Directors: Maximilian Weber Registered office and Austrian headquarters: Margaretenstr. 70/I/1, 1050 Wien, Austria, Tel. +43 (1) 9610567-0 The company is recorded at the commercial court of Vienna under the company register number FN 116859 b VAT-ID: ATU15138401, Austrian Tax ID: 264/4807 Diese E-Mail (mit zugeh?rigen Dateien) enth?lt m?glicherweise Informationen, die vertraulich sind, dem Urheberrecht unterliegen oder ein Gesch?ftsgeheimnis darstellen. Falls Sie diese Nachricht irrt?mlicherweise erhalten haben, benachrichtigen Sie uns bitte umgehend, indem Sie eine Antwort senden, und l?schen Sie bitte diese E-Mail und Ihre Antwort darauf. S?mtliche aufgef?hrten Ansichten oder Meinungen sind ausschlie?lich diejenigen des Autors und entsprechen nicht notwendigerweise denen des Unternehmens Intergraph. This E-Mail (and any attachments) may be confidential and protected by legal privilege. If you are not the intended recipient please notify us immediately by replying to the sender and delete this E-Mail and your reply from your system. All the views and opinions published here are solely based on the author's own opinion and should not be considered necessarily as reflecting the opinion of Intergraph. -----Original Message----- From: Anton V. Tarasov [mailto:anton.tarasov at oracle.com] Sent: Tuesday, June 23, 2015 5:46 PM To: Kevin Rushforth; Hruda, Steve Cc: openjfx-dev at openjdk.java.net Subject: Re: Patch for JDK-8090098 - [regression] Webview - getTimezoneOffset() of a ISO strings returns a wrong value On 23.06.2015 17:48, Kevin Rushforth wrote: Hi Steve, Thank you for taking the time to create this patch. I will add this information to the bug report. Since your OCA is in progress we will take a look at your patch, but will need indication from the OCA office that it the OCA has been received before we could push it. And just to be clear, you won't have access to the repository even with an OCA. What the OCA will do is allow you to contribute patches. I will note that it is likely too late for 8u60, but Anton can evaluate it and post his comment in the bug report. Kevin, I'm checking it. Steve, thanks for the participation! Regards, Anton. -- Kevin Hruda, Steve wrote: Hi, I've created a 8u-dev patch for the following WeKit regression which comes with 8u60. https://bugs.openjdk.java.net/browse/JDK-8090098 Please can someone of you apply this patch to fix the getTimezoneOffset() issue. I have no access to the repository -> my OCA is still pending. In addition I tried to test this patch , but I wasn't able to build the necessary jfxwebkit.dll on my windows system (https://www.mail-archive.com/openjfx-dev at openjdk.java.net/msg094 3 9.h tml )..... but I got no compile erros on Mac. Patch download: https://drive.google.com/file/d/0B7P_rknS1TWxM3BSTTU2OVZ4dGM/view ?u sp =sharing The patch includes the following WebKit fixes: Changeset 174377 - [Win] DateMath's calculateUTFOffset does not account for DST. http://trac.webkit.org/changeset/174377 Changeset 175078 - String(new Date(Mar 30 2014 01:00:00)) is wrong in CET http://trac.webkit.org/changeset/175078 Changeset 181360 - [Win] 17 different JSC tests started to fail in DST http://trac.webkit.org/changeset/181360 Please let me know if you need further information. Thanks in advance! Best Regards Steve Diese E-Mail wurde versandt im Auftrag des Unternehmens Intergraph Ges.m.b.H. Vertretungsberechtigte Gesch?ftsf?hrer: Maximilian Weber Sitz der Gesellschaft: Margaretenstra?e 70/I/1, 1050 Wien, ?sterreich, Tel. +43 (1) 9610567-0 Eingetragen beim Handelsgericht Wien, Firmenbuch-Nr.: FN 116859 b Umsatzsteuer-Identifikationsnummer / VAT-ID: ATU15138401, Steuer-Nummer: 264/4807 This E-Mail has been sent on behalf of the company Intergraph Ges.m.b.H. Authorised Managing Directors: Maximilian Weber Registered office and Austrian headquarters: Margaretenstr. 70/I/1, 1050 Wien, Austria, Tel. +43 (1) 9610567-0 The company is recorded at the commercial court of Vienna under the company register number FN 116859 b VAT-ID: ATU15138401, Austrian Tax ID: 264/4807 Diese E-Mail (mit zugeh?rigen Dateien) enth?lt m?glicherweise Informationen, die vertraulich sind, dem Urheberrecht unterliegen oder ein Gesch?ftsgeheimnis darstellen. Falls Sie diese Nachricht irrt?mlicherweise erhalten haben, benachrichtigen Sie uns bitte umgehend, indem Sie eine Antwort senden, und l?schen Sie bitte diese E-Mail und Ihre Antwort darauf. S?mtliche aufgef?hrten Ansichten oder Meinungen sind ausschlie?lich diejenigen des Autors und entsprechen nicht notwendigerweise denen des Unternehmens Intergraph. This E-Mail (and any attachments) may be confidential and protected by legal privilege. If you are not the intended recipient please notify us immediately by replying to the sender and delete this E-Mail and your reply from your system. All the views and opinions published here are solely based on the author's own opinion and should not be considered necessarily as reflecting the opinion of Intergraph. From anton.tarasov at oracle.com Thu Jul 2 13:26:09 2015 From: anton.tarasov at oracle.com (Anton V. Tarasov) Date: Thu, 02 Jul 2015 16:26:09 +0300 Subject: Patch for JDK-8090098 - [regression] Webview - getTimezoneOffset() of a ISO strings returns a wrong value In-Reply-To: References: <559191AA.8030800@oracle.com> <5592D943.3090407@oracle.com> <5592E269.6050200@oracle.com> <5592FFDB.5090501@oracle.com> <55930730.6050302@oracle.com> <5595337D.6000609@oracle.com> Message-ID: <55953BF1.60204@oracle.com> Ok, got it. You suggest trying the only 2-line change? Anton. On 02.07.2015 15:54, Hruda, Steve wrote: > > HI Anton, > > The diff fix must be there. > > if (diff<0) > diff += secondsPerDay; > > ? but the following fixes are unnecessary, for the midnight bug. I think one of these fixes could > be the problem. > > http://cr.openjdk.java.net/~ant/JDK-8090098/webrev.0/ > > > which contains the following fixed issues: > > http://trac.webkit.org/changeset/174377 > http://trac.webkit.org/changeset/175078 > http://trac.webkit.org/changeset/181360 > > Regards, > > Steve > > *From:*Anton V. Tarasov [mailto:anton.tarasov at oracle.com] > *Sent:* Thursday, July 2, 2015 2:50 PM > *To:* Hruda, Steve > *Cc:* Kevin Rushforth; openjfx-dev at openjdk.java.net > *Subject:* Re: Patch for JDK-8090098 - [regression] Webview - getTimezoneOffset() of a ISO strings > returns a wrong value > > Hi Steve, > > Actually, I already checked that removing > > if (diff<0) > diff += secondsPerDay; > > > didn't help. > > Regards, > Anton. > > On 02.07.2015 13:09, Hruda, Steve wrote: > > Hi Anton, > > I saw your comments on https://bugs.openjdk.java.net/browse/JDK-8090098. > > We?ve opened the test page which you have mentioned in our own compiled WebKit version -> > clean build & latest version. > > Used Timezone: Vienna CEST ? current Offset UTC+2:00 > > Without our Fix: > > Only the first and latest test pass. > > With our Fix: > > The same ? only the first and latest test pass. > > It seems that one changeset regress this behavior, but not the our latest ?if ?fix? > > if (diff<0) > > diff += secondsPerDay; > > I?m not able to build openjfx because of the missing dependencies (1.3). Please can you try > what happens if you only apply the diff fix and not the previous patch, which includes all > other date fixes. From my point of view are these fixes (which were provided by the patch > file) not necessary to solve our datepicker problem. > > Thanks in advance, > > Steve > > *From:*Kevin Rushforth [mailto:kevin.rushforth at oracle.com] > *Sent:* Tuesday, June 30, 2015 11:17 PM > *To:* Hruda, Steve > *Cc:* Anton V. Tarasov; openjfx-dev at openjdk.java.net > *Subject:* Re: Patch for JDK-8090098 - [regression] Webview - getTimezoneOffset() of a ISO > strings returns a wrong value > > Not by itself, although regressions are certainly taken very seriously. > > In any case, the process is to get this into 9-dev (once it has been reviewed), test it > thoroughly, and then consider whether we can make a case for taking it to the 8u60 release team. > > -- Kevin > > > Hruda, Steve wrote: > > Is a regression not release critical? > > > > > > > > > > Diese E-Mail wurde versandt im Auftrag des Unternehmens Intergraph Ges.m.b.H. > > Vertretungsberechtigte Gesch?ftsf?hrer: Maximilian Weber > > Sitz der Gesellschaft: Margaretenstra?e 70/I/1, 1050 Wien, ?sterreich, Tel. +43 (1) 9610567-0 > > Eingetragen beim Handelsgericht Wien, Firmenbuch-Nr.: FN 116859 b > > Umsatzsteuer-Identifikationsnummer / VAT-ID: ATU15138401, Steuer-Nummer: 264/4807 > > > > This E-Mail has been sent on behalf of the company Intergraph Ges.m.b.H. > > Authorised Managing Directors: Maximilian Weber > > Registered office and Austrian headquarters: Margaretenstr. 70/I/1, 1050 Wien, Austria, Tel. +43 (1) 9610567-0 > > The company is recorded at the commercial court of Vienna under the company register number FN 116859 b > > VAT-ID: ATU15138401, Austrian Tax ID: 264/4807 > > > > Diese E-Mail (mit zugeh?rigen Dateien) enth?lt m?glicherweise Informationen, die vertraulich sind, dem Urheberrecht unterliegen oder ein Gesch?ftsgeheimnis darstellen. Falls Sie diese Nachricht irrt?mlicherweise erhalten haben, benachrichtigen Sie uns bitte umgehend, indem Sie eine Antwort senden, und l?schen Sie bitte diese E-Mail und Ihre Antwort darauf. S?mtliche aufgef?hrten Ansichten oder Meinungen sind ausschlie?lich diejenigen des Autors und entsprechen nicht notwendigerweise denen des Unternehmens Intergraph. > > > > This E-Mail (and any attachments) may be confidential and protected by legal privilege. If you are not the intended recipient please notify us immediately by replying to the sender and delete this E-Mail and your reply from your system. All the views and opinions published here are solely based on the author's own opinion and should not be considered necessarily as reflecting the opinion of Intergraph. > > > > > > > Diese E-Mail wurde versandt im Auftrag des Unternehmens Intergraph Ges.m.b.H. > Vertretungsberechtigte Gesch?ftsf?hrer: Maximilian Weber > Sitz der Gesellschaft: Margaretenstra?e 70/I/1, 1050 Wien, ?sterreich, Tel. +43 (1) 9610567-0 > Eingetragen beim Handelsgericht Wien, Firmenbuch-Nr.: FN 116859 b > Umsatzsteuer-Identifikationsnummer / VAT-ID: ATU15138401, Steuer-Nummer: 264/4807 > > This E-Mail has been sent on behalf of the company Intergraph Ges.m.b.H. > Authorised Managing Directors: Maximilian Weber > Registered office and Austrian headquarters: Margaretenstr. 70/I/1, 1050 Wien, Austria, Tel. > +43 (1) 9610567-0 > The company is recorded at the commercial court of Vienna under the company register number FN > 116859 b > VAT-ID: ATU15138401, Austrian Tax ID: 264/4807 > > Diese E-Mail (mit zugeh?rigen Dateien) enth?lt m?glicherweise Informationen, die vertraulich > sind, dem Urheberrecht unterliegen oder ein Gesch?ftsgeheimnis darstellen. Falls Sie diese > Nachricht irrt?mlicherweise erhalten haben, benachrichtigen Sie uns bitte umgehend, indem Sie > eine Antwort senden, und l?schen Sie bitte diese E-Mail und Ihre Antwort darauf. S?mtliche > aufgef?hrten Ansichten oder Meinungen sind ausschlie?lich diejenigen des Autors und > entsprechen nicht notwendigerweise denen des Unternehmens Intergraph. > > This E-Mail (and any attachments) may be confidential and protected by legal privilege. If you > are not the intended recipient please notify us immediately by replying to the sender and > delete this E-Mail and your reply from your system. All the views and opinions published here > are solely based on the author's own opinion and should not be considered necessarily as > reflecting the opinion of Intergraph. > > > Diese E-Mail wurde versandt im Auftrag des Unternehmens Intergraph Ges.m.b.H. > Vertretungsberechtigte Gesch?ftsf?hrer: Maximilian Weber > Sitz der Gesellschaft: Margaretenstra?e 70/I/1, 1050 Wien, ?sterreich, Tel. +43 (1) 9610567-0 > Eingetragen beim Handelsgericht Wien, Firmenbuch-Nr.: FN 116859 b > Umsatzsteuer-Identifikationsnummer / VAT-ID: ATU15138401, Steuer-Nummer: 264/4807 > > This E-Mail has been sent on behalf of the company Intergraph Ges.m.b.H. > Authorised Managing Directors: Maximilian Weber > Registered office and Austrian headquarters: Margaretenstr. 70/I/1, 1050 Wien, Austria, Tel. +43 > (1) 9610567-0 > The company is recorded at the commercial court of Vienna under the company register number FN > 116859 b > VAT-ID: ATU15138401, Austrian Tax ID: 264/4807 > > Diese E-Mail (mit zugeh?rigen Dateien) enth?lt m?glicherweise Informationen, die vertraulich sind, > dem Urheberrecht unterliegen oder ein Gesch?ftsgeheimnis darstellen. Falls Sie diese Nachricht > irrt?mlicherweise erhalten haben, benachrichtigen Sie uns bitte umgehend, indem Sie eine Antwort > senden, und l?schen Sie bitte diese E-Mail und Ihre Antwort darauf. S?mtliche aufgef?hrten > Ansichten oder Meinungen sind ausschlie?lich diejenigen des Autors und entsprechen nicht > notwendigerweise denen des Unternehmens Intergraph. > > This E-Mail (and any attachments) may be confidential and protected by legal privilege. If you are > not the intended recipient please notify us immediately by replying to the sender and delete this > E-Mail and your reply from your system. All the views and opinions published here are solely based > on the author's own opinion and should not be considered necessarily as reflecting the opinion of > Intergraph. > > -----Original Message----- > > From: Kevin Rushforth [mailto:kevin.rushforth at oracle.com] > > Sent: Tuesday, June 30, 2015 10:45 PM > > To: Anton V. Tarasov > > Cc: Hruda, Steve;openjfx-dev at openjdk.java.net > > Subject: Re: Patch for JDK-8090098 - [regression] Webview - getTimezoneOffset() of a ISO strings returns a wrong value > > > > > > > > Anton V. Tarasov wrote: > > > > On 30.06.2015 21:13, Hruda, Steve wrote: > > > > Hi Anton, > > thanks for the detailed information and the good news. > > > > You talk about JDK's jira? Am I right? ..... I don't have an access > > for that JIRA system since the JavaFX's Jira has moved to the JDK Bug > > System. > > > > Ah, ok. Then I'll quote your e-mail. > > > > > > About the Apple stuff. > > I know that Apple dropped Windows Safari support and in my opinion is > > this a very bad situation for WebKit (in case of Windows).... and > > especially since Google and Opera using Google's Blink engine. > > > > In case of the JDK it would be more practicable to switch from WebKit > > to Blink, because this engine is still used by Companies which have > > Windows end-users. > > > > There is a high probability that WebKit get more such bugs if there > > is no big player like Google or Apple who has the man power to fix > > such OS dependent issues. > > > > I see. However, switching to Blink is another story. Honestly, we're > > not planning it in the nearest future. This requires extra resources > > which we don't have at the moment... > > > > > > Last questions: > > Do you need any additional information from my side? And is it > > possible to integrate this fix in 8u60? > > > > From my side, I'll do a sanity check with WebKit LayoutTests, then if > > it goes well, we can consider commiting this to 8u60. > > > > @Kevin, do you think we can? > > > > > > Very unlikely. The JDK release team would need to approve, and only release-critical issues may be considered at this point (it would be hard to argue that this is release-critical since it has already been deferred). > > > > -- Kevin > > > > > > > > Also, as an option for you (Steve). You can post the changes to the > > WebKit alias and ask if they think this is a valid fix for the issue. > > Any confirmation from the WebKit team would help us to make sure the > > fix is reliable. > > > > Thanks! > > Anton. > > > > > > Thanks in advance! > > Best Regards, > > Steve > > > > > > > > > > Diese E-Mail wurde versandt im Auftrag des Unternehmens Intergraph > > Ges.m.b.H. > > Vertretungsberechtigte Gesch?ftsf?hrer: Maximilian Weber Sitz der > > Gesellschaft: Margaretenstra?e 70/I/1, 1050 Wien, ?sterreich, Tel. > > +43 (1) 9610567-0 Eingetragen beim Handelsgericht Wien, > > Firmenbuch-Nr.: FN 116859 b Umsatzsteuer-Identifikationsnummer / > > VAT-ID: ATU15138401, > > Steuer-Nummer: 264/4807 > > > > This E-Mail has been sent on behalf of the company Intergraph Ges.m.b.H. > > Authorised Managing Directors: Maximilian Weber Registered office and > > Austrian headquarters: Margaretenstr. 70/I/1, > > 1050 Wien, Austria, Tel. +43 (1) 9610567-0 The company is recorded at > > the commercial court of Vienna under the company register number FN > > 116859 b > > VAT-ID: ATU15138401, Austrian Tax ID: 264/4807 > > > > Diese E-Mail (mit zugeh?rigen Dateien) enth?lt m?glicherweise > > Informationen, die vertraulich sind, dem Urheberrecht unterliegen > > oder ein Gesch?ftsgeheimnis darstellen. Falls Sie diese Nachricht > > irrt?mlicherweise erhalten haben, benachrichtigen Sie uns bitte > > umgehend, indem Sie eine Antwort senden, und l?schen Sie bitte diese > > E-Mail und Ihre Antwort darauf. S?mtliche aufgef?hrten Ansichten oder > > Meinungen sind ausschlie?lich diejenigen des Autors und entsprechen > > nicht notwendigerweise denen des Unternehmens Intergraph. > > > > This E-Mail (and any attachments) may be confidential and protected > > by legal privilege. If you are not the intended recipient please > > notify us immediately by replying to the sender and delete this > > E-Mail and your reply from your system. All the views and opinions > > published here are solely based on the author's own opinion and > > should not be considered necessarily as reflecting the opinion of > > Intergraph. > > > > > > -----Original Message----- > > From: Anton V. Tarasov [mailto:anton.tarasov at oracle.com] > > Sent: Tuesday, June 30, 2015 8:01 PM > > To: Hruda, Steve; Kevin Rushforth > > Cc:openjfx-dev at openjdk.java.net > > Subject: Re: Patch for JDK-8090098 - [regression] Webview - > > getTimezoneOffset() of a ISO strings returns a wrong value > > > > Steve, > > > > I applied your suggestion and it worked on Windows. > > > > The missed check you discovered could really be a mistake in WebKit, > > because Apple dropped releasing (and shipping nightly builds for) > > Safari for Windows at 2012. > > Safari 5.1.7 was the last version. I downloaded and checked it. The > > date bug is not reproducible with it, but this gives us almost > > nothing taking into account the version is much outdated. > > > > So that Windows code path might not have been well tested, since > > http://trac.webkit.org/changeset/159892 was commited... > > > > (WebKit Win port is still supported and can be built on your own.) > > > > What I can do else to verify the changes is to run WebKit LayoutTests > > aimed at date testing and see if there're no regressions. > > > > Also, please put the info you posted into JIRA. > > > > Regards, > > Anton. > > > > On 29.06.2015 21:42, Anton Tarasov wrote: > > > > Hi Steve, > > > > Ok, I'll investigate it. > > > > Thanks, > > Anton. > > > > On 29.06.2015 18:39, Hruda, Steve wrote: > > > > Hi Anton & Kevin, > > > > we read your comments in the JDK bug system and analyzed WebKit's > > changesets again. > > > > We?ve found the code which made this regression. > > > > http://trac.webkit.org/changeset/159892 > > > > This changeset doesn't handle one special case, which was handled > > by the previous code.... > > > > double diff = ((localSystemTime.wHour - offsetHour) * > > secondsPerHour) > > + ((localSystemTime.wMinute > > - offsetMinute) *60); > > > > > > (http://trac.webkit.org/browser/trunk/Source/WTF/wtf/DateMath.cpp?a > > nn > > otate=blame#L481 ) > > > > The diff is wrong if the calculated the offsetTime is one day > > before in case of the extreme values (e.g. midnight) where the > > offsetHour of the UTC time is 23 because of the day difference. > > > > In case of all other OS systems you will see the same code -> > > http://trac.webkit.org/browser/trunk/Source/WTF/wtf/DateMath.cpp?an > > no > > tate=blame#L495 > > > > But there are two additional lines -> 497 & 497 which fixes this > > special case? > > > > *if*(diff<0) > > > > diff += secondsPerDay; > > > > > > That means ?. > > > > localSystemTime.wHour = 0; > > > > offsetHour=23 ? which causes a negative value ? and the > > diff+=secondsPerDay ensures that the diff result would be one Hour > > instead of -23 hours > > > > We?ve found the attached V8DateTests.js (renamed to .txt) and > > adjusted it a little bit to get the results logged in the browsers > > console. > > > > As you can see at ?ResulBeforeOurBugFix.txt? and > > ?ResultAfterOurBugFix.txt?, we were able to fix > > 6 tests which failed before out bug fix. > > > > assertEquals("Sat Oct 25 2014 23:00:00 GMT+0200 (W. Europe Daylight > > Time)", > > > > (new Date(2014, 9, 25, 23, 0)).toString()); > > > > assertEquals("Sat, 25 Oct 2014 21:00:00 GMT", > > > > (new Date(2014, 9, 25, 23, 0)).toUTCString()); > > > > assertEquals("Sat Oct 25 2014 23:59:00 GMT+0200 (W. Europe > > Daylight Time)", > > > > (new Date(2014, 9, 25, 23, 59)).toString()); > > > > assertEquals("Sat, 25 Oct 2014 21:59:00 GMT", > > > > (new Date(2014, 9, 25, 23, 59)).toUTCString()); > > > > assertEquals("Sun Oct 26 2014 00:00:00 GMT+0200 (W. Europe > > Daylight Time)", > > > > (new Date(2014, 9, 26, 0, 0)).toString()); > > > > assertEquals("Sun Oct 26 2014 00:59:00 GMT+0200 (W. Europe Daylight > > Time)", > > > > (new Date(2014, 9, 26, 0, 59)).toString()); > > > > In addition we found out that WebKit also have problems in case of > > Windows in case of the change from winter to summer time. > > > > *_Winter to summer time:_* > > > > assertEquals("Sun Mar 30 2014 03:00:00 GMT+0200 (W. Europe Daylight > > Time)", > > > > (new Date(2014, 2, 30, 2, 0)).toString()); > > > > assertEquals("Sun, 30 Mar 2014 01:00:00 GMT", > > > > (new Date(2014, 2, 30, 2, 0)).toUTCString()); > > > > assertEquals("Sun Mar 30 2014 03:59:00 GMT+0200 (W. Europe > > Daylight Time)", > > > > (new Date(2014, 2, 30, 2, 59)).toString()); > > > > assertEquals("Sun, 30 Mar 2014 01:59:00 GMT", > > > > (new Date(2014, 2, 30, 2, 59)).toUTCString()); > > > > *_Summer to winter time:_* > > > > assertEquals("Sun Oct 26 2014 02:00:00 GMT+0200 (W. Europe Daylight > > Time)", > > > > (new Date(2014, 9, 26, 2, 0)).toString()); > > > > assertEquals("Sun, 26 Oct 2014 00:00:00 GMT", > > > > (new Date(2014, 9, 26, 2, 0)).toUTCString()); > > > > assertEquals("Sun Oct 26 2014 02:59:00 GMT+0200 (W. Europe > > Daylight Time)", > > > > (new Date(2014, 9, 26, 2, 59)).toString()); > > > > assertEquals("Sun, 26 Oct 2014 00:59:00 GMT", > > > > (new Date(2014, 9, 26, 2, 59)).toUTCString()); > > > > We will try to find a solution for that, but I think that the > > priority of this issue is lower than the priority of the opened > > regression. > > > > It would be amazing if you can add the patch of my previous and > > these additional two lines > > (DateMath.cpp) to the JDK8u60. > > > > Best Regards, > > > > Steve > > > > > > Diese E-Mail wurde versandt im Auftrag des Unternehmens Intergraph > > Ges.m.b.H. > > Vertretungsberechtigte Gesch?ftsf?hrer: Maximilian Weber Sitz der > > Gesellschaft: Margaretenstra?e 70/I/1, 1050 Wien, ?sterreich, Tel. > > +43 (1) 9610567-0 Eingetragen beim Handelsgericht Wien, > > Firmenbuch-Nr.: FN 116859 b Umsatzsteuer-Identifikationsnummer / > > VAT-ID: ATU15138401, Steuer-Nummer: 264/4807 > > > > This E-Mail has been sent on behalf of the company Intergraph > > Ges.m.b.H. > > Authorised Managing Directors: Maximilian Weber Registered office > > and Austrian headquarters: Margaretenstr. 70/I/1, 1050 Wien, > > Austria, Tel. +43 > > (1) 9610567-0 > > The company is recorded at the commercial court of Vienna under the > > company register number FN > > 116859 b > > VAT-ID: ATU15138401, Austrian Tax ID: 264/4807 > > > > Diese E-Mail (mit zugeh?rigen Dateien) enth?lt m?glicherweise > > Informationen, die vertraulich sind, dem Urheberrecht unterliegen > > oder ein Gesch?ftsgeheimnis darstellen. Falls Sie diese Nachricht > > irrt?mlicherweise erhalten haben, benachrichtigen Sie uns bitte > > umgehend, indem Sie eine Antwort senden, und l?schen Sie bitte > > diese E-Mail und Ihre Antwort darauf. S?mtliche aufgef?hrten > > Ansichten oder Meinungen sind ausschlie?lich diejenigen des Autors > > und entsprechen nicht notwendigerweise denen des Unternehmens Intergraph. > > > > This E-Mail (and any attachments) may be confidential and protected > > by legal privilege. If you are not the intended recipient please > > notify us immediately by replying to the sender and delete this > > E-Mail and your reply from your system. All the views and opinions > > published here are solely based on the author's own opinion and > > should not be considered necessarily as reflecting the opinion of > > Intergraph. > > > > -----Original Message----- > > > > From: openjfx-dev [mailto:openjfx-dev-bounces at openjdk.java.net] On > > Behalf Of Hruda, Steve > > > > Sent: Tuesday, June 23, 2015 6:26 PM > > > > To: Anton V. Tarasov; Kevin Rushforth > > > > Cc:openjfx-dev at openjdk.java.net > > > > Subject: RE: Patch for JDK-8090098 - [regression] Webview - > > getTimezoneOffset() of a ISO strings returns a wrong value > > > > Very cool Anton. > > > > I would be great if that pach could be added to 8u60, otherwise our > > all our customers have to avoid Java 8u60. > > > > Regards, > > > > Steve > > > > Diese E-Mail wurde versandt im Auftrag des Unternehmens Intergraph > > Ges.m.b.H. > > > > Vertretungsberechtigte Gesch?ftsf?hrer: Maximilian Weber Sitz der > > Gesellschaft: Margaretenstra?e 70/I/1, 1050 Wien, ?sterreich, Tel. > > +43 (1) 9610567-0 Eingetragen beim Handelsgericht Wien, > > Firmenbuch-Nr.: FN 116859 b Umsatzsteuer-Identifikationsnummer / > > VAT-ID: ATU15138401, > > Steuer-Nummer: 264/4807 > > > > This E-Mail has been sent on behalf of the company Intergraph > > Ges.m.b.H. > > > > Authorised Managing Directors: Maximilian Weber Registered office > > and Austrian headquarters: > > Margaretenstr. 70/I/1, 1050 Wien, Austria, Tel. +43 (1) 9610567-0 > > The company is recorded at the commercial court of Vienna under the > > company register number FN 116859 b > > > > VAT-ID: ATU15138401, Austrian Tax ID: 264/4807 > > > > Diese E-Mail (mit zugeh?rigen Dateien) enth?lt m?glicherweise > > Informationen, die vertraulich sind, dem Urheberrecht unterliegen > > oder ein Gesch?ftsgeheimnis darstellen. Falls Sie diese Nachricht > > irrt?mlicherweise erhalten haben, benachrichtigen Sie uns bitte > > umgehend, indem Sie eine Antwort senden, und l?schen Sie bitte > > diese E-Mail und Ihre Antwort darauf. S?mtliche aufgef?hrten > > Ansichten oder Meinungen sind ausschlie?lich diejenigen des Autors > > und entsprechen nicht notwendigerweise denen des Unternehmens Intergraph. > > > > This E-Mail (and any attachments) may be confidential and protected > > by legal privilege. If you are not the intended recipient please > > notify us immediately by replying to the sender and delete this > > E-Mail and your reply from your system. All the views and opinions > > published here are solely based on the author's own opinion and > > should not be considered necessarily as reflecting the opinion of > > Intergraph. > > > > -----Original Message----- > > > > From: Anton V. Tarasov [mailto:anton.tarasov at oracle.com] > > > > Sent: Tuesday, June 23, 2015 5:46 PM > > > > To: Kevin Rushforth; Hruda, Steve > > > > Cc:openjfx-dev at openjdk.java.net > > > > Subject: Re: Patch for JDK-8090098 - [regression] Webview - > > getTimezoneOffset() of a ISO strings returns a wrong value > > > > On 23.06.2015 17:48, Kevin Rushforth wrote: > > > > > > Hi Steve, > > Thank you for taking the time to create this patch. I will add > > this information to the bug report. > > Since your OCA is in progress we will take a look at your patch, > > but will need indication from the OCA office that it the OCA has > > been received before we could push it. And just to be clear, you > > won't have access to the repository even with an OCA. What the OCA > > will do is allow you to contribute > > > > patches. > > > > > > I will note that it is likely too late for 8u60, but Anton can > > evaluate it and post his comment in the bug report. > > > > Kevin, > > > > I'm checking it. > > > > Steve, thanks for the participation! > > > > Regards, > > > > Anton. > > > > > > -- Kevin > > Hruda, Steve wrote: > > > > Hi, > > I've created a 8u-dev patch for the following WeKit regression > > which comes with 8u60. > > https://bugs.openjdk.java.net/browse/JDK-8090098 > > Please can someone of you apply this patch to fix the > > getTimezoneOffset() issue. I have no access to the repository -> > > my OCA is still pending. > > In addition I tried to test this patch , but I wasn't able to > > build the necessary jfxwebkit.dll on my windows system > > (https://www.mail-archive.com/openjfx-dev at openjdk.java.net/msg094 > > 3 > > 9.h > > tml )..... but I got no compile erros on Mac. > > Patch download: > > https://drive.google.com/file/d/0B7P_rknS1TWxM3BSTTU2OVZ4dGM/view > > ?u > > sp > > =sharing > > The patch includes the following WebKit fixes: > > Changeset 174377 - [Win] DateMath's calculateUTFOffset does not > > account for DST. > > http://trac.webkit.org/changeset/174377 > > Changeset 175078 - String(new Date(Mar 30 2014 01:00:00)) is > > wrong in CET > > http://trac.webkit.org/changeset/175078 > > Changeset 181360 - [Win] 17 different JSC tests started to fail > > in DST > > http://trac.webkit.org/changeset/181360 > > Please let me know if you need further information. > > Thanks in advance! > > Best Regards > > Steve > > Diese E-Mail wurde versandt im Auftrag des Unternehmens > > Intergraph Ges.m.b.H. > > Vertretungsberechtigte Gesch?ftsf?hrer: Maximilian Weber Sitz der > > Gesellschaft: Margaretenstra?e 70/I/1, 1050 Wien, ?sterreich, Tel. > > +43 (1) 9610567-0 Eingetragen beim Handelsgericht Wien, > > Firmenbuch-Nr.: FN 116859 b Umsatzsteuer-Identifikationsnummer / > > VAT-ID: ATU15138401, Steuer-Nummer: 264/4807 This E-Mail has been > > sent on behalf of the company Intergraph Ges.m.b.H. > > Authorised Managing Directors: Maximilian Weber Registered office > > and Austrian headquarters: Margaretenstr. 70/I/1, 1050 Wien, > > Austria, Tel. +43 > > (1) 9610567-0 > > The company is recorded at the commercial court of Vienna under > > the company register number FN > > 116859 b > > VAT-ID: ATU15138401, Austrian Tax ID: 264/4807 Diese E-Mail (mit > > zugeh?rigen Dateien) enth?lt m?glicherweise Informationen, die > > vertraulich sind, dem Urheberrecht unterliegen oder ein > > Gesch?ftsgeheimnis darstellen. Falls Sie diese Nachricht > > irrt?mlicherweise erhalten haben, benachrichtigen Sie uns bitte > > umgehend, indem Sie eine Antwort senden, und l?schen Sie bitte > > diese E-Mail und Ihre Antwort darauf. S?mtliche aufgef?hrten > > Ansichten oder Meinungen sind > > > > ausschlie?lich diejenigen des Autors und entsprechen nicht > > notwendigerweise denen des Unternehmens Intergraph. > > > > > > This E-Mail (and any attachments) may be confidential and > > protected by legal privilege. If you are not the intended > > recipient please notify us immediately by replying to the sender > > and delete this E-Mail and your reply from your system. All the > > views and opinions published here are solely based on the > > author's own opinion and should not be considered > > > > necessarily as reflecting the opinion of Intergraph. > > > > > > > > > From steve.hruda at hexagongeospatial.com Thu Jul 2 13:31:08 2015 From: steve.hruda at hexagongeospatial.com (Hruda, Steve) Date: Thu, 2 Jul 2015 13:31:08 +0000 Subject: Patch for JDK-8090098 - [regression] Webview - getTimezoneOffset() of a ISO strings returns a wrong value In-Reply-To: <55953BF1.60204@oracle.com> References: <559191AA.8030800@oracle.com> <5592D943.3090407@oracle.com> <5592E269.6050200@oracle.com> <5592FFDB.5090501@oracle.com> <55930730.6050302@oracle.com> <5595337D.6000609@oracle.com> <55953BF1.60204@oracle.com> Message-ID: Yes! ;-) From: Anton V. Tarasov [mailto:anton.tarasov at oracle.com] Sent: Thursday, July 2, 2015 3:26 PM To: Hruda, Steve Cc: Kevin Rushforth; openjfx-dev at openjdk.java.net Subject: Re: Patch for JDK-8090098 - [regression] Webview - getTimezoneOffset() of a ISO strings returns a wrong value Ok, got it. You suggest trying the only 2-line change? Anton. On 02.07.2015 15:54, Hruda, Steve wrote: HI Anton, The diff fix must be there. if (diff<0) diff += secondsPerDay; ? but the following fixes are unnecessary, for the midnight bug. I think one of these fixes could be the problem. http://cr.openjdk.java.net/~ant/JDK-8090098/webrev.0/ which contains the following fixed issues: http://trac.webkit.org/changeset/174377 http://trac.webkit.org/changeset/175078 http://trac.webkit.org/changeset/181360 Regards, Steve From: Anton V. Tarasov [mailto:anton.tarasov at oracle.com] Sent: Thursday, July 2, 2015 2:50 PM To: Hruda, Steve Cc: Kevin Rushforth; openjfx-dev at openjdk.java.net Subject: Re: Patch for JDK-8090098 - [regression] Webview - getTimezoneOffset() of a ISO strings returns a wrong value Hi Steve, Actually, I already checked that removing if (diff<0) diff += secondsPerDay; didn't help. Regards, Anton. On 02.07.2015 13:09, Hruda, Steve wrote: Hi Anton, I saw your comments on https://bugs.openjdk.java.net/browse/JDK-8090098. We?ve opened the test page which you have mentioned in our own compiled WebKit version -> clean build & latest version. Used Timezone: Vienna CEST ? current Offset UTC+2:00 Without our Fix: Only the first and latest test pass. With our Fix: The same ? only the first and latest test pass. It seems that one changeset regress this behavior, but not the our latest ?if ?fix? if (diff<0) diff += secondsPerDay; I?m not able to build openjfx because of the missing dependencies (1.3). Please can you try what happens if you only apply the diff fix and not the previous patch, which includes all other date fixes. From my point of view are these fixes (which were provided by the patch file) not necessary to solve our datepicker problem. Thanks in advance, Steve From: Kevin Rushforth [mailto:kevin.rushforth at oracle.com] Sent: Tuesday, June 30, 2015 11:17 PM To: Hruda, Steve Cc: Anton V. Tarasov; openjfx-dev at openjdk.java.net Subject: Re: Patch for JDK-8090098 - [regression] Webview - getTimezoneOffset() of a ISO strings returns a wrong value Not by itself, although regressions are certainly taken very seriously. In any case, the process is to get this into 9-dev (once it has been reviewed), test it thoroughly, and then consider whether we can make a case for taking it to the 8u60 release team. -- Kevin Hruda, Steve wrote: Is a regression not release critical? Diese E-Mail wurde versandt im Auftrag des Unternehmens Intergraph Ges.m.b.H. Vertretungsberechtigte Gesch?ftsf?hrer: Maximilian Weber Sitz der Gesellschaft: Margaretenstra?e 70/I/1, 1050 Wien, ?sterreich, Tel. +43 (1) 9610567-0 Eingetragen beim Handelsgericht Wien, Firmenbuch-Nr.: FN 116859 b Umsatzsteuer-Identifikationsnummer / VAT-ID: ATU15138401, Steuer-Nummer: 264/4807 This E-Mail has been sent on behalf of the company Intergraph Ges.m.b.H. Authorised Managing Directors: Maximilian Weber Registered office and Austrian headquarters: Margaretenstr. 70/I/1, 1050 Wien, Austria, Tel. +43 (1) 9610567-0 The company is recorded at the commercial court of Vienna under the company register number FN 116859 b VAT-ID: ATU15138401, Austrian Tax ID: 264/4807 Diese E-Mail (mit zugeh?rigen Dateien) enth?lt m?glicherweise Informationen, die vertraulich sind, dem Urheberrecht unterliegen oder ein Gesch?ftsgeheimnis darstellen. Falls Sie diese Nachricht irrt?mlicherweise erhalten haben, benachrichtigen Sie uns bitte umgehend, indem Sie eine Antwort senden, und l?schen Sie bitte diese E-Mail und Ihre Antwort darauf. S?mtliche aufgef?hrten Ansichten oder Meinungen sind ausschlie?lich diejenigen des Autors und entsprechen nicht notwendigerweise denen des Unternehmens Intergraph. This E-Mail (and any attachments) may be confidential and protected by legal privilege. If you are not the intended recipient please notify us immediately by replying to the sender and delete this E-Mail and your reply from your system. All the views and opinions published here are solely based on the author's own opinion and should not be considered necessarily as reflecting the opinion of Intergraph. Diese E-Mail wurde versandt im Auftrag des Unternehmens Intergraph Ges.m.b.H. Vertretungsberechtigte Gesch?ftsf?hrer: Maximilian Weber Sitz der Gesellschaft: Margaretenstra?e 70/I/1, 1050 Wien, ?sterreich, Tel. +43 (1) 9610567-0 Eingetragen beim Handelsgericht Wien, Firmenbuch-Nr.: FN 116859 b Umsatzsteuer-Identifikationsnummer / VAT-ID: ATU15138401, Steuer-Nummer: 264/4807 This E-Mail has been sent on behalf of the company Intergraph Ges.m.b.H. Authorised Managing Directors: Maximilian Weber Registered office and Austrian headquarters: Margaretenstr. 70/I/1, 1050 Wien, Austria, Tel. +43 (1) 9610567-0 The company is recorded at the commercial court of Vienna under the company register number FN 116859 b VAT-ID: ATU15138401, Austrian Tax ID: 264/4807 Diese E-Mail (mit zugeh?rigen Dateien) enth?lt m?glicherweise Informationen, die vertraulich sind, dem Urheberrecht unterliegen oder ein Gesch?ftsgeheimnis darstellen. Falls Sie diese Nachricht irrt?mlicherweise erhalten haben, benachrichtigen Sie uns bitte umgehend, indem Sie eine Antwort senden, und l?schen Sie bitte diese E-Mail und Ihre Antwort darauf. S?mtliche aufgef?hrten Ansichten oder Meinungen sind ausschlie?lich diejenigen des Autors und entsprechen nicht notwendigerweise denen des Unternehmens Intergraph. This E-Mail (and any attachments) may be confidential and protected by legal privilege. If you are not the intended recipient please notify us immediately by replying to the sender and delete this E-Mail and your reply from your system. All the views and opinions published here are solely based on the author's own opinion and should not be considered necessarily as reflecting the opinion of Intergraph. Diese E-Mail wurde versandt im Auftrag des Unternehmens Intergraph Ges.m.b.H. Vertretungsberechtigte Gesch?ftsf?hrer: Maximilian Weber Sitz der Gesellschaft: Margaretenstra?e 70/I/1, 1050 Wien, ?sterreich, Tel. +43 (1) 9610567-0 Eingetragen beim Handelsgericht Wien, Firmenbuch-Nr.: FN 116859 b Umsatzsteuer-Identifikationsnummer / VAT-ID: ATU15138401, Steuer-Nummer: 264/4807 This E-Mail has been sent on behalf of the company Intergraph Ges.m.b.H. Authorised Managing Directors: Maximilian Weber Registered office and Austrian headquarters: Margaretenstr. 70/I/1, 1050 Wien, Austria, Tel. +43 (1) 9610567-0 The company is recorded at the commercial court of Vienna under the company register number FN 116859 b VAT-ID: ATU15138401, Austrian Tax ID: 264/4807 Diese E-Mail (mit zugeh?rigen Dateien) enth?lt m?glicherweise Informationen, die vertraulich sind, dem Urheberrecht unterliegen oder ein Gesch?ftsgeheimnis darstellen. Falls Sie diese Nachricht irrt?mlicherweise erhalten haben, benachrichtigen Sie uns bitte umgehend, indem Sie eine Antwort senden, und l?schen Sie bitte diese E-Mail und Ihre Antwort darauf. S?mtliche aufgef?hrten Ansichten oder Meinungen sind ausschlie?lich diejenigen des Autors und entsprechen nicht notwendigerweise denen des Unternehmens Intergraph. This E-Mail (and any attachments) may be confidential and protected by legal privilege. If you are not the intended recipient please notify us immediately by replying to the sender and delete this E-Mail and your reply from your system. All the views and opinions published here are solely based on the author's own opinion and should not be considered necessarily as reflecting the opinion of Intergraph. Diese E-Mail wurde versandt im Auftrag des Unternehmens Intergraph Ges.m.b.H. Vertretungsberechtigte Gesch?ftsf?hrer: Maximilian Weber Sitz der Gesellschaft: Margaretenstra?e 70/I/1, 1050 Wien, ?sterreich, Tel. +43 (1) 9610567-0 Eingetragen beim Handelsgericht Wien, Firmenbuch-Nr.: FN 116859 b Umsatzsteuer-Identifikationsnummer / VAT-ID: ATU15138401, Steuer-Nummer: 264/4807 This E-Mail has been sent on behalf of the company Intergraph Ges.m.b.H. Authorised Managing Directors: Maximilian Weber Registered office and Austrian headquarters: Margaretenstr. 70/I/1, 1050 Wien, Austria, Tel. +43 (1) 9610567-0 The company is recorded at the commercial court of Vienna under the company register number FN 116859 b VAT-ID: ATU15138401, Austrian Tax ID: 264/4807 Diese E-Mail (mit zugeh?rigen Dateien) enth?lt m?glicherweise Informationen, die vertraulich sind, dem Urheberrecht unterliegen oder ein Gesch?ftsgeheimnis darstellen. Falls Sie diese Nachricht irrt?mlicherweise erhalten haben, benachrichtigen Sie uns bitte umgehend, indem Sie eine Antwort senden, und l?schen Sie bitte diese E-Mail und Ihre Antwort darauf. S?mtliche aufgef?hrten Ansichten oder Meinungen sind ausschlie?lich diejenigen des Autors und entsprechen nicht notwendigerweise denen des Unternehmens Intergraph. This E-Mail (and any attachments) may be confidential and protected by legal privilege. If you are not the intended recipient please notify us immediately by replying to the sender and delete this E-Mail and your reply from your system. All the views and opinions published here are solely based on the author's own opinion and should not be considered necessarily as reflecting the opinion of Intergraph. -----Original Message----- From: Kevin Rushforth [mailto:kevin.rushforth at oracle.com] Sent: Tuesday, June 30, 2015 10:45 PM To: Anton V. Tarasov Cc: Hruda, Steve; openjfx-dev at openjdk.java.net Subject: Re: Patch for JDK-8090098 - [regression] Webview - getTimezoneOffset() of a ISO strings returns a wrong value Anton V. Tarasov wrote: On 30.06.2015 21:13, Hruda, Steve wrote: Hi Anton, thanks for the detailed information and the good news. You talk about JDK's jira? Am I right? ..... I don't have an access for that JIRA system since the JavaFX's Jira has moved to the JDK Bug System. Ah, ok. Then I'll quote your e-mail. About the Apple stuff. I know that Apple dropped Windows Safari support and in my opinion is this a very bad situation for WebKit (in case of Windows).... and especially since Google and Opera using Google's Blink engine. In case of the JDK it would be more practicable to switch from WebKit to Blink, because this engine is still used by Companies which have Windows end-users. There is a high probability that WebKit get more such bugs if there is no big player like Google or Apple who has the man power to fix such OS dependent issues. I see. However, switching to Blink is another story. Honestly, we're not planning it in the nearest future. This requires extra resources which we don't have at the moment... Last questions: Do you need any additional information from my side? And is it possible to integrate this fix in 8u60? From my side, I'll do a sanity check with WebKit LayoutTests, then if it goes well, we can consider commiting this to 8u60. @Kevin, do you think we can? Very unlikely. The JDK release team would need to approve, and only release-critical issues may be considered at this point (it would be hard to argue that this is release-critical since it has already been deferred). -- Kevin Also, as an option for you (Steve). You can post the changes to the WebKit alias and ask if they think this is a valid fix for the issue. Any confirmation from the WebKit team would help us to make sure the fix is reliable. Thanks! Anton. Thanks in advance! Best Regards, Steve Diese E-Mail wurde versandt im Auftrag des Unternehmens Intergraph Ges.m.b.H. Vertretungsberechtigte Gesch?ftsf?hrer: Maximilian Weber Sitz der Gesellschaft: Margaretenstra?e 70/I/1, 1050 Wien, ?sterreich, Tel. +43 (1) 9610567-0 Eingetragen beim Handelsgericht Wien, Firmenbuch-Nr.: FN 116859 b Umsatzsteuer-Identifikationsnummer / VAT-ID: ATU15138401, Steuer-Nummer: 264/4807 This E-Mail has been sent on behalf of the company Intergraph Ges.m.b.H. Authorised Managing Directors: Maximilian Weber Registered office and Austrian headquarters: Margaretenstr. 70/I/1, 1050 Wien, Austria, Tel. +43 (1) 9610567-0 The company is recorded at the commercial court of Vienna under the company register number FN 116859 b VAT-ID: ATU15138401, Austrian Tax ID: 264/4807 Diese E-Mail (mit zugeh?rigen Dateien) enth?lt m?glicherweise Informationen, die vertraulich sind, dem Urheberrecht unterliegen oder ein Gesch?ftsgeheimnis darstellen. Falls Sie diese Nachricht irrt?mlicherweise erhalten haben, benachrichtigen Sie uns bitte umgehend, indem Sie eine Antwort senden, und l?schen Sie bitte diese E-Mail und Ihre Antwort darauf. S?mtliche aufgef?hrten Ansichten oder Meinungen sind ausschlie?lich diejenigen des Autors und entsprechen nicht notwendigerweise denen des Unternehmens Intergraph. This E-Mail (and any attachments) may be confidential and protected by legal privilege. If you are not the intended recipient please notify us immediately by replying to the sender and delete this E-Mail and your reply from your system. All the views and opinions published here are solely based on the author's own opinion and should not be considered necessarily as reflecting the opinion of Intergraph. -----Original Message----- From: Anton V. Tarasov [mailto:anton.tarasov at oracle.com] Sent: Tuesday, June 30, 2015 8:01 PM To: Hruda, Steve; Kevin Rushforth Cc: openjfx-dev at openjdk.java.net Subject: Re: Patch for JDK-8090098 - [regression] Webview - getTimezoneOffset() of a ISO strings returns a wrong value Steve, I applied your suggestion and it worked on Windows. The missed check you discovered could really be a mistake in WebKit, because Apple dropped releasing (and shipping nightly builds for) Safari for Windows at 2012. Safari 5.1.7 was the last version. I downloaded and checked it. The date bug is not reproducible with it, but this gives us almost nothing taking into account the version is much outdated. So that Windows code path might not have been well tested, since http://trac.webkit.org/changeset/159892 was commited... (WebKit Win port is still supported and can be built on your own.) What I can do else to verify the changes is to run WebKit LayoutTests aimed at date testing and see if there're no regressions. Also, please put the info you posted into JIRA. Regards, Anton. On 29.06.2015 21:42, Anton Tarasov wrote: Hi Steve, Ok, I'll investigate it. Thanks, Anton. On 29.06.2015 18:39, Hruda, Steve wrote: Hi Anton & Kevin, we read your comments in the JDK bug system and analyzed WebKit's changesets again. We?ve found the code which made this regression. http://trac.webkit.org/changeset/159892 This changeset doesn't handle one special case, which was handled by the previous code.... double diff = ((localSystemTime.wHour - offsetHour) * secondsPerHour) + ((localSystemTime.wMinute - offsetMinute) *60); (http://trac.webkit.org/browser/trunk/Source/WTF/wtf/DateMath.cpp?a nn otate=blame#L481 ) The diff is wrong if the calculated the offsetTime is one day before in case of the extreme values (e.g. midnight) where the offsetHour of the UTC time is 23 because of the day difference. In case of all other OS systems you will see the same code -> http://trac.webkit.org/browser/trunk/Source/WTF/wtf/DateMath.cpp?an no tate=blame#L495 But there are two additional lines -> 497 & 497 which fixes this special case? *if*(diff<0) diff += secondsPerDay; That means ?. localSystemTime.wHour = 0; offsetHour=23 ? which causes a negative value ? and the diff+=secondsPerDay ensures that the diff result would be one Hour instead of -23 hours We?ve found the attached V8DateTests.js (renamed to .txt) and adjusted it a little bit to get the results logged in the browsers console. As you can see at ?ResulBeforeOurBugFix.txt? and ?ResultAfterOurBugFix.txt?, we were able to fix 6 tests which failed before out bug fix. assertEquals("Sat Oct 25 2014 23:00:00 GMT+0200 (W. Europe Daylight Time)", (new Date(2014, 9, 25, 23, 0)).toString()); assertEquals("Sat, 25 Oct 2014 21:00:00 GMT", (new Date(2014, 9, 25, 23, 0)).toUTCString()); assertEquals("Sat Oct 25 2014 23:59:00 GMT+0200 (W. Europe Daylight Time)", (new Date(2014, 9, 25, 23, 59)).toString()); assertEquals("Sat, 25 Oct 2014 21:59:00 GMT", (new Date(2014, 9, 25, 23, 59)).toUTCString()); assertEquals("Sun Oct 26 2014 00:00:00 GMT+0200 (W. Europe Daylight Time)", (new Date(2014, 9, 26, 0, 0)).toString()); assertEquals("Sun Oct 26 2014 00:59:00 GMT+0200 (W. Europe Daylight Time)", (new Date(2014, 9, 26, 0, 59)).toString()); In addition we found out that WebKit also have problems in case of Windows in case of the change from winter to summer time. *_Winter to summer time:_* assertEquals("Sun Mar 30 2014 03:00:00 GMT+0200 (W. Europe Daylight Time)", (new Date(2014, 2, 30, 2, 0)).toString()); assertEquals("Sun, 30 Mar 2014 01:00:00 GMT", (new Date(2014, 2, 30, 2, 0)).toUTCString()); assertEquals("Sun Mar 30 2014 03:59:00 GMT+0200 (W. Europe Daylight Time)", (new Date(2014, 2, 30, 2, 59)).toString()); assertEquals("Sun, 30 Mar 2014 01:59:00 GMT", (new Date(2014, 2, 30, 2, 59)).toUTCString()); *_Summer to winter time:_* assertEquals("Sun Oct 26 2014 02:00:00 GMT+0200 (W. Europe Daylight Time)", (new Date(2014, 9, 26, 2, 0)).toString()); assertEquals("Sun, 26 Oct 2014 00:00:00 GMT", (new Date(2014, 9, 26, 2, 0)).toUTCString()); assertEquals("Sun Oct 26 2014 02:59:00 GMT+0200 (W. Europe Daylight Time)", (new Date(2014, 9, 26, 2, 59)).toString()); assertEquals("Sun, 26 Oct 2014 00:59:00 GMT", (new Date(2014, 9, 26, 2, 59)).toUTCString()); We will try to find a solution for that, but I think that the priority of this issue is lower than the priority of the opened regression. It would be amazing if you can add the patch of my previous and these additional two lines (DateMath.cpp) to the JDK8u60. Best Regards, Steve Diese E-Mail wurde versandt im Auftrag des Unternehmens Intergraph Ges.m.b.H. Vertretungsberechtigte Gesch?ftsf?hrer: Maximilian Weber Sitz der Gesellschaft: Margaretenstra?e 70/I/1, 1050 Wien, ?sterreich, Tel. +43 (1) 9610567-0 Eingetragen beim Handelsgericht Wien, Firmenbuch-Nr.: FN 116859 b Umsatzsteuer-Identifikationsnummer / VAT-ID: ATU15138401, Steuer-Nummer: 264/4807 This E-Mail has been sent on behalf of the company Intergraph Ges.m.b.H. Authorised Managing Directors: Maximilian Weber Registered office and Austrian headquarters: Margaretenstr. 70/I/1, 1050 Wien, Austria, Tel. +43 (1) 9610567-0 The company is recorded at the commercial court of Vienna under the company register number FN 116859 b VAT-ID: ATU15138401, Austrian Tax ID: 264/4807 Diese E-Mail (mit zugeh?rigen Dateien) enth?lt m?glicherweise Informationen, die vertraulich sind, dem Urheberrecht unterliegen oder ein Gesch?ftsgeheimnis darstellen. Falls Sie diese Nachricht irrt?mlicherweise erhalten haben, benachrichtigen Sie uns bitte umgehend, indem Sie eine Antwort senden, und l?schen Sie bitte diese E-Mail und Ihre Antwort darauf. S?mtliche aufgef?hrten Ansichten oder Meinungen sind ausschlie?lich diejenigen des Autors und entsprechen nicht notwendigerweise denen des Unternehmens Intergraph. This E-Mail (and any attachments) may be confidential and protected by legal privilege. If you are not the intended recipient please notify us immediately by replying to the sender and delete this E-Mail and your reply from your system. All the views and opinions published here are solely based on the author's own opinion and should not be considered necessarily as reflecting the opinion of Intergraph. -----Original Message----- From: openjfx-dev [mailto:openjfx-dev-bounces at openjdk.java.net] On Behalf Of Hruda, Steve Sent: Tuesday, June 23, 2015 6:26 PM To: Anton V. Tarasov; Kevin Rushforth Cc: openjfx-dev at openjdk.java.net Subject: RE: Patch for JDK-8090098 - [regression] Webview - getTimezoneOffset() of a ISO strings returns a wrong value Very cool Anton. I would be great if that pach could be added to 8u60, otherwise our all our customers have to avoid Java 8u60. Regards, Steve Diese E-Mail wurde versandt im Auftrag des Unternehmens Intergraph Ges.m.b.H. Vertretungsberechtigte Gesch?ftsf?hrer: Maximilian Weber Sitz der Gesellschaft: Margaretenstra?e 70/I/1, 1050 Wien, ?sterreich, Tel. +43 (1) 9610567-0 Eingetragen beim Handelsgericht Wien, Firmenbuch-Nr.: FN 116859 b Umsatzsteuer-Identifikationsnummer / VAT-ID: ATU15138401, Steuer-Nummer: 264/4807 This E-Mail has been sent on behalf of the company Intergraph Ges.m.b.H. Authorised Managing Directors: Maximilian Weber Registered office and Austrian headquarters: Margaretenstr. 70/I/1, 1050 Wien, Austria, Tel. +43 (1) 9610567-0 The company is recorded at the commercial court of Vienna under the company register number FN 116859 b VAT-ID: ATU15138401, Austrian Tax ID: 264/4807 Diese E-Mail (mit zugeh?rigen Dateien) enth?lt m?glicherweise Informationen, die vertraulich sind, dem Urheberrecht unterliegen oder ein Gesch?ftsgeheimnis darstellen. Falls Sie diese Nachricht irrt?mlicherweise erhalten haben, benachrichtigen Sie uns bitte umgehend, indem Sie eine Antwort senden, und l?schen Sie bitte diese E-Mail und Ihre Antwort darauf. S?mtliche aufgef?hrten Ansichten oder Meinungen sind ausschlie?lich diejenigen des Autors und entsprechen nicht notwendigerweise denen des Unternehmens Intergraph. This E-Mail (and any attachments) may be confidential and protected by legal privilege. If you are not the intended recipient please notify us immediately by replying to the sender and delete this E-Mail and your reply from your system. All the views and opinions published here are solely based on the author's own opinion and should not be considered necessarily as reflecting the opinion of Intergraph. -----Original Message----- From: Anton V. Tarasov [mailto:anton.tarasov at oracle.com] Sent: Tuesday, June 23, 2015 5:46 PM To: Kevin Rushforth; Hruda, Steve Cc: openjfx-dev at openjdk.java.net Subject: Re: Patch for JDK-8090098 - [regression] Webview - getTimezoneOffset() of a ISO strings returns a wrong value On 23.06.2015 17:48, Kevin Rushforth wrote: Hi Steve, Thank you for taking the time to create this patch. I will add this information to the bug report. Since your OCA is in progress we will take a look at your patch, but will need indication from the OCA office that it the OCA has been received before we could push it. And just to be clear, you won't have access to the repository even with an OCA. What the OCA will do is allow you to contribute patches. I will note that it is likely too late for 8u60, but Anton can evaluate it and post his comment in the bug report. Kevin, I'm checking it. Steve, thanks for the participation! Regards, Anton. -- Kevin Hruda, Steve wrote: Hi, I've created a 8u-dev patch for the following WeKit regression which comes with 8u60. https://bugs.openjdk.java.net/b rowse/JDK-8090098 Please can someone of you apply this patch to fix the getTimezoneOffset() issue. I have no access to the repository -> my OCA is still pending. In addition I tried to test this patch , but I wasn't able to build the necessary jfxwebkit.dll on my windows system (https://www.mail-archive.com/openjfx-dev at openjdk.java.net/msg094 3 9.h tml )..... but I got no compile erros on Mac. Patch download: https://drive.google.com/file/d/0B7P_rknS1TWxM3BSTTU2OVZ4dGM/view ?u sp =sharing The patch includes the following WebKit fixes: Changeset 174377 - [Win] DateMath's calculateUTFOffset does not account for DST. http://trac.webkit.org/changeset/174377 Changeset 175078 - String(new Date(Mar 30 2014 01:00:00)) is wrong in CET http://trac.webkit.org/changeset/175078 Changeset 181360 - [Win] 17 different JSC tests started to fail in DST http://trac.webkit.org/changeset/181360 Please let me know if you need further information. Thanks in advance! Best Regards Steve Diese E-Mail wurde versandt im Auftrag des Unternehmens Intergraph Ges.m.b.H. Vertretungsberechtigte Gesch?ftsf?hrer: Maximilian Weber Sitz der Gesellschaft: Margaretenstra?e 70/I/1, 1050 Wien, ?sterreich, Tel. +43 (1) 9610567-0 Eingetragen beim Handelsgericht Wien, Firmenbuch-Nr.: FN 116859 b Umsatzsteuer-Identifikationsnummer / VAT-ID: ATU15138401, Steuer-Nummer: 264/4807 This E-Mail has been sent on behalf of the company Intergraph Ges.m.b.H. Authorised Managing Directors: Maximilian Weber Registered office and Austrian headquarters: Margaretenstr. 70/I/1, 1050 Wien, Austria, Tel. +43 (1) 9610567-0 The company is recorded at the commercial court of Vienna under the company register number FN 116859 b VAT-ID: ATU15138401, Austrian Tax ID: 264/4807 Diese E-Mail (mit zugeh?rigen Dateien) enth?lt m?glicherweise Informationen, die vertraulich sind, dem Urheberrecht unterliegen oder ein Gesch?ftsgeheimnis darstellen. Falls Sie diese Nachricht irrt?mlicherweise erhalten haben, benachrichtigen Sie uns bitte umgehend, indem Sie eine Antwort senden, und l?schen Sie bitte diese E-Mail und Ihre Antwort darauf. S?mtliche aufgef?hrten Ansichten oder Meinungen sind ausschlie?lich diejenigen des Autors und entsprechen nicht notwendigerweise denen des Unternehmens Intergraph. This E-Mail (and any attachments) may be confidential and protected by legal privilege. If you are not the intended recipient please notify us immediately by replying to the sender and delete this E-Mail and your reply from your system. All the views and opinions published here are solely based on the author's own opinion and should not be considered necessarily as reflecting the opinion of Intergraph. From anton.tarasov at oracle.com Thu Jul 2 14:44:17 2015 From: anton.tarasov at oracle.com (Anton V. Tarasov) Date: Thu, 02 Jul 2015 16:44:17 +0200 Subject: Patch for JDK-8090098 - [regression] Webview - getTimezoneOffset() of a ISO strings returns a wrong value In-Reply-To: References: <559191AA.8030800@oracle.com> <5592D943.3090407@oracle.com> <5592E269.6050200@oracle.com> <5592FFDB.5090501@oracle.com> <55930730.6050302@oracle.com> <5595337D.6000609@oracle.com> <55953BF1.60204@oracle.com> Message-ID: <55954E40.5090204@oracle.com> The test passes with this only change. And the original bug is not reproducible. Ok, I'll need to test it with other date LayoutTests again. Will update in JIRA. Regards, Anton. On 02.07.2015 15:31, Hruda, Steve wrote: > > Yes! ;-) > > *From:*Anton V. Tarasov [mailto:anton.tarasov at oracle.com] > *Sent:* Thursday, July 2, 2015 3:26 PM > *To:* Hruda, Steve > *Cc:* Kevin Rushforth; openjfx-dev at openjdk.java.net > *Subject:* Re: Patch for JDK-8090098 - [regression] Webview - getTimezoneOffset() of a ISO strings > returns a wrong value > > Ok, got it. You suggest trying the only 2-line change? > > Anton. > > On 02.07.2015 15:54, Hruda, Steve wrote: > > HI Anton, > > The diff fix must be there. > > if (diff<0) > > diff += secondsPerDay; > > ? but the following fixes are unnecessary, for the midnight bug. I think one of these fixes > could be the problem. > > http://cr.openjdk.java.net/~ant/JDK-8090098/webrev.0/ > > > which contains the following fixed issues: > > http://trac.webkit.org/changeset/174377 > http://trac.webkit.org/changeset/175078 > http://trac.webkit.org/changeset/181360 > > Regards, > > Steve > > *From:*Anton V. Tarasov [mailto:anton.tarasov at oracle.com] > *Sent:* Thursday, July 2, 2015 2:50 PM > *To:* Hruda, Steve > *Cc:* Kevin Rushforth; openjfx-dev at openjdk.java.net > *Subject:* Re: Patch for JDK-8090098 - [regression] Webview - getTimezoneOffset() of a ISO > strings returns a wrong value > > Hi Steve, > > Actually, I already checked that removing > > if (diff<0) > > diff += secondsPerDay; > > > didn't help. > > Regards, > Anton. > > On 02.07.2015 13:09, Hruda, Steve wrote: > > Hi Anton, > > I saw your comments on https://bugs.openjdk.java.net/browse/JDK-8090098. > > We?ve opened the test page which you have mentioned in our own compiled WebKit version -> > clean build & latest version. > > Used Timezone: Vienna CEST ? current Offset UTC+2:00 > > Without our Fix: > > Only the first and latest test pass. > > With our Fix: > > The same ? only the first and latest test pass. > > It seems that one changeset regress this behavior, but not the our latest ?if ?fix? > > if (diff<0) > > diff += secondsPerDay; > > I?m not able to build openjfx because of the missing dependencies (1.3). Please can you > try what happens if you only apply the diff fix and not the previous patch, which includes > all other date fixes. From my point of view are these fixes (which were provided by the > patch file) not necessary to solve our datepicker problem. > > Thanks in advance, > > Steve > > *From:*Kevin Rushforth [mailto:kevin.rushforth at oracle.com] > *Sent:* Tuesday, June 30, 2015 11:17 PM > *To:* Hruda, Steve > *Cc:* Anton V. Tarasov; openjfx-dev at openjdk.java.net > *Subject:* Re: Patch for JDK-8090098 - [regression] Webview - getTimezoneOffset() of a ISO > strings returns a wrong value > > Not by itself, although regressions are certainly taken very seriously. > > In any case, the process is to get this into 9-dev (once it has been reviewed), test it > thoroughly, and then consider whether we can make a case for taking it to the 8u60 release > team. > > -- Kevin > > > Hruda, Steve wrote: > > Is a regression not release critical? > > > > > > > > > > Diese E-Mail wurde versandt im Auftrag des Unternehmens Intergraph Ges.m.b.H. > > Vertretungsberechtigte Gesch?ftsf?hrer: Maximilian Weber > > Sitz der Gesellschaft: Margaretenstra?e 70/I/1, 1050 Wien, ?sterreich, Tel. +43 (1) 9610567-0 > > Eingetragen beim Handelsgericht Wien, Firmenbuch-Nr.: FN 116859 b > > Umsatzsteuer-Identifikationsnummer / VAT-ID: ATU15138401, Steuer-Nummer: 264/4807 > > > > This E-Mail has been sent on behalf of the company Intergraph Ges.m.b.H. > > Authorised Managing Directors: Maximilian Weber > > Registered office and Austrian headquarters: Margaretenstr. 70/I/1, 1050 Wien, Austria, Tel. +43 (1) 9610567-0 > > The company is recorded at the commercial court of Vienna under the company register number FN 116859 b > > VAT-ID: ATU15138401, Austrian Tax ID: 264/4807 > > > > Diese E-Mail (mit zugeh?rigen Dateien) enth?lt m?glicherweise Informationen, die vertraulich sind, dem Urheberrecht unterliegen oder ein Gesch?ftsgeheimnis darstellen. Falls Sie diese Nachricht irrt?mlicherweise erhalten haben, benachrichtigen Sie uns bitte umgehend, indem Sie eine Antwort senden, und l?schen Sie bitte diese E-Mail und Ihre Antwort darauf. S?mtliche aufgef?hrten Ansichten oder Meinungen sind ausschlie?lich diejenigen des Autors und entsprechen nicht notwendigerweise denen des Unternehmens Intergraph. > > > > This E-Mail (and any attachments) may be confidential and protected by legal privilege. If you are not the intended recipient please notify us immediately by replying to the sender and delete this E-Mail and your reply from your system. All the views and opinions published here are solely based on the author's own opinion and should not be considered necessarily as reflecting the opinion of Intergraph. > > > > > > > Diese E-Mail wurde versandt im Auftrag des Unternehmens Intergraph Ges.m.b.H. > Vertretungsberechtigte Gesch?ftsf?hrer: Maximilian Weber > Sitz der Gesellschaft: Margaretenstra?e 70/I/1, 1050 Wien, ?sterreich, Tel. +43 (1) 9610567-0 > Eingetragen beim Handelsgericht Wien, Firmenbuch-Nr.: FN 116859 b > Umsatzsteuer-Identifikationsnummer / VAT-ID: ATU15138401, Steuer-Nummer: 264/4807 > > This E-Mail has been sent on behalf of the company Intergraph Ges.m.b.H. > Authorised Managing Directors: Maximilian Weber > Registered office and Austrian headquarters: Margaretenstr. 70/I/1, 1050 Wien, Austria, > Tel. +43 (1) 9610567-0 > The company is recorded at the commercial court of Vienna under the company register > number FN 116859 b > VAT-ID: ATU15138401, Austrian Tax ID: 264/4807 > > Diese E-Mail (mit zugeh?rigen Dateien) enth?lt m?glicherweise Informationen, die > vertraulich sind, dem Urheberrecht unterliegen oder ein Gesch?ftsgeheimnis darstellen. > Falls Sie diese Nachricht irrt?mlicherweise erhalten haben, benachrichtigen Sie uns bitte > umgehend, indem Sie eine Antwort senden, und l?schen Sie bitte diese E-Mail und Ihre > Antwort darauf. S?mtliche aufgef?hrten Ansichten oder Meinungen sind ausschlie?lich > diejenigen des Autors und entsprechen nicht notwendigerweise denen des Unternehmens > Intergraph. > > This E-Mail (and any attachments) may be confidential and protected by legal privilege. If > you are not the intended recipient please notify us immediately by replying to the sender > and delete this E-Mail and your reply from your system. All the views and opinions > published here are solely based on the author's own opinion and should not be considered > necessarily as reflecting the opinion of Intergraph. > > > Diese E-Mail wurde versandt im Auftrag des Unternehmens Intergraph Ges.m.b.H. > Vertretungsberechtigte Gesch?ftsf?hrer: Maximilian Weber > Sitz der Gesellschaft: Margaretenstra?e 70/I/1, 1050 Wien, ?sterreich, Tel. +43 (1) 9610567-0 > Eingetragen beim Handelsgericht Wien, Firmenbuch-Nr.: FN 116859 b > Umsatzsteuer-Identifikationsnummer / VAT-ID: ATU15138401, Steuer-Nummer: 264/4807 > > This E-Mail has been sent on behalf of the company Intergraph Ges.m.b.H. > Authorised Managing Directors: Maximilian Weber > Registered office and Austrian headquarters: Margaretenstr. 70/I/1, 1050 Wien, Austria, Tel. > +43 (1) 9610567-0 > The company is recorded at the commercial court of Vienna under the company register number FN > 116859 b > VAT-ID: ATU15138401, Austrian Tax ID: 264/4807 > > Diese E-Mail (mit zugeh?rigen Dateien) enth?lt m?glicherweise Informationen, die vertraulich > sind, dem Urheberrecht unterliegen oder ein Gesch?ftsgeheimnis darstellen. Falls Sie diese > Nachricht irrt?mlicherweise erhalten haben, benachrichtigen Sie uns bitte umgehend, indem Sie > eine Antwort senden, und l?schen Sie bitte diese E-Mail und Ihre Antwort darauf. S?mtliche > aufgef?hrten Ansichten oder Meinungen sind ausschlie?lich diejenigen des Autors und > entsprechen nicht notwendigerweise denen des Unternehmens Intergraph. > > This E-Mail (and any attachments) may be confidential and protected by legal privilege. If you > are not the intended recipient please notify us immediately by replying to the sender and > delete this E-Mail and your reply from your system. All the views and opinions published here > are solely based on the author's own opinion and should not be considered necessarily as > reflecting the opinion of Intergraph. > > > Diese E-Mail wurde versandt im Auftrag des Unternehmens Intergraph Ges.m.b.H. > Vertretungsberechtigte Gesch?ftsf?hrer: Maximilian Weber > Sitz der Gesellschaft: Margaretenstra?e 70/I/1, 1050 Wien, ?sterreich, Tel. +43 (1) 9610567-0 > Eingetragen beim Handelsgericht Wien, Firmenbuch-Nr.: FN 116859 b > Umsatzsteuer-Identifikationsnummer / VAT-ID: ATU15138401, Steuer-Nummer: 264/4807 > > This E-Mail has been sent on behalf of the company Intergraph Ges.m.b.H. > Authorised Managing Directors: Maximilian Weber > Registered office and Austrian headquarters: Margaretenstr. 70/I/1, 1050 Wien, Austria, Tel. +43 > (1) 9610567-0 > The company is recorded at the commercial court of Vienna under the company register number FN > 116859 b > VAT-ID: ATU15138401, Austrian Tax ID: 264/4807 > > Diese E-Mail (mit zugeh?rigen Dateien) enth?lt m?glicherweise Informationen, die vertraulich sind, > dem Urheberrecht unterliegen oder ein Gesch?ftsgeheimnis darstellen. Falls Sie diese Nachricht > irrt?mlicherweise erhalten haben, benachrichtigen Sie uns bitte umgehend, indem Sie eine Antwort > senden, und l?schen Sie bitte diese E-Mail und Ihre Antwort darauf. S?mtliche aufgef?hrten > Ansichten oder Meinungen sind ausschlie?lich diejenigen des Autors und entsprechen nicht > notwendigerweise denen des Unternehmens Intergraph. > > This E-Mail (and any attachments) may be confidential and protected by legal privilege. If you are > not the intended recipient please notify us immediately by replying to the sender and delete this > E-Mail and your reply from your system. All the views and opinions published here are solely based > on the author's own opinion and should not be considered necessarily as reflecting the opinion of > Intergraph. > > -----Original Message----- > > From: Kevin Rushforth [mailto:kevin.rushforth at oracle.com] > > Sent: Tuesday, June 30, 2015 10:45 PM > > To: Anton V. Tarasov > > Cc: Hruda, Steve;openjfx-dev at openjdk.java.net > > Subject: Re: Patch for JDK-8090098 - [regression] Webview - getTimezoneOffset() of a ISO strings returns a wrong value > > > > > > > > Anton V. Tarasov wrote: > > > > On 30.06.2015 21:13, Hruda, Steve wrote: > > > > Hi Anton, > > thanks for the detailed information and the good news. > > > > You talk about JDK's jira? Am I right? ..... I don't have an access > > for that JIRA system since the JavaFX's Jira has moved to the JDK Bug > > System. > > > > Ah, ok. Then I'll quote your e-mail. > > > > > > About the Apple stuff. > > I know that Apple dropped Windows Safari support and in my opinion is > > this a very bad situation for WebKit (in case of Windows).... and > > especially since Google and Opera using Google's Blink engine. > > > > In case of the JDK it would be more practicable to switch from WebKit > > to Blink, because this engine is still used by Companies which have > > Windows end-users. > > > > There is a high probability that WebKit get more such bugs if there > > is no big player like Google or Apple who has the man power to fix > > such OS dependent issues. > > > > I see. However, switching to Blink is another story. Honestly, we're > > not planning it in the nearest future. This requires extra resources > > which we don't have at the moment... > > > > > > Last questions: > > Do you need any additional information from my side? And is it > > possible to integrate this fix in 8u60? > > > > From my side, I'll do a sanity check with WebKit LayoutTests, then if > > it goes well, we can consider commiting this to 8u60. > > > > @Kevin, do you think we can? > > > > > > Very unlikely. The JDK release team would need to approve, and only release-critical issues may be considered at this point (it would be hard to argue that this is release-critical since it has already been deferred). > > > > -- Kevin > > > > > > > > Also, as an option for you (Steve). You can post the changes to the > > WebKit alias and ask if they think this is a valid fix for the issue. > > Any confirmation from the WebKit team would help us to make sure the > > fix is reliable. > > > > Thanks! > > Anton. > > > > > > Thanks in advance! > > Best Regards, > > Steve > > > > > > > > > > Diese E-Mail wurde versandt im Auftrag des Unternehmens Intergraph > > Ges.m.b.H. > > Vertretungsberechtigte Gesch?ftsf?hrer: Maximilian Weber Sitz der > > Gesellschaft: Margaretenstra?e 70/I/1, 1050 Wien, ?sterreich, Tel. > > +43 (1) 9610567-0 Eingetragen beim Handelsgericht Wien, > > Firmenbuch-Nr.: FN 116859 b Umsatzsteuer-Identifikationsnummer / > > VAT-ID: ATU15138401, > > Steuer-Nummer: 264/4807 > > > > This E-Mail has been sent on behalf of the company Intergraph Ges.m.b.H. > > Authorised Managing Directors: Maximilian Weber Registered office and > > Austrian headquarters: Margaretenstr. 70/I/1, > > 1050 Wien, Austria, Tel. +43 (1) 9610567-0 The company is recorded at > > the commercial court of Vienna under the company register number FN > > 116859 b > > VAT-ID: ATU15138401, Austrian Tax ID: 264/4807 > > > > Diese E-Mail (mit zugeh?rigen Dateien) enth?lt m?glicherweise > > Informationen, die vertraulich sind, dem Urheberrecht unterliegen > > oder ein Gesch?ftsgeheimnis darstellen. Falls Sie diese Nachricht > > irrt?mlicherweise erhalten haben, benachrichtigen Sie uns bitte > > umgehend, indem Sie eine Antwort senden, und l?schen Sie bitte diese > > E-Mail und Ihre Antwort darauf. S?mtliche aufgef?hrten Ansichten oder > > Meinungen sind ausschlie?lich diejenigen des Autors und entsprechen > > nicht notwendigerweise denen des Unternehmens Intergraph. > > > > This E-Mail (and any attachments) may be confidential and protected > > by legal privilege. If you are not the intended recipient please > > notify us immediately by replying to the sender and delete this > > E-Mail and your reply from your system. All the views and opinions > > published here are solely based on the author's own opinion and > > should not be considered necessarily as reflecting the opinion of > > Intergraph. > > > > > > -----Original Message----- > > From: Anton V. Tarasov [mailto:anton.tarasov at oracle.com] > > Sent: Tuesday, June 30, 2015 8:01 PM > > To: Hruda, Steve; Kevin Rushforth > > Cc:openjfx-dev at openjdk.java.net > > Subject: Re: Patch for JDK-8090098 - [regression] Webview - > > getTimezoneOffset() of a ISO strings returns a wrong value > > > > Steve, > > > > I applied your suggestion and it worked on Windows. > > > > The missed check you discovered could really be a mistake in WebKit, > > because Apple dropped releasing (and shipping nightly builds for) > > Safari for Windows at 2012. > > Safari 5.1.7 was the last version. I downloaded and checked it. The > > date bug is not reproducible with it, but this gives us almost > > nothing taking into account the version is much outdated. > > > > So that Windows code path might not have been well tested, since > > http://trac.webkit.org/changeset/159892 was commited... > > > > (WebKit Win port is still supported and can be built on your own.) > > > > What I can do else to verify the changes is to run WebKit LayoutTests > > aimed at date testing and see if there're no regressions. > > > > Also, please put the info you posted into JIRA. > > > > Regards, > > Anton. > > > > On 29.06.2015 21:42, Anton Tarasov wrote: > > > > Hi Steve, > > > > Ok, I'll investigate it. > > > > Thanks, > > Anton. > > > > On 29.06.2015 18:39, Hruda, Steve wrote: > > > > Hi Anton & Kevin, > > > > we read your comments in the JDK bug system and analyzed WebKit's > > changesets again. > > > > We?ve found the code which made this regression. > > > > http://trac.webkit.org/changeset/159892 > > > > This changeset doesn't handle one special case, which was handled > > by the previous code.... > > > > double diff = ((localSystemTime.wHour - offsetHour) * > > secondsPerHour) > > + ((localSystemTime.wMinute > > - offsetMinute) *60); > > > > > > (http://trac.webkit.org/browser/trunk/Source/WTF/wtf/DateMath.cpp?a > > nn > > otate=blame#L481 ) > > > > The diff is wrong if the calculated the offsetTime is one day > > before in case of the extreme values (e.g. midnight) where the > > offsetHour of the UTC time is 23 because of the day difference. > > > > In case of all other OS systems you will see the same code -> > > http://trac.webkit.org/browser/trunk/Source/WTF/wtf/DateMath.cpp?an > > no > > tate=blame#L495 > > > > But there are two additional lines -> 497 & 497 which fixes this > > special case? > > > > *if*(diff<0) > > > > diff += secondsPerDay; > > > > > > That means ?. > > > > localSystemTime.wHour = 0; > > > > offsetHour=23 ? which causes a negative value ? and the > > diff+=secondsPerDay ensures that the diff result would be one Hour > > instead of -23 hours > > > > We?ve found the attached V8DateTests.js (renamed to .txt) and > > adjusted it a little bit to get the results logged in the browsers > > console. > > > > As you can see at ?ResulBeforeOurBugFix.txt? and > > ?ResultAfterOurBugFix.txt?, we were able to fix > > 6 tests which failed before out bug fix. > > > > assertEquals("Sat Oct 25 2014 23:00:00 GMT+0200 (W. Europe Daylight > > Time)", > > > > (new Date(2014, 9, 25, 23, 0)).toString()); > > > > assertEquals("Sat, 25 Oct 2014 21:00:00 GMT", > > > > (new Date(2014, 9, 25, 23, 0)).toUTCString()); > > > > assertEquals("Sat Oct 25 2014 23:59:00 GMT+0200 (W. Europe > > Daylight Time)", > > > > (new Date(2014, 9, 25, 23, 59)).toString()); > > > > assertEquals("Sat, 25 Oct 2014 21:59:00 GMT", > > > > (new Date(2014, 9, 25, 23, 59)).toUTCString()); > > > > assertEquals("Sun Oct 26 2014 00:00:00 GMT+0200 (W. Europe > > Daylight Time)", > > > > (new Date(2014, 9, 26, 0, 0)).toString()); > > > > assertEquals("Sun Oct 26 2014 00:59:00 GMT+0200 (W. Europe Daylight > > Time)", > > > > (new Date(2014, 9, 26, 0, 59)).toString()); > > > > In addition we found out that WebKit also have problems in case of > > Windows in case of the change from winter to summer time. > > > > *_Winter to summer time:_* > > > > assertEquals("Sun Mar 30 2014 03:00:00 GMT+0200 (W. Europe Daylight > > Time)", > > > > (new Date(2014, 2, 30, 2, 0)).toString()); > > > > assertEquals("Sun, 30 Mar 2014 01:00:00 GMT", > > > > (new Date(2014, 2, 30, 2, 0)).toUTCString()); > > > > assertEquals("Sun Mar 30 2014 03:59:00 GMT+0200 (W. Europe > > Daylight Time)", > > > > (new Date(2014, 2, 30, 2, 59)).toString()); > > > > assertEquals("Sun, 30 Mar 2014 01:59:00 GMT", > > > > (new Date(2014, 2, 30, 2, 59)).toUTCString()); > > > > *_Summer to winter time:_* > > > > assertEquals("Sun Oct 26 2014 02:00:00 GMT+0200 (W. Europe Daylight > > Time)", > > > > (new Date(2014, 9, 26, 2, 0)).toString()); > > > > assertEquals("Sun, 26 Oct 2014 00:00:00 GMT", > > > > (new Date(2014, 9, 26, 2, 0)).toUTCString()); > > > > assertEquals("Sun Oct 26 2014 02:59:00 GMT+0200 (W. Europe > > Daylight Time)", > > > > (new Date(2014, 9, 26, 2, 59)).toString()); > > > > assertEquals("Sun, 26 Oct 2014 00:59:00 GMT", > > > > (new Date(2014, 9, 26, 2, 59)).toUTCString()); > > > > We will try to find a solution for that, but I think that the > > priority of this issue is lower than the priority of the opened > > regression. > > > > It would be amazing if you can add the patch of my previous and > > these additional two lines > > (DateMath.cpp) to the JDK8u60. > > > > Best Regards, > > > > Steve > > > > > > Diese E-Mail wurde versandt im Auftrag des Unternehmens Intergraph > > Ges.m.b.H. > > Vertretungsberechtigte Gesch?ftsf?hrer: Maximilian Weber Sitz der > > Gesellschaft: Margaretenstra?e 70/I/1, 1050 Wien, ?sterreich, Tel. > > +43 (1) 9610567-0 Eingetragen beim Handelsgericht Wien, > > Firmenbuch-Nr.: FN 116859 b Umsatzsteuer-Identifikationsnummer / > > VAT-ID: ATU15138401, Steuer-Nummer: 264/4807 > > > > This E-Mail has been sent on behalf of the company Intergraph > > Ges.m.b.H. > > Authorised Managing Directors: Maximilian Weber Registered office > > and Austrian headquarters: Margaretenstr. 70/I/1, 1050 Wien, > > Austria, Tel. +43 > > (1) 9610567-0 > > The company is recorded at the commercial court of Vienna under the > > company register number FN > > 116859 b > > VAT-ID: ATU15138401, Austrian Tax ID: 264/4807 > > > > Diese E-Mail (mit zugeh?rigen Dateien) enth?lt m?glicherweise > > Informationen, die vertraulich sind, dem Urheberrecht unterliegen > > oder ein Gesch?ftsgeheimnis darstellen. Falls Sie diese Nachricht > > irrt?mlicherweise erhalten haben, benachrichtigen Sie uns bitte > > umgehend, indem Sie eine Antwort senden, und l?schen Sie bitte > > diese E-Mail und Ihre Antwort darauf. S?mtliche aufgef?hrten > > Ansichten oder Meinungen sind ausschlie?lich diejenigen des Autors > > und entsprechen nicht notwendigerweise denen des Unternehmens Intergraph. > > > > This E-Mail (and any attachments) may be confidential and protected > > by legal privilege. If you are not the intended recipient please > > notify us immediately by replying to the sender and delete this > > E-Mail and your reply from your system. All the views and opinions > > published here are solely based on the author's own opinion and > > should not be considered necessarily as reflecting the opinion of > > Intergraph. > > > > -----Original Message----- > > > > From: openjfx-dev [mailto:openjfx-dev-bounces at openjdk.java.net] On > > Behalf Of Hruda, Steve > > > > Sent: Tuesday, June 23, 2015 6:26 PM > > > > To: Anton V. Tarasov; Kevin Rushforth > > > > Cc:openjfx-dev at openjdk.java.net > > > > Subject: RE: Patch for JDK-8090098 - [regression] Webview - > > getTimezoneOffset() of a ISO strings returns a wrong value > > > > Very cool Anton. > > > > I would be great if that pach could be added to 8u60, otherwise our > > all our customers have to avoid Java 8u60. > > > > Regards, > > > > Steve > > > > Diese E-Mail wurde versandt im Auftrag des Unternehmens Intergraph > > Ges.m.b.H. > > > > Vertretungsberechtigte Gesch?ftsf?hrer: Maximilian Weber Sitz der > > Gesellschaft: Margaretenstra?e 70/I/1, 1050 Wien, ?sterreich, Tel. > > +43 (1) 9610567-0 Eingetragen beim Handelsgericht Wien, > > Firmenbuch-Nr.: FN 116859 b Umsatzsteuer-Identifikationsnummer / > > VAT-ID: ATU15138401, > > Steuer-Nummer: 264/4807 > > > > This E-Mail has been sent on behalf of the company Intergraph > > Ges.m.b.H. > > > > Authorised Managing Directors: Maximilian Weber Registered office > > and Austrian headquarters: > > Margaretenstr. 70/I/1, 1050 Wien, Austria, Tel. +43 (1) 9610567-0 > > The company is recorded at the commercial court of Vienna under the > > company register number FN 116859 b > > > > VAT-ID: ATU15138401, Austrian Tax ID: 264/4807 > > > > Diese E-Mail (mit zugeh?rigen Dateien) enth?lt m?glicherweise > > Informationen, die vertraulich sind, dem Urheberrecht unterliegen > > oder ein Gesch?ftsgeheimnis darstellen. Falls Sie diese Nachricht > > irrt?mlicherweise erhalten haben, benachrichtigen Sie uns bitte > > umgehend, indem Sie eine Antwort senden, und l?schen Sie bitte > > diese E-Mail und Ihre Antwort darauf. S?mtliche aufgef?hrten > > Ansichten oder Meinungen sind ausschlie?lich diejenigen des Autors > > und entsprechen nicht notwendigerweise denen des Unternehmens Intergraph. > > > > This E-Mail (and any attachments) may be confidential and protected > > by legal privilege. If you are not the intended recipient please > > notify us immediately by replying to the sender and delete this > > E-Mail and your reply from your system. All the views and opinions > > published here are solely based on the author's own opinion and > > should not be considered necessarily as reflecting the opinion of > > Intergraph. > > > > -----Original Message----- > > > > From: Anton V. Tarasov [mailto:anton.tarasov at oracle.com] > > > > Sent: Tuesday, June 23, 2015 5:46 PM > > > > To: Kevin Rushforth; Hruda, Steve > > > > Cc:openjfx-dev at openjdk.java.net > > > > Subject: Re: Patch for JDK-8090098 - [regression] Webview - > > getTimezoneOffset() of a ISO strings returns a wrong value > > > > On 23.06.2015 17:48, Kevin Rushforth wrote: > > > > > > Hi Steve, > > Thank you for taking the time to create this patch. I will add > > this information to the bug report. > > Since your OCA is in progress we will take a look at your patch, > > but will need indication from the OCA office that it the OCA has > > been received before we could push it. And just to be clear, you > > won't have access to the repository even with an OCA. What the OCA > > will do is allow you to contribute > > > > patches. > > > > > > I will note that it is likely too late for 8u60, but Anton can > > evaluate it and post his comment in the bug report. > > > > Kevin, > > > > I'm checking it. > > > > Steve, thanks for the participation! > > > > Regards, > > > > Anton. > > > > > > -- Kevin > > Hruda, Steve wrote: > > > > Hi, > > I've created a 8u-dev patch for the following WeKit regression > > which comes with 8u60. > > https://bugs.openjdk.java.net/b > > rowse/JDK-8090098 > > Please can someone of you apply this patch to fix the > > getTimezoneOffset() issue. I have no access to the repository -> > > my OCA is still pending. > > In addition I tried to test this patch , but I wasn't able to > > build the necessary jfxwebkit.dll on my windows system > > (https://www.mail-archive.com/openjfx-dev at openjdk.java.net/msg094 > > 3 > > 9.h > > tml )..... but I got no compile erros on Mac. > > Patch download: > > https://drive.google.com/file/d/0B7P_rknS1TWxM3BSTTU2OVZ4dGM/view > > ?u > > sp > > =sharing > > The patch includes the following WebKit fixes: > > Changeset 174377 - [Win] DateMath's calculateUTFOffset does not > > account for DST. > > http://trac.webkit.org/changeset/174377 > > Changeset 175078 - String(new Date(Mar 30 2014 01:00:00)) is > > wrong in CET > > http://trac.webkit.org/changeset/175078 > > Changeset 181360 - [Win] 17 different JSC tests started to fail > > in DST > > http://trac.webkit.org/changeset/181360 > > Please let me know if you need further information. > > Thanks in advance! > > Best Regards > > Steve > > Diese E-Mail wurde versandt im Auftrag des Unternehmens > > Intergraph Ges.m.b.H. > > Vertretungsberechtigte Gesch?ftsf?hrer: Maximilian Weber Sitz der > > Gesellschaft: Margaretenstra?e 70/I/1, 1050 Wien, ?sterreich, Tel. > > +43 (1) 9610567-0 Eingetragen beim Handelsgericht Wien, > > Firmenbuch-Nr.: FN 116859 b Umsatzsteuer-Identifikationsnummer / > > VAT-ID: ATU15138401, Steuer-Nummer: 264/4807 This E-Mail has been > > sent on behalf of the company Intergraph Ges.m.b.H. > > Authorised Managing Directors: Maximilian Weber Registered office > > and Austrian headquarters: Margaretenstr. 70/I/1, 1050 Wien, > > Austria, Tel. +43 > > (1) 9610567-0 > > The company is recorded at the commercial court of Vienna under > > the company register number FN > > 116859 b > > VAT-ID: ATU15138401, Austrian Tax ID: 264/4807 Diese E-Mail (mit > > zugeh?rigen Dateien) enth?lt m?glicherweise Informationen, die > > vertraulich sind, dem Urheberrecht unterliegen oder ein > > Gesch?ftsgeheimnis darstellen. Falls Sie diese Nachricht > > irrt?mlicherweise erhalten haben, benachrichtigen Sie uns bitte > > umgehend, indem Sie eine Antwort senden, und l?schen Sie bitte > > diese E-Mail und Ihre Antwort darauf. S?mtliche aufgef?hrten > > Ansichten oder Meinungen sind > > > > ausschlie?lich diejenigen des Autors und entsprechen nicht > > notwendigerweise denen des Unternehmens Intergraph. > > > > > > This E-Mail (and any attachments) may be confidential and > > protected by legal privilege. If you are not the intended > > recipient please notify us immediately by replying to the sender > > and delete this E-Mail and your reply from your system. All the > > views and opinions published here are solely based on the > > author's own opinion and should not be considered > > > > necessarily as reflecting the opinion of Intergraph. > > > > > > > > > From steve.hruda at hexagongeospatial.com Thu Jul 2 14:45:41 2015 From: steve.hruda at hexagongeospatial.com (Hruda, Steve) Date: Thu, 2 Jul 2015 14:45:41 +0000 Subject: Patch for JDK-8090098 - [regression] Webview - getTimezoneOffset() of a ISO strings returns a wrong value In-Reply-To: <55954E40.5090204@oracle.com> References: <559191AA.8030800@oracle.com> <5592D943.3090407@oracle.com> <5592E269.6050200@oracle.com> <5592FFDB.5090501@oracle.com> <55930730.6050302@oracle.com> <5595337D.6000609@oracle.com> <55953BF1.60204@oracle.com> <55954E40.5090204@oracle.com> Message-ID: Very cool! Thanks for your efforts! From: Anton V. Tarasov [mailto:anton.tarasov at oracle.com] Sent: Thursday, July 2, 2015 4:44 PM To: Hruda, Steve Cc: Kevin Rushforth; openjfx-dev at openjdk.java.net Subject: Re: Patch for JDK-8090098 - [regression] Webview - getTimezoneOffset() of a ISO strings returns a wrong value The test passes with this only change. And the original bug is not reproducible. Ok, I'll need to test it with other date LayoutTests again. Will update in JIRA. Regards, Anton. On 02.07.2015 15:31, Hruda, Steve wrote: Yes! ;-) From: Anton V. Tarasov [mailto:anton.tarasov at oracle.com] Sent: Thursday, July 2, 2015 3:26 PM To: Hruda, Steve Cc: Kevin Rushforth; openjfx-dev at openjdk.java.net Subject: Re: Patch for JDK-8090098 - [regression] Webview - getTimezoneOffset() of a ISO strings returns a wrong value Ok, got it. You suggest trying the only 2-line change? Anton. On 02.07.2015 15:54, Hruda, Steve wrote: HI Anton, The diff fix must be there. if (diff<0) diff += secondsPerDay; ? but the following fixes are unnecessary, for the midnight bug. I think one of these fixes could be the problem. http://cr.openjdk.java.net/~ant/JDK-8090098/webrev.0/ which contains the following fixed issues: http://trac.webkit.org/changeset/174377 http://trac.webkit.org/changeset/175078 http://trac.webkit.org/changeset/181360 Regards, Steve From: Anton V. Tarasov [mailto:anton.tarasov at oracle.com] Sent: Thursday, July 2, 2015 2:50 PM To: Hruda, Steve Cc: Kevin Rushforth; openjfx-dev at openjdk.java.net Subject: Re: Patch for JDK-8090098 - [regression] Webview - getTimezoneOffset() of a ISO strings returns a wrong value Hi Steve, Actually, I already checked that removing if (diff<0) diff += secondsPerDay; didn't help. Regards, Anton. On 02.07.2015 13:09, Hruda, Steve wrote: Hi Anton, I saw your comments on https://bugs.openjdk.java.net/browse/JDK-8090098. We?ve opened the test page which you have mentioned in our own compiled WebKit version -> clean build & latest version. Used Timezone: Vienna CEST ? current Offset UTC+2:00 Without our Fix: Only the first and latest test pass. With our Fix: The same ? only the first and latest test pass. It seems that one changeset regress this behavior, but not the our latest ?if ?fix? if (diff<0) diff += secondsPerDay; I?m not able to build openjfx because of the missing dependencies (1.3). Please can you try what happens if you only apply the diff fix and not the previous patch, which includes all other date fixes. From my point of view are these fixes (which were provided by the patch file) not necessary to solve our datepicker problem. Thanks in advance, Steve From: Kevin Rushforth [mailto:kevin.rushforth at oracle.com] Sent: Tuesday, June 30, 2015 11:17 PM To: Hruda, Steve Cc: Anton V. Tarasov; openjfx-dev at openjdk.java.net Subject: Re: Patch for JDK-8090098 - [regression] Webview - getTimezoneOffset() of a ISO strings returns a wrong value Not by itself, although regressions are certainly taken very seriously. In any case, the process is to get this into 9-dev (once it has been reviewed), test it thoroughly, and then consider whether we can make a case for taking it to the 8u60 release team. -- Kevin Hruda, Steve wrote: Is a regression not release critical? Diese E-Mail wurde versandt im Auftrag des Unternehmens Intergraph Ges.m.b.H. Vertretungsberechtigte Gesch?ftsf?hrer: Maximilian Weber Sitz der Gesellschaft: Margaretenstra?e 70/I/1, 1050 Wien, ?sterreich, Tel. +43 (1) 9610567-0 Eingetragen beim Handelsgericht Wien, Firmenbuch-Nr.: FN 116859 b Umsatzsteuer-Identifikationsnummer / VAT-ID: ATU15138401, Steuer-Nummer: 264/4807 This E-Mail has been sent on behalf of the company Intergraph Ges.m.b.H. Authorised Managing Directors: Maximilian Weber Registered office and Austrian headquarters: Margaretenstr. 70/I/1, 1050 Wien, Austria, Tel. +43 (1) 9610567-0 The company is recorded at the commercial court of Vienna under the company register number FN 116859 b VAT-ID: ATU15138401, Austrian Tax ID: 264/4807 Diese E-Mail (mit zugeh?rigen Dateien) enth?lt m?glicherweise Informationen, die vertraulich sind, dem Urheberrecht unterliegen oder ein Gesch?ftsgeheimnis darstellen. Falls Sie diese Nachricht irrt?mlicherweise erhalten haben, benachrichtigen Sie uns bitte umgehend, indem Sie eine Antwort senden, und l?schen Sie bitte diese E-Mail und Ihre Antwort darauf. S?mtliche aufgef?hrten Ansichten oder Meinungen sind ausschlie?lich diejenigen des Autors und entsprechen nicht notwendigerweise denen des Unternehmens Intergraph. This E-Mail (and any attachments) may be confidential and protected by legal privilege. If you are not the intended recipient please notify us immediately by replying to the sender and delete this E-Mail and your reply from your system. All the views and opinions published here are solely based on the author's own opinion and should not be considered necessarily as reflecting the opinion of Intergraph. Diese E-Mail wurde versandt im Auftrag des Unternehmens Intergraph Ges.m.b.H. Vertretungsberechtigte Gesch?ftsf?hrer: Maximilian Weber Sitz der Gesellschaft: Margaretenstra?e 70/I/1, 1050 Wien, ?sterreich, Tel. +43 (1) 9610567-0 Eingetragen beim Handelsgericht Wien, Firmenbuch-Nr.: FN 116859 b Umsatzsteuer-Identifikationsnummer / VAT-ID: ATU15138401, Steuer-Nummer: 264/4807 This E-Mail has been sent on behalf of the company Intergraph Ges.m.b.H. Authorised Managing Directors: Maximilian Weber Registered office and Austrian headquarters: Margaretenstr. 70/I/1, 1050 Wien, Austria, Tel. +43 (1) 9610567-0 The company is recorded at the commercial court of Vienna under the company register number FN 116859 b VAT-ID: ATU15138401, Austrian Tax ID: 264/4807 Diese E-Mail (mit zugeh?rigen Dateien) enth?lt m?glicherweise Informationen, die vertraulich sind, dem Urheberrecht unterliegen oder ein Gesch?ftsgeheimnis darstellen. Falls Sie diese Nachricht irrt?mlicherweise erhalten haben, benachrichtigen Sie uns bitte umgehend, indem Sie eine Antwort senden, und l?schen Sie bitte diese E-Mail und Ihre Antwort darauf. S?mtliche aufgef?hrten Ansichten oder Meinungen sind ausschlie?lich diejenigen des Autors und entsprechen nicht notwendigerweise denen des Unternehmens Intergraph. This E-Mail (and any attachments) may be confidential and protected by legal privilege. If you are not the intended recipient please notify us immediately by replying to the sender and delete this E-Mail and your reply from your system. All the views and opinions published here are solely based on the author's own opinion and should not be considered necessarily as reflecting the opinion of Intergraph. Diese E-Mail wurde versandt im Auftrag des Unternehmens Intergraph Ges.m.b.H. Vertretungsberechtigte Gesch?ftsf?hrer: Maximilian Weber Sitz der Gesellschaft: Margaretenstra?e 70/I/1, 1050 Wien, ?sterreich, Tel. +43 (1) 9610567-0 Eingetragen beim Handelsgericht Wien, Firmenbuch-Nr.: FN 116859 b Umsatzsteuer-Identifikationsnummer / VAT-ID: ATU15138401, Steuer-Nummer: 264/4807 This E-Mail has been sent on behalf of the company Intergraph Ges.m.b.H. Authorised Managing Directors: Maximilian Weber Registered office and Austrian headquarters: Margaretenstr. 70/I/1, 1050 Wien, Austria, Tel. +43 (1) 9610567-0 The company is recorded at the commercial court of Vienna under the company register number FN 116859 b VAT-ID: ATU15138401, Austrian Tax ID: 264/4807 Diese E-Mail (mit zugeh?rigen Dateien) enth?lt m?glicherweise Informationen, die vertraulich sind, dem Urheberrecht unterliegen oder ein Gesch?ftsgeheimnis darstellen. Falls Sie diese Nachricht irrt?mlicherweise erhalten haben, benachrichtigen Sie uns bitte umgehend, indem Sie eine Antwort senden, und l?schen Sie bitte diese E-Mail und Ihre Antwort darauf. S?mtliche aufgef?hrten Ansichten oder Meinungen sind ausschlie?lich diejenigen des Autors und entsprechen nicht notwendigerweise denen des Unternehmens Intergraph. This E-Mail (and any attachments) may be confidential and protected by legal privilege. If you are not the intended recipient please notify us immediately by replying to the sender and delete this E-Mail and your reply from your system. All the views and opinions published here are solely based on the author's own opinion and should not be considered necessarily as reflecting the opinion of Intergraph. Diese E-Mail wurde versandt im Auftrag des Unternehmens Intergraph Ges.m.b.H. Vertretungsberechtigte Gesch?ftsf?hrer: Maximilian Weber Sitz der Gesellschaft: Margaretenstra?e 70/I/1, 1050 Wien, ?sterreich, Tel. +43 (1) 9610567-0 Eingetragen beim Handelsgericht Wien, Firmenbuch-Nr.: FN 116859 b Umsatzsteuer-Identifikationsnummer / VAT-ID: ATU15138401, Steuer-Nummer: 264/4807 This E-Mail has been sent on behalf of the company Intergraph Ges.m.b.H. Authorised Managing Directors: Maximilian Weber Registered office and Austrian headquarters: Margaretenstr. 70/I/1, 1050 Wien, Austria, Tel. +43 (1) 9610567-0 The company is recorded at the commercial court of Vienna under the company register number FN 116859 b VAT-ID: ATU15138401, Austrian Tax ID: 264/4807 Diese E-Mail (mit zugeh?rigen Dateien) enth?lt m?glicherweise Informationen, die vertraulich sind, dem Urheberrecht unterliegen oder ein Gesch?ftsgeheimnis darstellen. Falls Sie diese Nachricht irrt?mlicherweise erhalten haben, benachrichtigen Sie uns bitte umgehend, indem Sie eine Antwort senden, und l?schen Sie bitte diese E-Mail und Ihre Antwort darauf. S?mtliche aufgef?hrten Ansichten oder Meinungen sind ausschlie?lich diejenigen des Autors und entsprechen nicht notwendigerweise denen des Unternehmens Intergraph. This E-Mail (and any attachments) may be confidential and protected by legal privilege. If you are not the intended recipient please notify us immediately by replying to the sender and delete this E-Mail and your reply from your system. All the views and opinions published here are solely based on the author's own opinion and should not be considered necessarily as reflecting the opinion of Intergraph. Diese E-Mail wurde versandt im Auftrag des Unternehmens Intergraph Ges.m.b.H. Vertretungsberechtigte Gesch?ftsf?hrer: Maximilian Weber Sitz der Gesellschaft: Margaretenstra?e 70/I/1, 1050 Wien, ?sterreich, Tel. +43 (1) 9610567-0 Eingetragen beim Handelsgericht Wien, Firmenbuch-Nr.: FN 116859 b Umsatzsteuer-Identifikationsnummer / VAT-ID: ATU15138401, Steuer-Nummer: 264/4807 This E-Mail has been sent on behalf of the company Intergraph Ges.m.b.H. Authorised Managing Directors: Maximilian Weber Registered office and Austrian headquarters: Margaretenstr. 70/I/1, 1050 Wien, Austria, Tel. +43 (1) 9610567-0 The company is recorded at the commercial court of Vienna under the company register number FN 116859 b VAT-ID: ATU15138401, Austrian Tax ID: 264/4807 Diese E-Mail (mit zugeh?rigen Dateien) enth?lt m?glicherweise Informationen, die vertraulich sind, dem Urheberrecht unterliegen oder ein Gesch?ftsgeheimnis darstellen. Falls Sie diese Nachricht irrt?mlicherweise erhalten haben, benachrichtigen Sie uns bitte umgehend, indem Sie eine Antwort senden, und l?schen Sie bitte diese E-Mail und Ihre Antwort darauf. S?mtliche aufgef?hrten Ansichten oder Meinungen sind ausschlie?lich diejenigen des Autors und entsprechen nicht notwendigerweise denen des Unternehmens Intergraph. This E-Mail (and any attachments) may be confidential and protected by legal privilege. If you are not the intended recipient please notify us immediately by replying to the sender and delete this E-Mail and your reply from your system. All the views and opinions published here are solely based on the author's own opinion and should not be considered necessarily as reflecting the opinion of Intergraph. -----Original Message----- From: Kevin Rushforth [mailto:kevin.rushforth at oracle.com] Sent: Tuesday, June 30, 2015 10:45 PM To: Anton V. Tarasov Cc: Hruda, Steve; openjfx-dev at openjdk.java.net Subject: Re: Patch for JDK-8090098 - [regression] Webview - getTimezoneOffset() of a ISO strings returns a wrong value Anton V. Tarasov wrote: On 30.06.2015 21:13, Hruda, Steve wrote: Hi Anton, thanks for the detailed information and the good news. You talk about JDK's jira? Am I right? ..... I don't have an access for that JIRA system since the JavaFX's Jira has moved to the JDK Bug System. Ah, ok. Then I'll quote your e-mail. About the Apple stuff. I know that Apple dropped Windows Safari support and in my opinion is this a very bad situation for WebKit (in case of Windows).... and especially since Google and Opera using Google's Blink engine. In case of the JDK it would be more practicable to switch from WebKit to Blink, because this engine is still used by Companies which have Windows end-users. There is a high probability that WebKit get more such bugs if there is no big player like Google or Apple who has the man power to fix such OS dependent issues. I see. However, switching to Blink is another story. Honestly, we're not planning it in the nearest future. This requires extra resources which we don't have at the moment... Last questions: Do you need any additional information from my side? And is it possible to integrate this fix in 8u60? From my side, I'll do a sanity check with WebKit LayoutTests, then if it goes well, we can consider commiting this to 8u60. @Kevin, do you think we can? Very unlikely. The JDK release team would need to approve, and only release-critical issues may be considered at this point (it would be hard to argue that this is release-critical since it has already been deferred). -- Kevin Also, as an option for you (Steve). You can post the changes to the WebKit alias and ask if they think this is a valid fix for the issue. Any confirmation from the WebKit team would help us to make sure the fix is reliable. Thanks! Anton. Thanks in advance! Best Regards, Steve Diese E-Mail wurde versandt im Auftrag des Unternehmens Intergraph Ges.m.b.H. Vertretungsberechtigte Gesch?ftsf?hrer: Maximilian Weber Sitz der Gesellschaft: Margaretenstra?e 70/I/1, 1050 Wien, ?sterreich, Tel. +43 (1) 9610567-0 Eingetragen beim Handelsgericht Wien, Firmenbuch-Nr.: FN 116859 b Umsatzsteuer-Identifikationsnummer / VAT-ID: ATU15138401, Steuer-Nummer: 264/4807 This E-Mail has been sent on behalf of the company Intergraph Ges.m.b.H. Authorised Managing Directors: Maximilian Weber Registered office and Austrian headquarters: Margaretenstr. 70/I/1, 1050 Wien, Austria, Tel. +43 (1) 9610567-0 The company is recorded at the commercial court of Vienna under the company register number FN 116859 b VAT-ID: ATU15138401, Austrian Tax ID: 264/4807 Diese E-Mail (mit zugeh?rigen Dateien) enth?lt m?glicherweise Informationen, die vertraulich sind, dem Urheberrecht unterliegen oder ein Gesch?ftsgeheimnis darstellen. Falls Sie diese Nachricht irrt?mlicherweise erhalten haben, benachrichtigen Sie uns bitte umgehend, indem Sie eine Antwort senden, und l?schen Sie bitte diese E-Mail und Ihre Antwort darauf. S?mtliche aufgef?hrten Ansichten oder Meinungen sind ausschlie?lich diejenigen des Autors und entsprechen nicht notwendigerweise denen des Unternehmens Intergraph. This E-Mail (and any attachments) may be confidential and protected by legal privilege. If you are not the intended recipient please notify us immediately by replying to the sender and delete this E-Mail and your reply from your system. All the views and opinions published here are solely based on the author's own opinion and should not be considered necessarily as reflecting the opinion of Intergraph. -----Original Message----- From: Anton V. Tarasov [mailto:anton.tarasov at oracle.com] Sent: Tuesday, June 30, 2015 8:01 PM To: Hruda, Steve; Kevin Rushforth Cc: openjfx-dev at openjdk.java.net Subject: Re: Patch for JDK-8090098 - [regression] Webview - getTimezoneOffset() of a ISO strings returns a wrong value Steve, I applied your suggestion and it worked on Windows. The missed check you discovered could really be a mistake in WebKit, because Apple dropped releasing (and shipping nightly builds for) Safari for Windows at 2012. Safari 5.1.7 was the last version. I downloaded and checked it. The date bug is not reproducible with it, but this gives us almost nothing taking into account the version is much outdated. So that Windows code path might not have been well tested, since http://trac.webkit.org/changeset/159892 was commited... (WebKit Win port is still supported and can be built on your own.) What I can do else to verify the changes is to run WebKit LayoutTests aimed at date testing and see if there're no regressions. Also, please put the info you posted into JIRA. Regards, Anton. On 29.06.2015 21:42, Anton Tarasov wrote: Hi Steve, Ok, I'll investigate it. Thanks, Anton. On 29.06.2015 18:39, Hruda, Steve wrote: Hi Anton & Kevin, we read your comments in the JDK bug system and analyzed WebKit's changesets again. We?ve found the code which made this regression. http://trac.webkit.org/changeset/159892 This changeset doesn't handle one special case, which was handled by the previous code.... double diff = ((localSystemTime.wHour - offsetHour) * secondsPerHour) + ((localSystemTime.wMinute - offsetMinute) *60); (http://trac.webkit.org/browser/trunk/Source/WTF/wtf/DateMath.cpp?a nn otate=blame#L481 ) The diff is wrong if the calculated the offsetTime is one day before in case of the extreme values (e.g. midnight) where the offsetHour of the UTC time is 23 because of the day difference. In case of all other OS systems you will see the same code -> http://trac.webkit.org/browser/trunk/Source/WTF/wtf/DateMath.cpp?an no tate=blame#L495 But there are two additional lines -> 497 & 497 which fixes this special case? *if*(diff<0) diff += secondsPerDay; That means ?. localSystemTime.wHour = 0; offsetHour=23 ? which causes a negative value ? and the diff+=secondsPerDay ensures that the diff result would be one Hour instead of -23 hours We?ve found the attached V8DateTests.js (renamed to .txt) and adjusted it a little bit to get the results logged in the browsers console. As you can see at ?ResulBeforeOurBugFix.txt? and ?ResultAfterOurBugFix.txt?, we were able to fix 6 tests which failed before out bug fix. assertEquals("Sat Oct 25 2014 23:00:00 GMT+0200 (W. Europe Daylight Time)", (new Date(2014, 9, 25, 23, 0)).toString()); assertEquals("Sat, 25 Oct 2014 21:00:00 GMT", (new Date(2014, 9, 25, 23, 0)).toUTCString()); assertEquals("Sat Oct 25 2014 23:59:00 GMT+0200 (W. Europe Daylight Time)", (new Date(2014, 9, 25, 23, 59)).toString()); assertEquals("Sat, 25 Oct 2014 21:59:00 GMT", (new Date(2014, 9, 25, 23, 59)).toUTCString()); assertEquals("Sun Oct 26 2014 00:00:00 GMT+0200 (W. Europe Daylight Time)", (new Date(2014, 9, 26, 0, 0)).toString()); assertEquals("Sun Oct 26 2014 00:59:00 GMT+0200 (W. Europe Daylight Time)", (new Date(2014, 9, 26, 0, 59)).toString()); In addition we found out that WebKit also have problems in case of Windows in case of the change from winter to summer time. *_Winter to summer time:_* assertEquals("Sun Mar 30 2014 03:00:00 GMT+0200 (W. Europe Daylight Time)", (new Date(2014, 2, 30, 2, 0)).toString()); assertEquals("Sun, 30 Mar 2014 01:00:00 GMT", (new Date(2014, 2, 30, 2, 0)).toUTCString()); assertEquals("Sun Mar 30 2014 03:59:00 GMT+0200 (W. Europe Daylight Time)", (new Date(2014, 2, 30, 2, 59)).toString()); assertEquals("Sun, 30 Mar 2014 01:59:00 GMT", (new Date(2014, 2, 30, 2, 59)).toUTCString()); *_Summer to winter time:_* assertEquals("Sun Oct 26 2014 02:00:00 GMT+0200 (W. Europe Daylight Time)", (new Date(2014, 9, 26, 2, 0)).toString()); assertEquals("Sun, 26 Oct 2014 00:00:00 GMT", (new Date(2014, 9, 26, 2, 0)).toUTCString()); assertEquals("Sun Oct 26 2014 02:59:00 GMT+0200 (W. Europe Daylight Time)", (new Date(2014, 9, 26, 2, 59)).toString()); assertEquals("Sun, 26 Oct 2014 00:59:00 GMT", (new Date(2014, 9, 26, 2, 59)).toUTCString()); We will try to find a solution for that, but I think that the priority of this issue is lower than the priority of the opened regression. It would be amazing if you can add the patch of my previous and these additional two lines (DateMath.cpp) to the JDK8u60. Best Regards, Steve Diese E-Mail wurde versandt im Auftrag des Unternehmens Intergraph Ges.m.b.H. Vertretungsberechtigte Gesch?ftsf?hrer: Maximilian Weber Sitz der Gesellschaft: Margaretenstra?e 70/I/1, 1050 Wien, ?sterreich, Tel. +43 (1) 9610567-0 Eingetragen beim Handelsgericht Wien, Firmenbuch-Nr.: FN 116859 b Umsatzsteuer-Identifikationsnummer / VAT-ID: ATU15138401, Steuer-Nummer: 264/4807 This E-Mail has been sent on behalf of the company Intergraph Ges.m.b.H. Authorised Managing Directors: Maximilian Weber Registered office and Austrian headquarters: Margaretenstr. 70/I/1, 1050 Wien, Austria, Tel. +43 (1) 9610567-0 The company is recorded at the commercial court of Vienna under the company register number FN 116859 b VAT-ID: ATU15138401, Austrian Tax ID: 264/4807 Diese E-Mail (mit zugeh?rigen Dateien) enth?lt m?glicherweise Informationen, die vertraulich sind, dem Urheberrecht unterliegen oder ein Gesch?ftsgeheimnis darstellen. Falls Sie diese Nachricht irrt?mlicherweise erhalten haben, benachrichtigen Sie uns bitte umgehend, indem Sie eine Antwort senden, und l?schen Sie bitte diese E-Mail und Ihre Antwort darauf. S?mtliche aufgef?hrten Ansichten oder Meinungen sind ausschlie?lich diejenigen des Autors und entsprechen nicht notwendigerweise denen des Unternehmens Intergraph. This E-Mail (and any attachments) may be confidential and protected by legal privilege. If you are not the intended recipient please notify us immediately by replying to the sender and delete this E-Mail and your reply from your system. All the views and opinions published here are solely based on the author's own opinion and should not be considered necessarily as reflecting the opinion of Intergraph. -----Original Message----- From: openjfx-dev [mailto:openjfx-dev-bounces at openjdk.java.net] On Behalf Of Hruda, Steve Sent: Tuesday, June 23, 2015 6:26 PM To: Anton V. Tarasov; Kevin Rushforth Cc: openjfx-dev at openjdk.java.net Subject: RE: Patch for JDK-8090098 - [regression] Webview - getTimezoneOffset() of a ISO strings returns a wrong value Very cool Anton. I would be great if that pach could be added to 8u60, otherwise our all our customers have to avoid Java 8u60. Regards, Steve Diese E-Mail wurde versandt im Auftrag des Unternehmens Intergraph Ges.m.b.H. Vertretungsberechtigte Gesch?ftsf?hrer: Maximilian Weber Sitz der Gesellschaft: Margaretenstra?e 70/I/1, 1050 Wien, ?sterreich, Tel. +43 (1) 9610567-0 Eingetragen beim Handelsgericht Wien, Firmenbuch-Nr.: FN 116859 b Umsatzsteuer-Ident ifikationsnummer / VAT-ID: ATU15138401, Steuer-Nummer: 264/4807 This E-Mail has been sent on behalf of the company Intergraph Ges.m.b.H. Authorised Managing Directors: Maximilian Weber Registered office and Austrian headquarters: Margaretenstr. 70/I/1, 1050 Wien, Austria, Tel. +43 (1) 9610567-0 The company is recorded at the commercial court of Vienna under the company register number FN 116859 b VAT-ID: ATU15138401, Austrian Tax ID: 264/4807 Diese E-Mail (mit zugeh?rigen Dateien) enth?lt m?glicherweise Informationen, die vertraulich sind, dem Urheberrecht unterliegen oder ein Gesch?ftsgeheimnis darstellen. Falls Sie diese Nachricht irrt?mlicherweise erhalten haben, benachrichtigen Sie uns bitte umgehend, indem Sie eine Antwort senden, und l?schen Sie bitte diese E-Mail und Ihre Antwort darauf. S?mtliche aufgef?hrten Ansichten oder Meinungen sind ausschlie?lich diejenigen des Autors und entsprechen nicht notwendigerweise denen des Unternehmens Intergraph. This E-Mail (and any attachments) may be confidential and protected by legal privilege. If you are not the intended recipient please notify us immediately by replying to the sender and delete this E-Mail and your reply from your system. All the views and opinions published here are solely based on the author's own opinion and should not be considered necessarily as reflecting the opinion of Intergraph. -----Original Message----- From: Anton V. Tarasov [mailto:anton.tarasov at oracle.com] Sent: Tuesday, June 23, 2015 5:46 PM To: Kevin Rushforth; Hruda, Steve Cc: openjfx-dev at openjdk.java.net Subject: Re: Patch for JDK-8090098 - [regression] Webview - getTimezoneOffset() of a ISO strings returns a wrong value On 23.06.2015 17:48, Kevin Rushforth wrote: Hi Steve, Thank you for taking the time to create this patch. I will add this information to the bug report. Since your OCA is in progress we will take a look at your patch, but will need indication from the OCA office that it the OCA has been received before we could push it. And just to be clear, you won't have access to the repository even with an OCA. What the OCA will do is allow you to contribute patches. I will note that it is likely too late for 8u60, but Anton can evaluate it and post his comment in the bug report. Kevin, I'm checking it. Steve, thanks for the participation! Regards, Anton. -- Kevin Hruda, Steve wrote: Hi, I've created a 8u-dev patch for the following WeKit regression which comes with 8u60. https://bugs.openjdk.java.net/b rowse/JDK-8090098 Please can someone of you apply this patch to fix the getTimezoneOffset() issue. I have no access to the repository -> my OCA is still pending. In addition I tried to test this patch , but I wasn't able to build the necessary jfxwebkit.dll on my windows system (https://www.mail-archive.com/openjfx-dev at openjdk.java.net/msg094 3 9.h tml )..... but I got no compile erros on Mac. Patch download: https://drive.google.com/file/d/0B7P_rknS1TWxM3BSTTU2OVZ4dGM/view ?u sp =sharing The patch includes the following WebKit fixes: Changeset 174377 - [Win] DateMath's calculateUTFOffset does not account for DST. http://trac.webkit.org/changeset/174377 Changeset 175078 - String(new Date(Mar 30 2014 01:00:00)) is wrong in CET http://trac.webkit.org/changeset/175078 Changeset 181360 - [Win] 17 different JSC tests started to fail in DST http://trac.webkit.org/changeset/181360 Please let me know if you need further information. Thanks in advance! Best Regards Steve Diese E-Mail wurde versandt im Auftrag des Unternehmens Intergraph Ges.m.b.H. Vertretungsberechtigte Gesch?ftsf?hrer: Maximilian Weber Sitz der Gesellschaft: Margaretenstra?e 70/I/1, 1050 Wien, ?sterreich, Tel. +43 (1) 9610567-0 Eingetragen beim Handelsgericht Wien, Firmenbuch-Nr.: FN 116859 b Umsatzsteuer-Identifikationsnummer / VAT-ID: ATU15138401, Steuer-Nummer: 264/4807 This E-Mail has been sent on behalf of the company Intergraph Ges.m.b.H. Authorised Managing Directors: Maximilian Weber Registered office and Austrian headquarters: Margaretenstr. 70/I/1, 1050 Wien, Austria, Tel. +43 (1) 9610567-0 The company is recorded at the commercial court of Vienna under the company register number FN 116859 b VAT-ID: ATU15138401, Austrian Tax ID: 264/4807 Diese E-Mail (mit zugeh?rigen Dateien) enth?lt m?glicherweise Informationen, die vertraulich sind, dem Urheberrecht unterliegen oder ein Gesch?ftsgeheimnis darstellen. Falls Sie diese Nachricht irrt?mlicherweise erhalten haben, benachrichtigen Sie uns bitte umgehend, indem Sie eine Antwort senden, und l?schen Sie bitte diese E-Mail und Ihre Antwort darauf. S?mtliche aufgef?hrten Ansichten oder Meinungen sind ausschlie?lich diejenigen des Autors und entsprechen nicht notwendigerweise denen des Unternehmens Intergraph. This E-Mail (and any attachments) may be confidential and protected by legal privilege. If you are not the intended recipient please notify us immediately by replying to the sender and delete this E-Mail and your reply from your system. All the views and opinions published here are solely based on the author's own opinion and should not be considered necessarily as reflecting the opinion of Intergraph. From vadim.pakhnushev at oracle.com Fri Jul 3 14:44:23 2015 From: vadim.pakhnushev at oracle.com (Vadim Pakhnushev) Date: Fri, 3 Jul 2015 17:44:23 +0300 Subject: In(Sanity) Testing Mondays Message-ID: <55969FC7.7020806@oracle.com> Reminder, Monday is our weekly sanity testing. You can find your testing assignment at: https://wiki.openjdk.java.net/display/OpenJFX/Sanity+Testing Also please remember that the repo will be locked from 1am PDT until 1pm PDT. Starting next week we would like to change the test target to 9-dev since there are no more fixes in the 8u60. Happy testing! Thanks, Vadim From danielhilst at gmail.com Fri Jul 3 15:50:54 2015 From: danielhilst at gmail.com (Daniel.) Date: Fri, 3 Jul 2015 12:50:54 -0300 Subject: Cross build JavaFX for iMX6 Message-ID: I trying to install JavaFX on a board running an iMX6q core. I follow the instructions to cross build the JavaFX of the openjdk wiki: https://wiki.openjdk.java.net/display/OpenJFX/Building+OpenJFX Looking at rt/buildSrc/crosslibs/crosslibs-armv6hf.sh I realised that I have two problems. 1) The script is targeted to Debian, while I'm using archlinux 2) The script uses linaro's toolchain, while I want to use Yocto's toolchain Galcore stack seems to be working: dmesg | grep Galcore Galcore version 5.0.11.25762 On my board I see this: root at varsomimx6:~# ls -l /lib/ld-linux-armhf.so.3 lrwxrwxrwx 1 root root 10 Jul 1 14:01 /lib/ld-linux-armhf.so.3 -> ld-2.19.so root at varsomimx6:~# So I think is hard float already. Also `uname -m' gives me `armv7l', so I need armv7hf crossbuild right? Now, how can I cross build JavaFX for armv7 with hardfloat using Yocto's toolchain? I can install toolchain or use it from build/tmp folder, I particulary prefer using build/tmp folder toolchain since saves space and sysroot is easily updatable. I'm would edit gradle stuff but I have never worked with gradle before. What it expects for crossbuilding? I'm using an Variscite module: http://www.variscite.com/products/system-on-module-som/cortex-a9/var-som-mx6-cpu-freescale-imx6 based on iMX6q core. I have a thread on Variscite's support forum too: http://www.variscite.com/support-forum/viewtopic.php?f=5&t=94 Best regards! - dhs -- *"Do or do not. There is no try"* *Yoda Master* From kevin.rushforth at oracle.com Fri Jul 3 16:45:21 2015 From: kevin.rushforth at oracle.com (Kevin Rushforth) Date: Fri, 03 Jul 2015 09:45:21 -0700 Subject: JavaFX features in JDK 9 In-Reply-To: <3509104.k00R3ZrUHt@andor> References: <4A33E952-B3B0-4C19-9F5E-CBB10EC9E19B@gmail.com> <558EBC40.3020300@oracle.com> <3509104.k00R3ZrUHt@andor> Message-ID: <5596BC21.1050902@oracle.com> This is unplanned for JDK 9. We will consider doing it for JDK 10. -- Kevin Florian Brunner wrote: > Hi Kevin, > > Thanks for the update. > > Back in 2012 there was the following statement from Oracle: > > "Oracle intends to standardize relevant parts of JavaFX through the JCP in the > Java SE 9 time frame." > > http://www.oracle.com/us/corporate/press/1854982 > > What about this plan? > > -Florian > > Am Samstag, 27. Juni 2015, 08.07:44 schrieb Kevin Rushforth: > >> Hi Felix, >> >> Sorry for the delay. Most of us were still pretty focused on 8u60, but >> we are turning our attention to JDK 9 now. >> >> The focus for JDK 9 is Jigsaw. The currently planned big features (JEPs) >> for FX in JDK 9 are these: >> >> JEP 253: Prepare JavaFX UI Controls & CSS APIs for Modularization >> JEP 257: Update JavaFX/Media to Newer Version of GStreamer >> >> Related to Jigasw, we intend to look into new API for heavily used >> internal methods / classes since they will no longer be accessible >> otherwise. We also plan to update WebKit at least one more time, and >> will likely do a few RFEs such as better Hi-DPI support (with API >> control) on Mac, Windows, Linux. >> >> We don't currently plan any other big features for 9, but will consider >> additional RFEs if they are important to enough developers and if they >> fit into the time frame. >> >> -- Kevin >> >> Felix Bembrick wrote: >> >>> Anyone got anything or is there a link somewhere that talks about these? >>> >>> On 15 June 2015 at 22:00, Felix Bembrick wrote: >>> >>>> I realise we are a long way off JDK 9 still and with crucial features >>>> such >>>> as Jigsaw still a little up in the air but is it possible someone could >>>> itemise the most likely new features, enhancements and bug fixes that we >>>> will see in JavaFX when JDK 9 is released? >>>> >>>> Of course it's purely speculation at this point but it would assist me >>>> greatly to have some of idea of where JavaFX is heading and which areas >>>> are >>>> seen as most important. >>>> >>>> Thanks, >>>> >>>> Felix >>>> > > From danielhilst at gmail.com Fri Jul 3 17:25:36 2015 From: danielhilst at gmail.com (Daniel.) Date: Fri, 3 Jul 2015 14:25:36 -0300 Subject: Cross build JavaFX for iMX6 In-Reply-To: References: Message-ID: Ok, the two problems wasn't a problem at all I compiled the arm6hf-sdk without problems. But when I try to run samples I get this error: Caused by: java.lang.RuntimeException: java.lang.UnsatisfiedLinkError: /opt/jdk1.8.0_60/jre/lib/arm/libglass.so: libgtk-x11-2.0.so.0: cannot open shared object file: No such file or directory Any ideia? I thought that JavaFX whould not use X at all, so can this be an absent of configuration while compiling? Best regards! - dhs 2015-07-03 12:50 GMT-03:00 Daniel. : > I trying to install JavaFX on a board running an iMX6q core. I follow the > instructions to cross build the JavaFX of the openjdk wiki: > https://wiki.openjdk.java.net/display/OpenJFX/Building+OpenJFX > > Looking at rt/buildSrc/crosslibs/crosslibs-armv6hf.sh I realised that I > have two problems. > > 1) The script is targeted to Debian, while I'm using archlinux > 2) The script uses linaro's toolchain, while I want to use Yocto's > toolchain > > Galcore stack seems to be working: > dmesg | grep Galcore > Galcore version 5.0.11.25762 > > On my board I see this: > root at varsomimx6:~# ls -l /lib/ld-linux-armhf.so.3 > lrwxrwxrwx 1 root root 10 Jul 1 14:01 /lib/ld-linux-armhf.so.3 -> > ld-2.19.so > root at varsomimx6:~# > > So I think is hard float already. Also `uname -m' gives me `armv7l', so I > need armv7hf crossbuild right? > > Now, how can I cross build JavaFX for armv7 with hardfloat using Yocto's > toolchain? I can install toolchain or use it from build/tmp folder, I > particulary prefer using build/tmp folder toolchain since saves space and > sysroot is easily updatable. I'm would edit gradle stuff but I have never > worked with gradle before. What it expects for crossbuilding? > > I'm using an Variscite module: > http://www.variscite.com/products/system-on-module-som/cortex-a9/var-som-mx6-cpu-freescale-imx6 > based on iMX6q core. I have a thread on Variscite's support forum too: > http://www.variscite.com/support-forum/viewtopic.php?f=5&t=94 > > Best regards! > > - dhs > > > -- > *"Do or do not. There is no try"* > *Yoda Master* > -- *"Do or do not. There is no try"* *Yoda Master* From johan at lodgon.com Sat Jul 4 19:35:34 2015 From: johan at lodgon.com (Johan Vos) Date: Sat, 4 Jul 2015 21:35:34 +0200 Subject: Gesture + MouseEvent Message-ID: Hi, On touch devices using Monocle (e.g. iOS and Android systems), there is an issue that a Swipe also generates a mouseClick event. This is a problem when e.g. Swiping in a ListView, where the ListCell has an action defined via setOnMouseClicked. At the end of the Swipe, the setOnMouseClicked will be triggered. com.sun.glass.ui.monocle.TouchPipeline.pushState is called when a native touchEvent is received. This method will call com.sun.glass.ui.monocle.TouchInput.setState() which will process the gestures, but which will also call this: MouseInputSynthesizer.getInstance().setState(newState) This method will then call MouseInput.getInstance().setState(mouseState, true); and it will generate a (synthesized) mouseEvent. The sequence of mousePressed, (ignored) mouseMoved and mouseReleased generate a mouseClick. It seems to me that when a gesture is detected, no mouse event processing should occur? Otherwise, there is no way to check wether the mouseClicked is generated due to a Swipe, or due to a real "click" (note that in case of a touch screen, the mouseEvent will always be synthesized). - Johan From joerg.wille at gmail.com Sun Jul 5 21:46:05 2015 From: joerg.wille at gmail.com (=?UTF-8?Q?J=C3=B6rg_Wille?=) Date: Sun, 5 Jul 2015 23:46:05 +0200 Subject: Cross build JavaFX for iMX6 Message-ID: Hi Daniel, did you try running javafx with monocle? Also sudo is required. I am also using yocto and using following bash-script to run ui-apps on i.MX6: #!/bin/sh sudo java \ -Xms128m \ -Xmx128m \ -Dprism.verbose=true \ -Dglass.platform=Monocle \ -Dembedded=monocle \ -Dmonocle.input.touchRadius=1 \ -Dmonocle.platform.traceConfig=true \ -Djava.ext.dirs=build/armv7hf-sdk/rt/lib/ext \ -jar $@ The last line depend whether you have build overlay (gradle -PCOMPILE_TARGETS=armv7hf zips) or just copied the build path (as I do here). Are you also using a touch-screen? I stumbled across errors in monocle/LinuxStatefulMultiTouchProcessor.java. But other than that, javafx/monocle works on I.MX6. Regards, J?rg From danielhilst at gmail.com Mon Jul 6 00:48:07 2015 From: danielhilst at gmail.com (Daniel.) Date: Sun, 5 Jul 2015 21:48:07 -0300 Subject: Cross build JavaFX for iMX6 In-Reply-To: References: Message-ID: Hi J?rg, I'm in home right now, tomorrow I'll try it. Thanks for the tip! - dhs Em 05/07/2015 18:47, "J?rg Wille" escreveu: > Hi Daniel, > did you try running javafx with monocle? Also sudo is required. > I am also using yocto and using following bash-script to run ui-apps on > i.MX6: > #!/bin/sh > sudo java \ > -Xms128m \ > -Xmx128m \ > -Dprism.verbose=true \ > -Dglass.platform=Monocle \ > -Dembedded=monocle \ > -Dmonocle.input.touchRadius=1 \ > -Dmonocle.platform.traceConfig=true \ > -Djava.ext.dirs=build/armv7hf-sdk/rt/lib/ext \ > -jar $@ > > The last line depend whether you have build overlay > < > https://wiki.openjdk.java.net/display/OpenJFX/Building+OpenJFX#BuildingOpenJFX-Overlay-JDK8 > > > (gradle -PCOMPILE_TARGETS=armv7hf zips) or just copied the build path (as I > do here). > > Are you also using a touch-screen? I stumbled across errors > in monocle/LinuxStatefulMultiTouchProcessor.java. But other than that, > javafx/monocle works on I.MX6. > > Regards, > J?rg > From ooo_saturn7 at mail.ru Mon Jul 6 04:20:29 2015 From: ooo_saturn7 at mail.ru (=?UTF-8?B?QWxleCBTdmlyaWRvdg==?=) Date: Mon, 06 Jul 2015 07:20:29 +0300 Subject: =?UTF-8?B?SmF2YUZ4ODogT25lIGNvbnRyb2xsZXIsIHR3byBmeG1sLGZhY3RvcnkgYW5k?= =?UTF-8?B?IEBGWE1MIHByb2JsZW0gLT4gYnVnIG9yIGxpbWl0?= Message-ID: <1436156429.384323020@f401.i.mail.ru> I've read the following from her e https://docs.oracle.com/javase/8/javafx/fxml-tutorial/jfx2_x-features.htm When a controller factory is provided to the FXMLLoader object, the loader will delegate controller construction to the factory. An implementation might return a null value to indicate that it does not or cannot create a controller of the given type; in this case, the default controller construction mechanism will be employed by the loader. Implementations might also "recycle" controllers such that controller instances can be shared by multiple FXML documents. However, developers must be aware of the implications of doing this: primarily, that controller field injection should not be used in this case because it will result in the controller fields containing values from only the most recently loaded document. As I understood it is the feature of javafx2. But what about javafx8? I did the following test: public class Test1Controller { ??? @FXML ??? public Button Test1Button; ?? ? ??? @FXML ??? public void onTest1Button(){ ??????? System.out.println("TEST1 BUTTON IS PRESSED"+Test1Button.getText()); ??? } } public class Test2Controller extends Test1Controller{ ??? @FXML ??? public Button Test2Button; ?? ? ??? @FXML ??? private void onTest2Button(){ ??????? System.out.println("TEST2 BUTTON IS PRESSED"+Test2Button.getText()+Test1Button.getText()); ???? } ?} test1.fxml ?? ?????