[9-dev] RFR: JDK-8142439: Ensemble8 media player slider issues

Morris Meyer morris.meyer at oracle.com
Tue Nov 10 21:37:20 UTC 2015


Kevin and Vadim,

Could you please review my changes for the post-commit cleanup to 
JDK-8144354?

Vadim regarding folding:

                  if (timeSlider.isValueChanging()) {
                      // multiply duration by percentage calculated by 
slider position
                      if (duration != null) {
mp.seek(duration.multiply(timeSlider.getValue() / 100.0));
                      }
                      updateValues();

                 } else if (Math.abs(now.doubleValue() - 
old.doubleValue()) > 1.5) {
                     // multiply duration by percentage calculated by 
slider position
                     if (duration != null) {
mp.seek(duration.multiply(timeSlider.getValue() / 100.0));
                     }
                 }

Pretty sure that is correct and cannot be folded as the updateValues() 
is necessary when with a slider changed value, and the click to seek 
value needs to stay unchanged.

Thanks much,

         --morris

WEBREV - http://cr.openjdk.java.net/~morris/JDK-8142439.01/
BUG - https://bugs.openjdk.java.net/browse/JDK-8142439



More information about the openjfx-dev mailing list