[PATCH] 8161282: FXCanvas does not forward horizontal mouse scroll events to the embedded scene

Kevin Rushforth kevin.rushforth at oracle.com
Mon Aug 15 17:26:44 UTC 2016


OK, I'll upload this revised version of the patch today.

-- Kevin


Alexander Nyssen wrote:
> Hi Kevin,
>
> please consider the following updated patch instead, which contains an 
> additional null-check.
>
> Regards
> Alexander
>
>
> ------------------------------------------------------------------------
>
>
>> Am 12.08.2016 um 16:04 schrieb Alexander Nyssen <alexander at nyssen.org 
>> <mailto:alexander at nyssen.org>>:
>>
>> Hi Kevin,
>>
>> attached please find an initial patch for 
>> https://bugs.openjdk.java.net/browse/JDK-8161282.
>>
>> The patch is not as minimal as I had hoped, as the 
>> EmbeddedSceneInterface had to be changed to differentiate between 
>> mouse and scroll events (while up to now, scroll events are handled 
>> as mouse events), but for me this seemed necessary to fix this issue 
>> properly. As a result, JFXPanel had to be adjusted as well to comply 
>> to the changes in the EmbeddedSceneInterface, while its behavior 
>> should not have changed.
>>
>> As horizontal mouse events cannot be synthesized via 
>> Display.post(Event) yet (an open issue for SWT), I did not add an 
>> automated test, but instead added a manual one 
>> (FXCanvasMouseWheelEventsTest). Therefore, this patch does not depend 
>> on the patch I provided earlier for JDK-8160325.
>>
>> Best Regards,
>> Alexander
>>
>> <JDK-8161282_12_08_16.patch>
>>
>>
>
> =


More information about the openjfx-dev mailing list