AW: Scenebuilder 8.1.0 removes Licensing / Copyright Terms and all other comments, worked with v8.0.0

[Eder Dennis (ETAS/ESY3)]

That is great news, thank you Joeri! 

I did not know about that separate issue tracker on https://bitbucket.org/gluon-oss/scenebuilder, outside of openjdk's http://hg.openjdk.java.net/
Maybe Gluon can add hyperlink references from their binary downloads listings (http://gluonhq.com/open-source/scene-builder/) into that repository (e.g. https://bitbucket.org/gluon-oss/scenebuilder/commits/tag/8.1.0).

Keep up the good work!

Best regards,
Dennis Eder                     

Von: Joeri Sykora [mailto:joeri at lodgon.com] 
Gesendet: Montag, 1. Februar 2016 12:19
An: Eder Dennis (ETAS/ESY3)
Cc: Benjamin Gudehus; support at gluonhq.com; openjfx-dev at openjdk.java.net
Betreff: Re: Scenebuilder 8.1.0 removes Licensing / Copyright Terms and all other comments, worked with v8.0.0

Hi Elder,

I've already looked into it and found the culprit. So there is no more need for you to look further into it. I'll create a pull request with a fix for the bug once I've finalized it.

Btw, there was already a bug report for this specific issue here: https://bitbucket.org/gluon-oss/scenebuilder/issues/53/comments-inside-fxml-are-removed

Kind regards,
Joeri Sykora

2016-02-01 11:48 GMT+01:00 Eder Dennis (ETAS/ESY3) <dennis.eder at etas.com>:
>> […] or even package scenebuilder as single jar and host it on maven central in the future
that is an interesting idea, Benjamin: self-executable, versioned JARs on Maven Central, incl. POM with build definitions.
Unfortunately, Maven is lacking a scope "DEV" as in "NPM --save-dev"

  <dependencies>
    <dependency>
      <groupId>Gluon</groupId>
      <artifactId>Scenebuilder</artifactId>
      <version>8.1.0.0</version>
      <scope>compile</scope>
      <optional>true</optional> <!-- for lack of NPM --save-dev -->
    </dependency>
  </dependencies>

Best regards,
Dennis

Von: Benjamin Gudehus [mailto:hastebrot at gmail.com]
Gesendet: Montag, 1. Februar 2016 10:36
An: Eder Dennis (ETAS/ESY3)
Cc: support at gluonhq.com; openjfx-dev at openjdk.java.net
Betreff: Re: Scenebuilder 8.1.0 removes Licensing / Copyright Terms and all other comments, worked with v8.0.0

>Until this is fixed, I recommend to continue using Scenebuilder 8.0.0
It saved the comment back as is.
That's bad. Is it possible to host old archives on Bintray or even package scenebuilder as single jar and host it on maven central in the future?
On Feb 1, 2016 10:23 AM, "Eder Dennis (ETAS/ESY3)" <dennis.eder at etas.com> wrote:
Hi FX'lers,

I want to inform everyone that the latest Gluon Scenebuilder 8.1.0, as available here
http://gluonhq.com/open-source/scene-builder/
removes comments, in particular License Headers, e.g.
<?xml version="1.0" encoding="UTF-8"?>
<!--
/*******************************************************************************
 * Copyright (c) etc
 * [...]
 *******************************************************************************/
 -->

This is a regression bug. Keeping comments was explicitly supported in earlier versions, as discussed here:
https://community.oracle.com/message/11122448#11122448

Until this is fixed, I recommend to continue using Scenebuilder 8.0.0
It saved the comment back as is.

Unfortunately that version does no longer seem to be available on
http://gluonhq.com

Best regards,
Dennis