Review Request for 8090160 8090252 8089111

[Ankit Srivastava]

Hi Kevin, Alexander,

 

 

Please review the fix for  below JIRA defects :

 

JIRA: https://bugs.openjdk.java.net/browse/JDK-8090160?filter=-1

 

JIRA: https://bugs.openjdk.java.net/browse/JDK-8090252?filter=-1

 

JIRA: https://bugs.openjdk.java.net/browse/JDK-8089111?filter=-1

 

 

 

 

Webrev:  http://cr.openjdk.java.net/~arajkumar/ankit/8090160/webrev.00

Above mentioned JIRA defect consist if media related drt. 

Webrev is for below DRT test cases :

LayoutTests/media/video-fast-seek.html

LayoutTests/media/video-canvas-drawing-output.html

LayoutTests/media/video-seek-multiple.html

 

RootCause and Solution:

1)      The root cause is canPlayThroughEvent firing continuously for the test case, added check to fire the event for the first time.

2)      Playing event firing incorrectly, added check to fire the event for correctly.

3)  Added function hasSingleSecurityOrigin with return value as "true" in MediaPlayerPrivateJava.h so that canvas can get data without being tainted.
 
I have verified all the media DRT cases in Win and Linux .
Also I have verified "playing" event functionality with video play/pause.
 
NOTE:
 
1)  In the issue HYPERLINK "https://bugs.openjdk.java.net/browse/JDK-8090252"8090252 a test case media/video-canvas-drawing.html, which is getting failed due to media source corruption not able to play the media file.
.Avprobe  output  for the media file is :
 
avprobe version 9.18-6:9.18-0ubuntu0.14.04.1, Copyright (c) 2007-2014 the Libav developers
  built on Mar 16 2015 13:19:10 with gcc 4.8 (Ubuntu 4.8.2-19ubuntu1)
[mov,mp4,m4a,3gp,3g2,mj2 @ 0x1f8e320] max_analyze_duration reached
Input #0, mov,mp4,m4a,3gp,3g2,mj2, from '/home/ankit/drt/LayoutTests/media/content/counting.mp4':
  Metadata:
    major_brand     : mp42
    minor_version   : 1
    compatible_brands: mp42mp41
    creation_time   : 2009-05-01 01:17:30
  Duration: 00:00:09.83, start: 0.000000, bitrate: 253 kb/s
    Stream #0.0(eng): Video: mpeg4 (Advanced Simple Profile), yuv420p, 352x288 [PAR 1:1 DAR 11:9], 250 kb/s, 30 fps, 30 tbr, 600 tbn, 1k tbc
    Metadata:
      creation_time   : 2009-05-01 01:17:30
    Stream #0.1(eng): Data: mp4s / 0x7334706D, 0 kb/s
    Metadata:
      creation_time   : 2009-05-01 01:17:30
    Stream #0.2(eng): Data: mp4s / 0x7334706D, 0 kb/s
    Metadata:
      creation_time   : 2009-05-01 01:17:30
Unsupported codec with id 0 for input stream 1
Unsupported codec with id 0 for input stream 2
# avprobe output
 
I will open a new issue for this test case.
 
2)  In the issue HYPERLINK "https://bugs.openjdk.java.net/browse/JDK-8090252"8090252  a test case media/video-canvas-drawing-output is getting failed on Win environment due to difference in colorspace management and/or media player on windows. I will open a new defect for the same.
The test has to be modified as per the Win environment.
 
3)  For test case media/video-load-preload-metadata.html and media/W3C/audio/canPlayType/canPlayType_supported_but_no_codecs_parameter_2.html, I have sent a mail to HYPERLINK "mailto:kirill.kirichenko at oracle.com"kirill.kirichenko at oracle.com and HYPERLINK "mailto:alexander.matveev at oracle.com"alexander.matveev at oracle.com to discuss some doubts.
 
 
 
 
Regards,
Ankit Srivastava