[webkit] [9] Review request for 8161258: [Win] Timer functionality is broken after JDK-8089563

Arunprasad Rajkumar arunprasad.rajkumar at oracle.com
Wed Jul 13 08:09:53 UTC 2016


Hello Guru, Murali,

Please review the following fix.

JIRA: https://bugs.openjdk.java.net/browse/JDK-8161258

Webrev: http://cr.openjdk.java.net/~arajkumar/8161258/webrev.00

Issue: Timer functionality is broken after JDK-8161258 in Windows.

Analysis: Our monotonically increasing time implementation for windows 
is based on glib's g_get_monotonic_time[1] function which returns time 
in microseconds. So the windows implementation of g_get_monotonic_time 
multiplies the ticks in millisecond by 1000 to convert to microseconds.

Solution: WTF::monotonicallyIncreasingTime() expects time in seconds, so 
we need to divide by value returned by GetTickCount64 by 1000, since it 
is in milliseconds.

Regards,
Arun


More information about the openjfx-dev mailing list