[9] Review request for 8157213: HiDPI support for Linux creates unnecessary dependency

Jim Graham james.graham at oracle.com
Wed May 18 20:47:55 UTC 2016


New updated webrevs with the new default value at:

http://cr.openjdk.java.net/~flar/JDK-8157213/webrev-01/

I also found a way to remove the schema from the Gentoo LiveCD environment and tested that way as well...

			...jim

On 5/18/16 1:28 PM, Erik De Rijcke wrote:
> Yes that seems to fix it.
>
> On Wed, May 18, 2016 at 9:55 PM, Jim Graham <james.graham at oracle.com> wrote:
>
>> Ah, this is probably me returning a -1 as an uint.  If you change the
>> "defval" used (line 167) in the call to query the property from -1 to 0
>> does it work as intended?
>>
>>                         ...jim
>>
>>
>> On 5/18/16 11:59 AM, Erik De Rijcke wrote:
>>
>>> I tested the patch.
>>>
>>> Without the dependency I get a an enormous stage (I explicitly set it to
>>> be 100x100). Debugging shows me the screen is
>>> initialized with these values:
>>>
>>> Screen:
>>>     ptr:0
>>>     adapter:0
>>>     depth:24
>>>     x:0
>>>     y:0
>>>     width:0
>>>     height:0
>>>     platformX:0
>>>     platformY:0
>>>     platformWidth:1680
>>>     platformHeight:946
>>>     visibleX:0
>>>     visibleY:0
>>>     visibleWidth:0
>>>     visibleHeight:0
>>>     platformScaleX:4.2949673E9
>>>     platformScaleY:4.2949673E9
>>>     outputScaleX:4.2949673E9
>>>     outputScaleY:4.2949673E9
>>>     resolutionX:0
>>>     resolutionY:0
>>>
>>>
>>> I assume the scaling factor is not what it should be?
>>>
>>> With the dependency installed the stage looks fine.
>>>
>>> On Wed, May 18, 2016 at 5:52 AM, Jim Graham <james.graham at oracle.com
>>> <mailto:james.graham at oracle.com>> wrote:
>>>
>>>     bug: https://bugs.openjdk.java.net/browse/JDK-8157213
>>>     webrev: http://cr.openjdk.java.net/~flar/JDK-8157213/webrev-00/
>>>
>>>     Details of what was fixed are listed in the bug report.  This will
>>> hopefully fix all of the dependencies that Erik
>>>     ran into in his Gentoo environment...
>>>
>>>                             ...jim
>>>
>>>
>>>


More information about the openjfx-dev mailing list