[9] RfR: 8169289: JavaFX application in named module fails to launch if no main method

David DeHaven david.dehaven at oracle.com
Thu Nov 17 17:48:28 UTC 2016


>> Looks good with two minor comments:
>> 
>> 1) It looks like the new "mainModule" parameter to launchApplicationWithArgs is only ever called with "null". Did you intend it to be called with the application module in the case of LM_MODULE?
> 
> You're correct... I wonder how that happened. It seems I never finished that part, probably due to splitting the work over the weekend :/
> 
> That needs to be corrected. Shouldn't take long.

Updated webrev after this mornings dose of <facepalm>

http://cr.openjdk.java.net/~ddehaven/8169289/openjfx-rt.1/

-DrD-



More information about the openjfx-dev mailing list