[9] RfR: 8169289: JavaFX application in named module fails to launch if no main method

[Kevin Rushforth]

Thanks for the explanation.

+1

-- Kevin


David DeHaven wrote:
> There's no way to specify a ClassLoader when loading from a Module, so there's not much point in passing it. Also, the only case where appLoader will be non-null is LM_JAR with JavaFX-Class-Path, so mainModule and appLoader are mutually exclusive.
>
> -DrD-
>
>   
>> I think you missed one place:
>>
>> +                lawa.invoke(null, new Object[] {null, mainClassName, preloaderClassName, appArgs});
>>
>>
>> You will want to pass in mainModule as the first argument here, too.
>>
>> -- Kevin
>>
>>
>> David DeHaven wrote:
>>     
>>>>> Looks good with two minor comments:
>>>>>
>>>>> 1) It looks like the new "mainModule" parameter to launchApplicationWithArgs is only ever called with "null". Did you intend it to be called with the application module in the case of LM_MODULE?
>>>>>       
>>>>>
>>>>>           
>>>> You're correct... I wonder how that happened. It seems I never finished that part, probably due to splitting the work over the weekend :/
>>>>
>>>> That needs to be corrected. Shouldn't take long.
>>>>     
>>>>
>>>>         
>>> Updated webrev after this mornings dose of <facepalm>
>>>
>>>
>>> http://cr.openjdk.java.net/~ddehaven/8169289/openjfx-rt.1/
>>>
>>>
>>> -DrD-
>>>
>>>   
>>>
>>>       
>
>