[9] Review request for 8157002: Toggle gtk version if SWT used via FXCanvas

Doychin Bondzhev doychin at dsoft-bg.com
Wed Nov 23 07:15:26 UTC 2016


Hi,

I think this line is incorrect:

if (ver < 2 && ver > 3) {

It should be || instead of &&

On 22.11.2016 г. 15:51 ч., Semyon Sadetsky wrote:
> Hello Kevin & David,
>
> Please review the fix for jfx9:
>
> bug: https://bugs.openjdk.java.net/browse/JDK-8157002
>
> webrev: http://cr.openjdk.java.net/~ssadetsky/8157002/webrev.00/
>
> In JFX embeded into SWT scenarios JFX loads GTK primarily. So SWT GTK
> version cannot be detected using the check for the loaded native library
> version.
>
> The fix proposes a way to detect if GTK version of swt.jar library is
> available on the classpath and tries to get the GTK version from SWT lib
> internal java classes.
>
> --Semyon
>
>


-- 
Doychin Bondzhev
dSoft-Bulgaria Ltd.
PowerPro - billing & provisioning solution for Service providers
PowerStor - Warehouse & POS
http://www.dsoft-bg.com/
Mobile: +359888243116


More information about the openjfx-dev mailing list