From mattias.eliasson at medsa.se Sat Oct 1 16:32:37 2016 From: mattias.eliasson at medsa.se (Mattias Eliasson) Date: Sat, 1 Oct 2016 18:32:37 +0200 Subject: Creating a plugin for WebEngine. Message-ID: Hi, I am planing to create an Applet plugin for WebEngine and in order to do so I need more information on the appropriate way to do this. What I basically want to do is to insert a JavaFX custom control where there are an Applet or Object html tag. As WebEngine internals isn't well documented I write to this list in hope of getting some hints on how to do this. I have thought of an "ugly" way to do this by intercepting the download and replacing the tags with empty spaces that I then can render upon. I am looking for something similar to this pseudocode: for each item in DOM if item tag is "applet" or "object" item.node = new MyPlugin(item) Or perhaps something like: web.setTagRenderer("applet", myPluginFactory) web.setTagRenderer("object", myPluginFactory) The latter may be more capable to do things like intercept JavaScript putting code into the DOM. Also it doesn't introduce a redundant loop outside of the engine. // Mattias From jonathan.giles at oracle.com Mon Oct 3 00:35:18 2016 From: jonathan.giles at oracle.com (Jonathan Giles) Date: Mon, 3 Oct 2016 13:35:18 +1300 Subject: [9] Review request: 8166950,Memory Leak: MenuBar added to Tab is still referenced on tab close and is not garbage collected Message-ID: <5163bf47-752b-5b1f-d620-e7cbeadc3c11@oracle.com> Kevin, Chien, Please can you review the webrev for the following issue: https://bugs.openjdk.java.net/browse/JDK-8166950 http://cr.openjdk.java.net/~jgiles/8166950 Thanks -- -- Jonathan From kevin.rushforth at oracle.com Mon Oct 3 14:11:21 2016 From: kevin.rushforth at oracle.com (Kevin Rushforth) Date: Mon, 03 Oct 2016 07:11:21 -0700 Subject: GLS language errors (Was: Internal error: Error loading stock shader FillRoundRect_LinearGradient,_PAD on Vivante ARM) In-Reply-To: References: <56D1E6A4.80301@cuhka.com> <56D32F81.7060708@cuhka.com> <56D597E4.2050805@cuhka.com> <56D5CD0C.3050704@cuhka.com> <56D64062.5050105@oracle.com> <56D699FF.3010806@cuhka.com> <56D7248B.8090400@oracle.com> <57EBEA81.1000103@oracle.com> Message-ID: <57F26709.10701@oracle.com> Hi Erik, Thank you for filing this. I see the bug has been filed as JI-9044144. Once the incident team finishes reviewing it they will transfer it to the JDK project where it will be publicly visible. -- Kevin Erik De Rijcke wrote: > I filed a report but it seems to be under review(?). > > On Wed, Sep 28, 2016 at 6:06 PM, Kevin Rushforth > > wrote: > > I don't find a bug relating to this, so it seems the bug was never > filed. > > Can you please file one? > > Thanks. > > -- Kevin > > > > Erik De Rijcke wrote: > > Hi all, > > Any follow up on this? I'm experiencing the same issue here > (latest > openjfx8 on wayland using mesa egl/gles2). > > Erik > > On Wed, Mar 2, 2016 at 6:36 PM, Chien Yang > > wrote: > > > > Hi Maurice, > > Can you please file a JIRA on this issue? > > Thanks, > - Chien > > > On 3/1/16, 11:45 PM, Maurice wrote: > > > > Jim, > > A solution in line of that of Johan Vos [1] works. > JavaFX can be run and > doesn't crash on startup when compiling the shaders. I > think they should be > taken into account for at least JavaFX 9, as it > reduces a very serious bug > to a possible optimization. > > Maurice. > > [1] > https://bitbucket.org/javafxports/8u60-rt/commits/595633bbaa > > e36f98d85d47d276294442ea43488c > > Op 02-03-16 om 02:22 schreef Jim Graham: > > > > The thing about this use of pixcoord is that the > same information can be > supplied much more efficiently as a pair of > texture coordinates. The value > of pixcoord ends up being a linear equation over > the area of the primitive > which is exactly what texture coordinate samples > give you for free. > > I believe some of the other gradient methods use > that texture coordinate > technique to avoid having to use pixcoord, but the > issue is that we've > hard-coded all of our VertexBuffer streams to have > exactly 2 sets of > texture coordinates and so you only get room to > pass in so many values and > these (i.e. this family of) shaders are already > using those texture > coordinates to pass in too many values to leave > enough free for the > gradient fractions. > > This shader could be avoided, I believe, by > rasterizing the shape into > an alpha mask and using one of the alpha mask > gradient shaders that doesn't > rely on pixcoord. In fact, in some embedded > environments these shaders > have so many computations per pixel that running > the shape rasterizer on > the CPU actually wins performance (and especially > if you cache the alpha > masks as some of our NGShape nodes do)... > > ...jim > > On 3/1/16 9:10 AM, Maurice wrote: > > > > > > From arunprasad.rajkumar at oracle.com Mon Oct 3 18:45:16 2016 From: arunprasad.rajkumar at oracle.com (Arunprasad Rajkumar) Date: Tue, 4 Oct 2016 00:15:16 +0530 Subject: [webkit] [9] Review request for 8088205: [Mac] WebView renders icons instead of letters on some sites Message-ID: <0863B2AC-2B17-4EA9-91F3-92FDC8E2C073@oracle.com> Hello Kevin, Phil, Guru Please review the following fix. JIRA: https://bugs.openjdk.java.net/browse/JDK-8088205 Webrev: http://cr.openjdk.java.net/~arajkumar/8088205/webrev.00 Analysis: Some Web Fonts(like Thin.ttf, refer the attachment) doesn?t have valid entry in the TTF Naming Table. Due to missing entry, ?CTFontCreateWithName? is not returning correct font reference. Solution: Use ?CGFontCreateWithDataProvider?, it takes font path as a parameter and creates a CGFontRef, then create a CTFontRef using CGFontRef. ?CGFontCreateWithDataProvider? doesn?t support TTC font type, so use ?CTFontCreateWithName? as a fallback if CGFontRef creation fails. Test - 1: Load http://www.cnet.com with HelloWebView Test - 2: Try simple fx application present in https://bugs.openjdk.java.net/secure/attachment/62649/CustomFontApp.tar.bz2 Regards, Arun From jonathan.giles at oracle.com Mon Oct 3 20:55:32 2016 From: jonathan.giles at oracle.com (Jonathan Giles) Date: Tue, 4 Oct 2016 09:55:32 +1300 Subject: [9] Review request: 8167055: TableViews with many columns lose alignment between headers and cells Message-ID: Vadim, Please review the webrev for the following issue: https://bugs.openjdk.java.net/browse/JDK-8167055 http://cr.openjdk.java.net/~jgiles/8167055/ Thanks! -- -- Jonathan From chien.yang at oracle.com Mon Oct 3 23:38:56 2016 From: chien.yang at oracle.com (Chien Yang) Date: Mon, 3 Oct 2016 16:38:56 -0700 Subject: [9] Code Review Request For 8166933: Clean up private TextAttributes class Message-ID: Kevin, Please review the proposed fix. In this fix I also took the chance to fix the wildcard import issue in this file: https://bugs.openjdk.java.net/browse/JDK-8166933 http://cr.openjdk.java.net/~ckyang/JDK-8166933/webrev.00/ Thanks, - Chien From chien.yang at oracle.com Tue Oct 4 00:18:53 2016 From: chien.yang at oracle.com (Chien Yang) Date: Mon, 3 Oct 2016 17:18:53 -0700 Subject: [9] Code Review Request For 8166934: Cleanup obsolete impl_ references in JavaFX modules Message-ID: <899bbe48-0954-c8a0-1566-875814e629b6@oracle.com> Hi Kevin, Please review the proposed fix: JIRA: https://bugs.openjdk.java.net/browse/JDK-8166934 Webrev: http://cr.openjdk.java.net/~ckyang/JDK-8166934/webrev.00/ Thanks, - Chien From tobi at ultramixer.com Tue Oct 4 20:38:58 2016 From: tobi at ultramixer.com (Tobi) Date: Tue, 4 Oct 2016 22:38:58 +0200 Subject: Running JavaFX headless without native dependencies Message-ID: Hi, is it possible to run JavaFX in a headless mode without native dependencies? Maybe I could use software rendering or monocle to do it? So I would like to cut off the real render part of JavaFX (e.g. OpenGL or DirectX). Thank you for your help. Best, Tobi From tai.hu at veroanalytics.com Tue Oct 4 20:58:16 2016 From: tai.hu at veroanalytics.com (Tai Hu) Date: Tue, 4 Oct 2016 16:58:16 -0400 Subject: Running JavaFX headless without native dependencies In-Reply-To: References: Message-ID: Recently I converted my JavaFX app to run in a headless Ubuntu Server from command line. I could not find a way to completely git rid of native dependencies. But if you could do the following two things, your JavaFX app should be able to run headless. 1. Install the the following lib apt-get install libswt-gtk-3-java-gcj 2. Make sure the part of JavaFX application runs in the headless environment do not use any methods from Platform object. Tai > On Oct 4, 2016, at 4:38 PM, Tobi wrote: > > Hi, > > is it possible to run JavaFX in a headless mode without native dependencies? Maybe I could use software rendering or monocle to do it? > > So I would like to cut off the real render part of JavaFX (e.g. OpenGL or DirectX). > > > Thank you for your help. > > Best, > Tobi > From jonathan.giles at oracle.com Tue Oct 4 21:30:46 2016 From: jonathan.giles at oracle.com (Jonathan Giles) Date: Wed, 5 Oct 2016 10:30:46 +1300 Subject: [9] Review request: 8167132: Menu keyboard navigation retains previous focus index Message-ID: <1e2c465d-d0e6-a09f-64be-7da9c53f0028@oracle.com> Vadim, Please review the following webrev: https://bugs.openjdk.java.net/browse/JDK-8167132 http://cr.openjdk.java.net/~jgiles/8167132/ Thanks! -- -- Jonathan From jonathan.giles at oracle.com Tue Oct 4 22:32:49 2016 From: jonathan.giles at oracle.com (Jonathan Giles) Date: Wed, 5 Oct 2016 11:32:49 +1300 Subject: [9] Review request: 8167134: Keyboard navigation between menus in menubar leads to incorrect selection Message-ID: <65c916ac-f4e9-108c-b781-20bb7248f7f7@oracle.com> Vadim, Please review the following webrev: https://bugs.openjdk.java.net/browse/JDK-8167134 http://cr.openjdk.java.net/~jgiles/8167134/ Thanks! -- -- Jonathan From jonathan.giles at oracle.com Tue Oct 4 22:41:51 2016 From: jonathan.giles at oracle.com (Jonathan Giles) Date: Wed, 5 Oct 2016 11:41:51 +1300 Subject: [9] Review request: 8167137: Keyboard navigation through collapsed menus in menubar should not show sibling menus Message-ID: Vadim, Please review the following webrev: https://bugs.openjdk.java.net/browse/JDK-8167137 http://cr.openjdk.java.net/~jgiles/8167137/ Thanks! -- -- Jonathan From jonathan.giles at oracle.com Tue Oct 4 23:11:59 2016 From: jonathan.giles at oracle.com (Jonathan Giles) Date: Wed, 5 Oct 2016 12:11:59 +1300 Subject: [9] Review request: 8167138: Menu does not respond on the repeating mouse clicks Message-ID: <4ad4ebe0-a04f-e53c-28dc-7076e2cfcfda@oracle.com> Vadim, Please review the following webrev: https://bugs.openjdk.java.net/browse/JDK-8167138 http://cr.openjdk.java.net/~jgiles/8167138/ Thanks! -- -- Jonathan From daniel.gloeckner at 360t.com Wed Oct 5 07:20:09 2016 From: daniel.gloeckner at 360t.com (=?iso-8859-1?Q?Daniel_Gl=F6ckner?=) Date: Wed, 5 Oct 2016 07:20:09 +0000 Subject: Running JavaFX headless without native dependencies In-Reply-To: References: Message-ID: <6D5AA6A29F1039459FDD3C00A9F5DE98EC64679E@EOFFICE-EX01.360t.com> Hi, We're successfully running our full-blown JavaFX application on our build server to run automated performance tests. Monocle is used as a renderer. Here are the relevant JVM arguments: -Dglass.platform=Monocle -Dmonocle.platform=Headless -Dprism.order=sw -Dprism.useFontConfig=false -Dprism.fontdir=" + jdk_path + "/jre/lib/fonts" The font dir stuff was required on our build server. I'm sure you need to tweak this to make it work :) Kind regards, Daniel > -----Original Message----- > From: openjfx-dev [mailto:openjfx-dev-bounces at openjdk.java.net] On Behalf > Of Tobi > Sent: Tuesday, October 04, 2016 10:39 PM > To: openjfx-dev at openjdk.java.net Mailing > Subject: Running JavaFX headless without native dependencies > > Hi, > > is it possible to run JavaFX in a headless mode without native dependencies? > Maybe I could use software rendering or monocle to do it? > > So I would like to cut off the real render part of JavaFX (e.g. OpenGL or > DirectX). > > > Thank you for your help. > > Best, > Tobi From a.ankit.srivastava at oracle.com Wed Oct 5 13:39:50 2016 From: a.ankit.srivastava at oracle.com (Ankit Srivastava) Date: Wed, 5 Oct 2016 06:39:50 -0700 (PDT) Subject: [9] Review Request 8166775 : Audio slider works incorrectly for short files Message-ID: <0faaba42-3214-4969-9ac6-c5d129068f5a@default> Hi Kevin, Arun, Please review the fix for : JBS: https://bugs.openjdk.java.net/browse/JDK-8166775 Webrev: http://cr.openjdk.java.net/~asrivastava/8166775/webrev.00/ Tested on Win64 and Linux 64. Used webkit patch: https://trac.webkit.org/changeset/195809 Regards, Ankit From vadim.pakhnushev at oracle.com Wed Oct 5 15:08:53 2016 From: vadim.pakhnushev at oracle.com (Vadim Pakhnushev) Date: Wed, 5 Oct 2016 18:08:53 +0300 Subject: [9] Review request for 8166662: Gradle test takes more time when skipping sdk Message-ID: <277a5026-e422-1c7f-2022-21bb4eac447d@oracle.com> Hi Dave, Kevin, Could you please review the fix: https://bugs.openjdk.java.net/browse/JDK-8166662 http://cr.openjdk.java.net/~vadim/8166662/webrev.00/ Thanks, Vadim From chris.bensen at oracle.com Wed Oct 5 15:11:19 2016 From: chris.bensen at oracle.com (Chris Bensen) Date: Wed, 5 Oct 2016 08:11:19 -0700 Subject: [9] Review Request: 8165414 javapackager throws NullPointerException in Windows Operating System for CLI Message-ID: <011C5401-3D49-41EB-A2D3-0250FB1EAB01@oracle.com> Kevin, This resolves the NullPointerExceptions when packaging on Windows. JIRA: https://bugs.openjdk.java.net/browse/JDK-8165414 Webrev: http://cr.openjdk.java.net/~cbensen/JDK-8165414/webrev.00/ Chris From tobi at ultramixer.com Wed Oct 5 17:39:57 2016 From: tobi at ultramixer.com (Tobi) Date: Wed, 5 Oct 2016 19:39:57 +0200 Subject: Running JavaFX headless without native dependencies In-Reply-To: <6D5AA6A29F1039459FDD3C00A9F5DE98EC64679E@EOFFICE-EX01.360t.com> References: <6D5AA6A29F1039459FDD3C00A9F5DE98EC64679E@EOFFICE-EX01.360t.com> Message-ID: <0FAFC315-BF96-464E-A177-CBB5B1ED47A2@ultramixer.com> Hi, thanks for all your hints, but my problem is not to start JavaFX in headless mode with Monocle. I need to start JavaFX without loading any native libraries (e.g. dylibs). But even the software renderer uses native code? So I suppose currently there is no prism/monocle implementation which does not uses any native libraries? Kind Regals, Tobi -- -------------------------------------------------------- UltraMixer Digital Audio Solutions Am Waldschl??chen 2 D-01099 Dresden Germany -------------------------------------------------------- http://www.ultramixer.com > Am 05.10.2016 um 09:20 schrieb Daniel Gl?ckner : > > Hi, > > We're successfully running our full-blown JavaFX application on our build server to run automated performance tests. > > Monocle is used as a renderer. Here are the relevant JVM arguments: > > -Dglass.platform=Monocle > -Dmonocle.platform=Headless > -Dprism.order=sw > -Dprism.useFontConfig=false > -Dprism.fontdir=" + jdk_path + "/jre/lib/fonts" > > The font dir stuff was required on our build server. I'm sure you need to tweak this to make it work :) > > Kind regards, > Daniel > >> -----Original Message----- >> From: openjfx-dev [mailto:openjfx-dev-bounces at openjdk.java.net] On Behalf >> Of Tobi >> Sent: Tuesday, October 04, 2016 10:39 PM >> To: openjfx-dev at openjdk.java.net Mailing >> Subject: Running JavaFX headless without native dependencies >> >> Hi, >> >> is it possible to run JavaFX in a headless mode without native dependencies? >> Maybe I could use software rendering or monocle to do it? >> >> So I would like to cut off the real render part of JavaFX (e.g. OpenGL or >> DirectX). >> >> >> Thank you for your help. >> >> Best, >> Tobi > From philip.race at oracle.com Wed Oct 5 17:48:22 2016 From: philip.race at oracle.com (Phil Race) Date: Wed, 5 Oct 2016 10:48:22 -0700 Subject: Running JavaFX headless without native dependencies In-Reply-To: <0FAFC315-BF96-464E-A177-CBB5B1ED47A2@ultramixer.com> References: <6D5AA6A29F1039459FDD3C00A9F5DE98EC64679E@EOFFICE-EX01.360t.com> <0FAFC315-BF96-464E-A177-CBB5B1ED47A2@ultramixer.com> Message-ID: <6373d28a-c299-08b5-1d7a-bfecc8c28c4b@oracle.com> The JDK itself that runs JavaFX has lots of native code so I am not sure you are heading down a productive path. -phil. On 10/05/2016 10:39 AM, Tobi wrote: > Hi, > > thanks for all your hints, but my problem is not to start JavaFX in headless mode with Monocle. I need to start JavaFX without loading any native libraries (e.g. dylibs). But even the software renderer uses native code? > > So I suppose currently there is no prism/monocle implementation which does not uses any native libraries? > > Kind Regals, > Tobi > > > From chris.bensen at oracle.com Wed Oct 5 17:56:39 2016 From: chris.bensen at oracle.com (Chris Bensen) Date: Wed, 5 Oct 2016 10:56:39 -0700 Subject: [9] Review Request: 8166881 .cfg Configuration file contains hard coded values of path Message-ID: <31AB5221-B38A-465F-B719-AC9D6239FCD2@oracle.com> Kevin, Fix so the config file entry of the jar file is not a hard coded path. JIRA: https://bugs.openjdk.java.net/browse/JDK-8166881 Webrev: http://cr.openjdk.java.net/~cbensen/JDK-8166881/webrev.00/ Chris From murali.billa at oracle.com Thu Oct 6 13:48:27 2016 From: murali.billa at oracle.com (Murali Billa) Date: Thu, 6 Oct 2016 06:48:27 -0700 (PDT) Subject: [9] Review request for 8166677: HTMLEditor freezes after restoring previously maximized window In-Reply-To: References: <5d429381-0799-e757-c070-827af4746317@oracle.com> <4816ea91-3506-4e52-84f6-86f04768d6f3@default> Message-ID: Hi Kevin, David Please review the following fix. JIRA: https://bugs.openjdk.java.net/browse/JDK-8166677 Webrev: http://cr.openjdk.java.net/~mbilla/8166677/webrev.02/ ? Thanks, Murali From chris.bensen at oracle.com Thu Oct 6 15:04:48 2016 From: chris.bensen at oracle.com (Chris Bensen) Date: Thu, 6 Oct 2016 08:04:48 -0700 Subject: [9] Review Request: 8165414 javapackager throws NullPointerException in Windows Operating System for CLI In-Reply-To: <011C5401-3D49-41EB-A2D3-0250FB1EAB01@oracle.com> References: <011C5401-3D49-41EB-A2D3-0250FB1EAB01@oracle.com> Message-ID: Kevin, did you see this one too? Chris > On Oct 5, 2016, at 8:11 AM, Chris Bensen wrote: > > Kevin, > > This resolves the NullPointerExceptions when packaging on Windows. > > JIRA: https://bugs.openjdk.java.net/browse/JDK-8165414 > Webrev: http://cr.openjdk.java.net/~cbensen/JDK-8165414/webrev.00/ > > Chris From markclaassenx at gmail.com Thu Oct 6 16:58:09 2016 From: markclaassenx at gmail.com (Mark Claassen) Date: Thu, 06 Oct 2016 16:58:09 +0000 Subject: Scaling WebEngine.print output Message-ID: I am having a problem with printing from the WebEngine. What I am trying to do is create a page of SVG, render it to the WebEngine, and print it. I don't completely control the SVG, but I know it needs to fit on one page. So, what I would like to do is be able to control the scaling and positioning of the WebEngine manually. I found that I can do this using JavaScript, but this gets a bit ugly. The WebEngine.load seems to be rendered on a background thread, however the WebEngine.executeScript calls execute immediately. This ends up creating a complex call structure so that I can guarantee that these JavaScript methods are not called before they can be executed. I am also forced to know more about the DOM than I would like to. It would be nice if there were some methods that could tell me what the bounding box is, and then let me translate this if I need to. (I realize that there would likely be a unit conversion necessary as well.) Example JavaScript methods: executeScript("document.getElementsByTagName('svg')[0].getBoundingClientRect().width")) executeScript("document.getElementsByTagName('svg')[0].currentTranslate.x = 100"); Thanks, Mark From david.dehaven at oracle.com Thu Oct 6 19:03:47 2016 From: david.dehaven at oracle.com (David DeHaven) Date: Thu, 6 Oct 2016 12:03:47 -0700 Subject: [8u-dev] RfR: backport of JDK-8156563: JavaFX Ensemble8 media sample hang and crash Message-ID: <98607185-36D5-4E91-AA0E-CCF9A52F2861@oracle.com> Kevin, Alexander, please review my backport of 8156563 to 8u-dev. Main issue: https://bugs.openjdk.java.net/browse/JDK-8156563 Backport issue: https://bugs.openjdk.java.net/browse/JDK-8167317 Code review: http://cr.openjdk.java.net/~ddehaven/8156563-8u/rt.0/ -DrD- From vadim.pakhnushev at oracle.com Fri Oct 7 14:30:35 2016 From: vadim.pakhnushev at oracle.com (Vadim Pakhnushev) Date: Fri, 7 Oct 2016 17:30:35 +0300 Subject: In(Sanity) Testing Mondays Message-ID: <388a1a74-2d1f-ee7e-7a9a-ade212a8cb4f@oracle.com> Reminder, Monday is our weekly sanity testing. You can find your testing assignment at: https://wiki.openjdk.java.net/display/OpenJFX/Sanity+Testing Also please remember that the repo will be locked from 1am PST until 1pm PST. Happy testing! Thanks, Vadim From kevin.rushforth at oracle.com Fri Oct 7 17:45:55 2016 From: kevin.rushforth at oracle.com (Kevin Rushforth) Date: Fri, 07 Oct 2016 10:45:55 -0700 Subject: [9] Review request: JDK-8166958: javafx dll binaries are in the wrong directory in the jmod files Message-ID: <57F7DF53.30108@oracle.com> Dave and Chris, Please review the following build change for Windows to fix the location of the .dll files in the jmods: https://bugs.openjdk.java.net/browse/JDK-8166958 http://cr.openjdk.java.net/~kcr/8166958/webrev.00/ In parallel with your review I still need to sanity test it on Mac and Linux to ensure no regressions. -- Kevin From david.dehaven at oracle.com Fri Oct 7 18:25:34 2016 From: david.dehaven at oracle.com (David DeHaven) Date: Fri, 7 Oct 2016 11:25:34 -0700 Subject: [8u-dev] RfR: backport of JDK-8156563: JavaFX Ensemble8 media sample hang and crash In-Reply-To: <98607185-36D5-4E91-AA0E-CCF9A52F2861@oracle.com> References: <98607185-36D5-4E91-AA0E-CCF9A52F2861@oracle.com> Message-ID: <8F92C725-E718-405D-92BF-B4D8A4D9A0D0@oracle.com> ping? -DrD- > Kevin, Alexander, please review my backport of 8156563 to 8u-dev. > > Main issue: > https://bugs.openjdk.java.net/browse/JDK-8156563 > > Backport issue: > https://bugs.openjdk.java.net/browse/JDK-8167317 > > Code review: > http://cr.openjdk.java.net/~ddehaven/8156563-8u/rt.0/ > > -DrD- > From chris.bensen at oracle.com Fri Oct 7 21:35:49 2016 From: chris.bensen at oracle.com (Chris Bensen) Date: Fri, 7 Oct 2016 14:35:49 -0700 Subject: [9] Review request: JDK-8166661 Remove "-outfile" as compulsary when bundling modules in javapackager Message-ID: Kevin, Please review the following change to remove the required argument -outfile. JIRA: https://bugs.openjdk.java.net/browse/JDK-8166661 Webrev: http://cr.openjdk.java.net/~cbensen/JDK-8166661/webrev.00/ Chris From jonathan.giles at oracle.com Mon Oct 10 00:12:39 2016 From: jonathan.giles at oracle.com (Jonathan Giles) Date: Mon, 10 Oct 2016 13:12:39 +1300 Subject: [9] Review request: 8165624: TreeTableView: incorrect scrolling range Message-ID: <61b69ee9-1aa3-025e-7aad-62721f93de38@oracle.com> Vadim, Could you please review the webrev for the mentioned issue: https://bugs.openjdk.java.net/browse/JDK-8165624 http://cr.openjdk.java.net/~jgiles/8165624/ Thanks! -- -- Jonathan From rahman.usta.88 at gmail.com Tue Oct 11 06:55:06 2016 From: rahman.usta.88 at gmail.com (Rahman USTA) Date: Tue, 11 Oct 2016 09:55:06 +0300 Subject: Detection Cut Operation in JavaFX System Clipboard Message-ID: Hello, Clipboard.getSystemClipboard() gives me files that are cut or copied from filesystem. So, How can I determine whether it is a cut or copy operation ? Thanks. -- Rahman USTA Istanbul JUG https://github.com/rahmanusta From diego.cirujano-cuesta at zeiss.com Tue Oct 11 12:24:29 2016 From: diego.cirujano-cuesta at zeiss.com (Cirujano Cuesta, Diego) Date: Tue, 11 Oct 2016 12:24:29 +0000 Subject: SVG Message-ID: Hi all, I was wondering why there is no javafx support to svg, is there any reason? I found nice the solution from codecentric interesting: https://github.com/codecentric/javafxsvg. But it uses com.sun.javafx.iio.ImageFormatDescription, com.sun.javafx.iio.ImageLoader, com.sun.javafx.iio.ImageStorage and com.sun.javafx.iio.ImageLoaderFactory. in openjfx9 is still there in com.sun... What's going to happen to these classes in Java 9? Is there strategy about providing ways to use them? Thanks! Diego From kevin.rushforth at oracle.com Tue Oct 11 12:36:24 2016 From: kevin.rushforth at oracle.com (Kevin Rushforth) Date: Tue, 11 Oct 2016 05:36:24 -0700 Subject: SVG In-Reply-To: References: Message-ID: <57FCDCC8.8090307@oracle.com> JavaFX supports SVG paths both directly and via CSS, but there is no general support for SVG. As for you other question, unless they use public API they will no longer work. Applications can export internal packages via a command line switch, but it is quite fragile and not likely to work from release to release. -- Kevin Cirujano Cuesta, Diego wrote: > Hi all, > > I was wondering why there is no javafx support to svg, is there any reason? I found nice the solution from codecentric interesting: https://github.com/codecentric/javafxsvg. But it uses com.sun.javafx.iio.ImageFormatDescription, com.sun.javafx.iio.ImageLoader, com.sun.javafx.iio.ImageStorage and com.sun.javafx.iio.ImageLoaderFactory. in openjfx9 is still there in com.sun... What's going to happen to these classes in Java 9? Is there strategy about providing ways to use them? > > Thanks! > Diego > From swpalmer at gmail.com Tue Oct 11 13:26:35 2016 From: swpalmer at gmail.com (Scott Palmer) Date: Tue, 11 Oct 2016 09:26:35 -0400 Subject: SVG In-Reply-To: <57FCDCC8.8090307@oracle.com> References: <57FCDCC8.8090307@oracle.com> Message-ID: <63A291AC-F7D9-4A97-9EC4-44CF917AB121@gmail.com> > On Oct 11, 2016, at 8:36 AM, Kevin Rushforth wrote: > > JavaFX supports SVG paths both directly and via CSS, but there is no general support for SVG. Perhaps there should be? Is there an enhancement request in JIRA? I just Worte a program that tried to get around this using WebView to render the SVG. It is more awkward than it should be, and due to an existing issue I had to use a workaround to get the background to be transparent that will surely break with Java 9. Scott From diego.cirujano-cuesta at zeiss.com Tue Oct 11 13:37:34 2016 From: diego.cirujano-cuesta at zeiss.com (Cirujano Cuesta, Diego) Date: Tue, 11 Oct 2016 13:37:34 +0000 Subject: SVG In-Reply-To: <57FCDCC8.8090307@oracle.com> References: <57FCDCC8.8090307@oracle.com> Message-ID: Hi Kevin, is there any public API that allow adding new Image formats? Thank you, Diego -----Original Message----- From: Kevin Rushforth [mailto:kevin.rushforth at oracle.com] Sent: Dienstag, 11. Oktober 2016 14:36 To: Cirujano Cuesta, Diego Cc: openjfx-dev at openjdk.java.net Subject: Re: SVG JavaFX supports SVG paths both directly and via CSS, but there is no general support for SVG. As for you other question, unless they use public API they will no longer work. Applications can export internal packages via a command line switch, but it is quite fragile and not likely to work from release to release. -- Kevin Cirujano Cuesta, Diego wrote: > Hi all, > > I was wondering why there is no javafx support to svg, is there any reason? I found nice the solution from codecentric interesting: https://github.com/codecentric/javafxsvg. But it uses com.sun.javafx.iio.ImageFormatDescription, com.sun.javafx.iio.ImageLoader, com.sun.javafx.iio.ImageStorage and com.sun.javafx.iio.ImageLoaderFactory. in openjfx9 is still there in com.sun... What's going to happen to these classes in Java 9? Is there strategy about providing ways to use them? > > Thanks! > Diego > From guru.hb at oracle.com Tue Oct 11 15:17:47 2016 From: guru.hb at oracle.com (Guru Hb) Date: Tue, 11 Oct 2016 20:47:47 +0530 Subject: SVG In-Reply-To: <63A291AC-F7D9-4A97-9EC4-44CF917AB121@gmail.com> References: <57FCDCC8.8090307@oracle.com> <63A291AC-F7D9-4A97-9EC4-44CF917AB121@gmail.com> Message-ID: <3a27fba2-931f-8a28-ca99-3cf67b530b62@oracle.com> WebView renders SVG ( WebView.getWebEngine().load("PathToSvg.svg"); ). Could you please let us know which content (SVG) failed to rendered as expected. Please file a JBS with simplified test content , will analyze. Thanks, Guru On 11/10/16 6:56 PM, Scott Palmer wrote: >> On Oct 11, 2016, at 8:36 AM, Kevin Rushforth wrote: >> >> JavaFX supports SVG paths both directly and via CSS, but there is no general support for SVG. > > Perhaps there should be? Is there an enhancement request in JIRA? > > I just Worte a program that tried to get around this using WebView to render the SVG. It is more awkward than it should be, and due to an existing issue I had to use a workaround to get the background to be transparent that will surely break with Java 9. > > Scott From tom.schindl at bestsolution.at Tue Oct 11 15:37:58 2016 From: tom.schindl at bestsolution.at (Tom Schindl) Date: Tue, 11 Oct 2016 17:37:58 +0200 Subject: SVG In-Reply-To: References: <57FCDCC8.8090307@oracle.com> Message-ID: <995fdd7b-1381-c46d-48a4-260a6ea451ac@bestsolution.at> Hi, A work around would be to use a custom protocol handler (I assume JavaFX loads the image using URL.openConnection/openStream) who loads the file, runs it through Batik and returns a stream with the rendered image. An URL might look like this: svg:file:/path/to/myfile.svg?size=16x16 and if the above assumption holds true then JavaFX does not even notice what's going on ;-) The only a caveat is that this is not working with CSS and relative URLs in there. Tom On 11.10.16 15:37, Cirujano Cuesta, Diego wrote: > Hi Kevin, > > is there any public API that allow adding new Image formats? > > Thank you, > Diego > > -----Original Message----- > From: Kevin Rushforth [mailto:kevin.rushforth at oracle.com] > Sent: Dienstag, 11. Oktober 2016 14:36 > To: Cirujano Cuesta, Diego > Cc: openjfx-dev at openjdk.java.net > Subject: Re: SVG > > JavaFX supports SVG paths both directly and via CSS, but there is no general support for SVG. > > As for you other question, unless they use public API they will no longer work. Applications can export internal packages via a command line switch, but it is quite fragile and not likely to work from release to release. > > -- Kevin > > > Cirujano Cuesta, Diego wrote: >> Hi all, >> >> I was wondering why there is no javafx support to svg, is there any reason? I found nice the solution from codecentric interesting: https://github.com/codecentric/javafxsvg. But it uses com.sun.javafx.iio.ImageFormatDescription, com.sun.javafx.iio.ImageLoader, com.sun.javafx.iio.ImageStorage and com.sun.javafx.iio.ImageLoaderFactory. in openjfx9 is still there in com.sun... What's going to happen to these classes in Java 9? Is there strategy about providing ways to use them? >> >> Thanks! >> Diego >> -- Thomas Schindl, CTO BestSolution.at EDV Systemhaus GmbH Eduard-Bodem-Gasse 5-7, A-6020 Innsbruck http://www.bestsolution.at/ Reg. Nr. FN 222302s am Firmenbuchgericht Innsbruck From swpalmer at gmail.com Tue Oct 11 16:26:21 2016 From: swpalmer at gmail.com (Scott Palmer) Date: Tue, 11 Oct 2016 12:26:21 -0400 Subject: SVG In-Reply-To: <3a27fba2-931f-8a28-ca99-3cf67b530b62@oracle.com> References: <57FCDCC8.8090307@oracle.com> <63A291AC-F7D9-4A97-9EC4-44CF917AB121@gmail.com> <3a27fba2-931f-8a28-ca99-3cf67b530b62@oracle.com> Message-ID: The issue was not related to WebView loading and rendering the SVG properly, it did. The issue is that it is currently impossible to make a WebView with a transparent background unless you use reflection and hack it. E.g.: Field f = engine.getClass().getDeclaredField(?page?); f.setAccessible(true); com.sun.webkit.WebPage page = (com.sun.webkit.WebPage) f.get(engine); page.setBackgroundColor(0); There is already a JIRA issue for this: JDK-8090547 That severely limits the ability to show SVG images in the UI. Given the prevalence of high DPI displays and the need to render images at various sizes, I think it would be great to have SVG image support in an ImageView instead of hacking it via a WebView (even if under the hood the WebEngine does the rendering). Scott > On Oct 11, 2016, at 11:17 AM, Guru Hb wrote: > > WebView renders SVG ( WebView.getWebEngine().load("PathToSvg.svg"); ). > Could you please let us know which content (SVG) failed to rendered as expected. Please file a JBS with simplified test content , will analyze. > > Thanks, > Guru > > On 11/10/16 6:56 PM, Scott Palmer wrote: >>> On Oct 11, 2016, at 8:36 AM, Kevin Rushforth wrote: >>> >>> JavaFX supports SVG paths both directly and via CSS, but there is no general support for SVG. >> >> Perhaps there should be? Is there an enhancement request in JIRA? >> >> I just Worte a program that tried to get around this using WebView to render the SVG. It is more awkward than it should be, and due to an existing issue I had to use a workaround to get the background to be transparent that will surely break with Java 9. >> >> Scott > From chris.bensen at oracle.com Tue Oct 11 16:46:14 2016 From: chris.bensen at oracle.com (Chris Bensen) Date: Tue, 11 Oct 2016 09:46:14 -0700 Subject: [9] Review request: JDK-8167496 Packager Cleanup Message-ID: <80D7C880-9698-44E3-A7F7-7D0898D646D6@oracle.com> Kevin, Just some cleanup. JIRA: https://bugs.openjdk.java.net/browse/JDK-8167496 Webrev: http://cr.openjdk.java.net/~cbensen/JDK-8167496/webrev.00/ Chris From james.graham at oracle.com Tue Oct 11 19:01:06 2016 From: james.graham at oracle.com (Jim Graham) Date: Tue, 11 Oct 2016 12:01:06 -0700 Subject: SVG In-Reply-To: <57FCDCC8.8090307@oracle.com> References: <57FCDCC8.8090307@oracle.com> Message-ID: <6c58d26b-fc82-919c-849e-ea5e32fc3084@oracle.com> Rather than try to hack around the exposure of the internal ImageLoader APIs, given the relatively small amount of glue code in that package it might be easier for them to reimplement the glue to use WritableImage... ...jim On 10/11/16 5:36 AM, Kevin Rushforth wrote: > As for you other question, unless they use public API they will no longer work. Applications can export internal > packages via a command line switch, but it is quite fragile and not likely to work from release to release. > > -- Kevin > > > Cirujano Cuesta, Diego wrote: >> Hi all, >> >> I was wondering why there is no javafx support to svg, is there any reason? I found nice the solution from codecentric >> interesting: https://github.com/codecentric/javafxsvg. But it uses com.sun.javafx.iio.ImageFormatDescription, >> com.sun.javafx.iio.ImageLoader, com.sun.javafx.iio.ImageStorage and com.sun.javafx.iio.ImageLoaderFactory. in openjfx9 >> is still there in com.sun... What's going to happen to these classes in Java 9? Is there strategy about providing ways >> to use them? >> >> Thanks! >> Diego >> From tom.schindl at bestsolution.at Tue Oct 11 19:11:10 2016 From: tom.schindl at bestsolution.at (Tom Schindl) Date: Tue, 11 Oct 2016 21:11:10 +0200 Subject: SVG In-Reply-To: <6c58d26b-fc82-919c-849e-ea5e32fc3084@oracle.com> References: <57FCDCC8.8090307@oracle.com> <6c58d26b-fc82-919c-849e-ea5e32fc3084@oracle.com> Message-ID: <8628D4F1-2490-47A9-B6BF-8E72E821279D@bestsolution.at> But that won't work for CSS Tom Von meinem iPhone gesendet > Am 11.10.2016 um 21:01 schrieb Jim Graham : > > Rather than try to hack around the exposure of the internal ImageLoader APIs, given the relatively small amount of glue code in that package it might be easier for them to reimplement the glue to use WritableImage... > > ...jim > >> On 10/11/16 5:36 AM, Kevin Rushforth wrote: >> As for you other question, unless they use public API they will no longer work. Applications can export internal >> packages via a command line switch, but it is quite fragile and not likely to work from release to release. >> >> -- Kevin >> >> >> Cirujano Cuesta, Diego wrote: >>> Hi all, >>> >>> I was wondering why there is no javafx support to svg, is there any reason? I found nice the solution from codecentric >>> interesting: https://github.com/codecentric/javafxsvg. But it uses com.sun.javafx.iio.ImageFormatDescription, >>> com.sun.javafx.iio.ImageLoader, com.sun.javafx.iio.ImageStorage and com.sun.javafx.iio.ImageLoaderFactory. in openjfx9 >>> is still there in com.sun... What's going to happen to these classes in Java 9? Is there strategy about providing ways >>> to use them? >>> >>> Thanks! >>> Diego >>> From alexander at nyssen.org Wed Oct 12 03:47:42 2016 From: alexander at nyssen.org (Alexander Nyssen) Date: Wed, 12 Oct 2016 05:47:42 +0200 Subject: Review request for 8166242: Removal of com.sun.javafx.embed.AbstractEvents In-Reply-To: <57E3CCB0.2040905@oracle.com> References: <57B9DC29-39B3-422A-B69D-7B3DAA8CD3FD@nyssen.org> <57E3CCB0.2040905@oracle.com> Message-ID: Hi Kevin, has there been any decision related to JDK-8166242 (Removal of com.sun.javafx.embed.AbstractEvents) yet? I was a bit busy the last weeks anyway, but I would still like to investigate JDK-8159227 (FXCanvas should properly forward consumption state of key events from SWT to embedded scene) for JavaFX-9 (the workaround for it is rather nasty). As the fix for JDK-8159227 would probably result in conflicts with the one for JDK-8166242, it would be good to know how you plan to proceed with JDK-8166242. Best Regards, Alexander > Am 22.09.2016 um 14:21 schrieb Kevin Rushforth : > > Hi Alexander, > > Since this is an enhancement, it needs to go through the FC extension process indicated here: > > http://openjdk.java.net/projects/jdk9/fc-extension-process > > First and foremost, we will need to assess the impact of the change and whether this is the right time to consider such a change. I note that since this does not add additional functionality, but just refactors existing functionality to be easier to maintain, we might at least consider it when/if the recently announced schedule slip for JDK 9 becomes effective. > > -- Kevin > > > Alexander Nyssen wrote: >> Hallo Kevin, Alexander Z, Vadim, >> >> I have created an initial patch for the replacement of AbstractEvents with direct usage of JavaFX representations: >> >> https://bugs.openjdk.java.net/browse/JDK-8166242 http://cr.openjdk.java.net/~anyssen/8166242/webrev.00/ >> >> Best Regards, >> Alexander From chris.bensen at oracle.com Wed Oct 12 15:44:09 2016 From: chris.bensen at oracle.com (Chris Bensen) Date: Wed, 12 Oct 2016 08:44:09 -0700 Subject: [9] Review request: JDK-8166996 "javapackager --add-modules ..." throws Exception: jdk.tools.jlink.plugin.PluginException: java.lang.module.ResolutionException: Module ... not found Message-ID: <849F95EE-3EC1-4A08-8866-13272857565E@oracle.com> Kevin, The add modules and limit modules type needs to be a string rather than a set at this point in the Java Packager. JIRA: https://bugs.openjdk.java.net/browse/JDK-8166996 Webrev: http://cr.openjdk.java.net/~cbensen/JDK-8166996/webrev.00/ Chris From markclaassenx at gmail.com Wed Oct 12 17:31:43 2016 From: markclaassenx at gmail.com (Mark Claassen) Date: Wed, 12 Oct 2016 17:31:43 +0000 Subject: SVG In-Reply-To: <8628D4F1-2490-47A9-B6BF-8E72E821279D@bestsolution.at> References: <57FCDCC8.8090307@oracle.com> <6c58d26b-fc82-919c-849e-ea5e32fc3084@oracle.com> <8628D4F1-2490-47A9-B6BF-8E72E821279D@bestsolution.at> Message-ID: I am glad to see an SVG conversation here. We are currently using apache Batik to render our SVG, but would like to move to JavaFX. The only way we found to do this is using the WebView. However, this presents some interesting challenges. We have fairly stringent printing requirements and going through the WebView for this is pretty difficult. See: "Scaling WebEngine.print output" from October 6 On Tue, Oct 11, 2016 at 3:11 PM Tom Schindl wrote: But that won't work for CSS Tom Von meinem iPhone gesendet > Am 11.10.2016 um 21:01 schrieb Jim Graham : > > Rather than try to hack around the exposure of the internal ImageLoader APIs, given the relatively small amount of glue code in that package it might be easier for them to reimplement the glue to use WritableImage... > > ...jim > >> On 10/11/16 5:36 AM, Kevin Rushforth wrote: >> As for you other question, unless they use public API they will no longer work. Applications can export internal >> packages via a command line switch, but it is quite fragile and not likely to work from release to release. >> >> -- Kevin >> >> >> Cirujano Cuesta, Diego wrote: >>> Hi all, >>> >>> I was wondering why there is no javafx support to svg, is there any reason? I found nice the solution from codecentric >>> interesting: https://github.com/codecentric/javafxsvg. But it uses com.sun.javafx.iio.ImageFormatDescription, >>> com.sun.javafx.iio.ImageLoader, com.sun.javafx.iio.ImageStorage and com.sun.javafx.iio.ImageLoaderFactory. in openjfx9 >>> is still there in com.sun... What's going to happen to these classes in Java 9? Is there strategy about providing ways >>> to use them? >>> >>> Thanks! >>> Diego >>> From chris.bensen at oracle.com Wed Oct 12 18:31:03 2016 From: chris.bensen at oracle.com (Chris Bensen) Date: Wed, 12 Oct 2016 11:31:03 -0700 Subject: [9] Review request: JDK-8148720 fx packager: in the generated jnlp file, property element should be under resources element not j2se element Message-ID: Kevin, This is a bug was introduced when the JNLP bundler was refactored to it?s own bundler. This just moves the JVM property outside the j2se section. JIRA: https://bugs.openjdk.java.net/browse/JDK-8148720 Webrev: http://cr.openjdk.java.net/~cbensen/JDK-8148720/webrev.00/ Chris From chris.bensen at oracle.com Wed Oct 12 18:38:41 2016 From: chris.bensen at oracle.com (Chris Bensen) Date: Wed, 12 Oct 2016 11:38:41 -0700 Subject: [9] Review request: JDK-8166305 Remove applet code Message-ID: Kevin, David and Alexander, Please review the removal of applet code generate from the java packager for supporting JDK7 JavaFX. JIRA: https://bugs.openjdk.java.net/browse/JDK-8166305 Webrev: http://cr.openjdk.java.net/~cbensen/JDK-8166305/webrev.00/ Chris From kevin.rushforth at oracle.com Wed Oct 12 23:29:50 2016 From: kevin.rushforth at oracle.com (Kevin Rushforth) Date: Wed, 12 Oct 2016 16:29:50 -0700 Subject: Review request for 8166242: Removal of com.sun.javafx.embed.AbstractEvents In-Reply-To: References: <57B9DC29-39B3-422A-B69D-7B3DAA8CD3FD@nyssen.org> <57E3CCB0.2040905@oracle.com> Message-ID: <57FEC76E.2080806@oracle.com> I was waiting for the revised JDK 9 schedule before addressing this (it's still being finalized). In any case, I will check with the JDK 9 release team as to whether such an RFE could be accepted. -- Kevin Alexander Nyssen wrote: > Hi Kevin, > > has there been any decision related to JDK-8166242 (Removal of > com.sun.javafx.embed.AbstractEvents) yet? I was a bit busy the last > weeks anyway, but I would still like to investigate JDK-8159227 > (FXCanvas should properly forward consumption state of key events from > SWT to embedded scene) for JavaFX-9 (the workaround for it is rather > nasty). As the fix for JDK-8159227 would probably result in conflicts > with the one for JDK-8166242, it would be good to know how you plan to > proceed with JDK-8166242. > > Best Regards, > Alexander > >> Am 22.09.2016 um 14:21 schrieb Kevin Rushforth >> >: >> >> Hi Alexander, >> >> Since this is an enhancement, it needs to go through the FC extension >> process indicated here: >> >> http://openjdk.java.net/projects/jdk9/fc-extension-process >> >> First and foremost, we will need to assess the impact of the change >> and whether this is the right time to consider such a change. I note >> that since this does not add additional functionality, but just >> refactors existing functionality to be easier to maintain, we might >> at least consider it when/if the recently announced schedule slip for >> JDK 9 becomes effective. >> >> -- Kevin >> >> >> Alexander Nyssen wrote: >>> Hallo Kevin, Alexander Z, Vadim, >>> >>> I have created an initial patch for the replacement of >>> AbstractEvents with direct usage of JavaFX representations: >>> >>> https://bugs.openjdk.java.net/browse/JDK-8166242 >>> http://cr.openjdk.java.net/~anyssen/8166242/webrev.00/ >>> >>> Best Regards, >>> Alexander > From David.Hill at Oracle.com Thu Oct 13 16:14:31 2016 From: David.Hill at Oracle.com (David Hill) Date: Thu, 13 Oct 2016 12:14:31 -0400 Subject: review: remove unused imports Message-ID: <57FFB2E7.80304@Oracle.com> Kevin, Two JBS, same issue. https://bugs.openjdk.java.net/browse/JDK-8167520 https://bugs.openjdk.java.net/browse/JDK-8167522 one line diffs in the description Both of these cause compile/runtime issues with a modular build, and are currently unused anyway. -- David Hill Java Embedded Development "A man's feet should be planted in his country, but his eyes should survey the world." -- George Santayana (1863 - 1952) From vadim.pakhnushev at oracle.com Fri Oct 14 14:35:58 2016 From: vadim.pakhnushev at oracle.com (Vadim Pakhnushev) Date: Fri, 14 Oct 2016 17:35:58 +0300 Subject: In(Sanity) Testing Mondays Message-ID: Reminder, Monday is our weekly sanity testing. You can find your testing assignment at: https://wiki.openjdk.java.net/display/OpenJFX/Sanity+Testing Also please remember that the repo will be locked from 1am PST until 1pm PST. Happy testing! Thanks, Vadim From bourges.laurent at gmail.com Sat Oct 15 12:05:33 2016 From: bourges.laurent at gmail.com (=?UTF-8?Q?Laurent_Bourg=C3=A8s?=) Date: Sat, 15 Oct 2016 14:05:33 +0200 Subject: Fwd: Re: Marlin-Renderer and JavaFX In-Reply-To: References: <9a8200b7-459d-910e-813e-24413ddc4d92@oracle.com> <5c64b983-f482-b382-1a1d-9b7465bf115f@oracle.com> Message-ID: Hi, I am pleased to announce the new MarlinFX project I released 2 days ago (GPL v2): https://github.com/bourgesl/marlin-fx MarlinFX is the JavaFX port of the Marlin renderer (scanline rasterizer integrated in OpenJDK9) aimed to be faster than Open/Native Pisces (notably for very complex paths: merge sort + optimized array copies and cleanup). I tested in on both linux & windows 64bits (server JVM) and it is at least as fast as OpenPisces or faster (javafx shape rasterization is single threaded up to now but marlin scales very well). Of course, it is always faster than native pisces on my machines. For the DemoFX sierpinski test: - native pisces = 130fps - open pisces = 150fps - marlin-fx = 325fps This test renders a very complex path so marlin-fx rocks in hard rendering cases. See https://github.com/chriswhocodes/DemoFX Another DemoFX test (stars): - open pisces: stars = 170 fps - marlin-fx: stars = 259 fps This test case is very simple: see https://www.youtube.com/watch?v=N1rihYA8c2M Setup: laptop zbook-15 (i7 4800 + nvidia Quadro K610M) on ubuntu 16.4 + Oracle JDK 1.8.0_b102 (javafx) - VSYNC: OFF Of course, there is lot of potential improvements in the JavaFX pipeline... (multi-threading, inner/outer strokes...) Finally I made a first step, and more benchmarks or test cases are needed (I could port my MapBench tool) to get some realistic data. Then how to go next, as there is no way to plug in such marlinFX in JavaFX ... Could you have a look at the code (on my github) ? I can make a webrev between openjfx and open jdk 9 if you prefer. Cheers, Laurent From kevin.rushforth at oracle.com Sat Oct 15 16:15:34 2016 From: kevin.rushforth at oracle.com (Kevin Rushforth) Date: Sat, 15 Oct 2016 09:15:34 -0700 Subject: Fwd: Re: Marlin-Renderer and JavaFX In-Reply-To: References: <9a8200b7-459d-910e-813e-24413ddc4d92@oracle.com> <5c64b983-f482-b382-1a1d-9b7465bf115f@oracle.com> Message-ID: <58025626.8080900@oracle.com> Hi Laruent, This sounds promising. I looks forward to taking it for a test drive. Besides asking other people to help you evaluate it and test it (which you just did), the next step would be for you to file a JEP for javafx/graphics as you did earlier for client-libs/java2d. It seems like something we might consider for JDK 10, once the JDK 10 project is open and we start scoping it. -- Kevin Laurent Bourg?s wrote: > Hi, > > I am pleased to announce the new MarlinFX project I released 2 days ago > (GPL v2): > https://github.com/bourgesl/marlin-fx > > MarlinFX is the JavaFX port of the Marlin renderer (scanline rasterizer > integrated in OpenJDK9) aimed to be faster than Open/Native Pisces (notably > for very complex paths: merge sort + optimized array copies and cleanup). > > I tested in on both linux & windows 64bits (server JVM) and it is at least > as fast as OpenPisces or faster (javafx shape rasterization is single > threaded up to now but marlin scales very well). Of course, it is always > faster than native pisces on my machines. > > For the DemoFX sierpinski test: > - native pisces = 130fps > - open pisces = 150fps > - marlin-fx = 325fps > This test renders a very complex path so marlin-fx rocks in hard rendering > cases. > See https://github.com/chriswhocodes/DemoFX > > Another DemoFX test (stars): > - open pisces: > stars = 170 fps > - marlin-fx: > stars = 259 fps > This test case is very simple: see > https://www.youtube.com/watch?v=N1rihYA8c2M > > Setup: laptop zbook-15 (i7 4800 + nvidia Quadro K610M) on ubuntu 16.4 + > Oracle JDK 1.8.0_b102 (javafx) - VSYNC: OFF > > Of course, there is lot of potential improvements in the JavaFX pipeline... > (multi-threading, inner/outer strokes...) > > Finally I made a first step, and more benchmarks or test cases are needed > (I could port my MapBench tool) to get some realistic data. > > Then how to go next, as there is no way to plug in such marlinFX in JavaFX > ... > > Could you have a look at the code (on my github) ? > I can make a webrev between openjfx and open jdk 9 if you prefer. > > Cheers, > Laurent > From bourges.laurent at gmail.com Sat Oct 15 17:31:53 2016 From: bourges.laurent at gmail.com (=?UTF-8?Q?Laurent_Bourg=C3=A8s?=) Date: Sat, 15 Oct 2016 19:31:53 +0200 Subject: Fwd: Re: Marlin-Renderer and JavaFX In-Reply-To: <58025626.8080900@oracle.com> References: <9a8200b7-459d-910e-813e-24413ddc4d92@oracle.com> <5c64b983-f482-b382-1a1d-9b7465bf115f@oracle.com> <58025626.8080900@oracle.com> Message-ID: Hi Kevin, > This sounds promising. I looks forward to taking it for a test drive. Thanks for your feedback. Could you share benchmark tools ? Or at least your results. I also tested marlinFX with large texts and it rocks. See https://bugs.openjdk.java.net/browse/JDK-8090461 > Besides asking other people to help you evaluate it and test it (which you just did), the next step would be for you to file a JEP for javafx/graphics as you did earlier for client-libs/java2d. It seems like something we might consider for JDK 10, once the JDK 10 project is open and we start scoping it. I know that process which is very slow and time consuming: marlin JEP265 was submitted in july 2015, integrated in dec 2015, few improvements after but still unreleased as OpenJDK9 should be GA in july 2017 !! It took me few evenings to make MarlinFX (some cleanup work remains but only few days of work) and I fear that jdk10 will be released in 2020 so this timescale is just too far for me, as all this work will be done for free and consume my spare time. Moreover I would hope GPU could perform the rasterization at that date (opencl, panama project...) Could somebody else endorse / sponsor this new OpenJFX JEP and help to make it ready for jdk9 (new JEPs are still acceptable). Of course I will not vanish but just focus on coding + testing improvements. Regards, Laurent From markus at headcrashing.eu Sun Oct 16 06:53:47 2016 From: markus at headcrashing.eu (Markus KARG) Date: Sun, 16 Oct 2016 08:53:47 +0200 Subject: Fwd: Re: Marlin-Renderer and JavaFX In-Reply-To: References: <9a8200b7-459d-910e-813e-24413ddc4d92@oracle.com> <5c64b983-f482-b382-1a1d-9b7465bf115f@oracle.com> <58025626.8080900@oracle.com> Message-ID: <000301d2277a$0e358e90$2aa0abb0$@eu> Laurent, the problem is that OpenJDK 9's feature set is already fixed, so I think it is not possible to *officially* adopt huge features like Marlin FX at such a "late" point. Besides that I think that Marlin FX is of so high value to OpenJDK that I would like to nominate you as an OpenJDK committer. But that is up to Kevin to decide, certainly! I don't know the internal structure of that part of JavaFX, but maybe Kevin could point us to some private APIs or config options one could use to allow anybody to simply bundle Marlin FX as an alternativ renderer with any JavaFX 8 or 9 application? -Markus -----Original Message----- From: openjfx-dev [mailto:openjfx-dev-bounces at openjdk.java.net] On Behalf Of Laurent Bourg?s Sent: Samstag, 15. Oktober 2016 19:32 To: Kevin Rushforth Cc: Jim Graham; openjfx-dev at openjdk.java.net Subject: Re: Fwd: Re: Marlin-Renderer and JavaFX Hi Kevin, > This sounds promising. I looks forward to taking it for a test drive. Thanks for your feedback. Could you share benchmark tools ? Or at least your results. I also tested marlinFX with large texts and it rocks. See https://bugs.openjdk.java.net/browse/JDK-8090461 > Besides asking other people to help you evaluate it and test it (which you just did), the next step would be for you to file a JEP for javafx/graphics as you did earlier for client-libs/java2d. It seems like something we might consider for JDK 10, once the JDK 10 project is open and we start scoping it. I know that process which is very slow and time consuming: marlin JEP265 was submitted in july 2015, integrated in dec 2015, few improvements after but still unreleased as OpenJDK9 should be GA in july 2017 !! It took me few evenings to make MarlinFX (some cleanup work remains but only few days of work) and I fear that jdk10 will be released in 2020 so this timescale is just too far for me, as all this work will be done for free and consume my spare time. Moreover I would hope GPU could perform the rasterization at that date (opencl, panama project...) Could somebody else endorse / sponsor this new OpenJFX JEP and help to make it ready for jdk9 (new JEPs are still acceptable). Of course I will not vanish but just focus on coding + testing improvements. Regards, Laurent From bourges.laurent at gmail.com Sun Oct 16 07:29:05 2016 From: bourges.laurent at gmail.com (=?UTF-8?Q?Laurent_Bourg=C3=A8s?=) Date: Sun, 16 Oct 2016 09:29:05 +0200 Subject: Fwd: Re: Marlin-Renderer and JavaFX In-Reply-To: <000301d2277a$0e358e90$2aa0abb0$@eu> References: <9a8200b7-459d-910e-813e-24413ddc4d92@oracle.com> <5c64b983-f482-b382-1a1d-9b7465bf115f@oracle.com> <58025626.8080900@oracle.com> <000301d2277a$0e358e90$2aa0abb0$@eu> Message-ID: Mark, > Laurent, the problem is that OpenJDK 9's feature set is already fixed, so I think it is not possible to *officially* adopt huge features like Marlin FX at such a "late" point. Besides that I think that Marlin FX is of so high value to OpenJDK that I would like to nominate you as an OpenJDK committer. But that is up to Kevin to decide, certainly! OpenJDK9 is currently in the Feature Complete extension-request process so it seems possible to submit a new JEP with very small impact and risk. As marlin-fx is very close to the integrated Marlin renderer in OpenJDK9, the risk is small for me but there will be certainly issues with jigsaw modularization of OpenJFX: MarlinFX uses jdk Unsafe for example. Moreover, integrating such JEP would imply to hurry up to be completed for dec 2016 ! FYI I am already jdk9 commiter in the client forrest but not in openjfx. > I don't know the internal structure of that part of JavaFX, but maybe Kevin could point us to some private APIs or config options one could use to allow anybody to simply bundle Marlin FX as an alternativ renderer with any JavaFX 8 or 9 application? It is certainly tricky due to classloader isolation and modules... but there is certainly some workaround. Cheers, Laurent From kevin.rushforth at oracle.com Mon Oct 17 14:41:45 2016 From: kevin.rushforth at oracle.com (Kevin Rushforth) Date: Mon, 17 Oct 2016 07:41:45 -0700 Subject: Fwd: Re: Marlin-Renderer and JavaFX In-Reply-To: References: <9a8200b7-459d-910e-813e-24413ddc4d92@oracle.com> <5c64b983-f482-b382-1a1d-9b7465bf115f@oracle.com> <58025626.8080900@oracle.com> <000301d2277a$0e358e90$2aa0abb0$@eu> Message-ID: <5804E329.9040609@oracle.com> Hi Laurent, Sure, we will share any benchmark results we have, although we likely won't have too much time to spend on it in the near term, since we are busily fixing bugs for JDK 9. As for getting this into JDK 9, it is way too late for something of this scope. We are already past feature freeze and are now in bug fix and stabilization mode. Yes, there is a process where a few small enhancements might be considered [1], but even those require JDK 9 release team approval, which is very unlikely for anything that rises to the level of a new feature. I hope JDK 10 won't take as long as JDK 9 is taking, but as there isn't a proposed JDK 10 project yet, we don't know the timeline. I expect we will know more in the next couple of months. With strong encapsulation, the only way to access internal implementation classes is via a command-line switch to add qualified exports for the internal packages that you access. Note that any such use of internal packages is fragile and could break at any time, but is an option for applications that bundle a specific version of the JRE. -- Kevin [1] http://openjdk.java.net/projects/jdk9/fc-extension-process Laurent Bourg?s wrote: > > Mark, > > > Laurent, the problem is that OpenJDK 9's feature set is already > fixed, so I think it is not possible to *officially* adopt huge > features like Marlin FX at such a "late" point. Besides that I think > that Marlin FX is of so high value to OpenJDK that I would like to > nominate you as an OpenJDK committer. But that is up to Kevin to > decide, certainly! > > OpenJDK9 is currently in the Feature Complete extension-request > process so it seems possible to submit a new JEP with very small > impact and risk. > As marlin-fx is very close to the integrated Marlin renderer in > OpenJDK9, the risk is small for me but there will be certainly issues > with jigsaw modularization of OpenJFX: MarlinFX uses jdk Unsafe for > example. Moreover, integrating such JEP would imply to hurry up to be > completed for dec 2016 ! > > FYI I am already jdk9 commiter in the client forrest but not in openjfx. > > > I don't know the internal structure of that part of JavaFX, but > maybe Kevin could point us to some private APIs or config options one > could use to allow anybody to simply bundle Marlin FX as an alternativ > renderer with any JavaFX 8 or 9 application? > > It is certainly tricky due to classloader isolation and modules... but > there is certainly some workaround. > > Cheers, > Laurent > From sven.reimers at gmail.com Mon Oct 17 14:59:04 2016 From: sven.reimers at gmail.com (Sven Reimers) Date: Mon, 17 Oct 2016 16:59:04 +0200 Subject: Fwd: Re: Marlin-Renderer and JavaFX In-Reply-To: <5804E329.9040609@oracle.com> References: <9a8200b7-459d-910e-813e-24413ddc4d92@oracle.com> <5c64b983-f482-b382-1a1d-9b7465bf115f@oracle.com> <58025626.8080900@oracle.com> <000301d2277a$0e358e90$2aa0abb0$@eu> <5804E329.9040609@oracle.com> Message-ID: Seeing that there is JEP about AOT showing a 9 in the release number just published, Marlin-Renderer should not be so big... -Sven Am 17.10.2016 16:42 schrieb "Kevin Rushforth" : > Hi Laurent, > > Sure, we will share any benchmark results we have, although we likely > won't have too much time to spend on it in the near term, since we are > busily fixing bugs for JDK 9. As for getting this into JDK 9, it is way too > late for something of this scope. We are already past feature freeze and > are now in bug fix and stabilization mode. Yes, there is a process where a > few small enhancements might be considered [1], but even those require JDK > 9 release team approval, which is very unlikely for anything that rises to > the level of a new feature. > > I hope JDK 10 won't take as long as JDK 9 is taking, but as there isn't a > proposed JDK 10 project yet, we don't know the timeline. I expect we will > know more in the next couple of months. > > With strong encapsulation, the only way to access internal implementation > classes is via a command-line switch to add qualified exports for the > internal packages that you access. Note that any such use of internal > packages is fragile and could break at any time, but is an option for > applications that bundle a specific version of the JRE. > > -- Kevin > > [1] http://openjdk.java.net/projects/jdk9/fc-extension-process > > Laurent Bourg?s wrote: > >> >> Mark, >> >> > Laurent, the problem is that OpenJDK 9's feature set is already fixed, >> so I think it is not possible to *officially* adopt huge features like >> Marlin FX at such a "late" point. Besides that I think that Marlin FX is of >> so high value to OpenJDK that I would like to nominate you as an OpenJDK >> committer. But that is up to Kevin to decide, certainly! >> >> OpenJDK9 is currently in the Feature Complete extension-request process >> so it seems possible to submit a new JEP with very small impact and risk. >> As marlin-fx is very close to the integrated Marlin renderer in OpenJDK9, >> the risk is small for me but there will be certainly issues with jigsaw >> modularization of OpenJFX: MarlinFX uses jdk Unsafe for example. Moreover, >> integrating such JEP would imply to hurry up to be completed for dec 2016 ! >> >> FYI I am already jdk9 commiter in the client forrest but not in openjfx. >> >> > I don't know the internal structure of that part of JavaFX, but maybe >> Kevin could point us to some private APIs or config options one could use >> to allow anybody to simply bundle Marlin FX as an alternativ renderer with >> any JavaFX 8 or 9 application? >> >> It is certainly tricky due to classloader isolation and modules... but >> there is certainly some workaround. >> >> Cheers, >> Laurent >> >> From chris.bensen at oracle.com Tue Oct 18 18:28:49 2016 From: chris.bensen at oracle.com (Chris Bensen) Date: Tue, 18 Oct 2016 11:28:49 -0700 Subject: [9] Review request: JDK-8167973 Absolute path for module-path is not working when trying to execute javapackager from other drive in CLI Message-ID: <2B7E549B-3018-495A-9DBF-E107CACF1AB5@oracle.com> Kevin, Please review this change to fix the path separate for Windows. JIRA: https://bugs.openjdk.java.net/browse/JDK-8167973 Webrev: http://cr.openjdk.java.net/~cbensen/JDK-8167973/webrev.00/ Chris From vadim.pakhnushev at oracle.com Tue Oct 18 19:34:06 2016 From: vadim.pakhnushev at oracle.com (Vadim Pakhnushev) Date: Tue, 18 Oct 2016 22:34:06 +0300 Subject: [9] Review request for 8166847: NumberAxis: sticked numbers sometimes Message-ID: Hi Jonathan, Could you please review the fix: https://bugs.openjdk.java.net/browse/JDK-8166847 http://cr.openjdk.java.net/~vadim/8166847/webrev.00/ Thanks, Vadim From kevin.rushforth at oracle.com Tue Oct 18 20:02:31 2016 From: kevin.rushforth at oracle.com (Kevin Rushforth) Date: Tue, 18 Oct 2016 13:02:31 -0700 Subject: Changes for October 2016 CPU release (8u111/8u112) synced into FX 8u-dev Message-ID: <58067FD7.1050807@oracle.com> I have synced the OpenJFX changes from the just-released October 2016 CPU release (8u111/8u112) into 8u. Here is a webrev of the FX 8u112 changes for those who are interested in the changes, but don't want to wade through the separate changesets I just pushed (most of which are tag or merge changesets). http://cr.openjdk.java.net/~kcr/8u112-8u-sync/webrev/ There are no changes for 9 this time. -- Kevin From swpalmer at gmail.com Tue Oct 18 20:16:07 2016 From: swpalmer at gmail.com (Scott Palmer) Date: Tue, 18 Oct 2016 16:16:07 -0400 Subject: javapacker's iconswap flagged as malware Message-ID: Just tried to run a build on Windows 10 with 8u112 and got this: Exception: java.io.IOException: Cannot run program "C:\Users\spalmer\AppData\Local\Temp\iconswap2930071229376508731.exe": CreateProcess error=225, Operation did not complete successfully because the file contains a virus or potentially unwanted software Windows Defender quarantined the file. It listed it and the launcher .exe for my application as threats: Trojan:Win32/Detplock Trojan:Win32/Repjexi I had to explicitly go into Windows Defender and pick "Allow Item" to get the build to succeed. After that subsequent scans of the created launcher .exe with Windows Defender came back clean. Are you aware of this issue? I didn't see anything in Jira but I can't recall if I ever needed to bypass this check before. Regards, Scott From jonathan.giles at oracle.com Tue Oct 18 21:45:57 2016 From: jonathan.giles at oracle.com (Jonathan Giles) Date: Wed, 19 Oct 2016 10:45:57 +1300 Subject: [9] Review request: 8168258: Remove bad Javadoc links in skin constructors Message-ID: <48410dce-82da-d8e1-b44a-2fd7b658e2f9@oracle.com> Kevin, Could you please review the following webrev. This is a docs-only change. https://bugs.openjdk.java.net/browse/JDK-8168258 http://cr.openjdk.java.net/~jgiles/8168258 Thanks. -- -- Jonathan From chris.bensen at oracle.com Tue Oct 18 22:47:37 2016 From: chris.bensen at oracle.com (Chris Bensen) Date: Tue, 18 Oct 2016 15:47:37 -0700 Subject: javapacker's iconswap flagged as malware In-Reply-To: References: Message-ID: <6AE77627-13E7-421A-9941-C3D5CFCBB56D@oracle.com> Hi Scott, I?m not actively running Windows 10 and last time I did run the Java Packager under Windows 10 it worked just fine so this is new behavior within I?d say the last 6 months. Feel free to file a bug, but I?m not sure there?s anything that can be done from the JDK side. Thanks, Chris > On Oct 18, 2016, at 1:16 PM, Scott Palmer wrote: > > Just tried to run a build on Windows 10 with 8u112 and got this: > > Exception: java.io.IOException: Cannot run program > "C:\Users\spalmer\AppData\Local\Temp\iconswap2930071229376508731.exe": > CreateProcess error=225, Operation did not complete successfully because > the file contains a virus or potentially unwanted software > > Windows Defender quarantined the file. It listed it and the launcher .exe > for my application as threats: > Trojan:Win32/Detplock > Trojan:Win32/Repjexi > > > I had to explicitly go into Windows Defender and pick "Allow Item" to get > the build to succeed. > > After that subsequent scans of the created launcher .exe with Windows > Defender came back clean. > > Are you aware of this issue? I didn't see anything in Jira but I can't > recall if I ever needed to bypass this check before. > > Regards, > > Scott From james.graham at oracle.com Wed Oct 19 00:53:18 2016 From: james.graham at oracle.com (Jim Graham) Date: Tue, 18 Oct 2016 17:53:18 -0700 Subject: [9] Review request: 8166382 [hidpi] Ubuntu 16.04: invalid coordinates when using glass robot Message-ID: <5f4a24df-ed1a-8f56-58a4-fcf132e9bac2@oracle.com> JBS: https://bugs.openjdk.java.net/browse/JDK-8166382 webrev: http://cr.openjdk.java.net/~flar/JDK-8166382/webrev.00/ Pretty self-explanatory fix... ...jim From davide.malpassini at gmail.com Tue Oct 18 10:47:04 2016 From: davide.malpassini at gmail.com (Davide Malpassini) Date: Tue, 18 Oct 2016 12:47:04 +0200 Subject: Fwd: Re: Marlin-Renderer and JavaFX Message-ID: I think that Marlin-Renderer can be included not as a default renderer to limit the impact to the jdk9 release , but leave to the user / developer the possibility to use and test on real applications the benefit of this Renderer . This is only an user opinion , but i think that the benefits are big. Davide Malpassini From kevin.rushforth at oracle.com Wed Oct 19 12:34:02 2016 From: kevin.rushforth at oracle.com (Kevin Rushforth) Date: Wed, 19 Oct 2016 05:34:02 -0700 Subject: Fwd: Re: Marlin-Renderer and JavaFX In-Reply-To: References: Message-ID: <5807683A.8020400@oracle.com> Jim Graham suggested the same thing to me privately, so he and Laurent are currently looking into that possibility. -- Kevin Davide Malpassini wrote: > I think that Marlin-Renderer can be included not as a default renderer to > limit the impact to the jdk9 release , but leave to the user / developer > the possibility to use and test on real applications the benefit of this > Renderer . > > This is only an user opinion , but i think that the benefits are big. > Davide Malpassini > From mp at jugs.org Wed Oct 19 13:07:04 2016 From: mp at jugs.org (Michael Paus) Date: Wed, 19 Oct 2016 15:07:04 +0200 Subject: Fwd: Re: Marlin-Renderer and JavaFX In-Reply-To: <5807683A.8020400@oracle.com> References: <5807683A.8020400@oracle.com> Message-ID: I'd appreciate such a solution too. Michael Am 19.10.16 um 14:34 schrieb Kevin Rushforth: > Jim Graham suggested the same thing to me privately, so he and Laurent > are currently looking into that possibility. > > -- Kevin > > > Davide Malpassini wrote: >> I think that Marlin-Renderer can be included not as a default >> renderer to >> limit the impact to the jdk9 release , but leave to the user / developer >> the possibility to use and test on real applications the benefit of this >> Renderer . >> >> This is only an user opinion , but i think that the benefits are big. >> Davide Malpassini From markus at headcrashing.eu Wed Oct 19 15:16:03 2016 From: markus at headcrashing.eu (Markus KARG) Date: Wed, 19 Oct 2016 17:16:03 +0200 Subject: Fwd: Re: Marlin-Renderer and JavaFX In-Reply-To: References: <5807683A.8020400@oracle.com> Message-ID: <004601d22a1b$b88d3070$29a79150$@eu> Michael, note that Marlin FX still is fully software rendering, while you asked for more hardware rendering recently. The latter will be an additional approach not targeted yet by Marlin FX. -Markus -----Original Message----- From: openjfx-dev [mailto:openjfx-dev-bounces at openjdk.java.net] On Behalf Of Michael Paus Sent: Mittwoch, 19. Oktober 2016 15:07 To: openjfx-dev at openjdk.java.net Subject: Re: Fwd: Re: Marlin-Renderer and JavaFX I'd appreciate such a solution too. Michael Am 19.10.16 um 14:34 schrieb Kevin Rushforth: > Jim Graham suggested the same thing to me privately, so he and Laurent > are currently looking into that possibility. > > -- Kevin > > > Davide Malpassini wrote: >> I think that Marlin-Renderer can be included not as a default >> renderer to limit the impact to the jdk9 release , but leave to the >> user / developer the possibility to use and test on real applications >> the benefit of this Renderer . >> >> This is only an user opinion , but i think that the benefits are big. >> Davide Malpassini From mp at jugs.org Thu Oct 20 07:44:13 2016 From: mp at jugs.org (Michael Paus) Date: Thu, 20 Oct 2016 09:44:13 +0200 Subject: Fwd: Re: Marlin-Renderer and JavaFX In-Reply-To: <004601d22a1b$b88d3070$29a79150$@eu> References: <5807683A.8020400@oracle.com> <004601d22a1b$b88d3070$29a79150$@eu> Message-ID: I know, but JavaFX is still doing a lot of software rendering and I doubt that this will change in the near future. So having at least the option to use MarlinFX instead of the current default renderer may be a advantage especially when multithreading is enabled. Michael Am 19.10.16 um 17:16 schrieb Markus KARG: > Michael, note that Marlin FX still is fully software rendering, while you asked for more hardware rendering recently. The latter will be an additional approach not targeted yet by Marlin FX. > -Markus > > -----Original Message----- > From: openjfx-dev [mailto:openjfx-dev-bounces at openjdk.java.net] On Behalf Of Michael Paus > Sent: Mittwoch, 19. Oktober 2016 15:07 > To: openjfx-dev at openjdk.java.net > Subject: Re: Fwd: Re: Marlin-Renderer and JavaFX > > I'd appreciate such a solution too. > > Michael > > Am 19.10.16 um 14:34 schrieb Kevin Rushforth: >> Jim Graham suggested the same thing to me privately, so he and Laurent >> are currently looking into that possibility. >> >> -- Kevin >> >> >> Davide Malpassini wrote: >>> I think that Marlin-Renderer can be included not as a default >>> renderer to limit the impact to the jdk9 release , but leave to the >>> user / developer the possibility to use and test on real applications >>> the benefit of this Renderer . >>> >>> This is only an user opinion , but i think that the benefits are big. >>> Davide Malpassini > > From bourges.laurent at gmail.com Thu Oct 20 11:37:08 2016 From: bourges.laurent at gmail.com (=?UTF-8?Q?Laurent_Bourg=C3=A8s?=) Date: Thu, 20 Oct 2016 13:37:08 +0200 Subject: Fwd: Re: Marlin-Renderer and JavaFX In-Reply-To: References: <5807683A.8020400@oracle.com> <004601d22a1b$b88d3070$29a79150$@eu> Message-ID: Michael, > I know, but JavaFX is still doing a lot of software rendering and I doubt that this will change > in the near future. So having at least the option to use MarlinFX instead of the current > default renderer may be a advantage especially when multithreading is enabled. Thanks for your positive feedback that motivates me to make the job to integrate the marlin renderer in the JavaFX pipeline. For now the OpenPiscesRasterizer class uses a static Renderer (single instance) so it is single-threaded. In MarlinFX I could prepare the multi-threading support by using 1 RendererContext per thread (ThreadLocal) as I did in Marlin for java2d. However it seems a complex task to enable parallelization in the javafx pipeline but I could help there also... Cheers, Laurent > Michael > > Am 19.10.16 um 17:16 schrieb Markus KARG: > >> Michael, note that Marlin FX still is fully software rendering, while you asked for more hardware rendering recently. The latter will be an additional approach not targeted yet by Marlin FX. >> -Markus >> >> -----Original Message----- >> From: openjfx-dev [mailto:openjfx-dev-bounces at openjdk.java.net] On Behalf Of Michael Paus >> Sent: Mittwoch, 19. Oktober 2016 15:07 >> To: openjfx-dev at openjdk.java.net >> Subject: Re: Fwd: Re: Marlin-Renderer and JavaFX >> >> I'd appreciate such a solution too. >> >> Michael >> >> Am 19.10.16 um 14:34 schrieb Kevin Rushforth: >>> >>> Jim Graham suggested the same thing to me privately, so he and Laurent >>> are currently looking into that possibility. >>> >>> -- Kevin >>> >>> >>> Davide Malpassini wrote: >>>> >>>> I think that Marlin-Renderer can be included not as a default >>>> renderer to limit the impact to the jdk9 release , but leave to the >>>> user / developer the possibility to use and test on real applications >>>> the benefit of this Renderer . >>>> >>>> This is only an user opinion , but i think that the benefits are big. >>>> Davide Malpassini >> >> >> > From kevin.rushforth at oracle.com Thu Oct 20 12:34:26 2016 From: kevin.rushforth at oracle.com (Kevin Rushforth) Date: Thu, 20 Oct 2016 05:34:26 -0700 Subject: Fwd: Re: Marlin-Renderer and JavaFX In-Reply-To: References: <5807683A.8020400@oracle.com> <004601d22a1b$b88d3070$29a79150$@eu> Message-ID: <5808B9D2.30909@oracle.com> Laurent Bourg?s wrote: > Michael, > > >> I know, but JavaFX is still doing a lot of software rendering and I doubt >> > that this will change > >> in the near future. So having at least the option to use MarlinFX instead >> > of the current > >> default renderer may be a advantage especially when multithreading is >> > enabled. > > Thanks for your positive feedback that motivates me to make the job to > integrate the marlin renderer in the JavaFX pipeline. > Early benchmark results look very promising, too. > For now the OpenPiscesRasterizer class uses a static Renderer (single > instance) so it is single-threaded. > > In MarlinFX I could prepare the multi-threading support by using 1 > RendererContext per thread (ThreadLocal) as I did in Marlin for java2d. > > However it seems a complex task to enable parallelization in the javafx > pipeline but I could help there also... > Enabling parallel rasterization seems like a good follow-on task, but is out of scope for the short term given the limited amount of time. Also, the only way that MarlinFX even has a chance of getting approved for in JDK 9 is for the default OpenPisces path to be unaltered. -- Kevin > Cheers, > Laurent > > >> Michael >> >> Am 19.10.16 um 17:16 schrieb Markus KARG: >> >> >>> Michael, note that Marlin FX still is fully software rendering, while >>> > you asked for more hardware rendering recently. The latter will be an > additional approach not targeted yet by Marlin FX. > >>> -Markus >>> >>> -----Original Message----- >>> From: openjfx-dev [mailto:openjfx-dev-bounces at openjdk.java.net] On >>> > Behalf Of Michael Paus > >>> Sent: Mittwoch, 19. Oktober 2016 15:07 >>> To: openjfx-dev at openjdk.java.net >>> Subject: Re: Fwd: Re: Marlin-Renderer and JavaFX >>> >>> I'd appreciate such a solution too. >>> >>> Michael >>> >>> Am 19.10.16 um 14:34 schrieb Kevin Rushforth: >>> >>>> Jim Graham suggested the same thing to me privately, so he and Laurent >>>> are currently looking into that possibility. >>>> >>>> -- Kevin >>>> >>>> >>>> Davide Malpassini wrote: >>>> >>>>> I think that Marlin-Renderer can be included not as a default >>>>> renderer to limit the impact to the jdk9 release , but leave to the >>>>> user / developer the possibility to use and test on real applications >>>>> the benefit of this Renderer . >>>>> >>>>> This is only an user opinion , but i think that the benefits are big. >>>>> Davide Malpassini >>>>> >>> >>> From vadim.pakhnushev at oracle.com Fri Oct 21 14:30:23 2016 From: vadim.pakhnushev at oracle.com (Vadim Pakhnushev) Date: Fri, 21 Oct 2016 17:30:23 +0300 Subject: In(Sanity) Testing Mondays Message-ID: Reminder, Monday is our weekly sanity testing. You can find your testing assignment at: https://wiki.openjdk.java.net/display/OpenJFX/Sanity+Testing Also please remember that the repo will be locked from 1am PST until 1pm PST. Happy testing! Thanks, Vadim From bourges.laurent at gmail.com Fri Oct 21 16:51:45 2016 From: bourges.laurent at gmail.com (=?UTF-8?Q?Laurent_Bourg=C3=A8s?=) Date: Fri, 21 Oct 2016 18:51:45 +0200 Subject: Fwd: Re: Marlin-Renderer and JavaFX In-Reply-To: <5808B9D2.30909@oracle.com> References: <5807683A.8020400@oracle.com> <004601d22a1b$b88d3070$29a79150$@eu> <5808B9D2.30909@oracle.com> Message-ID: Hi, Some new from the Marlin sides: - Marlin (java2d) for openjdk9: I backported changes from openpisces Dasher and Stroker classes + optimized the tile filling for almost empty / full tiles = 10% gain on huge shapes. I plan to provide new webrevs soon - Marlin FX: I implemented a new RendererNoAA class that optimize the nonAA case and started refactoring the integration (try/dispose). It remains to adjust the NaN coordinate filter + transformer. Jim, do you think possible to unify Marlin and MarlinFX for openjdk9 ? The main difference relies in different Shape/PathConsumer classes and Fx uses the AlphaConsumer + different initialization. Did you have a look at the diffs ? I also ported my java2d.Path2d improvements (growing algo + copy constructor) to javafx.Path2d as it suffers the same performance issue when the path grows... I fixed 2 years ago. > Early benchmark results look very promising, too. Yes and I will experience using Unsafe or DirectByteBuffer + my "block flag" optimization soon to optimize the coverage copies into the texture buffer... > Enabling parallel rasterization seems like a good follow-on task, but is out of scope for the short term given the limited amount of time. Also, the only way that MarlinFX even has a chance of getting approved for in JDK 9 is for the default OpenPisces path to be unaltered. Of course, MT rendering is out of my scope as I am running a sprint to provide Marlin for OpenJFX9... Any guideline or volunteers to help making it real ? Finally does somebody tested MarlinFX with real applications ? Cheers, Laurent From kevin.rushforth at oracle.com Mon Oct 24 21:14:25 2016 From: kevin.rushforth at oracle.com (Kevin Rushforth) Date: Mon, 24 Oct 2016 14:14:25 -0700 Subject: [8u] Review request: Backport various Ensemble8 bug fixes to 8u Message-ID: <580E79B1.3030800@oracle.com> Vadim, Chien, and Daniil, Please review the following to backport several bug fixes in Ensemble8 from FX 9 to FX 8u: https://bugs.openjdk.java.net/browse/JDK-8168611 This is an umbrella task that needs a little explanation. We need to replace the old Ensemble2 demo on OTN with Ensemble8 (see JDK-8160020 [1] for why this is the case). We further need to compile Ensemble8 with JDK 8u so that it will run on both JDK 8u and JDK 9. In support of this, I propose to backport 12 bugs from FX 9 to FX 8u-dev -- as 12 separate changesets, one for each bug -- so the version we deploy on OTN will have all of the needed bug fixes and run correctly on both JDK 8u and JDK 9. Further details are in the umbrella bug report. -- Kevin [1] https://bugs.openjdk.java.net/browse/JDK-8160020 From chien.yang at oracle.com Tue Oct 25 01:22:34 2016 From: chien.yang at oracle.com (Chien Yang) Date: Mon, 24 Oct 2016 18:22:34 -0700 Subject: [9] Code Review Request For 8166470: -Xcheck:jni indicates there are missing exception checks in Glass Message-ID: <580EB3DA.30107@oracle.com> Hi Kevin, Please the proposed fix: JIRA: https://bugs.openjdk.java.net/browse/JDK-8166470 Webrev: http://cr.openjdk.java.net/~ckyang/JDK-8166470/webrev.00/ Thanks, - Chien From vadim.pakhnushev at oracle.com Tue Oct 25 16:12:25 2016 From: vadim.pakhnushev at oracle.com (Vadim Pakhnushev) Date: Tue, 25 Oct 2016 19:12:25 +0300 Subject: [9] Review request for 8164933: Charts are layed out on each pulse Message-ID: <93a611ff-3c07-5a64-6b9c-e259ccbce90d@oracle.com> Hi Chien, Jonathan, Could you please review the fix: https://bugs.openjdk.java.net/browse/JDK-8164933 http://cr.openjdk.java.net/~vadim/8164933/webrev.00/ Thanks, Vadim From james.graham at oracle.com Tue Oct 25 15:26:21 2016 From: james.graham at oracle.com (Jim Graham) Date: Tue, 25 Oct 2016 08:26:21 -0700 Subject: [9] Review request for 8166856: OS X: dual screen rendering issue Message-ID: <9e6b40a0-2f2c-b2a0-8bd1-6425a4eb17c2@oracle.com> JBS: https://bugs.openjdk.java.net/browse/JDK-8166856 webrev: http://cr.openjdk.java.net/~flar/JDK-8166856/webrev.00/ Some analysis in the last 2 comments of the JBS, but the main fix is to not send bounds changes down to native when no change has happened from FX code. The main culprit here was that they would be sent down when only a scale change had occurred. Since scale changes occur during dragging across screens this could confuse the native code as to whether a window is in its transitional state due to a drag operation or due to a programmatic change (triggered by echoing back the bounds when the scale change occurs) - each of which might have their own heuristics relating to whether or not the scale is that of the first or second screens. Now we only send the bounds down when they have changed. I also break out the scale notifications on MacOS to only be sent when the OS determines them to be appropriate rather than when we think they have changed. This keeps us in better sync with the native scale. This should not affect 8 (but I'll test to be sure) because we didn't send scales up the chain to FX like we do on 9 so the only reason 8 would have to try to send the bounds down is when they have actually changed from FX code. It wasn't until scaling was added to the notification path in 9 that we started sending down false NOP bounds changes... ...jim From chien.yang at oracle.com Thu Oct 27 00:39:37 2016 From: chien.yang at oracle.com (Chien Yang) Date: Wed, 26 Oct 2016 17:39:37 -0700 Subject: [8u] Code Review Request For 8168821: Cleanup whitespace after fix for JDK-8156078 Message-ID: <58114CC9.7000909@oracle.com> Hi Kevin, Please review this one line cleanup fix (diff in the JIRA): JIRA: https://bugs.openjdk.java.net/browse/JDK-8168821 Thanks, - Chien From a.ankit.srivastava at oracle.com Thu Oct 27 12:45:33 2016 From: a.ankit.srivastava at oracle.com (Ankit Srivastava) Date: Thu, 27 Oct 2016 05:45:33 -0700 (PDT) Subject: [9] Review Request 8089915 : Input of type file doesn't honor "accept" attribute. Message-ID: Hi Kevin, Arun, Please review the patch: JBS: https://bugs.openjdk.java.net/browse/JDK-8089915 Webrev : http://cr.openjdk.java.net/~asrivastava/8089915/webrev.00/ Regards, Ankit From guru.hb at oracle.com Fri Oct 28 09:44:55 2016 From: guru.hb at oracle.com (Guru Hb) Date: Fri, 28 Oct 2016 15:14:55 +0530 Subject: [9] Review request for 8157686: JavaFX WebView fails to track URL changes for PJAX websites Message-ID: <47719DEA-2C1E-4E7D-B79F-B8107A9D3D1A@oracle.com> Hi Arun, Kevin & Murali, Please review the fix for JBS: https://bugs.openjdk.java.net/browse/JDK-8157686 Webrev: http://cr.openjdk.java.net/~ghb/8157686/webrev.00/ RC and Solution updated in JBS. Thanks, Guru From tobi at ultramixer.com Fri Oct 28 10:00:07 2016 From: tobi at ultramixer.com (Tobi) Date: Fri, 28 Oct 2016 12:00:07 +0200 Subject: Embedding JavaFX in Swing hardware accelerated Message-ID: <735B42DC-8A2D-4518-A1ED-0A8043931AD4@ultramixer.com> Hi, is there any other, more performant, way integrating JavaFX into Swing than using JFXPanel? The problem with JFXPanel is it seams to be not hardware accelerated because JFXPanel makes a snapshot of the JavaFX content and paints to Swing. With this way you can?t include JavaFX content like animations into Swing without getting a poor performance. Best regards, Tobi -- ----------------------------------------------------------------- UltraMixer :: Professional Digital DJ Solution ----------------------------------------------------------------- http://www.ultramixer.com | info at ultramixer.com From david.dehaven at oracle.com Fri Oct 28 22:39:15 2016 From: david.dehaven at oracle.com (David DeHaven) Date: Fri, 28 Oct 2016 15:39:15 -0700 Subject: [9] RfR: 8137324: Warning from MacOSX for deprecated Carbon Component Manager module Message-ID: <316D652B-0276-49B3-AEF6-DA5461C50A9E@oracle.com> Kevin, Alexander, please review the following update to the Apple provided CoreAudio utility classes: JBS issue: https://bugs.openjdk.java.net/browse/JDK-8137324 Webrev: http://cr.openjdk.java.net/~ddehaven/8137324/rt.v0/ The change to GstAVPlaybackPipeline.cpp is necessary to avoid a compiler error when building with a later version of Xcode. No changes to the media code were necessary, since we didn't use Component Manager. -DrD- From David.Hill at Oracle.com Mon Oct 31 20:21:48 2016 From: David.Hill at Oracle.com (David Hill) Date: Mon, 31 Oct 2016 16:21:48 -0400 Subject: Change coming in the JFX development line Message-ID: <5817A7DC.5050601@Oracle.com> We have been working to convert 9-dev to build with the current JDK 9 preview. This has been a significant undertaking, and will result in a cleaner, safer build, but will also require changes by all developers. TIMELINE Tuesday Nov 1 - monster webrev will be posed for review Monday Nov 7 - review comment are due, change will be merged into mainline, though this may be delayed by circumstances till Tuesday ACTIONS to get ready, download and install * [1] Gradle 3.0+ (3.1 would be a good choice) * [2] JDK 9 preview build 142 + It probably makes sense to keep the older Gradle 2.11+ around for a bit, as 3.0 will not work until the conversion. The current repo works properly with JIGSAW_HOME set to JDK9 build 142+ More emails will be sent that highlight the direct impacts to developers (for example jfxrt.jar will not longer be around). This commit will resolve the JBS [3] JDK-8161704: Switch to Jigsaw-aware boot JDK for compiling FX 9 [1] https://gradle.org/gradle-download/ [2] https://jdk9.java.net/download/ [3] https://bugs.openjdk.java.net/browse/JDK-8161704 -- David Hill Java Embedded Development "A man's feet should be planted in his country, but his eyes should survey the world." -- George Santayana (1863 - 1952)