[9] Review request: 8178015: Clarify requirement for app modules to export/open packages to javafx modules
Kevin Rushforth
kevin.rushforth at oracle.com
Fri Apr 21 12:06:30 UTC 2017
Alan Bateman wrote:
>
>
> On 20/04/2017 19:06, Kevin Rushforth wrote:
>> Here is an updated webrev with a few suggested wording changes (e.g.,
>> removed the reference to ModuleDescriptor, changed "accessible by"
>> back to "accessible to").
>>
>> http://cr.openjdk.java.net/~kcr/8178015/webrev.02/
>>
>> Additionally, I removed the example in the FXML annotation showing
>> the use of "opens to" in module-info.java (but left the example in
>> Application).
>>
> What would you think about dropping the "Alternative the module can
> open ...." from the Application javadoc. I say this because it could
> confuse the reader. An advanced developer may follow the link to
> isExported and read more but it seems a bit much to try to put in the
> Application javadoc.
That seems good to me. I will remove it before pushing.
-- Kevin
>
> FXML looks good.
>
> -Alan
More information about the openjfx-dev
mailing list