[10] RFR: JDK-8133329: Drag and Drop of files in a SwingNode fails

Jim Graham james.graham at oracle.com
Sat Aug 5 00:06:10 UTC 2017


This looks good... +1

			...jim

On 8/3/17 9:20 PM, Prasanta Sadhukhan wrote:
> 
> 
> On 8/4/2017 2:57 AM, Jim Graham wrote:
>> I noticed a "FIXME" comment in there.  Didn't we do a pass a while back and convert all of them into JBS entries?
>>
>> The new code simply repeats what was done for the existing Exception which is what has the "FIXME" comment so I would 
>> use this opportunity to upgrade that FIXME into an actual bug entry.
>>
>> Also, perhaps we could use the multi-catch syntax here instead of creating a new catch?
>>
> Ok. I have put it as a mult-catch in this webrev
> http://cr.openjdk.java.net/~psadhukhan/fx/8133329/webrev.01/
> 
> Regards
> Prasanta
>> ...jim
>>
>> On 8/3/17 2:01 AM, Prasanta Sadhukhan wrote:
>>> Hi All,
>>>
>>> Please review a fix
>>> http://cr.openjdk.java.net/~psadhukhan/fx/8133329/webrev.00/
>>> for issue
>>> https://bugs.openjdk.java.net/browse/JDK-8133329
>>> More information in JBS.
>>>
>>> Regards
>>> Prasanta
> 


More information about the openjfx-dev mailing list