From kevin.rushforth at oracle.com Wed Feb 1 13:55:47 2017
From: kevin.rushforth at oracle.com (Kevin Rushforth)
Date: Wed, 01 Feb 2017 05:55:47 -0800
Subject: [9] Review request : JDK-8089875 : MenuBarSkin does not update
if a menu changes its visibility.
In-Reply-To: <62a7437c-f41d-48d7-87e3-d2b871b14e38@default>
References: <62a7437c-f41d-48d7-87e3-d2b871b14e38@default>
Message-ID: <5891E8E3.9080602@oracle.com>
As a reminder we are not fixing P4 bugs at this phase of the JDK 9
release [1], except for test and doc bugs. We can consider this bug fix
for JDK 10 once we open an FX 10 repo (more on the time of this will be
forthcoming).
-- Kevin
[1] http://openjdk.java.net/projects/jdk9/rdp-1
Ajit Ghaisas wrote:
> Hi Jonathan,
>
> Request you to review following fix :
> Menus that were added after MenuBarSkin construction never used to trigger UI rebuilding if their visible property changed.
>
> Bug : https://bugs.openjdk.java.net/browse/JDK-8089875
>
> Fix : http://cr.openjdk.java.net/~aghaisas/fx/8089875/webrev.0/
>
> Regards,
> Ajit
>
From David.Hill at Oracle.com Wed Feb 1 17:20:17 2017
From: David.Hill at Oracle.com (David Hill)
Date: Wed, 01 Feb 2017 12:20:17 -0500
Subject: review: correct build.gradle buildVersionFile
Message-ID: <589218D1.6010705@Oracle.com>
Kevin, Chris,
this seems to fix and issue where version.properties may or may not be in ant-javafx.jar
https://bugs.openjdk.java.net/browse/JDK-8173767
webrev: http://cr.openjdk.java.net/~ddhill/8173767/
--
David Hill
Java Embedded Development
"A man's feet should be planted in his country, but his eyes should survey the world."
-- George Santayana (1863 - 1952)
From chris.bensen at oracle.com Wed Feb 1 18:37:43 2017
From: chris.bensen at oracle.com (Chris Bensen)
Date: Wed, 1 Feb 2017 10:37:43 -0800
Subject: [9] Review request: 8173661 Fix ALL-MODULE-PATH
Message-ID:
Victor,
Please review this change to the addModules. ALL-MODULE-PATH now works with this change but it is subtle and we need to make sure it doesn?t break anything.
JIRA: https://bugs.openjdk.java.net/browse/JDK-8173661
Webrev: http://cr.openjdk.java.net/~cbensen/JDK-8173661/webrev.00/
Chris
From kevin.rushforth at oracle.com Wed Feb 1 19:27:55 2017
From: kevin.rushforth at oracle.com (Kevin Rushforth)
Date: Wed, 01 Feb 2017 11:27:55 -0800
Subject: [9] Review request: 8173768: gradle -PBUILD_SDK_FOR_TEST=false fails
accessing a non-existent property
Message-ID: <589236BB.6090804@oracle.com>
Please review the following fix to allow "gradle
-PBUILD_SDK_FOR_TEST=false" to work again:
https://bugs.openjdk.java.net/browse/JDK-8173768
The patch is in the bug report.
-- Kevin
From chris.bensen at oracle.com Wed Feb 1 20:23:09 2017
From: chris.bensen at oracle.com (Chris Bensen)
Date: Wed, 1 Feb 2017 12:23:09 -0800
Subject: [9] Review request: 8173774 Update script and icon
Message-ID: <8FFBAA1E-D9DF-43BC-BECE-7701852904E4@oracle.com>
Victor,
Please review these minor changes to the AppStore version number and icons for submitting to the Mac AppStore.
JIRA: https://bugs.openjdk.java.net/browse/JDK-8173774
Webrev: http://cr.openjdk.java.net/~cbensen/JDK-8173774/webrev.02/
Chris
From David.Hill at Oracle.com Wed Feb 1 22:09:29 2017
From: David.Hill at Oracle.com (David Hill)
Date: Wed, 01 Feb 2017 17:09:29 -0500
Subject: review: fix developer script compareBuilds to properly support windows
Message-ID: <58925C99.9060001@Oracle.com>
https://bugs.openjdk.java.net/browse/JDK-8173779
webrev: http://cr.openjdk.java.net/~ddhill/8173779
--
David Hill
Java Embedded Development
"A man's feet should be planted in his country, but his eyes should survey the world."
-- George Santayana (1863 - 1952)
From chien.yang at oracle.com Wed Feb 1 23:57:27 2017
From: chien.yang at oracle.com (Chien Yang)
Date: Wed, 01 Feb 2017 15:57:27 -0800
Subject: Code Review Request 8172364: Ensemble8 Canvas Fireworks jitters while
animating
Message-ID: <589275E7.7060607@oracle.com>
Hi Kevin,
Please review the proposed fix.
JIRA: https://bugs.openjdk.java.net/browse/JDK-8172364
Webrev: http://cr.openjdk.java.net/~ckyang/JDK-8172364/webrev.00/
Thanks,
- Chien
From kevin.rushforth at oracle.com Thu Feb 2 01:14:19 2017
From: kevin.rushforth at oracle.com (Kevin Rushforth)
Date: Wed, 01 Feb 2017 17:14:19 -0800
Subject: [9] Review request: 8155687: Legacy sample jar fails in launch
Message-ID: <589287EB.6040506@oracle.com>
Dave D and Dave H,
Please review the following fix for launching legacy jar files:
https://bugs.openjdk.java.net/browse/JDK-8155687
http://cr.openjdk.java.net/~kcr/8155687/webrev.00/
Most of the changes are to implement a new unit test. The fix itself is
simple.
-- Kevin
From alexander.matveev at oracle.com Thu Feb 2 02:30:04 2017
From: alexander.matveev at oracle.com (Alexander Matveev)
Date: Wed, 1 Feb 2017 18:30:04 -0800
Subject: [9] Review request for 8170630: [MacOSX] Media crash
NSInvalidArgumentException playing some video
Message-ID: <9728e81a-d5d4-f727-ec17-c0f982ceaa41@oracle.com>
Hi David,
Please review the following:
https://bugs.openjdk.java.net/browse/JDK-8170630
Fixed crash by checking value for NSNull.
Thanks,
Alexander
From kevin.rushforth at oracle.com Thu Feb 2 12:58:46 2017
From: kevin.rushforth at oracle.com (Kevin Rushforth)
Date: Thu, 02 Feb 2017 04:58:46 -0800
Subject: Result: New OpenJFX Committer: Ramesh Gangadhar
Message-ID: <58932D06.1000304@oracle.com>
Voting for Ramesh Gangadhar [1] to OpenJFX Committer [2] is now closed.
Yes: 10
Veto: 0
Abstain: 0
According to the Bylaws definition of Lazy Consensus, this is sufficient
to approve the nomination.
-- Kevin
[1] http://openjdk.java.net/census#rgangadhar
[2]
http://mail.openjdk.java.net/pipermail/openjfx-dev/2017-January/020182.html
From alexander at nyssen.org Fri Feb 3 10:40:14 2017
From: alexander at nyssen.org (Alexander Nyssen)
Date: Fri, 3 Feb 2017 11:40:14 +0100
Subject: Review request for JDK-8173852: FXCanvas needs to invert rotation
angle when forwarding a gesture event.
Message-ID: <50134F1C-A230-4CA3-A3CE-588788923470@nyssen.org>
Hallo Kevin, hallo Alexander,
please review the following fix:
https://bugs.openjdk.java.net/browse/JDK-8173852
http://cr.openjdk.java.net/~anyssen/8173852/webrev/
Best Regards,
Alexander
From semyon.sadetsky at oracle.com Fri Feb 3 13:37:52 2017
From: semyon.sadetsky at oracle.com (Semyon Sadetsky)
Date: Fri, 3 Feb 2017 16:37:52 +0300
Subject: [9] Review request for 8090249: [Linux] Restoring owner stage after
minimize does not restore position of child stage
Message-ID:
Hello Kevin & David,
Please review the fix for jfx9:
bug: https://bugs.openjdk.java.net/browse/JDK-8090249
webrev: http://cr.openjdk.java.net/~ssadetsky/8090249/webrev.00/
--Semyon
From semyon.sadetsky at oracle.com Mon Feb 6 17:00:06 2017
From: semyon.sadetsky at oracle.com (Semyon Sadetsky)
Date: Mon, 6 Feb 2017 20:00:06 +0300
Subject: [9] Review request for 8173901: Linux: Position of Stage is not
restored after exiting full screen
Message-ID: <7b0e73a5-bd7b-b4d5-9805-0d3c27f747e5@oracle.com>
Hello Kevin & David,
Please review the fix for jfx9:
bug: https://bugs.openjdk.java.net/browse/JDK-8173901
webrev: http://cr.openjdk.java.net/~ssadetsky/8173901/webrev.00/
--Semyon
From victor.drozdov at oracle.com Mon Feb 6 22:02:59 2017
From: victor.drozdov at oracle.com (Victor Drozdov)
Date: Tue, 7 Feb 2017 01:02:59 +0300
Subject: [9] Review request: JDK-8147781: Javapackager installer needs to
cleanup temporary folders
Message-ID:
Chris,
Please review the changes about removing temporary files.
JIRA: https://bugs.openjdk.java.net/browse/JDK-8147781
Webrev: http://cr.openjdk.java.net/~vdrozdov/JDK-8147781/webrev.00/
--Victor
From snfuchs at gmx.de Tue Feb 7 00:31:11 2017
From: snfuchs at gmx.de (Stefan Fuchs)
Date: Tue, 7 Feb 2017 01:31:11 +0100
Subject: [9] Review request: JDK-8147781: Javapackager installer needs to
cleanup temporary folders
In-Reply-To:
References:
Message-ID: <1999ff49-1f00-defd-fa3f-656da54d9da7@gmx.de>
Hi,
are you sure that there is a bug?
The verbose paramter is explicitly documented to leave temporary files
around, as a starting point for customization.
Quote from
https://docs.oracle.com/javase/8/docs/technotes/guides/deploy/self-contained-packaging.html
Verbose mode includes the following actions:
.....
A copy of the configuration files and resources used to create the self
contained package are saved to a temporary folder. You can use these
files as a starting point for customization
...
- Stefan
> Chris,
>
> Please review the changes about removing temporary files.
>
> JIRA: https://bugs.openjdk.java.net/browse/JDK-8147781
> Webrev: http://cr.openjdk.java.net/~vdrozdov/JDK-8147781/webrev.00/
>
> --Victor
>
>
From chris.bensen at oracle.com Tue Feb 7 00:33:57 2017
From: chris.bensen at oracle.com (Chris Bensen)
Date: Mon, 6 Feb 2017 16:33:57 -0800
Subject: [9] Review request: JDK-8147781: Javapackager installer needs to
cleanup temporary folders
In-Reply-To: <1999ff49-1f00-defd-fa3f-656da54d9da7@gmx.de>
References:
<1999ff49-1f00-defd-fa3f-656da54d9da7@gmx.de>
Message-ID: <9F67B00B-66D7-4CEF-8642-025C25FC0771@oracle.com>
That?s a good point Stefan. I hadn?t noticed the -verbose.
Chris
> On Feb 6, 2017, at 4:31 PM, Stefan Fuchs wrote:
>
> Hi,
>
> are you sure that there is a bug?
>
> The verbose paramter is explicitly documented to leave temporary files around, as a starting point for customization.
>
> Quote from https://docs.oracle.com/javase/8/docs/technotes/guides/deploy/self-contained-packaging.html
>
> Verbose mode includes the following actions:
>
> .....
>
> A copy of the configuration files and resources used to create the self contained package are saved to a temporary folder. You can use these files as a starting point for customization
>
> ...
>
>
> - Stefan
>> Chris,
>>
>> Please review the changes about removing temporary files.
>>
>> JIRA: https://bugs.openjdk.java.net/browse/JDK-8147781
>> Webrev: http://cr.openjdk.java.net/~vdrozdov/JDK-8147781/webrev.00/
>>
>> --Victor
>>
>>
>
From victor.drozdov at oracle.com Tue Feb 7 13:38:45 2017
From: victor.drozdov at oracle.com (Victor Drozdov)
Date: Tue, 7 Feb 2017 16:38:45 +0300
Subject: [9] Review request: JDK-8147781: Javapackager installer needs to
cleanup temporary folders
In-Reply-To: <9F67B00B-66D7-4CEF-8642-025C25FC0771@oracle.com>
References:
<1999ff49-1f00-defd-fa3f-656da54d9da7@gmx.de>
<9F67B00B-66D7-4CEF-8642-025C25FC0771@oracle.com>
Message-ID: <88c30bca-e127-b935-c87b-1a217f5c0500@oracle.com>
Thanks for pointing out the problem. Currently, the directory is not
removed regardless "-verbose" is specified or not. I think we can check
if "-verbose" is specified, and if it is not, remove the temporary
directory.
New webrev: http://cr.openjdk.java.net/~vdrozdov/JDK-8147781/webrev.01/
--Victor
On 07/02/17 03:33, Chris Bensen wrote:
> That?s a good point Stefan. I hadn?t noticed the -verbose.
>
> Chris
>
>
>> On Feb 6, 2017, at 4:31 PM, Stefan Fuchs wrote:
>>
>> Hi,
>>
>> are you sure that there is a bug?
>>
>> The verbose paramter is explicitly documented to leave temporary files around, as a starting point for customization.
>>
>> Quote from https://docs.oracle.com/javase/8/docs/technotes/guides/deploy/self-contained-packaging.html
>>
>> Verbose mode includes the following actions:
>>
>> .....
>>
>> A copy of the configuration files and resources used to create the self contained package are saved to a temporary folder. You can use these files as a starting point for customization
>>
>> ...
>>
>>
>> - Stefan
>>> Chris,
>>>
>>> Please review the changes about removing temporary files.
>>>
>>> JIRA: https://bugs.openjdk.java.net/browse/JDK-8147781
>>> Webrev: http://cr.openjdk.java.net/~vdrozdov/JDK-8147781/webrev.00/
>>>
>>> --Victor
>>>
>>>
From David.Hill at Oracle.com Tue Feb 7 20:10:53 2017
From: David.Hill at Oracle.com (David Hill)
Date: Tue, 07 Feb 2017 15:10:53 -0500
Subject: review: Clean up gradle dependancies and build times
Message-ID: <589A29CD.8020109@Oracle.com>
Everyone,
this change set should significantly speed up incremental builds as well as fixing some issues we had with bad task deps.
Using a second 'noop/no change' "gradle sdk" as benchmark, on my virtual windows build, the time drops from around 65 seconds to
On my virtual windows build, a second 'gradle sdk' takes ~65, after this change set around 10 seconds.
One risk of this change - I might have missed a dependency. After this goes in tomorrow, please be on the lookout for odd build behavior and let me know.
We have a tool that also help track this....
bash tools/scripts/whatChanged
does a great job in showing what under ./build changed.
If something should change and does not ... then we need to correct it.
Kevin,
would you review:
jbs: https://bugs.openjdk.java.net/browse/JDK-8172237
webrev: http://cr.openjdk.java.net/~ddhill/8172237.4/
--
David Hill
Java Embedded Development
"A man's feet should be planted in his country, but his eyes should survey the world."
-- George Santayana (1863 - 1952)
From kevin.rushforth at oracle.com Tue Feb 7 20:21:43 2017
From: kevin.rushforth at oracle.com (Kevin Rushforth)
Date: Tue, 07 Feb 2017 12:21:43 -0800
Subject: review: Clean up gradle dependancies and build times
In-Reply-To: <589A29CD.8020109@Oracle.com>
References: <589A29CD.8020109@Oracle.com>
Message-ID: <589A2C57.2070904@oracle.com>
One other change with this patch is in the way API docs are built. Today
you need to set a flag while building the sdk:
gradle -PBUILD_JAVADOC=true sdk
With this patch there is a separate task:
gradle javadoc
-- Kevin
David Hill wrote:
>
> Everyone,
> this change set should significantly speed up incremental builds as
> well as fixing some issues we had with bad task deps.
>
> Using a second 'noop/no change' "gradle sdk" as benchmark, on my
> virtual windows build, the time drops from around 65 seconds to
> On my virtual windows build, a second 'gradle sdk' takes ~65, after
> this change set around 10 seconds.
>
> One risk of this change - I might have missed a dependency. After this
> goes in tomorrow, please be on the lookout for odd build behavior and
> let me know.
>
> We have a tool that also help track this....
>
> bash tools/scripts/whatChanged
> does a great job in showing what under ./build changed.
> If something should change and does not ... then we need to correct it.
>
> Kevin,
> would you review:
>
> jbs: https://bugs.openjdk.java.net/browse/JDK-8172237
> webrev: http://cr.openjdk.java.net/~ddhill/8172237.4/
>
> --
> David Hill
> Java Embedded Development
>
> "A man's feet should be planted in his country, but his eyes should survey the world."
> -- George Santayana (1863 - 1952)
>
From chien.yang at oracle.com Wed Feb 8 00:20:59 2017
From: chien.yang at oracle.com (Chien Yang)
Date: Tue, 7 Feb 2017 16:20:59 -0800
Subject: [9] Code Review Request For 8173796: Overriden method,
requestLayout(),
by subclass of Parent didn't get call when process layout
Message-ID: <9bc091ad-063b-cbfc-02ab-93d04ac62742@oracle.com>
Hi Kevin and Jonathan,
Please review the proposed fix.
JIRA: https://bugs.openjdk.java.net/browse/JDK-8173796
Webrev: http://cr.openjdk.java.net/~ckyang/JDK-8173796/webrev.00/
Thanks,
- Chien
From james.graham at oracle.com Wed Feb 8 00:23:17 2017
From: james.graham at oracle.com (Jim Graham)
Date: Tue, 7 Feb 2017 16:23:17 -0800
Subject: [9, 8u] Review request for 8148549: Region is not rendered correctly
when node cache is enabled
Message-ID:
JBS: https://bugs.openjdk.java.net/browse/JDK-8148549
webrev: http://cr.openjdk.java.net/~flar/JDK-8148549/webrev.00/
The webrev is for 9, but the same code appears in 8u so I will apply and test the fix there and request a backport when
I'm sure that it works...
...jim
From David.Hill at Oracle.com Wed Feb 8 20:32:43 2017
From: David.Hill at Oracle.com (David Hill)
Date: Wed, 08 Feb 2017 15:32:43 -0500
Subject: review: Clean up gradle dependancies and build times
In-Reply-To: <589A29CD.8020109@Oracle.com>
References: <589A29CD.8020109@Oracle.com>
Message-ID: <589B806B.1060807@Oracle.com>
On 2/7/17, 3:10 PM, David Hill wrote:
Hello, closing in on a final version of this gradle rework. There is an updated webrev in:
https://bugs.openjdk.java.net/browse/JDK-8172237
This fix has a number of cleanups that should help with developer "gradle sdk" times.
We added a new task: 'jdkZip' to create the zip that can be used to hand off our module build to the JDK. This step is no longer in the 'sdk' task resulting in a speed boost for most people. This change obsoletes the BUILD_MODULE_ZIP property. Note: it is possible to build a local JDK without using the zip at all....
When building the 'zips' task, there is no longer a need to include -P BUILD_JAVADOC=true, much to my relief as I have hated this flag for quite some time.
Give it a try :-)
>
> Everyone,
> this change set should significantly speed up incremental builds as well as fixing some issues we had with bad task deps.
>
> Using a second 'noop/no change' "gradle sdk" as benchmark, on my virtual windows build, the time drops from around 65 seconds to
> On my virtual windows build, a second 'gradle sdk' takes ~65, after this change set around 10 seconds.
>
> One risk of this change - I might have missed a dependency. After this goes in tomorrow, please be on the lookout for odd build behavior and let me know.
>
> We have a tool that also help track this....
>
> bash tools/scripts/whatChanged
> does a great job in showing what under ./build changed.
> If something should change and does not ... then we need to correct it.
>
> Kevin,
> would you review:
>
> jbs: https://bugs.openjdk.java.net/browse/JDK-8172237
> webrev: http://cr.openjdk.java.net/~ddhill/8172237.4/
>
--
David Hill
Java Embedded Development
"A man's feet should be planted in his country, but his eyes should survey the world."
-- George Santayana (1863 - 1952)
From chris.bensen at oracle.com Thu Feb 9 00:38:42 2017
From: chris.bensen at oracle.com (Chris Bensen)
Date: Wed, 8 Feb 2017 16:38:42 -0800
Subject: [9] Review request:
Message-ID:
Kevin, Victor:
Updating the redistributable module list, changing the name to legacy/jre.list and adding support for comments in the jre.list file.
JIRA: https://bugs.openjdk.java.net/browse/JDK-8174131
Webrev: http://cr.openjdk.java.net/~cbensen/JDK-8174131/webrev.00/
Chris
From David.Hill at Oracle.com Thu Feb 9 15:52:56 2017
From: David.Hill at Oracle.com (David Hill)
Date: Thu, 09 Feb 2017 10:52:56 -0500
Subject: Result: New OpenJFX Committer: Semyon Sadetsky
Message-ID: <589C9058.8080206@Oracle.com>
Voting for Semyon Sadetsky to OpenJFX Committer [1] is now closed.
Yes: 9
Veto: 0
Abstain: 0
According to the Bylaws definition of Lazy Consensus, this is sufficient to approve the nomination.
Dave
[1] http://mail.openjdk.java.net/pipermail/openjfx-dev/2014-May/013881.html
--
David Hill
Java Embedded Development
"The most likely way for the world to be destroyed, most experts agree, is by accident. That's where we come in; we're computer professionals. We cause accidents."
-- Nathaniel Borenstein (1957 - )
From swpalmer at gmail.com Thu Feb 9 19:08:01 2017
From: swpalmer at gmail.com (Scott Palmer)
Date: Thu, 9 Feb 2017 14:08:01 -0500
Subject: Is a Desktop Experience on ARM with X11 Possible?
Message-ID:
Just wondering if there are some options for building OpenJFX for
embedded ARM such that it behaves like it does on x86 Linux with X11.
I mean with actual decorated windows instead of just lumping
everything onto the frame buffer or a single window.
Is this currently possible?
Scott
From David.Hill at Oracle.com Thu Feb 9 20:02:43 2017
From: David.Hill at Oracle.com (David Hill)
Date: Thu, 09 Feb 2017 15:02:43 -0500
Subject: Is a Desktop Experience on ARM with X11 Possible?
In-Reply-To:
References:
Message-ID: <589CCAE3.3010201@Oracle.com>
On 2/9/17, 2:08 PM, Scott Palmer wrote:
> Just wondering if there are some options for building OpenJFX for
> embedded ARM such that it behaves like it does on x86 Linux with X11.
> I mean with actual decorated windows instead of just lumping
> everything onto the frame buffer or a single window.
>
> Is this currently possible?
It should be possible, I just have not done it in a while so would not be surprised if there is some bit rot.
In short, you want the GTK base glass plugin, instead of Monocle. We were building both before I stopped building ARM.
after that, it should be a simple command line toggle, or a small edit to the created platform properties file.
-Djavafx.platform=gtk
-Dprism.verbose=true
Note that there is a good chance that this will not be hardware accelerated because of differences in GL setup.
Dave
>
>
> Scott
--
David Hill
Java Embedded Development
"A man's feet should be planted in his country, but his eyes should survey the world."
-- George Santayana (1863 - 1952)
From mattias.eliasson at medsa.se Thu Feb 9 21:44:22 2017
From: mattias.eliasson at medsa.se (Mattias Eliasson)
Date: Thu, 09 Feb 2017 22:44:22 +0100
Subject: Is a Desktop Experience on ARM with X11 Possible?
In-Reply-To: <589CCAE3.3010201@Oracle.com>
References:
<589CCAE3.3010201@Oracle.com>
Message-ID:
It depends on the platform. On Raspberry Pi x11 doesn't support hardware acceleration. That's an x11 issue not a JFX issue. I'm currently gonna implement a very limited desktop environment for this platform specifically, although it should work on any ARM platform that can run JFX.
To make x11 and OpenGL mix well you need a good backed renderer for x11. If you can't get windows decoration on OpenGL windows that's probably because your platform doesn't use OpenGL for the window manager. That used to be a problem on x86 before they made x11 render everything using OpenGL. But the problem is that ARM usually has EGL which is not yet fully supported by x11. There may be support for some GPU:s but don't count on yours being supported.
David Hill skrev: (9 februari 2017 21:02:43 CET)
>On 2/9/17, 2:08 PM, Scott Palmer wrote:
>> Just wondering if there are some options for building OpenJFX for
>> embedded ARM such that it behaves like it does on x86 Linux with X11.
>> I mean with actual decorated windows instead of just lumping
>> everything onto the frame buffer or a single window.
>>
>> Is this currently possible?
>It should be possible, I just have not done it in a while so would not
>be surprised if there is some bit rot.
>
>In short, you want the GTK base glass plugin, instead of Monocle. We
>were building both before I stopped building ARM.
>
>after that, it should be a simple command line toggle, or a small edit
>to the created platform properties file.
>
>-Djavafx.platform=gtk
>
>-Dprism.verbose=true
>
>Note that there is a good chance that this will not be hardware
>accelerated because of differences in GL setup.
>
>Dave
>>
>>
>> Scott
>
>
>--
>David Hill
>Java Embedded Development
>
>"A man's feet should be planted in his country, but his eyes should
>survey the world."
>-- George Santayana (1863 - 1952)
From kevin.rushforth at oracle.com Fri Feb 10 03:04:07 2017
From: kevin.rushforth at oracle.com (Kevin Rushforth)
Date: Thu, 09 Feb 2017 19:04:07 -0800
Subject: [9] Review request: 8169286: Need to exclude Monocle from production
build
Message-ID: <589D2DA7.1010301@oracle.com>
Dave,
Please review the following simple fix:
https://bugs.openjdk.java.net/browse/JDK-8169286
http://cr.openjdk.java.net/~kcr/8169286/webrev.00/
-- Kevin
From johan.vos at gluonhq.com Fri Feb 10 09:03:03 2017
From: johan.vos at gluonhq.com (Johan Vos)
Date: Fri, 10 Feb 2017 09:03:03 +0000
Subject: Is a Desktop Experience on ARM with X11 Possible?
In-Reply-To:
References:
Message-ID:
Hi Scott,
I actually have this working, leveraging the new mesa driver for the Pi.
It is using monocle and ES2 and it integrates very well with the X11 system
on the Raspberry Pi.
- Johan
On Thu, Feb 9, 2017 at 8:19 PM Scott Palmer wrote:
> Just wondering if there are some options for building OpenJFX for
> embedded ARM such that it behaves like it does on x86 Linux with X11.
> I mean with actual decorated windows instead of just lumping
> everything onto the frame buffer or a single window.
>
> Is this currently possible?
>
>
> Scott
>
From yuri.nesterenko at oracle.com Fri Feb 10 10:55:03 2017
From: yuri.nesterenko at oracle.com (Yuri Nesterenko)
Date: Fri, 10 Feb 2017 13:55:03 +0300
Subject: [9] Review request: JDK-8170979: Update for Jigsaw etc. the
openFX functional tests
In-Reply-To: <4587affd-3d44-c322-2bc2-0fcedf6c7923@oracle.com>
References: <146f2adf-ee57-0c79-1a73-1b97798e6c8a@oracle.com>
<5b29377e-b016-83b0-98da-db03d315a3b8@oracle.com>
<90f3a0f8-b3bf-4d16-f840-3571d29127df@oracle.com>
<4587affd-3d44-c322-2bc2-0fcedf6c7923@oracle.com>
Message-ID:
Version .05:
http://cr.openjdk.java.net/~yan/8170979/webrev.05
added, two lines fixing some 300+ Css tests.
Updating https://bugs.openjdk.java.net/browse/JDK-8170979 --
I'll add there a plain diff. Perhaps it would be
easier to apply.
Thank,
-yan
On 01/31/2017 04:03 PM, Yuri Nesterenko wrote:
> And once more:
>
> http://cr.openjdk.java.net/~yan/8170979/webrev.04
>
> Added:
> a port of JDK-8138872;
> a change in javaclient/shared/screenshots/GoldenImageManager.java
> to allow it find old golden images.
>
> In the index.html there's a list of 10 files to remove after the patch
> applied. Webrev script includes only 4 of them in the patch.
> I tried to commit the change, jcheck has nothing against it.
>
> We use this state of the tests (plus a closed part, and
> our own svn storage for images) to run in ATR.
> If not to analyze.
>
> Thank you!
> -yan
>
> On 12/29/2016 04:38 PM, Yuri Nesterenko wrote:
>> And again:
>> http://cr.openjdk.java.net/~yan/8170979/webrev.03
>>
>> (Discussion in the bug)
>> Unfortunately, webrev doesn't process properly
>> files deleted by 'hg rm' .
>>
>> -yan
>>
>> On 12/22/2016 12:07 PM, Yuri Nesterenko wrote:
>>> A new version is here:
>>> http://cr.openjdk.java.net/~yan/8170979/webrev.01
>>> (trailing spaces removed).
>>> See also discussion in the bug report:
>>> https://bugs.openjdk.java.net/browse/JDK-8170979
>>> thank you, Kevin!
>>>
>>> -yan
>>>
>>> On 12/21/2016 12:19 PM, Yuri Nesterenko wrote:
>>>> A gentle reminder.
>>>> Without this change, we have to make All Test Run out of
>>>> the makeshift workspace.
>>>>
>>>> Thanks,
>>>> -yan
>>>>
>>>> On 12/09/2016 02:02 PM, Yuri Nesterenko wrote:
>>>>> Colleagues,
>>>>>
>>>>> please review this test bug fix:
>>>>> http://cr.openjdk.java.net/~yan/8170979/webrev.00/
>>>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8170979
>>>>>
>>>>>
>>>>> The changes are mostly in tests/functional/.
>>>>>
>>>>> This is a merge of current testbase in
>>>>> http://hg.openjdk.java.net/openjfx/9-dev/tests and whatever
>>>>> we have internally. The tests should now compile and work
>>>>> with Jigsaw (including b148, --add-opens), recognize already
>>>>> not too new JDK directory structure, do not use Builders etc.
>>>>> Small number of tests was excluded and even dropped for various
>>>>> reasons.
>>>>> Several suites were tested with b142-b146 and PIT build for
>>>>> the recent Jigsaw update (re: --add-opens).
>>>>>
>>>>> There are still some reservations and unanswered questions.
>>>>> For instance, a hard monotonous work of creation and maintaining
>>>>> of the so called golden images is up to a tester: I don't know a
>>>>> good place to share them between independent teams.
>>>>> A couple of the suites still won't start without a minor
>>>>> reconfiguration beforehand, not always properly documented.
>>>>> We intend to use this state of the tests for the next massive test run
>>>>> starting from jdk9 b150.
>>>>
>>>
>>
>>
>
From semyon.sadetsky at oracle.com Fri Feb 10 12:32:26 2017
From: semyon.sadetsky at oracle.com (Semyon Sadetsky)
Date: Fri, 10 Feb 2017 15:32:26 +0300
Subject: [9] Review request for 8174154: NPE in
JFXPanel$HostContainer#setEmbeddedStage
Message-ID:
Hello Kevin,
Please review fix for jfx9:
bug: https://bugs.openjdk.java.net/browse/JDK-8174154
webrev: http://cr.openjdk.java.net/~ssadetsky/8174154/webrev.00/
--Semyon
From sirishreddy at gmail.com Fri Feb 10 18:23:27 2017
From: sirishreddy at gmail.com (Sirish Vadala)
Date: Fri, 10 Feb 2017 10:23:27 -0800
Subject: Issue with WebView component
Message-ID:
Hello experts, I am have an issue with WebView component. Sometimes if the
application stays idle for a few minutes, the display is just a blank
screen and WebView is not rendered on the stage. Other times it works
perfectly fine. Also once a particular webView component fails to render
onto the screen, all other webViews through out the application fail to
load.
The component behaves very inconsistently and I couldn't identify a
definitive pattern to replicate the issue.
I appreciate if any of you experts can point me out in the right direction
to fix this inconsistent behavior.
------------------------------------------------------------------------------------------
|------------------|
| My WebView code: |
|------------------|
String htmlBillText = billTextController.transformBillXmlXsl();
WebView webView = new WebView();
WebEngine engine = webView.getEngine();
engine.setOnError((WebErrorEvent event) -> {
// NEVER GOES INTO THIS AT ALL
System.out.println("event.getMessage()::"+event.getMessage());
System.out.println("event.getException()::"+event.getException().getMessage());
System.out.println("event.toString()::"+event.toString());
engine.reload();
});
engine.getLoadWorker().stateProperty().addListener(new
ChangeListener() {
@Override
public void changed(ObservableValue ov, Worker.State oldState, Worker.State
newState) {
System.out.println("oldState::" + oldState);
System.out.println("newState::" + newState);
if (engine.getLoadWorker().getException() != null) {
System.out.println("engine.getLoadWorker().getException()::" +
engine.getLoadWorker().getException().getLocalizedMessage());
}
if (engine.getLoadWorker().getException() != null && newState ==
Worker.State.FAILED) {
System.out.println(engine.getLoadWorker().getException().getMessage());
}
if (newState == Worker.State.SUCCEEDED) {
System.out.println("engine.getDocument()::"+engine.getDocument());
if (engine.getDocument() != null) {
String html = (String)
engine.executeScript("document.documentElement.innerHTML");
if (StringUtils.isEmpty(html)) {
System.out.println("FX WebView Engine Failed To Load Content... Execute
Reload...");
engine.reload();
}
}
System.out.println("engine.getTitle()::" + engine.getTitle());
System.out.println("engine.getLocation()::" + engine.getLocation());
System.out.println("engine.getUserAgent()::" + engine.getUserAgent());
System.out.println("engine.getUserDataDirectory()::" +
engine.getUserDataDirectory());
System.out.println("engine.isJavaScriptEnabled()::" +
engine.isJavaScriptEnabled());
}
}
});
engine.loadContent(htmlBillText);
------------------------------------------------------------------------------------------
|------------------------------------------------|
| MY DISPLAY CONSOLE WHEN WEBVIEW FAILS TO LOAD: |
|------------------------------------------------|
oldState::READY
newState::SCHEDULED
oldState::SCHEDULED
newState::RUNNING
oldState::RUNNING
newState::SUCCEEDED
engine.getDocument()::[object HTMLDocument]
engine.getTitle()::SB6:v98#DOCUMENT
engine.getLocation()::
engine.getUserAgent()::Mozilla/5.0 (Windows NT 6.1; Win64; x64)
AppleWebKit/538.19 (KHTML, like Gecko) JavaFX/8.0 Safari/538.19
engine.getUserDataDirectory()::null
engine.isJavaScriptEnabled()::true
------------------------------------------------------------------------------------------
Thanks. -SV-
From joerg.wille at gmail.com Fri Feb 10 21:32:26 2017
From: joerg.wille at gmail.com (=?UTF-8?Q?J=C3=B6rg_Wille?=)
Date: Fri, 10 Feb 2017 22:32:26 +0100
Subject: Review request: 8169286: Need to exclude Monocle from production
build
Message-ID:
Hi Kevin,
in your "fix" you write: "JIGSAW -- Figure out what to do with Monocle"
Can you elaborate a bit on this topic?
- Why do you have to exclude Monocle from production build?
- Is Monocle not compatible with jigsaw and if so, is it not planned to
make it compatible?
- What possibilities have current users of Monocle when they want to switch
to jdk9?
The compony I work for, is using Monocle for some of its current products.
Monocle is of now the only way to get JavaFX running (at least
half-performant) on some smaller embedded devices.
And what about JavaFXPorts - does it not also have dependencies on Monocle?
regards,
joerg
From kevin.rushforth at oracle.com Fri Feb 10 21:59:49 2017
From: kevin.rushforth at oracle.com (Kevin Rushforth)
Date: Fri, 10 Feb 2017 13:59:49 -0800
Subject: Review request: 8169286: Need to exclude Monocle from production
build
In-Reply-To:
References:
Message-ID: <589E37D5.6090104@oracle.com>
That comment was just a reminder that I added when temporarily
commenting out the code that was always present to strip out Monocle on
desktop platforms.
This will not affect anyone building JavaFX for embedded.
-- Kevin
J?rg Wille wrote:
> Hi Kevin,
> in your "fix" you write: "JIGSAW -- Figure out what to do with Monocle"
> Can you elaborate a bit on this topic?
> - Why do you have to exclude Monocle from production build?
> - Is Monocle not compatible with jigsaw and if so, is it not planned to
> make it compatible?
> - What possibilities have current users of Monocle when they want to switch
> to jdk9?
>
> The compony I work for, is using Monocle for some of its current products.
> Monocle is of now the only way to get JavaFX running (at least
> half-performant) on some smaller embedded devices.
> And what about JavaFXPorts - does it not also have dependencies on Monocle?
>
> regards,
> joerg
>
From swpalmer at gmail.com Sat Feb 11 04:38:07 2017
From: swpalmer at gmail.com (Scott Palmer)
Date: Fri, 10 Feb 2017 23:38:07 -0500
Subject: Is a Desktop Experience on ARM with X11 Possible?
In-Reply-To:
References:
Message-ID:
Hi Johan,
Excellent! Do you have a build or instructions somewhere?
Thanks,
Scott
> On Feb 10, 2017, at 4:03 AM, Johan Vos wrote:
>
> Hi Scott,
>
> I actually have this working, leveraging the new mesa driver for the Pi.
> It is using monocle and ES2 and it integrates very well with the X11 system on the Raspberry Pi.
>
> - Johan
>
> On Thu, Feb 9, 2017 at 8:19 PM Scott Palmer > wrote:
> Just wondering if there are some options for building OpenJFX for
> embedded ARM such that it behaves like it does on x86 Linux with X11.
> I mean with actual decorated windows instead of just lumping
> everything onto the frame buffer or a single window.
>
> Is this currently possible?
>
>
> Scott
From james.graham at oracle.com Sun Feb 12 23:15:23 2017
From: james.graham at oracle.com (Jim Graham)
Date: Sun, 12 Feb 2017 15:15:23 -0800
Subject: [9] Review request for 8174688: JavaFX Applet popup windows are in
the wrong location
Message-ID:
JBS: https://bugs.openjdk.java.net/browse/JDK-8174688
webrev: http://cr.openjdk.java.net/~flar/JDK-8174688/webrev.00/
It was a one-ish-line-ish fix (just needed to invert one Y coordinate consistent with other cases, but it took a couple
of lines to fetch the necessary data for inversion).
Still need to investigate if it fails on 8u-dev where we have nearly the same code and request a backport if necessary.
Will need to file a couple of follow-on bugs to investigate the way we flip Y coordinates to make sure there are no
additional, but more subtle, bugs in there. Until then, this one fix improves the popup window positioning for the
9-dev release and makes the code more consistent with the way we handle the Mac inverted Y coordinate systems...
...jim
From cnewland at chrisnewland.com Sun Feb 12 23:36:28 2017
From: cnewland at chrisnewland.com (Chris Newland)
Date: Sun, 12 Feb 2017 23:36:28 -0000
Subject: Is a Desktop Experience on ARM with X11 Possible?
In-Reply-To:
References:
Message-ID: <39cae8a6c440b35314f7fc3fdc846372.squirrel@excalibur.xssl.net>
Hi Scott,
I run windowed JavaFX desktop apps on the Raspberry Pi 3 (Latest Raspbian
+ PIXEL desktop without experimental driver) using the GTK platform and
software pipeline with an OpenJFX build from my server at
https://chriswhocodes.com/
Just download an ARM nightly:
wget
https://chriswhocodes.com/downloads/openjfx-8-sdk-overlay-linux-armv6hf.zip
and unzip it over your JDK
unzip openjfx-8-sdk-overlay-linux-armv6hf.zip -d /home/pi/jdk1.8.0_121
and then add the switches -Dprism.platform=gtk -Dprism.order=sw to your
java command.
Cheers,
Chris
On Thu, February 9, 2017 19:08, Scott Palmer wrote:
> Just wondering if there are some options for building OpenJFX for
> embedded ARM such that it behaves like it does on x86 Linux with X11. I
> mean with actual decorated windows instead of just lumping everything
> onto the frame buffer or a single window.
>
> Is this currently possible?
>
>
>
> Scott
>
>
From johan.vos at gluonhq.com Mon Feb 13 07:54:33 2017
From: johan.vos at gluonhq.com (Johan Vos)
Date: Mon, 13 Feb 2017 07:54:33 +0000
Subject: Is a Desktop Experience on ARM with X11 Possible?
In-Reply-To:
References:
Message-ID:
The changes for the new mesa-driver are in a branch (
https://bitbucket.org/javafxports/8u-dev-rt/branch/mesa) and we don't
distribute binaries from the Gluon download yet, as the new driver is still
experimental.
I am told, though, that it will soon become the default driver, and then
those changes are needed and we will update the binary SDK on
http://gluonhq.com/labs/javafxports/get/
Meanwhile, if you want to test, there is a build of the JavaFX SDK for
armv6hf that works with X11 and OpenGL here:
http://download.gluonhq.com/tmp/armv6hf-sdk.tar.bz2
You can get a very simple JavaFX app here:
http://download.gluonhq.com/tmp/HelloPi.jar
When the tar.bz2 is unpacked in /opt, you can run the sample app as follows:
java -Djava.ext.dirs=/opt/armv6hf-sdk/rt/lib/ext/
-Dmonocle.platform.traceConfig=true -Djavafx.verbose=true
-Dx11.geometry=400x200 -Dx11.input=true -jar HelloPi.jar
Make sure the java.ext.dirs points to the directory where you unpacked the
JavaFX SDK/rt/lib/ext .
One final thing, I removed the /opt/vc dir on my Pi, as somehow the
eglGetDisplay was still retrieved from a lib in /opt/vc instead of the mesa
library.
- Johan
On Sat, Feb 11, 2017 at 5:38 AM Scott Palmer wrote:
> Hi Johan,
>
> Excellent! Do you have a build or instructions somewhere?
>
> Thanks,
>
> Scott
>
> On Feb 10, 2017, at 4:03 AM, Johan Vos wrote:
>
> Hi Scott,
>
> I actually have this working, leveraging the new mesa driver for the Pi.
> It is using monocle and ES2 and it integrates very well with the X11
> system on the Raspberry Pi.
>
> - Johan
>
> On Thu, Feb 9, 2017 at 8:19 PM Scott Palmer wrote:
>
> Just wondering if there are some options for building OpenJFX for
> embedded ARM such that it behaves like it does on x86 Linux with X11.
> I mean with actual decorated windows instead of just lumping
> everything onto the frame buffer or a single window.
>
> Is this currently possible?
>
>
> Scott
>
>
>
From chris.bensen at oracle.com Mon Feb 13 19:58:31 2017
From: chris.bensen at oracle.com (Chris Bensen)
Date: Mon, 13 Feb 2017 11:58:31 -0800
Subject: [9] Review request: JDK-8174842 Uninitialized variable in
PosixPlatform.cpp
Message-ID: <4328B168-26F3-4C17-8336-8B7D902E3586@oracle.com>
Victor,
Please review the fix for initializing the uninitialized variable.
JIRA: https://bugs.openjdk.java.net/browse/JDK-8174842
Webrev: http://cr.openjdk.java.net/~cbensen/JDK-8174842/webrev.00/
Chris
From murali.billa at oracle.com Mon Feb 13 21:30:40 2017
From: murali.billa at oracle.com (Murali Billa)
Date: Mon, 13 Feb 2017 13:30:40 -0800 (PST)
Subject: [9] Review request for 8174866: User Agent String for JavaFX is not
correct
In-Reply-To:
References:
<5d429381-0799-e757-c070-827af4746317@oracle.com>
<4816ea91-3506-4e52-84f6-86f04768d6f3@default>
<9d808a20-87b9-4b9e-bcd8-a3a7a8ad2a20@default>
<6d514638-a60c-4215-9b0e-f28514cdbeb9@default>
<4e8a047a-3bf0-433c-94a3-b5c996421185@default>
Message-ID:
?
Hi Kevin, Arun, Guru
Please review the simple fix for ? JDK-8174866
JIRA: https://bugs.openjdk.java.net/browse/JDK-8174866
?
Webrev: http://cr.openjdk.java.net/~mbilla/8174866/webrev.00/
?
Thanks,
Murali
From kevin.rushforth at oracle.com Mon Feb 13 21:50:41 2017
From: kevin.rushforth at oracle.com (Kevin Rushforth)
Date: Mon, 13 Feb 2017 13:50:41 -0800
Subject: [9] Review request: 8172526: Third-party licenses for javafx.* modules
are missing
Message-ID: <58A22A31.8000608@oracle.com>
Dave & Mandy,
Please review the following fix to deliver the JavaFX third-party
license content into the JDK build.
https://bugs.openjdk.java.net/browse/JDK-8172526
http://cr.openjdk.java.net/~kcr/8172526/webrev.00/
Thanks.
-- Kevin
From mandy.chung at oracle.com Tue Feb 14 00:26:28 2017
From: mandy.chung at oracle.com (Mandy Chung)
Date: Mon, 13 Feb 2017 16:26:28 -0800
Subject: [9] Review request: 8172526: Third-party licenses for javafx.*
modules are missing
In-Reply-To: <58A22A31.8000608@oracle.com>
References: <58A22A31.8000608@oracle.com>
Message-ID:
> On Feb 13, 2017, at 1:50 PM, Kevin Rushforth wrote:
>
> Dave & Mandy,
>
> Please review the following fix to deliver the JavaFX third-party license content into the JDK build.
>
> https://bugs.openjdk.java.net/browse/JDK-8172526
> http://cr.openjdk.java.net/~kcr/8172526/webrev.00/
javafx.graphics/src/main/legal/jpeg_v7.md
5 jcapimin.c
6 *
/* is missing.
Otherwise looks okay.
Mandy
From kevin.rushforth at oracle.com Tue Feb 14 01:30:04 2017
From: kevin.rushforth at oracle.com (Kevin Rushforth)
Date: Mon, 13 Feb 2017 17:30:04 -0800
Subject: [9] Review request: 8172526: Third-party licenses for javafx.*
modules are missing
In-Reply-To:
References: <58A22A31.8000608@oracle.com>
Message-ID: <58A25D9C.1090105@oracle.com>
Fixed. Thanks.
http://cr.openjdk.java.net/~kcr/8172526/webrev.01/
-- Kevin
Mandy Chung wrote:
>> On Feb 13, 2017, at 1:50 PM, Kevin Rushforth wrote:
>>
>> Dave & Mandy,
>>
>> Please review the following fix to deliver the JavaFX third-party license content into the JDK build.
>>
>> https://bugs.openjdk.java.net/browse/JDK-8172526
>> http://cr.openjdk.java.net/~kcr/8172526/webrev.00/
>>
>
>
> javafx.graphics/src/main/legal/jpeg_v7.md
>
> 5 jcapimin.c
> 6 *
>
> /* is missing.
>
> Otherwise looks okay.
>
> Mandy
From mandy.chung at oracle.com Tue Feb 14 01:45:02 2017
From: mandy.chung at oracle.com (Mandy Chung)
Date: Mon, 13 Feb 2017 17:45:02 -0800
Subject: [9] Review request: 8172526: Third-party licenses for javafx.*
modules are missing
In-Reply-To: <58A25D9C.1090105@oracle.com>
References: <58A22A31.8000608@oracle.com>
<58A25D9C.1090105@oracle.com>
Message-ID:
+1
Mandy
> On Feb 13, 2017, at 5:30 PM, Kevin Rushforth wrote:
>
> Fixed. Thanks.
>
> http://cr.openjdk.java.net/~kcr/8172526/webrev.01/
>
> -- Kevin
>
>
> Mandy Chung wrote:
>>
>>> On Feb 13, 2017, at 1:50 PM, Kevin Rushforth wrote:
>>>
>>> Dave & Mandy,
>>>
>>> Please review the following fix to deliver the JavaFX third-party license content into the JDK build.
>>>
>>> https://bugs.openjdk.java.net/browse/JDK-8172526
>>> http://cr.openjdk.java.net/~kcr/8172526/webrev.00/
>>>
>>
>>
>> javafx.graphics/src/main/legal/jpeg_v7.md
>>
>> 5 jcapimin.c
>> 6 *
>>
>> /* is missing.
>>
>> Otherwise looks okay.
>>
>> Mandy
From guru.hb at oracle.com Tue Feb 14 17:40:18 2017
From: guru.hb at oracle.com (Guru Hb)
Date: Tue, 14 Feb 2017 23:10:18 +0530
Subject: [9] Review request: 8174919: SocketException no longer handled by
WebView when processing web pages
Message-ID:
Hi Kevin & Murali,
Please review the fix for JBS : https://bugs.openjdk.java.net/browse/JDK-8174919
Webrev : http://cr.openjdk.java.net/~ghb/8174919/webrev.00/
Thanks,
Guru
From David.Hill at Oracle.com Tue Feb 14 17:36:27 2017
From: David.Hill at Oracle.com (David Hill)
Date: Tue, 14 Feb 2017 12:36:27 -0500
Subject: review: Resources are not copied to the shims directory causing unit
test failures
Message-ID: <58A3401B.2010600@Oracle.com>
Kevin,
jbs: https://bugs.openjdk.java.net/browse/JDK-8174763
webrev: http://cr.openjdk.java.net/~ddhill/8174763.3/
--
David Hill
Java Embedded Development
"A man's feet should be planted in his country, but his eyes should survey the world."
-- George Santayana (1863 - 1952)
From james.graham at oracle.com Tue Feb 14 23:35:19 2017
From: james.graham at oracle.com (Jim Graham)
Date: Tue, 14 Feb 2017 15:35:19 -0800
Subject: [9] Review request for 8174671: Native debug build fails on Windows
Message-ID: <8c4c1eb7-7ee6-bd57-e98a-a094d2bffab3@oracle.com>
Fix suggested in description works just fine:
JBS: https://bugs.openjdk.java.net/browse/JDK-8174671
webrev: http://cr.openjdk.java.net/~flar/JDK-8174671/webrev.00/
...jim
From yuri.nesterenko at oracle.com Wed Feb 15 13:46:46 2017
From: yuri.nesterenko at oracle.com (Yuri Nesterenko)
Date: Wed, 15 Feb 2017 16:46:46 +0300
Subject: [9] Review request: JDK-8170979: Update for Jigsaw etc. the
openFX functional tests
In-Reply-To:
References: <146f2adf-ee57-0c79-1a73-1b97798e6c8a@oracle.com>
<5b29377e-b016-83b0-98da-db03d315a3b8@oracle.com>
<90f3a0f8-b3bf-4d16-f840-3571d29127df@oracle.com>
<4587affd-3d44-c322-2bc2-0fcedf6c7923@oracle.com>
Message-ID: <67f6ff28-5bdf-cfa0-e40d-7d29cbcf0a52@oracle.com>
Version .06:
http://cr.openjdk.java.net/~yan/8170979/webrev.06/
added, a couple more of add-exports for ControlsTests.
Updated https://bugs.openjdk.java.net/browse/JDK-8170979 :
an attached 'hg diff' for this version presumably works
better than a patch generated by webrev.
Thanks,
-yan
On 02/10/2017 01:55 PM, Yuri Nesterenko wrote:
> Version .05:
>
> http://cr.openjdk.java.net/~yan/8170979/webrev.05
>
> added, two lines fixing some 300+ Css tests.
> Updating https://bugs.openjdk.java.net/browse/JDK-8170979 --
> I'll add there a plain diff. Perhaps it would be
> easier to apply.
>
> Thank,
> -yan
>
> On 01/31/2017 04:03 PM, Yuri Nesterenko wrote:
>> And once more:
>>
>> http://cr.openjdk.java.net/~yan/8170979/webrev.04
>>
>> Added:
>> a port of JDK-8138872;
>> a change in javaclient/shared/screenshots/GoldenImageManager.java
>> to allow it find old golden images.
>>
>> In the index.html there's a list of 10 files to remove after the patch
>> applied. Webrev script includes only 4 of them in the patch.
>> I tried to commit the change, jcheck has nothing against it.
>>
>> We use this state of the tests (plus a closed part, and
>> our own svn storage for images) to run in ATR.
>> If not to analyze.
>>
>> Thank you!
>> -yan
>>
>> On 12/29/2016 04:38 PM, Yuri Nesterenko wrote:
>>> And again:
>>> http://cr.openjdk.java.net/~yan/8170979/webrev.03
>>>
>>> (Discussion in the bug)
>>> Unfortunately, webrev doesn't process properly
>>> files deleted by 'hg rm' .
>>>
>>> -yan
>>>
>>> On 12/22/2016 12:07 PM, Yuri Nesterenko wrote:
>>>> A new version is here:
>>>> http://cr.openjdk.java.net/~yan/8170979/webrev.01
>>>> (trailing spaces removed).
>>>> See also discussion in the bug report:
>>>> https://bugs.openjdk.java.net/browse/JDK-8170979
>>>> thank you, Kevin!
>>>>
>>>> -yan
>>>>
>>>> On 12/21/2016 12:19 PM, Yuri Nesterenko wrote:
>>>>> A gentle reminder.
>>>>> Without this change, we have to make All Test Run out of
>>>>> the makeshift workspace.
>>>>>
>>>>> Thanks,
>>>>> -yan
>>>>>
>>>>> On 12/09/2016 02:02 PM, Yuri Nesterenko wrote:
>>>>>> Colleagues,
>>>>>>
>>>>>> please review this test bug fix:
>>>>>> http://cr.openjdk.java.net/~yan/8170979/webrev.00/
>>>>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8170979
>>>>>>
>>>>>>
>>>>>> The changes are mostly in tests/functional/.
>>>>>>
>>>>>> This is a merge of current testbase in
>>>>>> http://hg.openjdk.java.net/openjfx/9-dev/tests and whatever
>>>>>> we have internally. The tests should now compile and work
>>>>>> with Jigsaw (including b148, --add-opens), recognize already
>>>>>> not too new JDK directory structure, do not use Builders etc.
>>>>>> Small number of tests was excluded and even dropped for various
>>>>>> reasons.
>>>>>> Several suites were tested with b142-b146 and PIT build for
>>>>>> the recent Jigsaw update (re: --add-opens).
>>>>>>
>>>>>> There are still some reservations and unanswered questions.
>>>>>> For instance, a hard monotonous work of creation and maintaining
>>>>>> of the so called golden images is up to a tester: I don't know a
>>>>>> good place to share them between independent teams.
>>>>>> A couple of the suites still won't start without a minor
>>>>>> reconfiguration beforehand, not always properly documented.
>>>>>> We intend to use this state of the tests for the next massive test
>>>>>> run
>>>>>> starting from jdk9 b150.
>>>>>
>>>>
>>>
>>>
>>
>
From Jens.Auer at h-d-gmbh.de Wed Feb 15 15:59:27 2017
From: Jens.Auer at h-d-gmbh.de (Jens Auer)
Date: Wed, 15 Feb 2017 15:59:27 +0000
Subject: SimpleIntegerProperty is not a Property
Message-ID: <98c2fd66f09e4160844d9350edcbc817@td-hud-ex01.muc.hd.local>
Hi,
I am wondering why SimpleIntegerProperty implements only Property and not Property. This came up while using ReactFx where I tried to bind a Var to a SimpleIntegerProperty and it fails to compile:
SimpleIntegerProperty s = null;
Var v=null;;
v.bindBidirectional(s);
It turns out that this is due to the inheritance hierarchy and it also prevents code like
javafx.beans.property.Property p;
javafx.beans.property.SimpleIntegerProperty s;
p = s;
Cheers,
Jens
Jens Auer
(Softwareentwicklung)
___________________________________________________________
Unternehmensberatung H & D GmbH
Niederlassung Wei?enthurm
Werftstr. 5 - 56575 Wei?enthurm
Tel.: 02637/94238 -110
Fax: 02637/94238 -149
michael.zimmer at h-d-gmbh.de
http://www.h-d-gmbh.de
http://www.h-d-gmbh.de/impressum.html
___________________________________________________________
From mp at jugs.org Wed Feb 15 16:19:43 2017
From: mp at jugs.org (Michael Paus)
Date: Wed, 15 Feb 2017 17:19:43 +0100
Subject: SimpleIntegerProperty is not a Property
In-Reply-To: <98c2fd66f09e4160844d9350edcbc817@td-hud-ex01.muc.hd.local>
References: <98c2fd66f09e4160844d9350edcbc817@td-hud-ex01.muc.hd.local>
Message-ID:
I am also wondering why this has to be so inconsistent.
Just in case you didn't know.
You can say
p = s.asObject();
in your example.
LG, Michael
Am 15.02.17 um 16:59 schrieb Jens Auer:
> Hi,
>
> I am wondering why SimpleIntegerProperty implements only Property and not Property. This came up while using ReactFx where I tried to bind a Var to a SimpleIntegerProperty and it fails to compile:
> SimpleIntegerProperty s = null;
>
> Var v=null;;
> v.bindBidirectional(s);
>
> It turns out that this is due to the inheritance hierarchy and it also prevents code like
> javafx.beans.property.Property p;
> javafx.beans.property.SimpleIntegerProperty s;
>
> p = s;
>
> Cheers,
> Jens
>
> Jens Auer
> (Softwareentwicklung)
> ___________________________________________________________
> Unternehmensberatung H & D GmbH
> Niederlassung Wei?enthurm
> Werftstr. 5 - 56575 Wei?enthurm
> Tel.: 02637/94238 -110
> Fax: 02637/94238 -149
> michael.zimmer at h-d-gmbh.de
> http://www.h-d-gmbh.de
> http://www.h-d-gmbh.de/impressum.html
> ___________________________________________________________
>
From chris.bensen at oracle.com Wed Feb 15 17:46:07 2017
From: chris.bensen at oracle.com (Chris Bensen)
Date: Wed, 15 Feb 2017 09:46:07 -0800
Subject: [8] Review request: 8173139 Packager update App Store runtime rules
for libjfxwebkit.dylib
Message-ID: <5A2A4990-E912-47A9-8790-323CBD1CA698@oracle.com>
Kevin,
Please review this change to no longer strip libjfxwebkit.dylib after 8u152 from a packaged app.
JIRA: https://bugs.openjdk.java.net/browse/8173139
Webrev: http://cr.openjdk.java.net/~cbensen/JDK-8173139/webrev.00/
Chris
From tom.schindl at bestsolution.at Wed Feb 15 20:28:41 2017
From: tom.schindl at bestsolution.at (Tom Schindl)
Date: Wed, 15 Feb 2017 21:28:41 +0100
Subject: SimpleIntegerProperty is not a Property
In-Reply-To:
References: <98c2fd66f09e4160844d9350edcbc817@td-hud-ex01.muc.hd.local>
Message-ID: <2f0a6451-1823-b1e1-c1ae-1018168d5b23@bestsolution.at>
Hi,
See that Michael had to say on that
https://twitter.com/tomsontom/status/760489595029090304
Tom
On 15.02.17 17:19, Michael Paus wrote:
> I am also wondering why this has to be so inconsistent.
> Just in case you didn't know.
>
> You can say
> p = s.asObject();
> in your example.
>
> LG, Michael
>
> Am 15.02.17 um 16:59 schrieb Jens Auer:
>> Hi,
>>
>> I am wondering why SimpleIntegerProperty implements only
>> Property and not Property. This came up while using
>> ReactFx where I tried to bind a Var to a
>> SimpleIntegerProperty and it fails to compile:
>> SimpleIntegerProperty s = null;
>>
>> Var v=null;;
>> v.bindBidirectional(s);
>>
>> It turns out that this is due to the inheritance hierarchy and it also
>> prevents code like
>> javafx.beans.property.Property p;
>> javafx.beans.property.SimpleIntegerProperty s;
>>
>> p = s;
>>
>> Cheers,
>> Jens
>>
>> Jens Auer
>> (Softwareentwicklung)
>> ___________________________________________________________
>> Unternehmensberatung H & D GmbH
>> Niederlassung Wei?enthurm
>> Werftstr. 5 - 56575 Wei?enthurm
>> Tel.: 02637/94238 -110
>> Fax: 02637/94238 -149
>> michael.zimmer at h-d-gmbh.de
>> http://www.h-d-gmbh.de
>> http://www.h-d-gmbh.de/impressum.html
>> ___________________________________________________________
>>
>
--
Thomas Schindl, CTO
BestSolution.at EDV Systemhaus GmbH
Eduard-Bodem-Gasse 5-7, A-6020 Innsbruck
http://www.bestsolution.at/
Reg. Nr. FN 222302s am Firmenbuchgericht Innsbruck
From chris.bensen at oracle.com Wed Feb 15 23:49:54 2017
From: chris.bensen at oracle.com (Chris Bensen)
Date: Wed, 15 Feb 2017 15:49:54 -0800
Subject: [8] Review request: 8173139 Packager update App Store runtime
rules for libjfxwebkit.dylib
In-Reply-To: <5A2A4990-E912-47A9-8790-323CBD1CA698@oracle.com>
References: <5A2A4990-E912-47A9-8790-323CBD1CA698@oracle.com>
Message-ID:
Accidentally send out the wrong bug number. Here?s the correct one:
JIRA: https://bugs.openjdk.java.net/browse/JDK-8174806
Webrev: http://cr.openjdk.java.net/~cbensen/JDK-8174806/webrev.00/
Chris
> On Feb 15, 2017, at 9:46 AM, Chris Bensen wrote:
>
> Kevin,
>
> Please review this change to no longer strip libjfxwebkit.dylib after 8u152 from a packaged app.
>
> JIRA: https://bugs.openjdk.java.net/browse/8173139
> Webrev: http://cr.openjdk.java.net/~cbensen/JDK-8173139/webrev.00/
>
> Chris
From victor.drozdov at oracle.com Fri Feb 17 13:42:47 2017
From: victor.drozdov at oracle.com (Victor Drozdov)
Date: Fri, 17 Feb 2017 16:42:47 +0300
Subject: [9] Review request: JDK-8175179: Windows Defender warning is not
correct for all cases
Message-ID: <564a0844-3a97-88ae-1ed8-6e06139ee94f@oracle.com>
Chris,
Please review the changes about temp directory
JIRA: https://bugs.openjdk.java.net/browse/JDK-8175179
Webrev:http://cr.openjdk.java.net/~vdrozdov/JDK-8175179/webrev.00/
--Victor
From David.Hill at Oracle.com Fri Feb 17 21:11:27 2017
From: David.Hill at Oracle.com (David Hill)
Date: Fri, 17 Feb 2017 16:11:27 -0500
Subject: review: correct developer script make_runargs.sh
Message-ID: <58A766FF.5020106@Oracle.com>
Kevin,
a small set of changes to the make_runargs.sh script
https://bugs.openjdk.java.net/browse/JDK-8175207
webrev: http://cr.openjdk.java.net/~ddhill/8175207/
--
David Hill
Java Embedded Development
"A man's feet should be planted in his country, but his eyes should survey the world."
-- George Santayana (1863 - 1952)
From chris.bensen at oracle.com Sat Feb 18 00:17:21 2017
From: chris.bensen at oracle.com (Chris Bensen)
Date: Fri, 17 Feb 2017 16:17:21 -0800
Subject: [8] Review request: 8174842 Uninitialized variable in
PosixPlatform.cpp
Message-ID:
Kevin,
Please review backport request:
JIRA: https://bugs.openjdk.java.net/browse/JDK-8174842
Webrev: http://cr.openjdk.java.net/~cbensen/JDK-8174842/webrev.03/
Chris
From semyon.sadetsky at oracle.com Mon Feb 20 08:48:29 2017
From: semyon.sadetsky at oracle.com (Semyon Sadetsky)
Date: Mon, 20 Feb 2017 11:48:29 +0300
Subject: [9] Review request for 8175205: Linux: Stage initially in full-screen
mode not shown when exiting full-screen
Message-ID: <70239b43-292e-f285-5914-8438f01085da@oracle.com>
Hello Kevin & David,
Please review the fix for jfx9:
bug: https://bugs.openjdk.java.net/browse/JDK-8175205
webrev: http://cr.openjdk.java.net/~ssadetsky/8175205/webrev.00/
--Semyon
From semyon.sadetsky at oracle.com Tue Feb 21 10:02:12 2017
From: semyon.sadetsky at oracle.com (Semyon Sadetsky)
Date: Tue, 21 Feb 2017 13:02:12 +0300
Subject: [9] Review request for 8175204: Linux: Dialog windows come up 1-pixel
wide
Message-ID:
Hello Kevin & David,
Please review the fix for jfx9:
bug: https://bugs.openjdk.java.net/browse/JDK-8175204
webrev: http://cr.openjdk.java.net/~ssadetsky/8175204/webrev.00/
--Semyon
From itaisha at gmail.com Wed Feb 22 11:02:54 2017
From: itaisha at gmail.com (Itai)
Date: Wed, 22 Feb 2017 13:02:54 +0200
Subject: Will JDK-8150946 be backported to 8?
Message-ID:
Looking at https://bugs.openjdk.java.net/browse/JDK-8150946 , it seems to
be fixed in 9 but not in 8. The similar JDK-8136838 (
https://bugs.openjdk.java.net/browse/JDK-8136838) was backported to 8 , but
it seems the spinner behavior of not saving values on focus lost still
exists in 8.
Is this likely to be backported? If not the whole focus-loss semantics,
maybe just making Spinners and ComboBoxes have consistent behavior?
Regards,
Itai.
From chris.bensen at oracle.com Thu Feb 23 15:47:14 2017
From: chris.bensen at oracle.com (Chris Bensen)
Date: Thu, 23 Feb 2017 07:47:14 -0800
Subject: [9] Review request: 8150511 LSMinimumSystemVersion set incorrectly
Message-ID:
Victor,
Please review this change to the minimum supported system version.
JIRA: https://bugs.openjdk.java.net/browse/JDK-8150511
Webrev: http://cr.openjdk.java.net/~cbensen/JDK-8150511/webrev.00/
Chris
From kevin.rushforth at oracle.com Thu Feb 23 16:18:45 2017
From: kevin.rushforth at oracle.com (Kevin Rushforth)
Date: Thu, 23 Feb 2017 21:48:45 +0530
Subject: Will JDK-8150946 be backported to 8?
In-Reply-To:
References:
Message-ID: <58AF0B65.4070606@oracle.com>
JDK-8136838 introduced new public API, and is a P4 bug, so no it will
not be backported to JDK 8.
If you think there is a specific part of this fix that could be isolated
into a new bug report, then we could consider it, but the bar is pretty
high for JDK 8u backports.
-- Kevin
Itai wrote:
> Looking at https://bugs.openjdk.java.net/browse/JDK-8150946 , it seems to
> be fixed in 9 but not in 8. The similar JDK-8136838 (
> https://bugs.openjdk.java.net/browse/JDK-8136838) was backported to 8 , but
> it seems the spinner behavior of not saving values on focus lost still
> exists in 8.
>
> Is this likely to be backported? If not the whole focus-loss semantics,
> maybe just making Spinners and ComboBoxes have consistent behavior?
>
> Regards,
> Itai.
>
From ajit.ghaisas at oracle.com Mon Feb 27 10:08:01 2017
From: ajit.ghaisas at oracle.com (Ajit Ghaisas)
Date: Mon, 27 Feb 2017 02:08:01 -0800 (PST)
Subject: [9] Review request : JDK-8089059 : Left padding of CheckBox doesn't
only add padding to the left, but also to top.
Message-ID: <03b4bf2d-fb90-41f6-9add-9cb83894607e@default>
Hi Jonathan, Kevin,
Request you to review a simple fix :
Bug :
https://bugs.openjdk.java.net/browse/JDK-8089059
Left padding of CheckBox doesn't only add padding to the left, but also to top.
Fix :
http://cr.openjdk.java.net/~aghaisas/fx/8089059/webrev.0/
Regards,
Ajit
From vadim.pakhnushev at oracle.com Tue Feb 28 15:21:14 2017
From: vadim.pakhnushev at oracle.com (Vadim Pakhnushev)
Date: Tue, 28 Feb 2017 18:21:14 +0300
Subject: [9] Review request for 8163501: NumberAxis: a couple of typos in the
docs
Message-ID:
Jonathan, Kevin,
Could you please review this fix?
https://bugs.openjdk.java.net/browse/JDK-8163501
http://cr.openjdk.java.net/~vadim/8163501/webrev.00/
Thanks,
Vadim
From chien.yang at oracle.com Tue Feb 28 23:00:19 2017
From: chien.yang at oracle.com (Chien Yang)
Date: Tue, 28 Feb 2017 15:00:19 -0800
Subject: [9] Code Review Request For 8163384: Fix doclint errors and warnings
in javafx.graphics module
Message-ID: <74283999-7c95-3a7d-5f87-99354e74163f@oracle.com>
Hi all,
Please review the proposed fix.
JIRA: https://bugs.openjdk.java.net/browse/JDK-8163384
Webrev: http://cr.openjdk.java.net/~ckyang/JDK-8163384/webrev.00/
Thanks,
- Chien