review: Clean up gradle dependancies and build times

David Hill David.Hill at Oracle.com
Wed Feb 8 20:32:43 UTC 2017


On 2/7/17, 3:10 PM, David Hill wrote:

Hello, closing in on a final version of this gradle rework. There is an updated webrev in:
     https://bugs.openjdk.java.net/browse/JDK-8172237

This fix has a number of cleanups that should help with developer "gradle sdk" times.

We added a new task: 'jdkZip' to create the zip that can be used to hand off our module build to the JDK. This step is no longer in the 'sdk' task resulting in a speed boost for most people. This change obsoletes the BUILD_MODULE_ZIP property. Note: it is possible to build a local JDK without using the zip at all....

When building the 'zips' task, there is no longer a need to include -P BUILD_JAVADOC=true, much to my relief as I have hated this flag for quite some time.

Give it a try :-)

>
> Everyone,
>    this change set should significantly speed up incremental builds as well as fixing some issues we had with bad task deps.
>
> Using a second 'noop/no change'  "gradle sdk" as benchmark, on my virtual windows build, the time drops from around 65 seconds to
> On my virtual windows build, a second 'gradle sdk' takes ~65, after this change set around 10 seconds.
>
> One risk of this change - I might have missed a dependency. After this goes in tomorrow, please be on the lookout for odd build behavior and let me know.
>
> We have a tool that also help track this....
>
> bash tools/scripts/whatChanged
> does a great job in showing what under ./build changed.
> If something should change and does not ... then we need to correct it.
>
> Kevin,
>    would you review:
>
> jbs: https://bugs.openjdk.java.net/browse/JDK-8172237
> webrev: http://cr.openjdk.java.net/~ddhill/8172237.4/ <http://cr.openjdk.java.net/%7Eddhill/8172237.4/>
>


-- 
David Hill<David.Hill at Oracle.com>
Java Embedded Development

"A man's feet should be planted in his country, but his eyes should survey the world."
-- George Santayana (1863 - 1952)



More information about the openjfx-dev mailing list