From info at cuhka.com Thu Jun 1 20:22:36 2017 From: info at cuhka.com (Maurice) Date: Thu, 1 Jun 2017 22:22:36 +0200 Subject: (Multi)Touch Ubuntu not working - where to look for implementation Message-ID: <8b0e8ab9-41ae-1c5b-5f4c-8b85b1463f19@cuhka.com> I'm using JavaFX on Ubuntu 17.04 and a touch screen capable of 10 points. Officially the last only on Windows, but I think Ubuntu does support it too. Unfortunately JavaFX claims that INPUT_TOUCH is false. I'd like to find out but do not know where to start. My assumption is that JavaFX settles for the synthesized mouse. The output of "udevadm info --export-db" seems to acknowledge that Ubuntu sees the screen as a touch device, I've included a part of the output at the end of the email, but the line 'DRIVER=hid-multitouch" and ' ID_INPUT_TOUCHSCREEN=1' give me that idea. This leads me to the idea that I have to look inside the JavaFX implementation. However, it would be nice if I could have some pointer of where to start and what to look for. For the record, I'm on JavaFX 8. Maurice. P: /devices/pci0000:00/0000:00:14.0/usb1/1-3/1-3:1.0/0003:2149:544D.0001 E: DEVPATH=/devices/pci0000:00/0000:00:14.0/usb1/1-3/1-3:1.0/0003:2149:544D.0001 E: DRIVER=hid-multitouch E: HID_ID=0003:00002149:0000544D E: HID_NAME=Weida Hi-Tech CoolTouchR System E: HID_PHYS=usb-0000:00:14.0-3/input0 E: HID_UNIQ= E: MODALIAS=hid:b0003g0004v00002149p0000544D E: SUBSYSTEM=hid P: /devices/pci0000:00/0000:00:14.0/usb1/1-3/1-3:1.0/0003:2149:544D.0001/hidraw/hidraw0 N: hidraw0 E: DEVNAME=/dev/hidraw0 E: DEVPATH=/devices/pci0000:00/0000:00:14.0/usb1/1-3/1-3:1.0/0003:2149:544D.0001/hidraw/hidraw0 E: MAJOR=246 E: MINOR=0 E: SUBSYSTEM=hidraw P: /devices/pci0000:00/0000:00:14.0/usb1/1-3/1-3:1.0/0003:2149:544D.0001/input/input4 E: ABS=260800000000003 E: DEVPATH=/devices/pci0000:00/0000:00:14.0/usb1/1-3/1-3:1.0/0003:2149:544D.0001/input/input4 E: EV=b E: ID_BUS=usb E: ID_FOR_SEAT=input-pci-0000_00_14_0-usb-0_3_1_0 E: ID_INPUT=1 E: ID_INPUT_TOUCHSCREEN=1 E: ID_MODEL=CoolTouchR_System E: ID_MODEL_ENC=CoolTouchR\x20System\x20\x20\x20\x20\x20\x20\x20\x20\x20\x20\x20 E: ID_MODEL_ID=544d E: ID_PATH=pci-0000:00:14.0-usb-0:3:1.0 E: ID_PATH_TAG=pci-0000_00_14_0-usb-0_3_1_0 E: ID_REVISION=1330 E: ID_SERIAL=Weida_Hi-Tech_CoolTouchR_System E: ID_TYPE=hid E: ID_USB_DRIVER=usbhid E: ID_USB_INTERFACES=:030102: E: ID_USB_INTERFACE_NUM=00 E: ID_VENDOR=Weida_Hi-Tech E: ID_VENDOR_ENC=Weida\x20Hi-Tech\x20\x20\x20\x20\x20\x20\x20\x20\x20\x20\x20\x20\x20\x20\x20 E: ID_VENDOR_ID=2149 E: KEY=400 0 0 0 0 0 E: MODALIAS=input:b0003v2149p544De0110-e0,1,3,k14A,ra0,1,2F,35,36,39,mlsfw E: NAME="Weida Hi-Tech CoolTouchR System " E: PHYS="usb-0000:00:14.0-3/input0" E: PRODUCT=3/2149/544d/110 E: PROP=2 E: SUBSYSTEM=input E: TAGS=:seat: E: UNIQ="" E: USEC_INITIALIZED=6371585 P: /devices/pci0000:00/0000:00:14.0/usb1/1-3/1-3:1.0/0003:2149:544D.0001/input/input4/event4 N: input/event4 S: input/by-id/usb-Weida_Hi-Tech_CoolTouchR_System-event-if00 S: input/by-path/pci-0000:00:14.0-usb-0:3:1.0-event E: DEVLINKS=/dev/input/by-id/usb-Weida_Hi-Tech_CoolTouchR_System-event-if00 /dev/input/by-path/pci-0000:00:14.0-usb-0:3:1.0-event E: DEVNAME=/dev/input/event4 E: DEVPATH=/devices/pci0000:00/0000:00:14.0/usb1/1-3/1-3:1.0/0003:2149:544D.0001/input/input4/event4 E: ID_BUS=usb E: ID_INPUT=1 E: ID_INPUT_HEIGHT_MM=268 E: ID_INPUT_TOUCHSCREEN=1 E: ID_INPUT_WIDTH_MM=474 E: ID_MODEL=CoolTouchR_System E: ID_MODEL_ENC=CoolTouchR\x20System\x20\x20\x20\x20\x20\x20\x20\x20\x20\x20\x20 E: ID_MODEL_ID=544d E: ID_PATH=pci-0000:00:14.0-usb-0:3:1.0 E: ID_PATH_TAG=pci-0000_00_14_0-usb-0_3_1_0 E: ID_REVISION=1330 E: ID_SERIAL=Weida_Hi-Tech_CoolTouchR_System E: ID_TYPE=hid E: ID_USB_DRIVER=usbhid E: ID_USB_INTERFACES=:030102: E: ID_USB_INTERFACE_NUM=00 E: ID_VENDOR=Weida_Hi-Tech E: ID_VENDOR_ENC=Weida\x20Hi-Tech\x20\x20\x20\x20\x20\x20\x20\x20\x20\x20\x20\x20\x20\x20\x20 E: ID_VENDOR_ID=2149 E: LIBINPUT_DEVICE_GROUP=3/2149/544d/110:usb-0000:00:14.0-3 E: MAJOR=13 E: MINOR=68 E: SUBSYSTEM=input E: USEC_INITIALIZED=6499966 P: /devices/pci0000:00/0000:00:14.0/usb1/1-3/1-3:1.0/0003:2149:544D.0001/input/input4/mouse0 N: input/mouse0 E: DEVNAME=/dev/input/mouse0 E: DEVPATH=/devices/pci0000:00/0000:00:14.0/usb1/1-3/1-3:1.0/0003:2149:544D.0001/input/input4/mouse0 E: ID_BUS=usb E: ID_INPUT=1 P: /devices/pci0000:00/0000:00:14.0/usb1/1-3/1-3:1.0/0003:2149:544D.0001 E: DEVPATH=/devices/pci0000:00/0000:00:14.0/usb1/1-3/1-3:1.0/0003:2149:544D.0001 E: DRIVER=hid-multitouch E: HID_ID=0003:00002149:0000544D E: HID_NAME=Weida Hi-Tech CoolTouchR System E: HID_PHYS=usb-0000:00:14.0-3/input0 E: HID_UNIQ= E: MODALIAS=hid:b0003g0004v00002149p0000544D E: SUBSYSTEM=hid P: /devices/pci0000:00/0000:00:14.0/usb1/1-3/1-3:1.0/0003:2149:544D.0001/hidraw/hidraw0 N: hidraw0 E: DEVNAME=/dev/hidraw0 E: DEVPATH=/devices/pci0000:00/0000:00:14.0/usb1/1-3/1-3:1.0/0003:2149:544D.0001/hidraw/hidraw0 E: MAJOR=246 E: MINOR=0 E: SUBSYSTEM=hidraw P: /devices/pci0000:00/0000:00:14.0/usb1/1-3/1-3:1.0/0003:2149:544D.0001/input/input4 E: ABS=260800000000003 E: DEVPATH=/devices/pci0000:00/0000:00:14.0/usb1/1-3/1-3:1.0/0003:2149:544D.0001/input/input4 E: EV=b E: ID_BUS=usb E: ID_FOR_SEAT=input-pci-0000_00_14_0-usb-0_3_1_0 E: ID_INPUT=1 E: ID_INPUT_TOUCHSCREEN=1 E: ID_MODEL=CoolTouchR_System E: ID_MODEL_ENC=CoolTouchR\x20System\x20\x20\x20\x20\x20\x20\x20\x20\x20\x20\x20 E: ID_MODEL_ID=544d E: ID_PATH=pci-0000:00:14.0-usb-0:3:1.0 E: ID_PATH_TAG=pci-0000_00_14_0-usb-0_3_1_0 E: ID_REVISION=1330 E: ID_SERIAL=Weida_Hi-Tech_CoolTouchR_System E: ID_TYPE=hid E: ID_USB_DRIVER=usbhid E: ID_USB_INTERFACES=:030102: E: ID_USB_INTERFACE_NUM=00 E: ID_VENDOR=Weida_Hi-Tech E: ID_VENDOR_ENC=Weida\x20Hi-Tech\x20\x20\x20\x20\x20\x20\x20\x20\x20\x20\x20\x20\x20\x20\x20 E: ID_VENDOR_ID=2149 E: KEY=400 0 0 0 0 0 E: MODALIAS=input:b0003v2149p544De0110-e0,1,3,k14A,ra0,1,2F,35,36,39,mlsfw E: NAME="Weida Hi-Tech CoolTouchR System " E: PHYS="usb-0000:00:14.0-3/input0" E: PRODUCT=3/2149/544d/110 E: PROP=2 E: SUBSYSTEM=input E: TAGS=:seat: E: UNIQ="" E: USEC_INITIALIZED=6371585 P: /devices/pci0000:00/0000:00:14.0/usb1/1-3/1-3:1.0/0003:2149:544D.0001/input/input4/event4 N: input/event4 S: input/by-id/usb-Weida_Hi-Tech_CoolTouchR_System-event-if00 S: input/by-path/pci-0000:00:14.0-usb-0:3:1.0-event E: DEVLINKS=/dev/input/by-id/usb-Weida_Hi-Tech_CoolTouchR_System-event-if00 /dev/input/by-path/pci-0000:00:14.0-usb-0:3:1.0-event E: DEVNAME=/dev/input/event4 E: DEVPATH=/devices/pci0000:00/0000:00:14.0/usb1/1-3/1-3:1.0/0003:2149:544D.0001/input/input4/event4 E: ID_BUS=usb E: ID_INPUT=1 E: ID_INPUT_HEIGHT_MM=268 E: ID_INPUT_TOUCHSCREEN=1 E: ID_INPUT_WIDTH_MM=474 E: ID_MODEL=CoolTouchR_System E: ID_MODEL_ENC=CoolTouchR\x20System\x20\x20\x20\x20\x20\x20\x20\x20\x20\x20\x20 E: ID_MODEL_ID=544d E: ID_PATH=pci-0000:00:14.0-usb-0:3:1.0 E: ID_PATH_TAG=pci-0000_00_14_0-usb-0_3_1_0 E: ID_REVISION=1330 E: ID_SERIAL=Weida_Hi-Tech_CoolTouchR_System E: ID_TYPE=hid E: ID_USB_DRIVER=usbhid E: ID_USB_INTERFACES=:030102: E: ID_USB_INTERFACE_NUM=00 E: ID_VENDOR=Weida_Hi-Tech E: ID_VENDOR_ENC=Weida\x20Hi-Tech\x20\x20\x20\x20\x20\x20\x20\x20\x20\x20\x20\x20\x20\x20\x20 E: ID_VENDOR_ID=2149 E: LIBINPUT_DEVICE_GROUP=3/2149/544d/110:usb-0000:00:14.0-3 E: MAJOR=13 E: MINOR=68 E: SUBSYSTEM=input E: USEC_INITIALIZED=6499966 P: /devices/pci0000:00/0000:00:14.0/usb1/1-3/1-3:1.0/0003:2149:544D.0001/input/input4/mouse0 N: input/mouse0 E: DEVNAME=/dev/input/mouse0 E: DEVPATH=/devices/pci0000:00/0000:00:14.0/usb1/1-3/1-3:1.0/0003:2149:544D.0001/input/input4/mouse0 E: ID_BUS=usb E: ID_INPUT=1 E: ID_INPUT_TOUCHSCREEN=1 E: ID_MODEL=CoolTouchR_System E: ID_MODEL_ENC=CoolTouchR\x20System\x20\x20\x20\x20\x20\x20\x20\x20\x20\x20\x20 E: ID_MODEL_ID=544d E: ID_PATH=pci-0000:00:14.0-usb-0:3:1.0 E: ID_PATH_TAG=pci-0000_00_14_0-usb-0_3_1_0 E: ID_REVISION=1330 E: ID_SERIAL=Weida_Hi-Tech_CoolTouchR_System E: ID_TYPE=hid E: ID_USB_DRIVER=usbhid E: ID_USB_INTERFACES=:030102: E: ID_USB_INTERFACE_NUM=00 E: ID_VENDOR=Weida_Hi-Tech E: ID_VENDOR_ENC=Weida\x20Hi-Tech\x20\x20\x20\x20\x20\x20\x20\x20\x20\x20\x20\x20\x20\x20\x20 E: ID_VENDOR_ID=2149 E: MAJOR=13 E: MINOR=32 E: SUBSYSTEM=input E: USEC_INITIALIZED=6383972 E: ID_MODEL=CoolTouchR_System E: ID_MODEL_ENC=CoolTouchR\x20System\x20\x20\x20\x20\x20\x20\x20\x20\x20\x20\x20 E: ID_MODEL_ID=544d E: ID_PATH=pci-0000:00:14.0-usb-0:3:1.0 E: ID_PATH_TAG=pci-0000_00_14_0-usb-0_3_1_0 E: ID_REVISION=1330 E: ID_SERIAL=Weida_Hi-Tech_CoolTouchR_System E: ID_TYPE=hid E: ID_USB_DRIVER=usbhid E: ID_USB_INTERFACES=:030102: E: ID_USB_INTERFACE_NUM=00 E: ID_VENDOR=Weida_Hi-Tech E: ID_VENDOR_ENC=Weida\x20Hi-Tech\x20\x20\x20\x20\x20\x20\x20\x20\x20\x20\x20\x20\x20\x20\x20 E: ID_VENDOR_ID=2149 E: MAJOR=13 E: MINOR=32 E: SUBSYSTEM=input E: USEC_INITIALIZED=6383972 From wowselim at gmail.com Fri Jun 2 08:18:03 2017 From: wowselim at gmail.com (Selim Dincer) Date: Fri, 2 Jun 2017 10:18:03 +0200 Subject: measuring time to render in javafx Message-ID: Hey, I am looking for a way to measure how long it takes for JavaFX to render something graphically. Say I change the text of a label, then this will schedule a new pulse. How can I now actually get feedback when the rendering is done? In swing I guess I could override the paint or paintComponent methods. In JavaFX I found a hacky way in which I supply a Canvas with my own implementation of NGCanvas and then override the impl_createPeer() method to return my implementation. However this is surely not the way to go and it will break in 9 :-) What would be the preferred way of doing this in JavaFX? -- Viele Gr??e *Selim Dincer* From hastebrot at gmail.com Fri Jun 2 08:33:37 2017 From: hastebrot at gmail.com (Benjamin Gudehus) Date: Fri, 2 Jun 2017 10:33:37 +0200 Subject: measuring time to render in javafx In-Reply-To: References: Message-ID: Hi Selim, there was a presentation a while back about PerformanceTracker and the anatomy of pulses: - Oleg Mazurov: ?Optimizing JavaFX Applications? - https://www.youtube.com/watch?v=dw8se4uA1qc You can activate the pulse logging using Java start parameters. If you want something more sophisticated like an render indicator in your GUI you probably need to access private fields/methods in the classes responsible for the pulse. Here is a brief overview of the call hierarchy for PerformanceTracker.pulse(): - PerformanceTracker#pulse() - Scene#pulse() - Toolkit#runPulse() - Toolkit#firePulse() - QuantumToolkit#pulse() And for frameRenderered(): - PerformanceTracker#frameRendered() - Scene.ScenePeerPaintListener#frameRendered() - GlassScene#frameRendered() - PaintCollector#done(RenderJob) - RenderJob#run() - QuantumToolkit#addRenderJob() - QuantumToolkit#renderToImage(ImageRenderingContext) - ViewScene#repaint() - PaintCollector#renderAll() - QuantumToolkit#pulse() And a rough list of start parameters: - -Dquantum.pulse=true - -Dquantum.debug=trre - -Dquantum.verbose=true - -Dprism.order=d3d - -Dprism.order=sw - -Djavafx.pulseLogger=true (If we had something like the developer tools in modern browsers in JavaFX 10, this would be amazing) --Benjamin On Fri, Jun 2, 2017 at 10:18 AM, Selim Dincer wrote: > Hey, > > I am looking for a way to measure how long it takes for JavaFX to render > something graphically. Say I change the text of a label, then this will > schedule a new pulse. How can I now actually get feedback when the > rendering is done? > In swing I guess I could override the paint or paintComponent methods. In > JavaFX I found a hacky way in which I supply a Canvas with my own > implementation of NGCanvas and then override the impl_createPeer() method > to return my implementation. > However this is surely not the way to go and it will break in 9 :-) > > What would be the preferred way of doing this in JavaFX? > > -- > Viele Gr??e > *Selim Dincer* > From jonathan.giles at oracle.com Mon Jun 5 23:17:10 2017 From: jonathan.giles at oracle.com (Jonathan Giles) Date: Tue, 6 Jun 2017 11:17:10 +1200 Subject: [Review request] 8181169: Block comments mistakenly used in place of missing javadoc comments Message-ID: <3e7e0c0f-37be-2664-a8de-d65764db7921@oracle.com> Kevin, Could you please review the javadoc fix here: https://bugs.openjdk.java.net/browse/JDK-8181169 http://cr.openjdk.java.net/~jgiles/8181169/index.html Thanks -- -- Jonathan From alexander.zvegintsev at oracle.com Tue Jun 6 06:03:39 2017 From: alexander.zvegintsev at oracle.com (Alexander Zvegintsev) Date: Tue, 6 Jun 2017 11:33:39 +0530 Subject: [10] Review request for 8172847 [macos] If you hit the escape key repeatedly to close the subwindow, the process crashes Message-ID: <5032e40b-9ac2-4dc3-2a48-31be6697130b@oracle.com> Hello, please review the fix http://cr.openjdk.java.net/~azvegint/jdk/10/8172847/00/ for the issue https://bugs.openjdk.java.net/browse/JDK-8172847 -- Thanks, Alexander. From alexander.zvegintsev at oracle.com Tue Jun 6 08:33:27 2017 From: alexander.zvegintsev at oracle.com (Alexander Zvegintsev) Date: Tue, 6 Jun 2017 14:03:27 +0530 Subject: [10] Review request for 8181476 [macos] Stages with StageStyle.UTILITY are always on-top when initialized without an owner Message-ID: <54800313-ec9f-858f-0ff5-9751b3c5bf52@oracle.com> Hello, please review the fix http://cr.openjdk.java.net/~azvegint/jdk/10/8181476/00/ for the issue https://bugs.openjdk.java.net/browse/JDK-8181476 -- Thanks, Alexander. From dipak.kumar at oracle.com Tue Jun 6 09:05:38 2017 From: dipak.kumar at oracle.com (Dipak Kumar) Date: Tue, 6 Jun 2017 02:05:38 -0700 (PDT) Subject: [10] Review request for 8089283 : Padding property of the select tag is incorrect in WebView Message-ID: <08c314c4-e0c1-4888-862e-c13de60ae3fb@default> Hi Kevin, Please review the proposed fix: Webrev : http://cr.openjdk.java.net/~asrivastava/dipak/8089283/webrev.00/ JBS : https://bugs.openjdk.java.net/browse/JDK-8089283 DRT and unit test cases are running fine with this change. Many thanks, Dipak From ajit.ghaisas at oracle.com Wed Jun 7 04:40:36 2017 From: ajit.ghaisas at oracle.com (Ajit Ghaisas) Date: Tue, 6 Jun 2017 21:40:36 -0700 (PDT) Subject: [10] Review request: JDK-8087978 : ProgressIndicator text disappears when using a larger font Message-ID: Hi Jonathan, Request you to review following fix : Bug : https://bugs.openjdk.java.net/browse/JDK-8087978 Fix : http://cr.openjdk.java.net/~aghaisas/fx/8087978/webrev.1/ Regards, Ajit From prem.balakrishnan at oracle.com Wed Jun 7 12:07:51 2017 From: prem.balakrishnan at oracle.com (Prem Balakrishnan) Date: Wed, 7 Jun 2017 05:07:51 -0700 (PDT) Subject: [10] Review request: JDK-8167209 Menu bar is not selected by right ALT key Message-ID: <770c6408-e459-4e75-898f-edd32c2a6232@default> Hi Jonathan, Request you to review following fix: Bug: https://bugs.openjdk.java.net/browse/JDK-8167209 Webrev: http://cr.openjdk.java.net/~pkbalakr/fx/8167209/webrev.00/ Regards, Prem From chris.bensen at oracle.com Thu Jun 8 20:53:44 2017 From: chris.bensen at oracle.com (Chris Bensen) Date: Thu, 8 Jun 2017 13:53:44 -0700 Subject: [10] Review request: 8177696 contents of javapackager -help needs to be updated Message-ID: <9A6D690F-DD59-4BD1-BE8F-3688E5154DEE@oracle.com> Kevin, Victor, Please review JIRA: https://bugs.openjdk.java.net/browse/JDK-8177696 Webrev: http://cr.openjdk.java.net/~cbensen/JDK-8177696/webrev.02/ Chris From kevin.rushforth at oracle.com Fri Jun 9 15:17:57 2017 From: kevin.rushforth at oracle.com (Kevin Rushforth) Date: Fri, 09 Jun 2017 08:17:57 -0700 Subject: Result: New OpenJFX Committer: Ajit Ghaisas Message-ID: <593ABC25.4010808@oracle.com> Voting for Ajit Ghaisas [1] to OpenJFX Committer [2] is now closed. Yes: 10 Veto: 0 Abstain: 0 According to the Bylaws definition of Lazy Consensus, this is sufficient to approve the nomination. -- Kevin [1] http://openjdk.java.net/census#aghaisas [2] http://mail.openjdk.java.net/pipermail/openjfx-dev/2017-May/020588.html From kevin.rushforth at oracle.com Fri Jun 9 17:09:30 2017 From: kevin.rushforth at oracle.com (Kevin Rushforth) Date: Fri, 09 Jun 2017 10:09:30 -0700 Subject: [9] Review request: 8181828: Broken Image link in documentation for Tangent interpolator Message-ID: <593AD64A.1090709@oracle.com> Jim or Phil, Please review the simple fix to move tangent_interpolator.png to the correct module. https://bugs.openjdk.java.net/browse/JDK-8181828 The diff for the proposed fix, which is also in JBS, is: ------------------------------------------------------------------------------------ diff --git a/modules/javafx.base/src/main/docs/javafx/animation/doc-files/tangent_interpolator.png b/modules/javafx.graphics/src/main/docs/javafx/animation/doc-files/tangent_interpolator.png rename from modules/javafx.base/src/main/docs/javafx/animation/doc-files/tangent_interpolator.png rename to modules/javafx.graphics/src/main/docs/javafx/animation/doc-files/tangent_interpolator.png ------------------------------------------------------------------------------------ -- Kevin From kevin.rushforth at oracle.com Fri Jun 9 17:25:26 2017 From: kevin.rushforth at oracle.com (Kevin Rushforth) Date: Fri, 09 Jun 2017 10:25:26 -0700 Subject: [9] Review request: 8181829: Broken link to css reference guide in Background documentation Message-ID: <593ADA06.9080902@oracle.com> Phil or Jonathan, Please review the simple fix for a broken javadoc link: https://bugs.openjdk.java.net/browse/JDK-8181829 The diff for the proposed fix, which is also in JBS, is: diff --git a/modules/javafx.graphics/src/main/java/javafx/scene/layout/Background.java b/modules/javafx.graphics/src/main/java/javafx/scene/layout/Background.java --- a/modules/javafx.graphics/src/main/java/javafx/scene/layout/Background.java +++ b/modules/javafx.graphics/src/main/java/javafx/scene/layout/Background.java @@ -53,7 +53,7 @@ * encapsulates the entire set of data required to render the background * of a Region. Because this class is immutable, you can freely reuse the same * Background on many different Regions. Please refer to - * JavaFX CSS Reference Guide for a + * JavaFX CSS Reference Guide for a * complete description of the CSS rules for styling the background of a Region. *

* Every Background is comprised of {@link #getFills() fills} and / or -- Kevin From victor.drozdov at oracle.com Fri Jun 9 22:24:45 2017 From: victor.drozdov at oracle.com (victor.drozdov at oracle.com) Date: Fri, 9 Jun 2017 15:24:45 -0700 Subject: [10] Review request: JDK-8179445: Use jdeps ToolProvider Message-ID: <95195f19-f30a-3ae5-3e97-efe1b6093e2c@oracle.com> Chris, Kevin Please review my changes about jdeps ToolProvider JIRA: https://bugs.openjdk.java.net/browse/JDK-8179445 Webrev: http://cr.openjdk.java.net/~vdrozdov/JDK-8179445/webrev.00/ --Victor From james.graham at oracle.com Mon Jun 12 22:21:29 2017 From: james.graham at oracle.com (Jim Graham) Date: Mon, 12 Jun 2017 15:21:29 -0700 Subject: [10] Review request: JDK-8181976 - Specifying desired dimensions for Image with HiDPI (@2x) variant gets the size wrong Message-ID: <2d442f6b-0760-bfff-fa6b-561a2446182a@oracle.com> JBS: https://bugs.openjdk.java.net/browse/JDK-8181976 webrev: http://cr.openjdk.java.net/~flar/JDK-8181976/webrev.00/ Simple fix is to carry the double "size requested" values all the way down to where the image pixel scale is determined (not strictly required, but important for precision) and then to scale them with the final image pixel scale before rounding to integer and using them to resize the thumbnail... ...jim From kevin.rushforth at oracle.com Tue Jun 13 01:39:37 2017 From: kevin.rushforth at oracle.com (Kevin Rushforth) Date: Mon, 12 Jun 2017 18:39:37 -0700 Subject: [9] Review request: 8180338: Additional HTML5 cleanup In-Reply-To: <5924DFA3.40301@oracle.com> References: <5924DFA3.40301@oracle.com> Message-ID: <593F4259.8040109@oracle.com> Jonathan (Giles) and Jon (Gibbons), Here is an updated webrev for this bug that fixes all errors and warnings in "introduction_to_fxml.html" reported by tidy. It additionally fixes 3 of the warnings (there were already no errors) in cssref.html. As with the previous webrev, the outdated "faq.html" is removed. http://cr.openjdk.java.net/~kcr/8180338/webrev.02/ -- Kevin Kevin Rushforth wrote: > Hi Jon, > > Can you review this simple change to the three .html files (other than > package.html) in the FX docs? > > https://bugs.openjdk.java.net/browse/JDK-8180338 > http://cr.openjdk.java.net/~kcr/8180338/webrev.00/ > > Thanks. > > -- Kevin > From arunprasad.rajkumar at oracle.com Tue Jun 13 10:51:28 2017 From: arunprasad.rajkumar at oracle.com (Arunprasad Rajkumar) Date: Tue, 13 Jun 2017 16:21:28 +0530 Subject: [webkit] [9] 8180825: Javafx WebView fails to render pdf.js Message-ID: <34E4AD14-5B2A-40BB-8A1B-665006F452EA@oracle.com> Kevin, Guru, Murali, Please review the following fix targeted for JDK-9. JBS: https://bugs.openjdk.java.net/browse/JDK-8180825 Webrev: http://cr.openjdk.java.net/~arajkumar/8180825/webrev Regards, Arun From nlisker at gmail.com Wed Jun 14 23:44:21 2017 From: nlisker at gmail.com (Nir Lisker) Date: Thu, 15 Jun 2017 02:44:21 +0300 Subject: Small javadoc corrections Message-ID: A few more corrections for the Javadoc: - ListChangeListener.Change, in the code example, "" should be "". In this class refer to the following methods (I'm looking at http://www.oracle.com/technetwork/java/javase/documentation/index-137868.html#styleguide ): - getAddedSubList: is phrased unconventionally. Instead of the usual "does X" phrasing, it uses "to do X, use this method". So the first sentence should probably be "Get(s) a subList view of the list that contains only the elements added." - getPermutation(int): similar to above. Probably "Allows to observe the permutation that happened" or similar is slightly more in line. - getPermutation(): "an permutation" should be "a permutation". - wasAdded: missing a period in its first and only sentence. - next: "a requires" should probably be "and requires". - getTo: the return description should be "an end" instead of "a end". - next and reset: use the unconventional imperative "Go to..." and "Reset to..." instead of "Goes to..." and "Resets to...". - Some methods are described by what they return rather than what they do. getAddedSize: "Size of the interval that was added.", getRemovedSize: "Size of getRemoved() list.", getRemoved: "An immutable list of removed/replaced elements." etc. More conventional is "returns/gets a/an..." or similar, although this is also - Most methods don't use @code style when mentioning other methods (compare getAddedSubList and wasUpdated, for example). If you follow the style guide I linked, then many other classes are affected. Other: - TreeItem should have a link to TreeView in the first sentence, or as a @see, or both. Possibly also for TreeTableView as these are its 2 main uses. From kevin.rushforth at oracle.com Thu Jun 15 00:23:22 2017 From: kevin.rushforth at oracle.com (Kevin Rushforth) Date: Wed, 14 Jun 2017 17:23:22 -0700 Subject: Small javadoc corrections In-Reply-To: References: Message-ID: <5941D37A.3040709@oracle.com> I'll open up a new JBS issue for these, but they may need to wait for JDK 10 at this point. -- Kevin Nir Lisker wrote: > A few more corrections for the Javadoc: > > - ListChangeListener.Change, in the code example, "" should be > "". > > In this class refer to the following methods (I'm looking at > http://www.oracle.com/technetwork/java/javase/documentation/index-137868.html#styleguide > ): > > - getAddedSubList: is phrased unconventionally. Instead of the usual "does > X" phrasing, it uses "to do X, use this method". So the first sentence > should probably be "Get(s) a subList view of the list that contains only > the elements added." > > - getPermutation(int): similar to above. Probably "Allows to observe the > permutation that happened" or similar is slightly more in line. > > - getPermutation(): "an permutation" should be "a permutation". > > - wasAdded: missing a period in its first and only sentence. > > - next: "a requires" should probably be "and requires". > > - getTo: the return description should be "an end" instead of "a end". > > - next and reset: use the unconventional imperative "Go to..." and "Reset > to..." instead of "Goes to..." and "Resets to...". > > - Some methods are described by what they return rather than what they do. > getAddedSize: "Size of the interval that was added.", getRemovedSize: "Size > of getRemoved() list.", getRemoved: "An immutable list of removed/replaced > elements." etc. More conventional is "returns/gets a/an..." or similar, > although this is also > > - Most methods don't use @code style when mentioning other methods (compare > getAddedSubList and wasUpdated, for example). If you follow the style guide > I linked, then many other classes are affected. > > Other: > > - TreeItem should have a link to TreeView in the first sentence, or as a > @see, or both. Possibly also for TreeTableView as these are its 2 main uses. > From chris.bensen at oracle.com Thu Jun 15 13:59:44 2017 From: chris.bensen at oracle.com (Chris Bensen) Date: Thu, 15 Jun 2017 06:59:44 -0700 Subject: [10] Review request: JDK-8181738 Remove com.sun.tools.jdeps to jdk.packager Message-ID: Kevin, Victor, Please review this change following JDK-8179445 to remove the qualified exports of com.sun.tools.jdeps: JIRA: https://bugs.openjdk.java.net/browse/JDK-JDK-8181738 Webrev: http://cr.openjdk.java.net/~cbensen/JDK-JDK-8181738/webrev.00/ Chris From kevin.rushforth at oracle.com Thu Jun 15 22:16:06 2017 From: kevin.rushforth at oracle.com (Kevin Rushforth) Date: Thu, 15 Jun 2017 15:16:06 -0700 Subject: Small javadoc corrections In-Reply-To: <5941D37A.3040709@oracle.com> References: <5941D37A.3040709@oracle.com> Message-ID: <59430726.9090206@oracle.com> https://bugs.openjdk.java.net/browse/JDK-8182314 Kevin Rushforth wrote: > I'll open up a new JBS issue for these, but they may need to wait for > JDK 10 at this point. > > -- Kevin > > > Nir Lisker wrote: >> A few more corrections for the Javadoc: >> >> - ListChangeListener.Change, in the code example, "" should be >> "". >> >> In this class refer to the following methods (I'm looking at >> http://www.oracle.com/technetwork/java/javase/documentation/index-137868.html#styleguide >> >> ): >> >> - getAddedSubList: is phrased unconventionally. Instead of the usual >> "does >> X" phrasing, it uses "to do X, use this method". So the first sentence >> should probably be "Get(s) a subList view of the list that contains only >> the elements added." >> >> - getPermutation(int): similar to above. Probably "Allows to observe the >> permutation that happened" or similar is slightly more in line. >> >> - getPermutation(): "an permutation" should be "a permutation". >> >> - wasAdded: missing a period in its first and only sentence. >> >> - next: "a requires" should probably be "and requires". >> >> - getTo: the return description should be "an end" instead of "a end". >> >> - next and reset: use the unconventional imperative "Go to..." and >> "Reset >> to..." instead of "Goes to..." and "Resets to...". >> >> - Some methods are described by what they return rather than what >> they do. >> getAddedSize: "Size of the interval that was added.", getRemovedSize: >> "Size >> of getRemoved() list.", getRemoved: "An immutable list of >> removed/replaced >> elements." etc. More conventional is "returns/gets a/an..." or similar, >> although this is also >> >> - Most methods don't use @code style when mentioning other methods >> (compare >> getAddedSubList and wasUpdated, for example). If you follow the style >> guide >> I linked, then many other classes are affected. >> >> Other: >> >> - TreeItem should have a link to TreeView in the first sentence, or as a >> @see, or both. Possibly also for TreeTableView as these are its 2 >> main uses. >> From Michael.Kaesbauer at krones.com Mon Jun 19 11:01:09 2017 From: Michael.Kaesbauer at krones.com (Kaesbauer, Michael) Date: Mon, 19 Jun 2017 11:01:09 +0000 Subject: gesture events at JFXPanel Message-ID: <562104E13FF46B45B310C37B773A59C9CB77B0A6@EMB-P-NTR002.Krones-DEU.Krones-Group.com> Hi everybody, I try to embed JavaFX controls in a swing application by using the JFXPanel at JavaFX8. Is it possible to process gesture events (Zoom, Swipe) inside these JavaFX controls? At my test application this use case is not working right now. If not, is there another way to receive gestures events at the swing application? Kind regards Michael Kaesbauer ______________________________________________________________ Krones AG Vorstand: Christoph Klenk, Vorstandsvorsitzender, Michael Andersen, Rainulf Diepold, Thomas Ricker, Markus Tischer, Ralf Goldbrunner Vorsitzender des Aufsichtsrats: Volker Kronseder Registergericht: Regensburg HRB 23 44, Umsatzsteuer-ID-Nummer: DE 133 695 999 ______________________________________________________________ Der Inhalt dieser E-Mail und jeder Anhang ist vertraulich. Diese Inhalte sind nur fuer die benannten Adressaten. Wenn Sie diese E-Mail durch einen Fehler erhalten haben, benachrichtigen Sie sofort Ihren Administrator oder den Absender. Behandeln Sie die E-Mail vertraulich. * Diese E-Mail wurde auf Viren und gefaehrlichen Inhalt geprueft. * ______________________________________________________________ The contents of this email and any attachments are confidential. They are intended for the named recipient(s) only. If you have received this email in error please notify the system manager or the sender immediately and do not disclose the contents to anyone or make copies. * This e-Mail was scanned for viruses, vandals and malicious content. * From herve.girod at gmail.com Mon Jun 19 20:25:38 2017 From: herve.girod at gmail.com (=?utf-8?Q?Herv=C3=A9_Girod?=) Date: Mon, 19 Jun 2017 22:25:38 +0200 Subject: gesture events at JFXPanel In-Reply-To: <562104E13FF46B45B310C37B773A59C9CB77B0A6@EMB-P-NTR002.Krones-DEU.Krones-Group.com> References: <562104E13FF46B45B310C37B773A59C9CB77B0A6@EMB-P-NTR002.Krones-DEU.Krones-Group.com> Message-ID: <7C08FA4D-EB23-4306-9652-2D86201BAFE7@gmail.com> Multitouch events are not handled at the swing layer, so normally they can not be detected in the JavaFX controls. Herv? Sent from my iPad > On 19 Jun 2017, at 13:01, Kaesbauer, Michael wrote: > > Hi everybody, > > I try to embed JavaFX controls in a swing application by using the JFXPanel at JavaFX8. Is it possible to process gesture events (Zoom, Swipe) inside these JavaFX controls? At my test application this use case is not working right now. > > If not, is there another way to receive gestures events at the swing application? > > > Kind regards > Michael Kaesbauer > > ______________________________________________________________ > > Krones AG > Vorstand: Christoph Klenk, Vorstandsvorsitzender, > Michael Andersen, Rainulf Diepold, Thomas Ricker, Markus Tischer, Ralf Goldbrunner > Vorsitzender des Aufsichtsrats: Volker Kronseder > Registergericht: Regensburg HRB 23 44, Umsatzsteuer-ID-Nummer: DE 133 695 999 > ______________________________________________________________ > Der Inhalt dieser E-Mail und jeder Anhang ist vertraulich. > Diese Inhalte sind nur fuer die benannten Adressaten. > Wenn Sie diese E-Mail durch einen Fehler erhalten haben, > benachrichtigen Sie sofort Ihren Administrator oder den Absender. > Behandeln Sie die E-Mail vertraulich. > > * Diese E-Mail wurde auf Viren und gefaehrlichen Inhalt geprueft. * > ______________________________________________________________ > > The contents of this email and any attachments are confidential. > They are intended for the named recipient(s) only. > If you have received this email in error please notify the system manager > or the sender immediately and do not disclose the contents to anyone or > make copies. > > * This e-Mail was scanned for viruses, vandals and malicious content. * From chris.bensen at oracle.com Tue Jun 20 14:47:31 2017 From: chris.bensen at oracle.com (Chris Bensen) Date: Tue, 20 Jun 2017 07:47:31 -0700 Subject: [10] Review request: JDK-8182564 Create a Debug JDK for Unit Tests Message-ID: <3BDBF735-D3DF-44D1-919A-799B3221EFD7@oracle.com> Kevin, Victor, Please review this change for unit tests to create a debug JDK. It?s a little odd. It only works in a bash shell because java and javac are copied to java.original and javac.original and replaced with bash scripts which always supply the --upgrade-module-path containing the newly built jdk.packager and jdk.packager.services modules. JIRA: https://bugs.openjdk.java.net/browse/JDK-8182564 Webrev: http://cr.openjdk.java.net/~cbensen/JDK-8182564/webrev.00/ Chris From info at cuhka.com Wed Jun 21 09:19:33 2017 From: info at cuhka.com (Maurice) Date: Wed, 21 Jun 2017 11:19:33 +0200 Subject: Where should JavaFX get its touch events? Message-ID: <1157866e-5e10-6934-e86c-1c9533fb1705@cuhka.com> As a follow up to my previous question - how to get touch running in JavaFX on Ubuntu I would like to know where JavaFX should get its touch events from. Research seems to indicate that JavaFX standard reads /dev/input/event0, but even if I link /dev/input/event4 to event0 it does not notice that there are touch events. I can override the system properties com.sun.javafx.touch and com.sun.javafx.multiTouch, but even though the system then reports it does support touch no events are generated and mouse events are not synthesized. To test if the system in itself recognizes the touch screen I've run chromium-browser --touch-events=enabled and visited a touch website. Multiple touch points were recognized. Maurice. From vivek.x.rao at oracle.com Wed Jun 21 19:01:33 2017 From: vivek.x.rao at oracle.com (Vivek Rao) Date: Wed, 21 Jun 2017 12:01:33 -0700 Subject: [10] Review Request: JDK-8179399 - Call trim() when loaded jre.list (Vivek Rao) Message-ID: <0D5998FE-19D4-48A9-AE39-A714052449FD@oracle.com> Hi, Chris, Victor, Please review the following change for fixing the ?stripComments? method for redistributableModules. Bug URL: https://bugs.openjdk.java.net/browse/JDK-8179399 Webrev: http://cr.openjdk.java.net/~vrao/JDK-8179399/ Issue: 1. When each line of jre.list is loaded in RedistributableModules.java trim() should be called 2. NoSuchElementException not caught for ModuleReference 3. Unused imports Fix: Using trim() inside stripComments to remove unnecessary space and cleaning the if else condition. Added NoSuchElementException Removed all unused imports Thanks and regards, Vivek Rao From bszbur at gmail.com Thu Jun 22 04:23:12 2017 From: bszbur at gmail.com (Cindy Prather/massey) Date: Thu, 22 Jun 2017 00:23:12 -0400 Subject: No subject Message-ID: cindy prather From prem.balakrishnan at oracle.com Thu Jun 22 10:28:36 2017 From: prem.balakrishnan at oracle.com (Prem Balakrishnan) Date: Thu, 22 Jun 2017 03:28:36 -0700 (PDT) Subject: [10] Review Request : JDK-8167139 Menu's selection disappears on collapsing Message-ID: Hi Jonathan, Request you to review following fix: Bug: https://bugs.openjdk.java.net/browse/JDK-8167139 Webrev: http://cr.openjdk.java.net/~pkbalakr/fx/8167139/webrev.00/ Regards, Prem From dlemmermann at gmail.com Thu Jun 22 13:22:28 2017 From: dlemmermann at gmail.com (Dirk Lemmermann) Date: Thu, 22 Jun 2017 15:22:28 +0200 Subject: Scroll Event Delta Values Message-ID: <7B6F52C7-51BD-4EFD-8828-37F14680A2FB@gmail.com> Hi, I noticed in my application that the delta values of the ScrollEvent seem to be incorrect at the end of the scroll event sequence. Values should first increase and then decrease: smooth-in / smooth-out style. But when I print out the values I noticed that at the end I receive a few non-linear values: 9.000091552734375 8.000030517578125 7.0001220703125 6.00006103515625 8.000030517578125 10.0 10.0 9.000091552734375 9.000091552734375 9.000091552734375 8.000030517578125 7.0001220703125 7.0001220703125 6.00006103515625 6.00006103515625 6.00006103515625 5.0 5.0 5.0 16.00006103515625 The problem with these values is that it results in ?stuttering" of the timeline control of my app. ?Dirk From chris.bensen at oracle.com Mon Jun 26 16:09:33 2017 From: chris.bensen at oracle.com (Chris Bensen) Date: Mon, 26 Jun 2017 09:09:33 -0700 Subject: [10] Review request: 8182778 Debug JDK Additions Message-ID: Kevin, Victor, Please review these additions to the Java Packager debug JDK. This change will bundle the jdk.packager.services module with the resulting application and cleans up the gradle sourceSet. JIRA: https://bugs.openjdk.java.net/browse/JDK-8182778 Webrev: http://cr.openjdk.java.net/~cbensen/JDK-8182778/webrev.00/ Chris From m-matsushima at bk.jp.nec.com Thu Jun 29 04:37:15 2017 From: m-matsushima at bk.jp.nec.com (Mitsuru Matsushima) Date: Thu, 29 Jun 2017 04:37:15 +0000 Subject: Additional information about JDK-8183120 Message-ID: Hi, I reported following bug report. But it seems my explanation was not clear enough. https://bugs.openjdk.java.net/browse/JDK-8183120 First, there is a lack in the STEPS TO FOLLOW TO REPRODUCE THE PROBLEM. A sample text I described is tested with 'MS Gothic' font. So, the sample attached to the issue need to modify following. Then, you can probably get same result of my report. public void start(Stage primaryStage) { primaryStage.setTitle("TextArea Test"); Group root = new Group(); Scene scene = new Scene(root, 600, 330, Color.WHITE); final TextArea cssEditorFld = new TextArea(); cssEditorFld.setPrefColumnCount(10); cssEditorFld.setWrapText(true); cssEditorFld.setStyle("-fx-font-family:'MS Gothic'"); root.getChildren().add(cssEditorFld); primaryStage.setScene(scene); primaryStage.show(); } Second, I tested also JDK9 and the result is same. Test environment: java version "9-ea" Java(TM) SE Runtime Environment (build 9-ea+174) Java HotSpot(TM) 64-Bit Server VM (build 9-ea+174, mixed mode) --- Mitsuru From guru.hb at oracle.com Thu Jun 29 12:50:50 2017 From: guru.hb at oracle.com (Guru Hb) Date: Thu, 29 Jun 2017 18:20:50 +0530 Subject: [10] Review request: 8178360: Build and integrate ICU from source Message-ID: Hi Kevin, Arun and Murali, Please review the fix for : JBS : https://bugs.openjdk.java.net/browse/JDK-8178360 Webrev : http://cr.openjdk.java.net/~ghb/8178360/webrev.07 (Modified Source) patch : http://cr.openjdk.java.net/~ghb/8178360/rt.patch_07.tar.gz (patch for local build and testing) Thanks, Guru From manajit.halder at oracle.com Fri Jun 30 09:43:22 2017 From: manajit.halder at oracle.com (Manajit Halder) Date: Fri, 30 Jun 2017 15:13:22 +0530 Subject: Review Request: JDK-8176319: [macosx] problems with Character Viewer Message-ID: <4F4C0EB0-0C68-441D-9898-83640995B406@oracle.com> Hi All, Kindly review the following JavaFx fix. Bug: https://bugs.openjdk.java.net/browse/JDK-8176319 Webrev: http://cr.openjdk.java.net/~mhalder/fx/8176319/webrev.00/ Regards, Manajit From manajit.halder at oracle.com Fri Jun 30 14:36:59 2017 From: manajit.halder at oracle.com (Manajit Halder) Date: Fri, 30 Jun 2017 20:06:59 +0530 Subject: Review Request: JDK-8176319: [macosx] problems with Character Viewer In-Reply-To: <4F4C0EB0-0C68-441D-9898-83640995B406@oracle.com> References: <4F4C0EB0-0C68-441D-9898-83640995B406@oracle.com> Message-ID: <77817957-0157-4257-AEB7-DFBC1EE27F8B@oracle.com> Hi All, Please review the modified fix which is more efficient than the initial fix: http://cr.openjdk.java.net/~mhalder/fx/8176319/webrev.01/ Regards, Manajit > On 30-Jun-2017, at 3:13 PM, Manajit Halder wrote: > > Hi All, > > Kindly review the following JavaFx fix. > > Bug: https://bugs.openjdk.java.net/browse/JDK-8176319 > > Webrev: http://cr.openjdk.java.net/~mhalder/fx/8176319/webrev.00/ > > Regards, > Manajit From chris.bensen at oracle.com Fri Jun 30 17:09:28 2017 From: chris.bensen at oracle.com (Chris Bensen) Date: Fri, 30 Jun 2017 10:09:28 -0700 Subject: [10] Review request: 8091418 Evaluate TODOs in code, either removing or filing issues as appropriate Message-ID: Victor, Please review these changes related to the TODOs and FIXMEs in the java packager code. JIRA: https://bugs.openjdk.java.net/browse/JDK-8091418 Webrev: http://cr.openjdk.java.net/~cbensen/JDK-8091418/webrev.00/ Chris From victor.drozdov at oracle.com Fri Jun 30 19:51:53 2017 From: victor.drozdov at oracle.com (victor.drozdov at oracle.com) Date: Fri, 30 Jun 2017 12:51:53 -0700 Subject: [10] Review request: 8182615: Check registry paths Message-ID: <99102e82-b178-a80f-87c3-4b4fa420fc63@oracle.com> Chris, Please review my changes about correcting registry paths JIRA: https://bugs.openjdk.java.net/browse/JDK-8182615 Webrev: http://cr.openjdk.java.net/~vdrozdov/JDK-8182615/webrev.00/ --Victor